[INFO] fetching crate blissb 0.2.3... [INFO] checking blissb-0.2.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate blissb 0.2.3 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate blissb 0.2.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate blissb 0.2.3 [INFO] finished tweaking crates.io crate blissb 0.2.3 [INFO] tweaked toml for crates.io crate blissb 0.2.3 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 15 packages to latest compatible versions [INFO] [stderr] Adding rand v0.3.23 (latest: v0.8.5) [INFO] [stderr] Adding rand v0.4.6 (latest: v0.8.5) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding rdrand v0.4.0 (latest: v0.8.3) [INFO] [stderr] Adding tiny-keccak v1.5.0 (latest: v2.0.2) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f879ee0c31c4c99200aacaa6c97e97ef299d86054e7cc57ac7e358ffcfc2cd07 [INFO] running `Command { std: "docker" "start" "-a" "f879ee0c31c4c99200aacaa6c97e97ef299d86054e7cc57ac7e358ffcfc2cd07", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f879ee0c31c4c99200aacaa6c97e97ef299d86054e7cc57ac7e358ffcfc2cd07", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f879ee0c31c4c99200aacaa6c97e97ef299d86054e7cc57ac7e358ffcfc2cd07", kill_on_drop: false }` [INFO] [stdout] f879ee0c31c4c99200aacaa6c97e97ef299d86054e7cc57ac7e358ffcfc2cd07 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 55907b37649e7927c51cd91ba3c7e213b8f302b191486a30bdd121d6aa7b8ac9 [INFO] running `Command { std: "docker" "start" "-a" "55907b37649e7927c51cd91ba3c7e213b8f302b191486a30bdd121d6aa7b8ac9", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking bitpack v0.2.1 [INFO] [stderr] Checking tiny-keccak v1.5.0 [INFO] [stderr] Checking rand v0.3.23 [INFO] [stderr] Checking blissb v0.2.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `o` [INFO] [stdout] --> src/param.rs:64:7 [INFO] [stdout] | [INFO] [stdout] 64 | #[cfg(feature = "o")] [INFO] [stdout] | ^^^^^^^^^^--- [INFO] [stdout] | | [INFO] [stdout] | help: there is a expected value with a similar name: `"i"` [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default`, `i`, `ii`, `iii`, and `iv` [INFO] [stdout] = help: consider adding `o` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `o` [INFO] [stdout] --> src/param.rs:100:7 [INFO] [stdout] | [INFO] [stdout] 100 | #[cfg(feature = "o")] [INFO] [stdout] | ^^^^^^^^^^--- [INFO] [stdout] | | [INFO] [stdout] | help: there is a expected value with a similar name: `"i"` [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default`, `i`, `ii`, `iii`, and `iv` [INFO] [stdout] = help: consider adding `o` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `iterator_step_by` has been stable since 1.28.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(iterator_step_by)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/utils.rs:22:46 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn uniform_poly(v: &mut [i32], rng: &mut Rng) { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 22 | pub fn uniform_poly(v: &mut [i32], rng: &mut dyn Rng) { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `o` [INFO] [stdout] --> src/param.rs:64:7 [INFO] [stdout] | [INFO] [stdout] 64 | #[cfg(feature = "o")] [INFO] [stdout] | ^^^^^^^^^^--- [INFO] [stdout] | | [INFO] [stdout] | help: there is a expected value with a similar name: `"i"` [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default`, `i`, `ii`, `iii`, and `iv` [INFO] [stdout] = help: consider adding `o` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `o` [INFO] [stdout] --> src/param.rs:100:7 [INFO] [stdout] | [INFO] [stdout] 100 | #[cfg(feature = "o")] [INFO] [stdout] | ^^^^^^^^^^--- [INFO] [stdout] | | [INFO] [stdout] | help: there is a expected value with a similar name: `"i"` [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default`, `i`, `ii`, `iii`, and `iv` [INFO] [stdout] = help: consider adding `o` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `iterator_step_by` has been stable since 1.28.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(iterator_step_by)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/utils.rs:22:46 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn uniform_poly(v: &mut [i32], rng: &mut Rng) { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 22 | pub fn uniform_poly(v: &mut [i32], rng: &mut dyn Rng) { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bliss.rs:75:13 [INFO] [stdout] | [INFO] [stdout] 31 | let mut rng = OsRng::new()?.gen::(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | Err(io::Error::new(io::ErrorKind::Other, "Unable to generate the correct private key.")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bliss.rs:164:13 [INFO] [stdout] | [INFO] [stdout] 95 | let mut rng = OsRng::new()?.gen::(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 164 | Err(io::Error::new(io::ErrorKind::Other, "Unable to generate the correct signature.")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `blissb` (lib) due to 3 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bliss.rs:75:13 [INFO] [stdout] | [INFO] [stdout] 31 | let mut rng = OsRng::new()?.gen::(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | Err(io::Error::new(io::ErrorKind::Other, "Unable to generate the correct private key.")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bliss.rs:164:13 [INFO] [stdout] | [INFO] [stdout] 95 | let mut rng = OsRng::new()?.gen::(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 164 | Err(io::Error::new(io::ErrorKind::Other, "Unable to generate the correct signature.")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `blissb` (lib test) due to 3 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "55907b37649e7927c51cd91ba3c7e213b8f302b191486a30bdd121d6aa7b8ac9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "55907b37649e7927c51cd91ba3c7e213b8f302b191486a30bdd121d6aa7b8ac9", kill_on_drop: false }` [INFO] [stdout] 55907b37649e7927c51cd91ba3c7e213b8f302b191486a30bdd121d6aa7b8ac9