[INFO] fetching crate blink-timer 0.3.2... [INFO] checking blink-timer-0.3.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate blink-timer 0.3.2 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate blink-timer 0.3.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate blink-timer 0.3.2 [INFO] finished tweaking crates.io crate blink-timer 0.3.2 [INFO] tweaked toml for crates.io crate blink-timer 0.3.2 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate blink-timer 0.3.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7199bcbfeeee554c0dddb6d8c90ef8ffab8d6a975e115f10a64d1e87d23824ab [INFO] running `Command { std: "docker" "start" "-a" "7199bcbfeeee554c0dddb6d8c90ef8ffab8d6a975e115f10a64d1e87d23824ab", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7199bcbfeeee554c0dddb6d8c90ef8ffab8d6a975e115f10a64d1e87d23824ab", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7199bcbfeeee554c0dddb6d8c90ef8ffab8d6a975e115f10a64d1e87d23824ab", kill_on_drop: false }` [INFO] [stdout] 7199bcbfeeee554c0dddb6d8c90ef8ffab8d6a975e115f10a64d1e87d23824ab [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 459e33528e2744ccaae4ab71853372ee2550011323141fac1a44488fffcacecd [INFO] running `Command { std: "docker" "start" "-a" "459e33528e2744ccaae4ab71853372ee2550011323141fac1a44488fffcacecd", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.43 [INFO] [stderr] Compiling unicode-ident v1.0.3 [INFO] [stderr] Compiling quote v1.0.21 [INFO] [stderr] Compiling libc v0.2.129 [INFO] [stderr] Compiling syn v1.0.99 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling futures-core v0.3.21 [INFO] [stderr] Compiling serde v1.0.143 [INFO] [stderr] Compiling pkg-config v0.3.25 [INFO] [stderr] Compiling serde_derive v1.0.143 [INFO] [stderr] Checking smallvec v1.9.0 [INFO] [stderr] Checking pin-project-lite v0.2.9 [INFO] [stderr] Compiling lock_api v0.4.7 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling slab v0.4.7 [INFO] [stderr] Checking once_cell v1.13.0 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Checking cache-padded v1.2.0 [INFO] [stderr] Compiling parking_lot_core v0.9.3 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking concurrent-queue v1.2.4 [INFO] [stderr] Checking parking v2.0.0 [INFO] [stderr] Checking fastrand v1.8.0 [INFO] [stderr] Compiling futures-task v0.3.21 [INFO] [stderr] Checking waker-fn v1.1.0 [INFO] [stderr] Checking futures-io v0.3.21 [INFO] [stderr] Compiling parking_lot_core v0.8.5 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking instant v0.1.12 [INFO] [stderr] Checking ppv-lite86 v0.2.16 [INFO] [stderr] Compiling regex-syntax v0.6.27 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Compiling async-trait v0.1.57 [INFO] [stderr] Checking tracing-core v0.1.29 [INFO] [stderr] Compiling indexmap v1.9.1 [INFO] [stderr] Compiling aho-corasick v0.7.18 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Compiling alsa-sys v0.3.1 [INFO] [stderr] Compiling x11 v2.20.0 [INFO] [stderr] Checking futures-sink v0.3.21 [INFO] [stderr] Checking sha1_smol v1.0.0 [INFO] [stderr] Compiling cpal v0.13.5 [INFO] [stderr] Checking async-task v4.3.0 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking futures-lite v1.12.0 [INFO] [stderr] Checking async-channel v1.7.1 [INFO] [stderr] Checking sha1 v0.6.1 [INFO] [stderr] Checking async-lock v2.5.0 [INFO] [stderr] Checking ogg v0.8.0 [INFO] [stderr] Checking ordered-stream v0.0.1 [INFO] [stderr] Checking os_str_bytes v6.2.0 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking nix v0.23.1 [INFO] [stderr] Checking getrandom v0.2.7 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Checking polling v2.2.0 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking dirs v4.0.0 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stderr] Checking async-broadcast v0.4.1 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking async-io v1.7.0 [INFO] [stderr] Checking async-executor v1.4.1 [INFO] [stderr] Checking lewton v0.10.2 [INFO] [stderr] Checking regex v1.6.0 [INFO] [stderr] Checking rdev v0.5.1 [INFO] [stderr] Checking env_logger v0.9.0 [INFO] [stderr] Compiling toml v0.5.9 [INFO] [stderr] Checking alsa v0.6.0 [INFO] [stderr] Compiling thiserror-impl v1.0.32 [INFO] [stderr] Compiling enumflags2_derive v0.7.4 [INFO] [stderr] Compiling tracing-attributes v0.1.22 [INFO] [stderr] Compiling serde_repr v0.1.9 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Compiling async-recursion v0.3.2 [INFO] [stderr] Compiling clap_derive v3.2.15 [INFO] [stderr] Compiling thiserror v1.0.32 [INFO] [stderr] Checking tracing v0.1.36 [INFO] [stderr] Compiling proc-macro-crate v1.2.1 [INFO] [stderr] Compiling zvariant_derive v3.6.0 [INFO] [stderr] Compiling zbus_macros v2.3.2 [INFO] [stderr] Checking rodio v0.15.0 [INFO] [stderr] Checking clap v3.2.16 [INFO] [stderr] Checking enumflags2 v0.7.5 [INFO] [stderr] Checking zvariant v3.6.0 [INFO] [stderr] Checking zbus_names v2.2.0 [INFO] [stderr] Checking zbus v2.3.2 [INFO] [stderr] Checking notify-rust v4.5.8 [INFO] [stderr] Checking blink-timer v0.3.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:364:13 [INFO] [stdout] | [INFO] [stdout] 364 | for mut item in self.state.iter_mut() { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:364:13 [INFO] [stdout] | [INFO] [stdout] 364 | for mut item in self.state.iter_mut() { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:390:21 [INFO] [stdout] | [INFO] [stdout] 390 | if let Some(mut next) = self.state.first_mut() { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:390:21 [INFO] [stdout] | [INFO] [stdout] 390 | if let Some(mut next) = self.state.first_mut() { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/main.rs:174:16 [INFO] [stdout] | [INFO] [stdout] 174 | FileSystem(String), [INFO] [stdout] | ---------- ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Error` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 174 | FileSystem(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/main.rs:174:16 [INFO] [stdout] | [INFO] [stdout] 174 | FileSystem(String), [INFO] [stdout] | ---------- ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Error` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 174 | FileSystem(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/main.rs:175:16 [INFO] [stdout] | [INFO] [stdout] 175 | Configfile(String), [INFO] [stdout] | ---------- ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Error` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 175 | Configfile(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/main.rs:175:16 [INFO] [stdout] | [INFO] [stdout] 175 | Configfile(String), [INFO] [stdout] | ---------- ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Error` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 175 | Configfile(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/main.rs:176:11 [INFO] [stdout] | [INFO] [stdout] 176 | Fatal(String), [INFO] [stdout] | ----- ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Error` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 176 | Fatal(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/main.rs:176:11 [INFO] [stdout] | [INFO] [stdout] 176 | Fatal(String), [INFO] [stdout] | ----- ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Error` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 176 | Fatal(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:110:15 [INFO] [stdout] | [INFO] [stdout] 106 | pub fn deserialize<'de, D>(deserializer: D) -> Result, D::Error> [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | match duration_format::deserialize(deserializer) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:110:15 [INFO] [stdout] | [INFO] [stdout] 106 | pub fn deserialize<'de, D>(deserializer: D) -> Result, D::Error> [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | match duration_format::deserialize(deserializer) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `blink-timer` (bin "blink-timer" test) due to 2 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `blink-timer` (bin "blink-timer") due to 2 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "459e33528e2744ccaae4ab71853372ee2550011323141fac1a44488fffcacecd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "459e33528e2744ccaae4ab71853372ee2550011323141fac1a44488fffcacecd", kill_on_drop: false }` [INFO] [stdout] 459e33528e2744ccaae4ab71853372ee2550011323141fac1a44488fffcacecd