[INFO] fetching crate blend-inspect-rs 0.3.0... [INFO] checking blend-inspect-rs-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate blend-inspect-rs 0.3.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate blend-inspect-rs 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate blend-inspect-rs 0.3.0 [INFO] finished tweaking crates.io crate blend-inspect-rs 0.3.0 [INFO] tweaked toml for crates.io crate blend-inspect-rs 0.3.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 25 packages to latest compatible versions [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding num v0.2.1 (latest: v0.4.3) [INFO] [stderr] Adding num-bigint v0.2.6 (latest: v0.4.6) [INFO] [stderr] Adding num-complex v0.2.4 (latest: v0.4.6) [INFO] [stderr] Adding num-rational v0.2.4 (latest: v0.4.2) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 26f29a57dbee8efd970774b313eb5e2b516642cf1415e744b4e58e68a343e40c [INFO] running `Command { std: "docker" "start" "-a" "26f29a57dbee8efd970774b313eb5e2b516642cf1415e744b4e58e68a343e40c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "26f29a57dbee8efd970774b313eb5e2b516642cf1415e744b4e58e68a343e40c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "26f29a57dbee8efd970774b313eb5e2b516642cf1415e744b4e58e68a343e40c", kill_on_drop: false }` [INFO] [stdout] 26f29a57dbee8efd970774b313eb5e2b516642cf1415e744b4e58e68a343e40c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 704dbeda908f208327e8ca3176da2b81a2bc96c525e731af062e1bbb28acd47b [INFO] running `Command { std: "docker" "start" "-a" "704dbeda908f208327e8ca3176da2b81a2bc96c525e731af062e1bbb28acd47b", kill_on_drop: false }` [INFO] [stderr] Compiling num-bigint v0.2.6 [INFO] [stderr] Compiling num-complex v0.2.4 [INFO] [stderr] Compiling num-rational v0.2.4 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking num v0.2.1 [INFO] [stderr] Checking hamcrest2 v0.3.0 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking blend-inspect-rs v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `endianness` is never read [INFO] [stdout] --> src/analyse/mod.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 14 | pub struct Structure { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 15 | endianness: Endianness, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Structure` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:96:8 [INFO] [stdout] | [INFO] [stdout] 80 | pub fn inspect<'a, A>(source: A) -> Result [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | let structure = analyse(&blend_file, Mode::All) [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | Ok(Blend { [INFO] [stdout] | ________^ [INFO] [stdout] 97 | | blend_file, [INFO] [stdout] 98 | | structure [INFO] [stdout] 99 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/analyse/analysers.rs:72:8 [INFO] [stdout] | [INFO] [stdout] 49 | let mut structs: HashMap = HashMap::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | Ok(Structure::new( [INFO] [stdout] | ________^ [INFO] [stdout] 73 | | file_header.endianness, [INFO] [stdout] 74 | | structs.into_iter().map(|(_, strct)| strct).collect(), [INFO] [stdout] 75 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/analyse/analysers.rs:210:64 [INFO] [stdout] | [INFO] [stdout] 209 | ... (0..pointers).fold(result_type, |result, _| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 210 | ... Type::Pointer { base_type: Box::new(result), size: dna.pointer_size } [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/analyse/analysers.rs:219:66 [INFO] [stdout] | [INFO] [stdout] 218 | ... .fold(result_type, |result, array_size| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 219 | ... Type::Array { base_type: Box::new(result), length: array_size.parse::().unwrap() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/analyse/analysers.rs:240:9 [INFO] [stdout] | [INFO] [stdout] 239 | analyse_type(&base_type, dna).and_then(|base_type| { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 240 | parse_field_name(field_name, &base_type, dna) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/analyse/analysers.rs:268:8 [INFO] [stdout] | [INFO] [stdout] 257 | let fields = { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 268 | Ok(Struct::new(index, dna_struct.type_index, name, fields, size)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse/parsers.rs:219:5 [INFO] [stdout] | [INFO] [stdout] 211 | let parse_file_header = preceded( [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 219 | / map(parse_file_header, |(pointer_size, endianness, version)| { [INFO] [stdout] 220 | | FileHeader { [INFO] [stdout] 221 | | pointer_size, [INFO] [stdout] 222 | | endianness, [INFO] [stdout] 223 | | version, [INFO] [stdout] 224 | | } [INFO] [stdout] 225 | | })(input) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `blend-inspect-rs` (lib) due to 8 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:96:8 [INFO] [stdout] | [INFO] [stdout] 80 | pub fn inspect<'a, A>(source: A) -> Result [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | let structure = analyse(&blend_file, Mode::All) [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | Ok(Blend { [INFO] [stdout] | ________^ [INFO] [stdout] 97 | | blend_file, [INFO] [stdout] 98 | | structure [INFO] [stdout] 99 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/analyse/analysers.rs:72:8 [INFO] [stdout] | [INFO] [stdout] 49 | let mut structs: HashMap = HashMap::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | Ok(Structure::new( [INFO] [stdout] | ________^ [INFO] [stdout] 73 | | file_header.endianness, [INFO] [stdout] 74 | | structs.into_iter().map(|(_, strct)| strct).collect(), [INFO] [stdout] 75 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/analyse/analysers.rs:210:64 [INFO] [stdout] | [INFO] [stdout] 209 | ... (0..pointers).fold(result_type, |result, _| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 210 | ... Type::Pointer { base_type: Box::new(result), size: dna.pointer_size } [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/analyse/analysers.rs:219:66 [INFO] [stdout] | [INFO] [stdout] 218 | ... .fold(result_type, |result, array_size| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 219 | ... Type::Array { base_type: Box::new(result), length: array_size.parse::().unwrap() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/analyse/analysers.rs:240:9 [INFO] [stdout] | [INFO] [stdout] 239 | analyse_type(&base_type, dna).and_then(|base_type| { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 240 | parse_field_name(field_name, &base_type, dna) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/analyse/analysers.rs:268:8 [INFO] [stdout] | [INFO] [stdout] 257 | let fields = { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 268 | Ok(Struct::new(index, dna_struct.type_index, name, fields, size)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse/parsers.rs:219:5 [INFO] [stdout] | [INFO] [stdout] 211 | let parse_file_header = preceded( [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 219 | / map(parse_file_header, |(pointer_size, endianness, version)| { [INFO] [stdout] 220 | | FileHeader { [INFO] [stdout] 221 | | pointer_size, [INFO] [stdout] 222 | | endianness, [INFO] [stdout] 223 | | version, [INFO] [stdout] 224 | | } [INFO] [stdout] 225 | | })(input) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `blend-inspect-rs` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "704dbeda908f208327e8ca3176da2b81a2bc96c525e731af062e1bbb28acd47b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "704dbeda908f208327e8ca3176da2b81a2bc96c525e731af062e1bbb28acd47b", kill_on_drop: false }` [INFO] [stdout] 704dbeda908f208327e8ca3176da2b81a2bc96c525e731af062e1bbb28acd47b