[INFO] fetching crate blarg 1.0.4... [INFO] checking blarg-1.0.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate blarg 1.0.4 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate blarg 1.0.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate blarg 1.0.4 [INFO] finished tweaking crates.io crate blarg 1.0.4 [INFO] tweaked toml for crates.io crate blarg 1.0.4 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate blarg 1.0.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e9c36a5c1383fb4b5cd988dbe31461545fab58d30544498eb27bae3b1f7de220 [INFO] running `Command { std: "docker" "start" "-a" "e9c36a5c1383fb4b5cd988dbe31461545fab58d30544498eb27bae3b1f7de220", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e9c36a5c1383fb4b5cd988dbe31461545fab58d30544498eb27bae3b1f7de220", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e9c36a5c1383fb4b5cd988dbe31461545fab58d30544498eb27bae3b1f7de220", kill_on_drop: false }` [INFO] [stdout] e9c36a5c1383fb4b5cd988dbe31461545fab58d30544498eb27bae3b1f7de220 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 097bb3894dc9237897a3ef6e1654180867ca5ce8ee64c0db64a5e8d19414c94d [INFO] running `Command { std: "docker" "start" "-a" "097bb3894dc9237897a3ef6e1654180867ca5ce8ee64c0db64a5e8d19414c94d", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.70 [INFO] [stderr] Compiling rustix v0.38.26 [INFO] [stderr] Compiling thiserror v1.0.50 [INFO] [stderr] Checking linux-raw-sys v0.4.12 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling syn v2.0.39 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Compiling thiserror-impl v1.0.50 [INFO] [stderr] Compiling blarg_derive v1.0.4 [INFO] [stderr] Checking blarg_builder v1.0.4 [INFO] [stderr] Checking blarg v1.0.4 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> examples/dynamic_sub_command.rs:25:25 [INFO] [stdout] | [INFO] [stdout] 24 | let mut clp = clp.branch(condition).command(1, |sub_command| { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | sub_command.add(Parameter::argument(Scalar::new(&mut arg_1), "arg")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> examples/dynamic_sub_command.rs:30:29 [INFO] [stdout] | [INFO] [stdout] 29 | clp = clp.command(0, |sub_command| { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | sub_command.add(Parameter::argument(Scalar::new(&mut arg_0), "arg")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> examples/dynamic_sub_command.rs:36:29 [INFO] [stdout] | [INFO] [stdout] 35 | clp = clp.command(2, |sub_command| { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | sub_command.add(Parameter::argument(Scalar::new(&mut arg_2), "arg")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `blarg` (example "dynamic_sub_command") due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> examples/foo_bar.rs:75:13 [INFO] [stdout] | [INFO] [stdout] 74 | .command(FooBar::Foo, |sub| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | / sub.add(Parameter::option( [INFO] [stdout] 76 | | Optional::new(&mut initial), [INFO] [stdout] 77 | | "initial", [INFO] [stdout] 78 | | None, [INFO] [stdout] 79 | | )) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> examples/foo_bar.rs:81:17 [INFO] [stdout] | [INFO] [stdout] 74 | .command(FooBar::Foo, |sub| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | / Parameter::argument(Collection::new(&mut items, Nargs::Any), "item") [INFO] [stdout] 82 | | .help("The items."), [INFO] [stdout] | |_______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> examples/foo_bar.rs:86:21 [INFO] [stdout] | [INFO] [stdout] 85 | .command(FooBar::Bar, |sub| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | sub.add(Parameter::option( [INFO] [stdout] | _____________________^ [INFO] [stdout] 87 | | Collection::new(&mut countries, Nargs::AtLeastOne), [INFO] [stdout] 88 | | "country", [INFO] [stdout] 89 | | None, [INFO] [stdout] 90 | | )) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> examples/derived_edgy.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 27 | fn elective_choices(value: Parameter) -> Parameter { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | / value [INFO] [stdout] 29 | | .choice(0, "0th") [INFO] [stdout] 30 | | .choice(1, "1st") [INFO] [stdout] 31 | | .choice(2, "2nd") [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> examples/demo_sub_command.rs:24:13 [INFO] [stdout] | [INFO] [stdout] 23 | .command(0, |sub_command| { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | / sub_command [INFO] [stdout] 25 | | .about("Describe the 0 sub-command parser. Let's make it a little long for fun.") [INFO] [stdout] 26 | | .add(Parameter::argument(Scalar::new(&mut arg_0), "arg")) [INFO] [stdout] | |_________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> examples/demo_sub_command.rs:27:22 [INFO] [stdout] | [INFO] [stdout] 23 | .command(0, |sub_command| { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | .add(Parameter::option( [INFO] [stdout] | ______________________^ [INFO] [stdout] 28 | | Switch::new(&mut opt_0, true), [INFO] [stdout] 29 | | "opt", [INFO] [stdout] 30 | | None, [INFO] [stdout] 31 | | )) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> examples/demo_sub_command.rs:34:13 [INFO] [stdout] | [INFO] [stdout] 33 | .command(1, |sub_command| { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | / sub_command [INFO] [stdout] 35 | | .about("Describe the 1 sub-command parser.") [INFO] [stdout] | |____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> examples/demo_sub_command.rs:36:22 [INFO] [stdout] | [INFO] [stdout] 33 | .command(1, |sub_command| { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | .add(Parameter::argument(Scalar::new(&mut arg_1), "arg")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `blarg` (example "foo_bar") due to 4 previous errors [INFO] [stderr] error: could not compile `blarg` (example "derived_edgy") due to 2 previous errors [INFO] [stderr] error: could not compile `blarg` (example "demo_sub_command") due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "097bb3894dc9237897a3ef6e1654180867ca5ce8ee64c0db64a5e8d19414c94d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "097bb3894dc9237897a3ef6e1654180867ca5ce8ee64c0db64a5e8d19414c94d", kill_on_drop: false }` [INFO] [stdout] 097bb3894dc9237897a3ef6e1654180867ca5ce8ee64c0db64a5e8d19414c94d