[INFO] fetching crate blackhole 0.20.2... [INFO] checking blackhole-0.20.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate blackhole 0.20.2 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate blackhole 0.20.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate blackhole 0.20.2 [INFO] finished tweaking crates.io crate blackhole 0.20.2 [INFO] tweaked toml for crates.io crate blackhole 0.20.2 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d06f6a271a60c295bd7f0fa36f68ebb5d59a36953e0c894b85972bc17598e84d [INFO] running `Command { std: "docker" "start" "-a" "d06f6a271a60c295bd7f0fa36f68ebb5d59a36953e0c894b85972bc17598e84d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d06f6a271a60c295bd7f0fa36f68ebb5d59a36953e0c894b85972bc17598e84d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d06f6a271a60c295bd7f0fa36f68ebb5d59a36953e0c894b85972bc17598e84d", kill_on_drop: false }` [INFO] [stdout] d06f6a271a60c295bd7f0fa36f68ebb5d59a36953e0c894b85972bc17598e84d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5d24dc0039b902f9e5de9c24d3640fa4f4ae778fc62277b1cc6a0438556736ab [INFO] running `Command { std: "docker" "start" "-a" "5d24dc0039b902f9e5de9c24d3640fa4f4ae778fc62277b1cc6a0438556736ab", kill_on_drop: false }` [INFO] [stderr] Checking blackhole v0.20.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `8` [INFO] [stdout] --> src/root.rs:149:25 [INFO] [stdout] | [INFO] [stdout] 149 | if cfg!(not(any(target_pointer_width="8", target_pointer_width="16"))) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `target_pointer_width` are: `16`, `32`, and `64` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `8` [INFO] [stdout] --> src/root.rs:149:25 [INFO] [stdout] | [INFO] [stdout] 149 | if cfg!(not(any(target_pointer_width="8", target_pointer_width="16"))) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `target_pointer_width` are: `16`, `32`, and `64` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/job.rs:87:16 [INFO] [stdout] | [INFO] [stdout] 85 | pub fn new(f: F) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | Self { [INFO] [stdout] 87 | f: Some(f), [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/root.rs:156:12 [INFO] [stdout] | [INFO] [stdout] 155 | let (sender, receiver) = mpsc::sync_channel::>(queue_limit); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 156 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 157 | | job_manager: spawn_job_manager(receiver, sender.clone(), active_limit, queue_limit)?, [INFO] [stdout] 158 | | job_sender: sender, [INFO] [stdout] 159 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/root.rs:168:15 [INFO] [stdout] | [INFO] [stdout] 166 | pub fn throw(&self, job: J) -> Result> { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 167 | let (sender, receiver) = mpsc::channel(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 168 | match self.job_sender.try_send(Msg::NewJob { job, sender }) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/root.rs:183:9 [INFO] [stdout] | [INFO] [stdout] 182 | pub unsafe fn escape(self) -> Result<()> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 183 | self.job_sender.send(Msg::StopJobManager) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/root.rs:189:15 [INFO] [stdout] | [INFO] [stdout] 188 | pub fn escape_on_idle(self) -> Result<()> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 189 | match self.job_sender.send(Msg::StopJobManagerOnIdle) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/root.rs:208:8 [INFO] [stdout] | [INFO] [stdout] 204 | job_manager_receiver: Receiver>, job_manager_sender: SyncSender>, active_limit: ActiveLimit, queue_limit: usize, [INFO] [stdout] | -------------------------------------- -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 208 | Ok(thread::spawn(move || { [INFO] [stdout] | ________^ [INFO] [stdout] 209 | | let mut active_jobs = Vec::with_capacity(active_limit); [INFO] [stdout] 210 | | let mut job_queue = Vec::with_capacity(queue_limit); [INFO] [stdout] 211 | | let mut stop_on_idle = false; [INFO] [stdout] ... | [INFO] [stdout] 276 | | } [INFO] [stdout] 277 | | })) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/root.rs:282:19 [INFO] [stdout] | [INFO] [stdout] 281 | fn spawn_job_runner(job_manager_sender: SyncSender>, mut job: J, handle: JobHandle) -> JobRunnerHandle where J: Job { [INFO] [stdout] | -------------------------------------- ---------- ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 282 | thread::spawn(move || { [INFO] [stdout] | ___________________^ [INFO] [stdout] 283 | | let (sender, receiver) = mpsc::channel(); [INFO] [stdout] 284 | | loop { [INFO] [stdout] 285 | | crate::run_to_end(job); [INFO] [stdout] ... | [INFO] [stdout] 302 | | } [INFO] [stdout] 303 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `blackhole` (lib) due to 8 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/job.rs:87:16 [INFO] [stdout] | [INFO] [stdout] 85 | pub fn new(f: F) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | Self { [INFO] [stdout] 87 | f: Some(f), [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/root.rs:156:12 [INFO] [stdout] | [INFO] [stdout] 155 | let (sender, receiver) = mpsc::sync_channel::>(queue_limit); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 156 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 157 | | job_manager: spawn_job_manager(receiver, sender.clone(), active_limit, queue_limit)?, [INFO] [stdout] 158 | | job_sender: sender, [INFO] [stdout] 159 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/root.rs:168:15 [INFO] [stdout] | [INFO] [stdout] 166 | pub fn throw(&self, job: J) -> Result> { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 167 | let (sender, receiver) = mpsc::channel(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 168 | match self.job_sender.try_send(Msg::NewJob { job, sender }) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/root.rs:183:9 [INFO] [stdout] | [INFO] [stdout] 182 | pub unsafe fn escape(self) -> Result<()> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 183 | self.job_sender.send(Msg::StopJobManager) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/root.rs:189:15 [INFO] [stdout] | [INFO] [stdout] 188 | pub fn escape_on_idle(self) -> Result<()> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 189 | match self.job_sender.send(Msg::StopJobManagerOnIdle) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/root.rs:208:8 [INFO] [stdout] | [INFO] [stdout] 204 | job_manager_receiver: Receiver>, job_manager_sender: SyncSender>, active_limit: ActiveLimit, queue_limit: usize, [INFO] [stdout] | -------------------------------------- -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 208 | Ok(thread::spawn(move || { [INFO] [stdout] | ________^ [INFO] [stdout] 209 | | let mut active_jobs = Vec::with_capacity(active_limit); [INFO] [stdout] 210 | | let mut job_queue = Vec::with_capacity(queue_limit); [INFO] [stdout] 211 | | let mut stop_on_idle = false; [INFO] [stdout] ... | [INFO] [stdout] 276 | | } [INFO] [stdout] 277 | | })) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/root.rs:282:19 [INFO] [stdout] | [INFO] [stdout] 281 | fn spawn_job_runner(job_manager_sender: SyncSender>, mut job: J, handle: JobHandle) -> JobRunnerHandle where J: Job { [INFO] [stdout] | -------------------------------------- ---------- ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 282 | thread::spawn(move || { [INFO] [stdout] | ___________________^ [INFO] [stdout] 283 | | let (sender, receiver) = mpsc::channel(); [INFO] [stdout] 284 | | loop { [INFO] [stdout] 285 | | crate::run_to_end(job); [INFO] [stdout] ... | [INFO] [stdout] 302 | | } [INFO] [stdout] 303 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `blackhole` (lib test) due to 8 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "5d24dc0039b902f9e5de9c24d3640fa4f4ae778fc62277b1cc6a0438556736ab", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5d24dc0039b902f9e5de9c24d3640fa4f4ae778fc62277b1cc6a0438556736ab", kill_on_drop: false }` [INFO] [stdout] 5d24dc0039b902f9e5de9c24d3640fa4f4ae778fc62277b1cc6a0438556736ab