[INFO] fetching crate bitvec_simd 0.20.5... [INFO] checking bitvec_simd-0.20.5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate bitvec_simd 0.20.5 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate bitvec_simd 0.20.5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate bitvec_simd 0.20.5 [INFO] finished tweaking crates.io crate bitvec_simd 0.20.5 [INFO] tweaked toml for crates.io crate bitvec_simd 0.20.5 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 82 packages to latest compatible versions [INFO] [stderr] Adding bit-vec v0.6.3 (latest: v0.8.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding criterion v0.3.6 (latest: v0.5.1) [INFO] [stderr] Adding criterion-plot v0.4.5 (latest: v0.5.0) [INFO] [stderr] Adding half v1.8.3 (latest: v2.4.1) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding radium v0.7.0 (latest: v1.1.0) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] [stderr] Adding wyz v0.5.1 (latest: v0.6.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b8c2f274e32670b88eab268d4b77de6be41291cf817561efcb2115e8a4c0e90e [INFO] running `Command { std: "docker" "start" "-a" "b8c2f274e32670b88eab268d4b77de6be41291cf817561efcb2115e8a4c0e90e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b8c2f274e32670b88eab268d4b77de6be41291cf817561efcb2115e8a4c0e90e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b8c2f274e32670b88eab268d4b77de6be41291cf817561efcb2115e8a4c0e90e", kill_on_drop: false }` [INFO] [stdout] b8c2f274e32670b88eab268d4b77de6be41291cf817561efcb2115e8a4c0e90e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9dfed2f478c35fd5143e5da1ffac405e8165c972a24c08d82404f762a253363c [INFO] running `Command { std: "docker" "start" "-a" "9dfed2f478c35fd5143e5da1ffac405e8165c972a24c08d82404f762a253363c", kill_on_drop: false }` [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking plotters-backend v0.3.6 [INFO] [stderr] Checking bytemuck v1.17.1 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking half v1.8.3 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking wyz v0.5.1 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking serde_test v1.0.177 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking bitvec v1.0.1 [INFO] [stderr] Checking plotters-svg v0.3.6 [INFO] [stderr] Checking safe_arch v0.7.2 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking wide v0.7.28 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking criterion-plot v0.4.5 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking bitvec_simd v0.20.5 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:728:18 [INFO] [stdout] | [INFO] [stdout] 727 | pub fn difference(self, other: Self) -> Self { [INFO] [stdout] | ---- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 728 | self.and(other.not()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:733:31 [INFO] [stdout] | [INFO] [stdout] 733 | self.and_cloned(&other.clone().not()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `BitVecSimd` does not implement `Clone`, so calling `clone` on `&BitVecSimd` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 733 - self.and_cloned(&other.clone().not()) [INFO] [stdout] 733 + self.and_cloned(&other.not()) [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `BitVecSimd`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 100 + #[derive(Clone)] [INFO] [stdout] 101 | pub struct BitVecSimd [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1002:9 [INFO] [stdout] | [INFO] [stdout] 1001 | fn from(v: BitVecSimd) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1002 | / v.storage [INFO] [stdout] 1003 | | .into_iter() [INFO] [stdout] 1004 | | .flat_map(|x| x.to_array()) [INFO] [stdout] 1005 | | .flat_map(|x| { [INFO] [stdout] ... | [INFO] [stdout] 1008 | | }) [INFO] [stdout] 1009 | | .take(v.nbits) [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1020:9 [INFO] [stdout] | [INFO] [stdout] 1019 | fn from(v: BitVecSimd) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1020 | / v.storage [INFO] [stdout] 1021 | | .into_iter() [INFO] [stdout] 1022 | | .flat_map(|x| x.to_array()) [INFO] [stdout] 1023 | | .flat_map(|x| { (0..A::Item::ELEMENT_BIT_WIDTH).map(move |i| (x.wrapping_shr(i as u32)) & A::Item::ONE_ELEMENT != A::Item::ZE... [INFO] [stdout] ... | [INFO] [stdout] 1026 | | .filter(|(_, b)| *b) [INFO] [stdout] 1027 | | .map(|(i, _)| i) [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bitvec_simd` (lib) due to 4 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "9dfed2f478c35fd5143e5da1ffac405e8165c972a24c08d82404f762a253363c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9dfed2f478c35fd5143e5da1ffac405e8165c972a24c08d82404f762a253363c", kill_on_drop: false }` [INFO] [stdout] 9dfed2f478c35fd5143e5da1ffac405e8165c972a24c08d82404f762a253363c