[INFO] fetching crate bitkv-rs 0.2.1... [INFO] checking bitkv-rs-0.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate bitkv-rs 0.2.1 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate bitkv-rs 0.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate bitkv-rs 0.2.1 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate bitkv-rs 0.2.1 [INFO] tweaked toml for crates.io crate bitkv-rs 0.2.1 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate bitkv-rs 0.2.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 82c00248e33694c95837a5fc18e71329b221aabf151c54669eab96766aee76b2 [INFO] running `Command { std: "docker" "start" "-a" "82c00248e33694c95837a5fc18e71329b221aabf151c54669eab96766aee76b2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "82c00248e33694c95837a5fc18e71329b221aabf151c54669eab96766aee76b2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "82c00248e33694c95837a5fc18e71329b221aabf151c54669eab96766aee76b2", kill_on_drop: false }` [INFO] [stdout] 82c00248e33694c95837a5fc18e71329b221aabf151c54669eab96766aee76b2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] dd29cef9e9d2e924c03aa0966f1dd0d4934a51ee4b8d4ee79a99b3e81d638ad5 [INFO] running `Command { std: "docker" "start" "-a" "dd29cef9e9d2e924c03aa0966f1dd0d4934a51ee4b8d4ee79a99b3e81d638ad5", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Compiling anyhow v1.0.81 [INFO] [stderr] Compiling rustix v0.38.32 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking either v1.10.0 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Compiling syn v2.0.52 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Compiling serde_json v1.0.115 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking regex-automata v0.4.5 [INFO] [stderr] Compiling itertools v0.11.0 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking half v2.4.0 [INFO] [stderr] Compiling thiserror v1.0.57 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Compiling crc32fast v1.4.0 [INFO] [stderr] Checking plotters-backend v0.3.5 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking smallvec v1.13.1 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking plotters-svg v0.3.5 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking sha3 v0.10.8 [INFO] [stderr] Checking rayon-core v1.12.1 [INFO] [stderr] Checking page_size v0.6.0 [INFO] [stderr] Checking memmap2 v0.9.4 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking bumpalo v3.15.4 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking plotters v0.3.5 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Checking fs4 v0.7.0 [INFO] [stderr] Checking jammdb v0.11.0 [INFO] [stderr] Checking env_filter v0.1.0 [INFO] [stderr] Checking env_logger v0.11.2 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking crossbeam-skiplist v0.1.3 [INFO] [stderr] Checking fs_extra v1.3.0 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling prost-derive v0.12.3 [INFO] [stderr] Compiling thiserror-impl v1.0.57 [INFO] [stderr] Checking prost v0.12.3 [INFO] [stderr] Checking bitkv-rs v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/data_file.rs:28:14 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new>(dir_path: P, file_id: u32, io_type: IOManagerType) -> Result { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let file_name = get_data_file_name(&dir_path, file_id); [INFO] [stdout] 27 | let io_manager = new_io_manager(&file_name, &io_type); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | Ok(Self { [INFO] [stdout] | ______________^ [INFO] [stdout] 29 | | file_id: std::sync::Arc::new(parking_lot::RwLock::new(file_id)), [INFO] [stdout] 30 | | write_off: std::sync::Arc::new(parking_lot::RwLock::new(0)), [INFO] [stdout] 31 | | io_manager, [INFO] [stdout] 32 | | }) [INFO] [stdout] | |___________^ [INFO] [stdout] ... [INFO] [stdout] 61 | new_data_file!(); [INFO] [stdout] | ---------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `new_data_file` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/data_file.rs:43:18 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn $name>(dir_path: P) -> Result { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | let io_manager = new_io_manager(&file_name, &$io_type); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | Ok(Self { [INFO] [stdout] | __________________^ [INFO] [stdout] 44 | | file_id: std::sync::Arc::new(parking_lot::RwLock::new($file_id)), [INFO] [stdout] 45 | | write_off: std::sync::Arc::new(parking_lot::RwLock::new(0)), [INFO] [stdout] 46 | | io_manager, [INFO] [stdout] 47 | | }) [INFO] [stdout] | |_______________^ [INFO] [stdout] ... [INFO] [stdout] 64 | / new_data_file!( [INFO] [stdout] 65 | | new_hint_file, [INFO] [stdout] 66 | | 0, [INFO] [stdout] 67 | | IOManagerType::StandardFileIO, [INFO] [stdout] ... | [INFO] [stdout] 76 | | Some(SEQ_NO_FILE_NAME); [INFO] [stdout] 77 | | ); [INFO] [stdout] | |___- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `new_data_file` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fio/file_io.rs:24:11 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn new

(file_name: P) -> Result [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | match OpenOptions::new() [INFO] [stdout] | ___________^ [INFO] [stdout] 25 | | .create(true) [INFO] [stdout] 26 | | .read(true) [INFO] [stdout] 27 | | .append(true) [INFO] [stdout] 28 | | .open(file_name) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fio/file_io.rs:44:11 [INFO] [stdout] | [INFO] [stdout] 43 | let read_guard = self.fd.read(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | match read_guard.read_at(buf, offset) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fio/file_io.rs:55:11 [INFO] [stdout] | [INFO] [stdout] 54 | let mut write_guard = self.fd.write(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | match write_guard.write(buf) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fio/file_io.rs:75:5 [INFO] [stdout] | [INFO] [stdout] 74 | let read_guard = self.fd.read(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | read_guard.metadata().unwrap().len() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fio/mmap.rs:21:11 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn new

(file_name: P) -> Result [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | match OpenOptions::new() [INFO] [stdout] | ___________^ [INFO] [stdout] 22 | | .create(true) [INFO] [stdout] 23 | | .read(true) [INFO] [stdout] 24 | | .append(true) [INFO] [stdout] 25 | | .open(file_name) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/index/bptree.rs:63:5 [INFO] [stdout] | [INFO] [stdout] 61 | let tx = self.tree.tx(false).expect("failed to begin tx"); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | let bucket = tx.get_bucket(BPTREE_BUCKET_NAME).unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | / bucket [INFO] [stdout] 64 | | .get_kv(&key) [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db.rs:356:8 [INFO] [stdout] | [INFO] [stdout] 333 | let active_file = self.active_data_file.read(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 334 | let oldre_files = self.old_data_files.read(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 356 | Ok(log_record.value.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/file.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn dir_disk_size>(dir_path: P) -> u64 { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | match fs_extra::dir::get_size(dir_path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bitkv-rs` (lib) due to 11 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "dd29cef9e9d2e924c03aa0966f1dd0d4934a51ee4b8d4ee79a99b3e81d638ad5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dd29cef9e9d2e924c03aa0966f1dd0d4934a51ee4b8d4ee79a99b3e81d638ad5", kill_on_drop: false }` [INFO] [stdout] dd29cef9e9d2e924c03aa0966f1dd0d4934a51ee4b8d4ee79a99b3e81d638ad5