[INFO] fetching crate bitcoind-json-rpc-regtest 0.3.0... [INFO] checking bitcoind-json-rpc-regtest-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate bitcoind-json-rpc-regtest 0.3.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate bitcoind-json-rpc-regtest 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate bitcoind-json-rpc-regtest 0.3.0 [INFO] finished tweaking crates.io crate bitcoind-json-rpc-regtest 0.3.0 [INFO] tweaked toml for crates.io crate bitcoind-json-rpc-regtest 0.3.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 120 packages to latest compatible versions [INFO] [stderr] Adding base64 v0.13.1 (latest: v0.22.1) [INFO] [stderr] Adding constant_time_eq v0.1.5 (latest: v0.3.1) [INFO] [stderr] Adding env_logger v0.9.3 (latest: v0.11.5) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding password-hash v0.4.2 (latest: v0.5.0) [INFO] [stderr] Adding pbkdf2 v0.11.0 (latest: v0.12.2) [INFO] [stderr] Adding rustls v0.21.12 (latest: v0.23.12) [INFO] [stderr] Adding rustls-webpki v0.101.7 (latest: v0.102.7) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding webpki-roots v0.25.4 (latest: v0.26.5) [INFO] [stderr] Adding which v4.4.2 (latest: v6.0.3) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding zip v0.6.6 (latest: v2.2.0) [INFO] [stderr] Adding zstd v0.11.2+zstd.1.5.2 (latest: v0.13.2) [INFO] [stderr] Adding zstd-safe v5.0.2+zstd.1.5.2 (latest: v7.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b5a1029e7ecc0eb78a0f7ed38e7549c3bb6dbefce42edf9fe4edccc649de6f99 [INFO] running `Command { std: "docker" "start" "-a" "b5a1029e7ecc0eb78a0f7ed38e7549c3bb6dbefce42edf9fe4edccc649de6f99", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b5a1029e7ecc0eb78a0f7ed38e7549c3bb6dbefce42edf9fe4edccc649de6f99", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b5a1029e7ecc0eb78a0f7ed38e7549c3bb6dbefce42edf9fe4edccc649de6f99", kill_on_drop: false }` [INFO] [stdout] b5a1029e7ecc0eb78a0f7ed38e7549c3bb6dbefce42edf9fe4edccc649de6f99 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 74d9388c0cb5f9a2f3b70a38dc89f5e81618dcbdb15d9a6120e0b26eccb60b52 [INFO] running `Command { std: "docker" "start" "-a" "74d9388c0cb5f9a2f3b70a38dc89f5e81618dcbdb15d9a6120e0b26eccb60b52", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Compiling bitcoin-internals v0.3.0 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking bitcoin-io v0.1.2 [INFO] [stderr] Compiling hex_lit v0.1.1 [INFO] [stderr] Compiling secp256k1-sys v0.10.0 [INFO] [stderr] Compiling minreq v2.12.0 [INFO] [stderr] Compiling bitcoin v0.32.2 [INFO] [stderr] Checking bech32 v0.11.0 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking hex-conservative v0.2.1 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Compiling bitcoind-json-rpc-regtest v0.3.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking which v4.4.2 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking env_logger v0.9.3 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking bitcoin_hashes v0.14.0 [INFO] [stderr] Checking bitcoin-units v0.1.2 [INFO] [stderr] Checking secp256k1 v0.29.0 [INFO] [stderr] Checking base58ck v0.1.0 [INFO] [stderr] Checking jsonrpc v0.18.0 [INFO] [stderr] Checking bitcoind-json-rpc-types v0.3.0 [INFO] [stderr] Checking bitcoind-json-rpc-client v0.3.0 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:428:12 [INFO] [stdout] | [INFO] [stdout] 280 | pub fn with_conf>(exe: S, conf: &Conf) -> anyhow::Result { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 283 | let work_dir = match (&tmpdir, &conf.staticdir) { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 345 | let stdout = if conf.view_stdout { Stdio::inherit() } else { Stdio::null() }; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 360 | let mut process = Command::new(exe.as_ref()) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 388 | let client_base = [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 391 | let client = loop { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 392 | // Just use serde value because changes to the GetBlockchainInfo type make debugging hard. [INFO] [stdout] 393 | let client_result: Result = [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 405 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 428 | Ok(BitcoinD { [INFO] [stdout] | ____________^ [INFO] [stdout] 429 | | process, [INFO] [stdout] 430 | | client, [INFO] [stdout] 431 | | work_dir, [INFO] [stdout] ... | [INFO] [stdout] 438 | | }, [INFO] [stdout] 439 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:471:12 [INFO] [stdout] | [INFO] [stdout] 469 | pub fn create_wallet>(&self, wallet: T) -> anyhow::Result { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 470 | let _ = self.client.create_wallet(wallet.as_ref())?; [INFO] [stdout] 471 | Ok(Client::new_with_auth( [INFO] [stdout] | ____________^ [INFO] [stdout] 472 | | &self.rpc_url_with_wallet(wallet), [INFO] [stdout] 473 | | Auth::CookieFile(self.params.cookie_file.clone()), [INFO] [stdout] 474 | | )?) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:554:22 [INFO] [stdout] | [INFO] [stdout] 554 | .map_err(|_| Error::NoBitcoindExecutableFound.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bitcoind-json-rpc-regtest` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:428:12 [INFO] [stdout] | [INFO] [stdout] 280 | pub fn with_conf>(exe: S, conf: &Conf) -> anyhow::Result { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 283 | let work_dir = match (&tmpdir, &conf.staticdir) { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 345 | let stdout = if conf.view_stdout { Stdio::inherit() } else { Stdio::null() }; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 360 | let mut process = Command::new(exe.as_ref()) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 388 | let client_base = [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 391 | let client = loop { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 392 | // Just use serde value because changes to the GetBlockchainInfo type make debugging hard. [INFO] [stdout] 393 | let client_result: Result = [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 405 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 428 | Ok(BitcoinD { [INFO] [stdout] | ____________^ [INFO] [stdout] 429 | | process, [INFO] [stdout] 430 | | client, [INFO] [stdout] 431 | | work_dir, [INFO] [stdout] ... | [INFO] [stdout] 438 | | }, [INFO] [stdout] 439 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:471:12 [INFO] [stdout] | [INFO] [stdout] 469 | pub fn create_wallet>(&self, wallet: T) -> anyhow::Result { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 470 | let _ = self.client.create_wallet(wallet.as_ref())?; [INFO] [stdout] 471 | Ok(Client::new_with_auth( [INFO] [stdout] | ____________^ [INFO] [stdout] 472 | | &self.rpc_url_with_wallet(wallet), [INFO] [stdout] 473 | | Auth::CookieFile(self.params.cookie_file.clone()), [INFO] [stdout] 474 | | )?) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:554:22 [INFO] [stdout] | [INFO] [stdout] 554 | .map_err(|_| Error::NoBitcoindExecutableFound.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bitcoind-json-rpc-regtest` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "74d9388c0cb5f9a2f3b70a38dc89f5e81618dcbdb15d9a6120e0b26eccb60b52", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "74d9388c0cb5f9a2f3b70a38dc89f5e81618dcbdb15d9a6120e0b26eccb60b52", kill_on_drop: false }` [INFO] [stdout] 74d9388c0cb5f9a2f3b70a38dc89f5e81618dcbdb15d9a6120e0b26eccb60b52