[INFO] fetching crate bitcoin-proptest 0.0.1-alpha.3... [INFO] checking bitcoin-proptest-0.0.1-alpha.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate bitcoin-proptest 0.0.1-alpha.3 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate bitcoin-proptest 0.0.1-alpha.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate bitcoin-proptest 0.0.1-alpha.3 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate bitcoin-proptest 0.0.1-alpha.3 [INFO] tweaked toml for crates.io crate bitcoin-proptest 0.0.1-alpha.3 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate bitcoin-proptest 0.0.1-alpha.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c0a9a9e4807fde76ecaee5f4e8767cd68ddc37a14839892b5ad172a8a15457e3 [INFO] running `Command { std: "docker" "start" "-a" "c0a9a9e4807fde76ecaee5f4e8767cd68ddc37a14839892b5ad172a8a15457e3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c0a9a9e4807fde76ecaee5f4e8767cd68ddc37a14839892b5ad172a8a15457e3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c0a9a9e4807fde76ecaee5f4e8767cd68ddc37a14839892b5ad172a8a15457e3", kill_on_drop: false }` [INFO] [stdout] c0a9a9e4807fde76ecaee5f4e8767cd68ddc37a14839892b5ad172a8a15457e3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 76b8e6d55f2d7c13e9f6f7376578f399b230d1f16ba71bd1b25667dac38e7dae [INFO] running `Command { std: "docker" "start" "-a" "76b8e6d55f2d7c13e9f6f7376578f399b230d1f16ba71bd1b25667dac38e7dae", kill_on_drop: false }` [INFO] [stderr] Compiling cc v1.0.95 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling proc-macro2 v1.0.83 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Compiling memchr v2.7.2 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Compiling regex-syntax v0.8.3 [INFO] [stderr] Compiling bitcoin-internals v0.2.0 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Compiling hex_lit v0.1.1 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Checking hex-conservative v0.1.1 [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Checking fastrand v2.0.2 [INFO] [stderr] Compiling bitcoin v0.31.2 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Checking bech32 v0.10.0-beta [INFO] [stderr] Checking unarray v0.1.4 [INFO] [stderr] Checking bitcoin_hashes v0.13.0 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Checking getrandom v0.2.14 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Compiling tree-sitter v0.22.6 [INFO] [stderr] Compiling secp256k1-sys v0.9.2 [INFO] [stderr] Compiling tree-sitter-rust v0.21.2 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand_xorshift v0.3.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Checking rusty-fork v0.3.0 [INFO] [stderr] Compiling regex-automata v0.4.6 [INFO] [stderr] Checking proptest v1.4.0 [INFO] [stderr] Checking secp256k1 v0.28.2 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling blarg_derive v1.0.4 [INFO] [stderr] Compiling regex v1.10.4 [INFO] [stderr] Checking blarg_builder v1.0.4 [INFO] [stderr] Checking blarg v1.0.4 [INFO] [stderr] Compiling bitcoin-proptest v0.0.1-alpha.3 (/opt/rustwide/workdir) [INFO] [stderr] Checking miniscript v11.0.0 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prop/bitcoin/address.rs:73:13 [INFO] [stdout] | [INFO] [stdout] 72 | pub fn build(network: impl Strategy) -> impl Strategy { [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | super::build(network).prop_map(|addr| addr.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prop/bitcoin/address.rs:106:13 [INFO] [stdout] | [INFO] [stdout] 105 | pub fn build(network: impl Strategy) -> impl Strategy { [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | super::build(network).prop_map(|addr| addr.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prop/bitcoin/address.rs:129:9 [INFO] [stdout] | [INFO] [stdout] 126 | network: impl Strategy, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | script: impl Strategy, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | ) -> impl Strategy { [INFO] [stdout] 129 | (network, script).prop_map(|(network, script)| Address::p2sh(&script, network).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prop/bitcoin/address.rs:142:13 [INFO] [stdout] | [INFO] [stdout] 139 | network: impl Strategy, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 140 | script: impl Strategy, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 141 | ) -> impl Strategy { [INFO] [stdout] 142 | super::build(network, script).prop_map(|addr| addr.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prop/bitcoin/address.rs:175:13 [INFO] [stdout] | [INFO] [stdout] 174 | pub fn build(network: impl Strategy) -> impl Strategy { [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 175 | super::build(network).prop_map(|addr| addr.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prop/bitcoin/bip32.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 30 | network: impl Strategy, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | seed: impl Strategy, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | ) -> impl Strategy { [INFO] [stdout] 33 | (network, seed).prop_map(|(n, s)| match s { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prop/bitcoin/bip32.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 52 | network: impl Strategy, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | seed: impl Strategy, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | ) -> impl Strategy { [INFO] [stdout] 55 | super::build(network, seed).prop_map(|xprv| xprv.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prop/bitcoin/bip32.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 70 | network: impl Strategy, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | seed: impl Strategy, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | ) -> impl Strategy { [INFO] [stdout] 73 | super::xpriv::build(network, seed).prop_map(|prv| Xpub::from_priv(&Secp256k1::new(), &prv)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prop/bitcoin/bip32.rs:73:76 [INFO] [stdout] | [INFO] [stdout] 73 | super::xpriv::build(network, seed).prop_map(|prv| Xpub::from_priv(&Secp256k1::new(), &prv)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prop/bitcoin/descriptor/pkh.rs:79:21 [INFO] [stdout] | [INFO] [stdout] 78 | super::valid::build(Just(descpk)).prop_flat_map(move |desc| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | public_key::invalid::compressed::hex().prop_map(move |nopk| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prop/bitcoin/descriptor/pkh.rs:79:69 [INFO] [stdout] | [INFO] [stdout] 78 | super::valid::build(Just(descpk)).prop_flat_map(move |desc| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | public_key::invalid::compressed::hex().prop_map(move |nopk| { [INFO] [stdout] | _____________________________________________________________________^ [INFO] [stdout] 80 | | let pk = hex::encode(pk.serialize()); [INFO] [stdout] 81 | | let valid_desc = desc.to_string(); [INFO] [stdout] 82 | | let invalid_desc = valid_desc.replace(&pk, &nopk); [INFO] [stdout] ... | [INFO] [stdout] 86 | | format!("{desc}#{checksum}") [INFO] [stdout] 87 | | }) [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prop/bitcoin/descriptor/public_key.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 53 | xkey: impl Strategy, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | derivation_path: impl Strategy, [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | wildcard: impl Strategy, [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | ) -> impl Strategy { [INFO] [stdout] 57 | (xkey, derivation_path, wildcard).prop_map(|(xkey, derivation_path, wildcard)| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prop/bitcoin/descriptor/tr.rs:46:53 [INFO] [stdout] | [INFO] [stdout] 46 | public_key.prop_map(|pk| Descriptor::Tr(Tr::new(pk, None).unwrap())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prop/bitcoin/descriptor/tr.rs:79:13 [INFO] [stdout] | [INFO] [stdout] 76 | internal_key: impl Strategy, [INFO] [stdout] | -------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | tap_tree: impl Strategy>, [INFO] [stdout] | ------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | ) -> impl Strategy> { [INFO] [stdout] 79 | (internal_key, prop::option::of(tap_tree)).prop_map(|(int, tree)| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prop/bitcoin/descriptor/tr.rs:80:32 [INFO] [stdout] | [INFO] [stdout] 79 | (internal_key, prop::option::of(tap_tree)).prop_map(|(int, tree)| { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | Descriptor::Tr(Tr::new(int, tree).expect("valid recursion")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prop/bitcoin/descriptor/tr.rs:108:17 [INFO] [stdout] | [INFO] [stdout] 106 | public_keys: impl Strategy, [INFO] [stdout] | ------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | ) -> impl Strategy> { [INFO] [stdout] 108 | prop::collection::vec(public_keys, 1..10).prop_map(|keys| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prop/bitcoin/descriptor/tr.rs:120:21 [INFO] [stdout] | [INFO] [stdout] 109 | let leaves = keys [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | / leaves [INFO] [stdout] 121 | | .into_iter() [INFO] [stdout] 122 | | // TODO: randomly balance the tree [INFO] [stdout] 123 | | .reduce(TapTree::combine) [INFO] [stdout] | |_________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 17 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bitcoin-proptest` (lib) due to 18 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prop/bitcoin/address.rs:73:13 [INFO] [stdout] | [INFO] [stdout] 72 | pub fn build(network: impl Strategy) -> impl Strategy { [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | super::build(network).prop_map(|addr| addr.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prop/bitcoin/address.rs:106:13 [INFO] [stdout] | [INFO] [stdout] 105 | pub fn build(network: impl Strategy) -> impl Strategy { [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | super::build(network).prop_map(|addr| addr.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prop/bitcoin/address.rs:129:9 [INFO] [stdout] | [INFO] [stdout] 126 | network: impl Strategy, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | script: impl Strategy, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | ) -> impl Strategy { [INFO] [stdout] 129 | (network, script).prop_map(|(network, script)| Address::p2sh(&script, network).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prop/bitcoin/address.rs:142:13 [INFO] [stdout] | [INFO] [stdout] 139 | network: impl Strategy, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 140 | script: impl Strategy, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 141 | ) -> impl Strategy { [INFO] [stdout] 142 | super::build(network, script).prop_map(|addr| addr.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prop/bitcoin/address.rs:175:13 [INFO] [stdout] | [INFO] [stdout] 174 | pub fn build(network: impl Strategy) -> impl Strategy { [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 175 | super::build(network).prop_map(|addr| addr.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prop/bitcoin/bip32.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 30 | network: impl Strategy, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | seed: impl Strategy, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | ) -> impl Strategy { [INFO] [stdout] 33 | (network, seed).prop_map(|(n, s)| match s { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prop/bitcoin/bip32.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 52 | network: impl Strategy, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | seed: impl Strategy, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | ) -> impl Strategy { [INFO] [stdout] 55 | super::build(network, seed).prop_map(|xprv| xprv.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prop/bitcoin/bip32.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 70 | network: impl Strategy, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | seed: impl Strategy, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | ) -> impl Strategy { [INFO] [stdout] 73 | super::xpriv::build(network, seed).prop_map(|prv| Xpub::from_priv(&Secp256k1::new(), &prv)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prop/bitcoin/bip32.rs:73:76 [INFO] [stdout] | [INFO] [stdout] 73 | super::xpriv::build(network, seed).prop_map(|prv| Xpub::from_priv(&Secp256k1::new(), &prv)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prop/bitcoin/descriptor/pkh.rs:79:21 [INFO] [stdout] | [INFO] [stdout] 78 | super::valid::build(Just(descpk)).prop_flat_map(move |desc| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | public_key::invalid::compressed::hex().prop_map(move |nopk| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prop/bitcoin/descriptor/pkh.rs:79:69 [INFO] [stdout] | [INFO] [stdout] 78 | super::valid::build(Just(descpk)).prop_flat_map(move |desc| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | public_key::invalid::compressed::hex().prop_map(move |nopk| { [INFO] [stdout] | _____________________________________________________________________^ [INFO] [stdout] 80 | | let pk = hex::encode(pk.serialize()); [INFO] [stdout] 81 | | let valid_desc = desc.to_string(); [INFO] [stdout] 82 | | let invalid_desc = valid_desc.replace(&pk, &nopk); [INFO] [stdout] ... | [INFO] [stdout] 86 | | format!("{desc}#{checksum}") [INFO] [stdout] 87 | | }) [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prop/bitcoin/descriptor/public_key.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 53 | xkey: impl Strategy, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | derivation_path: impl Strategy, [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | wildcard: impl Strategy, [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | ) -> impl Strategy { [INFO] [stdout] 57 | (xkey, derivation_path, wildcard).prop_map(|(xkey, derivation_path, wildcard)| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prop/bitcoin/descriptor/tr.rs:46:53 [INFO] [stdout] | [INFO] [stdout] 46 | public_key.prop_map(|pk| Descriptor::Tr(Tr::new(pk, None).unwrap())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prop/bitcoin/descriptor/tr.rs:79:13 [INFO] [stdout] | [INFO] [stdout] 76 | internal_key: impl Strategy, [INFO] [stdout] | -------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | tap_tree: impl Strategy>, [INFO] [stdout] | ------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | ) -> impl Strategy> { [INFO] [stdout] 79 | (internal_key, prop::option::of(tap_tree)).prop_map(|(int, tree)| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prop/bitcoin/descriptor/tr.rs:80:32 [INFO] [stdout] | [INFO] [stdout] 79 | (internal_key, prop::option::of(tap_tree)).prop_map(|(int, tree)| { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | Descriptor::Tr(Tr::new(int, tree).expect("valid recursion")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prop/bitcoin/descriptor/tr.rs:108:17 [INFO] [stdout] | [INFO] [stdout] 106 | public_keys: impl Strategy, [INFO] [stdout] | ------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | ) -> impl Strategy> { [INFO] [stdout] 108 | prop::collection::vec(public_keys, 1..10).prop_map(|keys| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prop/bitcoin/descriptor/tr.rs:120:21 [INFO] [stdout] | [INFO] [stdout] 109 | let leaves = keys [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | / leaves [INFO] [stdout] 121 | | .into_iter() [INFO] [stdout] 122 | | // TODO: randomly balance the tree [INFO] [stdout] 123 | | .reduce(TapTree::combine) [INFO] [stdout] | |_________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 17 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bitcoin-proptest` (lib test) due to 18 previous errors [INFO] running `Command { std: "docker" "inspect" "76b8e6d55f2d7c13e9f6f7376578f399b230d1f16ba71bd1b25667dac38e7dae", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "76b8e6d55f2d7c13e9f6f7376578f399b230d1f16ba71bd1b25667dac38e7dae", kill_on_drop: false }` [INFO] [stdout] 76b8e6d55f2d7c13e9f6f7376578f399b230d1f16ba71bd1b25667dac38e7dae