[INFO] fetching crate bitcode_derive 0.6.3... [INFO] checking bitcode_derive-0.6.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate bitcode_derive 0.6.3 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate bitcode_derive 0.6.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate bitcode_derive 0.6.3 [INFO] finished tweaking crates.io crate bitcode_derive 0.6.3 [INFO] tweaked toml for crates.io crate bitcode_derive 0.6.3 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 5 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4bc586cc1cd075cc54dc4a3d2038fa102a46c5bfda428c90fdbd2bd6321c3b9c [INFO] running `Command { std: "docker" "start" "-a" "4bc586cc1cd075cc54dc4a3d2038fa102a46c5bfda428c90fdbd2bd6321c3b9c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4bc586cc1cd075cc54dc4a3d2038fa102a46c5bfda428c90fdbd2bd6321c3b9c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4bc586cc1cd075cc54dc4a3d2038fa102a46c5bfda428c90fdbd2bd6321c3b9c", kill_on_drop: false }` [INFO] [stdout] 4bc586cc1cd075cc54dc4a3d2038fa102a46c5bfda428c90fdbd2bd6321c3b9c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 736f68a2331ebddf1b98839e1ba100f1fb9f7e78bb40a82a76d3afe9bbcc6852 [INFO] running `Command { std: "docker" "start" "-a" "736f68a2331ebddf1b98839e1ba100f1fb9f7e78bb40a82a76d3afe9bbcc6852", kill_on_drop: false }` [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Checking proc-macro2 v1.0.86 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking syn v2.0.77 [INFO] [stderr] Checking bitcode_derive v0.6.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn $fn_name(input: TokenStream) -> TokenStream { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | / $trait_ [INFO] [stdout] 20 | | .derive(parse_macro_input!(input as DeriveInput)) [INFO] [stdout] 21 | | .unwrap_or_else(Error::into_compile_error) [INFO] [stdout] | |__________________________________________________________^ [INFO] [stdout] ... [INFO] [stdout] 26 | derive!(derive_encode, Encode); [INFO] [stdout] | ------------------------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `derive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn $fn_name(input: TokenStream) -> TokenStream { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | / $trait_ [INFO] [stdout] 20 | | .derive(parse_macro_input!(input as DeriveInput)) [INFO] [stdout] 21 | | .unwrap_or_else(Error::into_compile_error) [INFO] [stdout] | |__________________________________________________________^ [INFO] [stdout] ... [INFO] [stdout] 27 | derive!(derive_decode, Decode); [INFO] [stdout] | ------------------------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `derive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/attribute.rs:102:25 [INFO] [stdout] | [INFO] [stdout] 99 | fn new(attr_type: AttrType) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | crate_name: syn::parse_str("bitcode").expect("invalid crate name"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bound.rs:204:20 [INFO] [stdout] | [INFO] [stdout] 203 | .map(|id| syn::TypePath { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 204 | qself: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bound.rs:205:19 [INFO] [stdout] | [INFO] [stdout] 203 | .map(|id| syn::TypePath { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 204 | qself: None, [INFO] [stdout] 205 | path: id.into(), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bound.rs:211:39 [INFO] [stdout] | [INFO] [stdout] 210 | .map(|bounded_ty| { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 211 | syn::WherePredicate::Type(syn::PredicateType { [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 212 | | lifetimes: None, [INFO] [stdout] 213 | | // the type parameter that is being bounded e.g. T [INFO] [stdout] 214 | | bounded_ty, [INFO] [stdout] ... | [INFO] [stdout] 224 | | .collect(), [INFO] [stdout] 225 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shared.rs:166:12 [INFO] [stdout] | [INFO] [stdout] 101 | fn derive(&self, mut input: DeriveInput) -> Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | let attrs = BitcodeAttrs::parse_derive(&input.attrs)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | let ident = input.ident; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | syn::visit_mut::visit_data_mut(&mut ReplaceSelves(&ident), &mut input.data); [INFO] [stdout] 105 | let mut bounds = FieldBounds::default(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | [INFO] [stdout] 107 | let output = match input.data { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | let field_attrs = [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | Data::Enum(data_enum) => { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | let variant_attrs = data_enum [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 166 | Ok(self.derive_impl( [INFO] [stdout] | ____________^ [INFO] [stdout] 167 | | &attrs.crate_name, [INFO] [stdout] 168 | | output, [INFO] [stdout] 169 | | ident, [INFO] [stdout] 170 | | bounds.added_to(input.generics), [INFO] [stdout] 171 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bitcode_derive` (lib test) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn $fn_name(input: TokenStream) -> TokenStream { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | / $trait_ [INFO] [stdout] 20 | | .derive(parse_macro_input!(input as DeriveInput)) [INFO] [stdout] 21 | | .unwrap_or_else(Error::into_compile_error) [INFO] [stdout] | |__________________________________________________________^ [INFO] [stdout] ... [INFO] [stdout] 26 | derive!(derive_encode, Encode); [INFO] [stdout] | ------------------------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `derive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn $fn_name(input: TokenStream) -> TokenStream { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | / $trait_ [INFO] [stdout] 20 | | .derive(parse_macro_input!(input as DeriveInput)) [INFO] [stdout] 21 | | .unwrap_or_else(Error::into_compile_error) [INFO] [stdout] | |__________________________________________________________^ [INFO] [stdout] ... [INFO] [stdout] 27 | derive!(derive_decode, Decode); [INFO] [stdout] | ------------------------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `derive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/attribute.rs:102:25 [INFO] [stdout] | [INFO] [stdout] 99 | fn new(attr_type: AttrType) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | crate_name: syn::parse_str("bitcode").expect("invalid crate name"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bound.rs:204:20 [INFO] [stdout] | [INFO] [stdout] 203 | .map(|id| syn::TypePath { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 204 | qself: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bound.rs:205:19 [INFO] [stdout] | [INFO] [stdout] 203 | .map(|id| syn::TypePath { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 204 | qself: None, [INFO] [stdout] 205 | path: id.into(), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bound.rs:211:39 [INFO] [stdout] | [INFO] [stdout] 210 | .map(|bounded_ty| { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 211 | syn::WherePredicate::Type(syn::PredicateType { [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 212 | | lifetimes: None, [INFO] [stdout] 213 | | // the type parameter that is being bounded e.g. T [INFO] [stdout] 214 | | bounded_ty, [INFO] [stdout] ... | [INFO] [stdout] 224 | | .collect(), [INFO] [stdout] 225 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shared.rs:166:12 [INFO] [stdout] | [INFO] [stdout] 101 | fn derive(&self, mut input: DeriveInput) -> Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | let attrs = BitcodeAttrs::parse_derive(&input.attrs)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | let ident = input.ident; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | syn::visit_mut::visit_data_mut(&mut ReplaceSelves(&ident), &mut input.data); [INFO] [stdout] 105 | let mut bounds = FieldBounds::default(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | [INFO] [stdout] 107 | let output = match input.data { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | let field_attrs = [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | Data::Enum(data_enum) => { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | let variant_attrs = data_enum [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 166 | Ok(self.derive_impl( [INFO] [stdout] | ____________^ [INFO] [stdout] 167 | | &attrs.crate_name, [INFO] [stdout] 168 | | output, [INFO] [stdout] 169 | | ident, [INFO] [stdout] 170 | | bounds.added_to(input.generics), [INFO] [stdout] 171 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bitcode_derive` (lib) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "736f68a2331ebddf1b98839e1ba100f1fb9f7e78bb40a82a76d3afe9bbcc6852", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "736f68a2331ebddf1b98839e1ba100f1fb9f7e78bb40a82a76d3afe9bbcc6852", kill_on_drop: false }` [INFO] [stdout] 736f68a2331ebddf1b98839e1ba100f1fb9f7e78bb40a82a76d3afe9bbcc6852