[INFO] fetching crate bitbybit 1.3.2... [INFO] checking bitbybit-1.3.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate bitbybit 1.3.2 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate bitbybit 1.3.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate bitbybit 1.3.2 [INFO] finished tweaking crates.io crate bitbybit 1.3.2 [INFO] tweaked toml for crates.io crate bitbybit 1.3.2 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 6 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5737443fee4da97dd127dbe9fe0d8f82fcde79d4f276f771f5ec7895f0cedc15 [INFO] running `Command { std: "docker" "start" "-a" "5737443fee4da97dd127dbe9fe0d8f82fcde79d4f276f771f5ec7895f0cedc15", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5737443fee4da97dd127dbe9fe0d8f82fcde79d4f276f771f5ec7895f0cedc15", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5737443fee4da97dd127dbe9fe0d8f82fcde79d4f276f771f5ec7895f0cedc15", kill_on_drop: false }` [INFO] [stdout] 5737443fee4da97dd127dbe9fe0d8f82fcde79d4f276f771f5ec7895f0cedc15 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6a343e4835e9f4b877810c0e2396e610d5d8da01e0247caf3b664e7e0921b267 [INFO] running `Command { std: "docker" "start" "-a" "6a343e4835e9f4b877810c0e2396e610d5d8da01e0247caf3b664e7e0921b267", kill_on_drop: false }` [INFO] [stderr] Checking arbitrary-int v1.2.7 [INFO] [stderr] Checking syn v2.0.77 [INFO] [stderr] Checking bitbybit v1.3.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:32:11 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn bitenum(args: TokenStream1, input: TokenStream1) -> TokenStream1 { [INFO] [stdout] | ------------------ ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let mut config = bitenum::Config::default(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | [INFO] [stdout] 28 | let config_parser = syn::meta::parser(|meta| config.parse(meta)); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | let input = parse_macro_input!(input as syn::ItemEnum); [INFO] [stdout] | ----- ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | match bitenum::bitenum(config, &input) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bit_size.rs:42:12 [INFO] [stdout] | [INFO] [stdout] 40 | let (base, size) = (self.base_type()?, self.size); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | let some = || quote!(arbitrary_int::UInt::<#base, #size>::new); [INFO] [stdout] 42 | Ok(self.is_arbitrary_int().then(some)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bitenum.rs:147:12 [INFO] [stdout] | [INFO] [stdout] 138 | fn explicit(self) -> syn::Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | let span = Span::call_site(); [INFO] [stdout] 140 | let Some(bits) = self.explicit_bits else { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 147 | Ok(FullConfig { bits, exhaustive }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bitfield/parsing.rs:393:8 [INFO] [stdout] | [INFO] [stdout] 70 | let unsigned_field_type = if field_type_is_signed { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | let mut doc_comment: Vec = Vec::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 246 | let (field_type_size, primitive_type) = match field_type_size_from_data_type { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 249 | quote! { u8 } [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 250 | } else if number_of_bits <= 16 { [INFO] [stdout] 251 | quote! { u16 } [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 252 | } else if number_of_bits <= 32 { [INFO] [stdout] 253 | quote! { u32 } [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 254 | } else if number_of_bits <= 64 { [INFO] [stdout] 255 | quote! { u64 } [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 256 | } else if number_of_bits <= 128 { [INFO] [stdout] 257 | quote! { u128 } [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 262 | Some(b) => (b, quote! { #ty }), [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 338 | let (custom_type, getter_type, setter_type) = if field_type_size_from_data_type.is_none() { [INFO] [stdout] | ----------- ----------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 339 | // Test for optional type. We have to dissect the Option type to do that [INFO] [stdout] 340 | let (inner_type, result_type) = if let Type::Path(type_path) = ty { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 359 | let result_type = syn::parse_str::(&result_type_string) [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 393 | Ok(FieldDefinition { [INFO] [stdout] | ________^ [INFO] [stdout] 394 | | field_name: field_name.clone(), [INFO] [stdout] 395 | | ranges, [INFO] [stdout] 396 | | field_type_size, [INFO] [stdout] ... | [INFO] [stdout] 413 | | unsigned_field_type, [INFO] [stdout] 414 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bitbybit` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:32:11 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn bitenum(args: TokenStream1, input: TokenStream1) -> TokenStream1 { [INFO] [stdout] | ------------------ ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let mut config = bitenum::Config::default(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | [INFO] [stdout] 28 | let config_parser = syn::meta::parser(|meta| config.parse(meta)); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | let input = parse_macro_input!(input as syn::ItemEnum); [INFO] [stdout] | ----- ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | match bitenum::bitenum(config, &input) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bit_size.rs:42:12 [INFO] [stdout] | [INFO] [stdout] 40 | let (base, size) = (self.base_type()?, self.size); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | let some = || quote!(arbitrary_int::UInt::<#base, #size>::new); [INFO] [stdout] 42 | Ok(self.is_arbitrary_int().then(some)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bitenum.rs:147:12 [INFO] [stdout] | [INFO] [stdout] 138 | fn explicit(self) -> syn::Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | let span = Span::call_site(); [INFO] [stdout] 140 | let Some(bits) = self.explicit_bits else { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 147 | Ok(FullConfig { bits, exhaustive }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bitfield/parsing.rs:393:8 [INFO] [stdout] | [INFO] [stdout] 70 | let unsigned_field_type = if field_type_is_signed { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | let mut doc_comment: Vec = Vec::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 246 | let (field_type_size, primitive_type) = match field_type_size_from_data_type { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 249 | quote! { u8 } [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 250 | } else if number_of_bits <= 16 { [INFO] [stdout] 251 | quote! { u16 } [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 252 | } else if number_of_bits <= 32 { [INFO] [stdout] 253 | quote! { u32 } [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 254 | } else if number_of_bits <= 64 { [INFO] [stdout] 255 | quote! { u64 } [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 256 | } else if number_of_bits <= 128 { [INFO] [stdout] 257 | quote! { u128 } [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 262 | Some(b) => (b, quote! { #ty }), [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 338 | let (custom_type, getter_type, setter_type) = if field_type_size_from_data_type.is_none() { [INFO] [stdout] | ----------- ----------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 339 | // Test for optional type. We have to dissect the Option type to do that [INFO] [stdout] 340 | let (inner_type, result_type) = if let Type::Path(type_path) = ty { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 359 | let result_type = syn::parse_str::(&result_type_string) [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 393 | Ok(FieldDefinition { [INFO] [stdout] | ________^ [INFO] [stdout] 394 | | field_name: field_name.clone(), [INFO] [stdout] 395 | | ranges, [INFO] [stdout] 396 | | field_type_size, [INFO] [stdout] ... | [INFO] [stdout] 413 | | unsigned_field_type, [INFO] [stdout] 414 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bitbybit` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "6a343e4835e9f4b877810c0e2396e610d5d8da01e0247caf3b664e7e0921b267", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6a343e4835e9f4b877810c0e2396e610d5d8da01e0247caf3b664e7e0921b267", kill_on_drop: false }` [INFO] [stdout] 6a343e4835e9f4b877810c0e2396e610d5d8da01e0247caf3b664e7e0921b267