[INFO] fetching crate bita 0.12.0... [INFO] checking bita-0.12.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate bita 0.12.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate bita 0.12.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate bita 0.12.0 [INFO] finished tweaking crates.io crate bita 0.12.0 [INFO] tweaked toml for crates.io crate bita 0.12.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate bita 0.12.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6cd572310df55a38bcdf27f6c6cc79cf4a3aac93dd4184c37ca2d9643057811f [INFO] running `Command { std: "docker" "start" "-a" "6cd572310df55a38bcdf27f6c6cc79cf4a3aac93dd4184c37ca2d9643057811f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6cd572310df55a38bcdf27f6c6cc79cf4a3aac93dd4184c37ca2d9643057811f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6cd572310df55a38bcdf27f6c6cc79cf4a3aac93dd4184c37ca2d9643057811f", kill_on_drop: false }` [INFO] [stdout] 6cd572310df55a38bcdf27f6c6cc79cf4a3aac93dd4184c37ca2d9643057811f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9a816924a82d668db10a1a360b05712c0a7df107d0c0743dde005a173664b69c [INFO] running `Command { std: "docker" "start" "-a" "9a816924a82d668db10a1a360b05712c0a7df107d0c0743dde005a173664b69c", kill_on_drop: false }` [INFO] [stderr] Compiling either v1.12.0 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Compiling bytes v1.6.0 [INFO] [stderr] Compiling syn v2.0.65 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling regex-syntax v0.8.3 [INFO] [stderr] Compiling prettyplease v0.2.20 [INFO] [stderr] Compiling linux-raw-sys v0.4.14 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Compiling equivalent v1.0.1 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling fixedbitset v0.4.2 [INFO] [stderr] Compiling serde v1.0.202 [INFO] [stderr] Compiling fastrand v2.1.0 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Checking tower-layer v0.3.2 [INFO] [stderr] Checking alloc-no-stdlib v2.0.4 [INFO] [stderr] Compiling multimap v0.10.0 [INFO] [stderr] Compiling itertools v0.12.1 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Compiling log v0.4.21 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking alloc-stdlib v0.2.2 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Checking rustls-pki-types v1.7.0 [INFO] [stderr] Compiling indexmap v2.2.6 [INFO] [stderr] Checking brotli-decompressor v4.0.0 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking fern v0.6.2 [INFO] [stderr] Checking rustls-pemfile v2.1.2 [INFO] [stderr] Checking http-body v1.0.0 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking http-body-util v0.1.1 [INFO] [stderr] Checking brotli v6.0.0 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Compiling petgraph v0.6.5 [INFO] [stderr] Compiling regex-automata v0.4.6 [INFO] [stderr] Compiling tempfile v3.10.1 [INFO] [stderr] Compiling regex v1.10.4 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling prost-derive v0.12.6 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling async-trait v0.1.80 [INFO] [stderr] Checking openssl v0.10.64 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Compiling prost v0.12.6 [INFO] [stderr] Compiling prost-types v0.12.6 [INFO] [stderr] Compiling prost-build v0.12.6 [INFO] [stderr] Checking native-tls v0.2.11 [INFO] [stderr] Compiling bitar v0.12.0 [INFO] [stderr] Checking hyper v1.3.1 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking hyper-util v0.1.3 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.4 [INFO] [stderr] Checking bita v0.12.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 18 | let (command_opts, log_opts) = parse_opts(std::env::args_os()).unwrap_or_else(|e| e.exit()); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | init_log(log_opts)?; [INFO] [stdout] 20 | tokio::runtime::Runtime::new()?.block_on(async { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:20:46 [INFO] [stdout] | [INFO] [stdout] 18 | let (command_opts, log_opts) = parse_opts(std::env::args_os()).unwrap_or_else(|e| e.exit()); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | init_log(log_opts)?; [INFO] [stdout] 20 | tokio::runtime::Runtime::new()?.block_on(async { [INFO] [stdout] | ______________________________________________^ [INFO] [stdout] 21 | | match command_opts { [INFO] [stdout] 22 | | CommandOpts::Compress(opts) => compress_cmd::compress_cmd(opts).await, [INFO] [stdout] 23 | | CommandOpts::Clone(opts) => clone_cmd::clone_cmd(opts).await, [INFO] [stdout] ... | [INFO] [stdout] 26 | | } [INFO] [stdout] 27 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:398:5 [INFO] [stdout] | [INFO] [stdout] 397 | fn add_chunker_args(cmd: Command) -> Command { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 398 | / cmd.arg( [INFO] [stdout] 399 | | Arg::new("avg-chunk-size") [INFO] [stdout] 400 | | .long("avg-chunk-size") [INFO] [stdout] 401 | | .value_name("SIZE") [INFO] [stdout] ... | [INFO] [stdout] 469 | | .help("Set the chunk data compression type"), [INFO] [stdout] 470 | | ) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:472:9 [INFO] [stdout] | [INFO] [stdout] 397 | fn add_chunker_args(cmd: Command) -> Command { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 472 | / Arg::new("hash-length") [INFO] [stdout] 473 | | .long("hash-length") [INFO] [stdout] 474 | | .value_name("LENGTH") [INFO] [stdout] 475 | | .default_value("64") [INFO] [stdout] 476 | | .value_parser(value_parser!(u32).range(4..=(HashSum::MAX_LEN as i64))) [INFO] [stdout] 477 | | .help("Truncate the length of the stored chunk hash"), [INFO] [stdout] | |_________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/clone_cmd.rs:90:33 [INFO] [stdout] | [INFO] [stdout] 90 | .map(|r| spawn_blocking(|| r.map(|(_, chunk)| chunk.verify()))) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/clone_cmd.rs:116:28 [INFO] [stdout] | [INFO] [stdout] 112 | .map(|r| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | spawn_blocking(move || -> Result { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 117 | | let compressed = r.context("read archive")?; [INFO] [stdout] 118 | | let verified = compressed [INFO] [stdout] 119 | | .decompress() [INFO] [stdout] ... | [INFO] [stdout] 123 | | Ok(verified) [INFO] [stdout] 124 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/clone_cmd.rs:151:33 [INFO] [stdout] | [INFO] [stdout] 151 | .map(|r| spawn_blocking(|| r.map(|(offset, chunk)| (offset, chunk.verify())))) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/clone_cmd.rs:151:69 [INFO] [stdout] | [INFO] [stdout] 151 | .map(|r| spawn_blocking(|| r.map(|(offset, chunk)| (offset, chunk.verify())))) [INFO] [stdout] | --------------- ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compress_cmd.rs:61:45 [INFO] [stdout] | [INFO] [stdout] 56 | .map(|result| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | let (offset, chunk) = result.expect("error while chunking"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | tokio::task::spawn_blocking(move || (offset, chunk.verify())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compress_cmd.rs:61:62 [INFO] [stdout] | [INFO] [stdout] 57 | let (offset, chunk) = result.expect("error while chunking"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | tokio::task::spawn_blocking(move || (offset, chunk.verify())) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compress_cmd.rs:77:31 [INFO] [stdout] | [INFO] [stdout] 64 | .filter_map(|result| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | // Filter unique chunks to be compressed [INFO] [stdout] 66 | let (offset, verified) = result.expect("error while hashing chunk"); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | future::ready(if unique { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 78 | | Some((chunk_index, offset, verified)) [INFO] [stdout] 79 | | } else { [INFO] [stdout] 80 | | None [INFO] [stdout] 81 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compress_cmd.rs:84:45 [INFO] [stdout] | [INFO] [stdout] 83 | .map(|(chunk_index, offset, verified)| { [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | tokio::task::spawn_blocking(move || { [INFO] [stdout] | _____________________________________________^ [INFO] [stdout] 85 | | // Compress each chunk [INFO] [stdout] 86 | | let compressed = verified [INFO] [stdout] 87 | | .chunk() [INFO] [stdout] ... | [INFO] [stdout] 91 | | (chunk_index, offset, verified, compressed) [INFO] [stdout] 92 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/diff_cmd.rs:45:45 [INFO] [stdout] | [INFO] [stdout] 43 | .map(|result| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | let (offset, chunk) = result.expect("error chunking"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | tokio::task::spawn_blocking(move || (offset, chunk.verify())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/diff_cmd.rs:45:62 [INFO] [stdout] | [INFO] [stdout] 44 | let (offset, chunk) = result.expect("error chunking"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | tokio::task::spawn_blocking(move || (offset, chunk.verify())) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/diff_cmd.rs:58:45 [INFO] [stdout] | [INFO] [stdout] 57 | .map(|(offset, verified, do_compress)| { [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | tokio::task::spawn_blocking(move || { [INFO] [stdout] | _____________________________________________^ [INFO] [stdout] 59 | | if do_compress { [INFO] [stdout] 60 | | // Compress unique chunks [INFO] [stdout] 61 | | let compressed = verified [INFO] [stdout] ... | [INFO] [stdout] 69 | | } [INFO] [stdout] 70 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 15 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bita` (bin "bita" test) due to 16 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 18 | let (command_opts, log_opts) = parse_opts(std::env::args_os()).unwrap_or_else(|e| e.exit()); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | init_log(log_opts)?; [INFO] [stdout] 20 | tokio::runtime::Runtime::new()?.block_on(async { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:20:46 [INFO] [stdout] | [INFO] [stdout] 18 | let (command_opts, log_opts) = parse_opts(std::env::args_os()).unwrap_or_else(|e| e.exit()); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | init_log(log_opts)?; [INFO] [stdout] 20 | tokio::runtime::Runtime::new()?.block_on(async { [INFO] [stdout] | ______________________________________________^ [INFO] [stdout] 21 | | match command_opts { [INFO] [stdout] 22 | | CommandOpts::Compress(opts) => compress_cmd::compress_cmd(opts).await, [INFO] [stdout] 23 | | CommandOpts::Clone(opts) => clone_cmd::clone_cmd(opts).await, [INFO] [stdout] ... | [INFO] [stdout] 26 | | } [INFO] [stdout] 27 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:398:5 [INFO] [stdout] | [INFO] [stdout] 397 | fn add_chunker_args(cmd: Command) -> Command { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 398 | / cmd.arg( [INFO] [stdout] 399 | | Arg::new("avg-chunk-size") [INFO] [stdout] 400 | | .long("avg-chunk-size") [INFO] [stdout] 401 | | .value_name("SIZE") [INFO] [stdout] ... | [INFO] [stdout] 469 | | .help("Set the chunk data compression type"), [INFO] [stdout] 470 | | ) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:472:9 [INFO] [stdout] | [INFO] [stdout] 397 | fn add_chunker_args(cmd: Command) -> Command { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 472 | / Arg::new("hash-length") [INFO] [stdout] 473 | | .long("hash-length") [INFO] [stdout] 474 | | .value_name("LENGTH") [INFO] [stdout] 475 | | .default_value("64") [INFO] [stdout] 476 | | .value_parser(value_parser!(u32).range(4..=(HashSum::MAX_LEN as i64))) [INFO] [stdout] 477 | | .help("Truncate the length of the stored chunk hash"), [INFO] [stdout] | |_________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/clone_cmd.rs:90:33 [INFO] [stdout] | [INFO] [stdout] 90 | .map(|r| spawn_blocking(|| r.map(|(_, chunk)| chunk.verify()))) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/clone_cmd.rs:116:28 [INFO] [stdout] | [INFO] [stdout] 112 | .map(|r| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | spawn_blocking(move || -> Result { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 117 | | let compressed = r.context("read archive")?; [INFO] [stdout] 118 | | let verified = compressed [INFO] [stdout] 119 | | .decompress() [INFO] [stdout] ... | [INFO] [stdout] 123 | | Ok(verified) [INFO] [stdout] 124 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/clone_cmd.rs:151:33 [INFO] [stdout] | [INFO] [stdout] 151 | .map(|r| spawn_blocking(|| r.map(|(offset, chunk)| (offset, chunk.verify())))) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/clone_cmd.rs:151:69 [INFO] [stdout] | [INFO] [stdout] 151 | .map(|r| spawn_blocking(|| r.map(|(offset, chunk)| (offset, chunk.verify())))) [INFO] [stdout] | --------------- ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compress_cmd.rs:61:45 [INFO] [stdout] | [INFO] [stdout] 56 | .map(|result| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | let (offset, chunk) = result.expect("error while chunking"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | tokio::task::spawn_blocking(move || (offset, chunk.verify())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compress_cmd.rs:61:62 [INFO] [stdout] | [INFO] [stdout] 57 | let (offset, chunk) = result.expect("error while chunking"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | tokio::task::spawn_blocking(move || (offset, chunk.verify())) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compress_cmd.rs:77:31 [INFO] [stdout] | [INFO] [stdout] 64 | .filter_map(|result| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | // Filter unique chunks to be compressed [INFO] [stdout] 66 | let (offset, verified) = result.expect("error while hashing chunk"); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | future::ready(if unique { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 78 | | Some((chunk_index, offset, verified)) [INFO] [stdout] 79 | | } else { [INFO] [stdout] 80 | | None [INFO] [stdout] 81 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compress_cmd.rs:84:45 [INFO] [stdout] | [INFO] [stdout] 83 | .map(|(chunk_index, offset, verified)| { [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | tokio::task::spawn_blocking(move || { [INFO] [stdout] | _____________________________________________^ [INFO] [stdout] 85 | | // Compress each chunk [INFO] [stdout] 86 | | let compressed = verified [INFO] [stdout] 87 | | .chunk() [INFO] [stdout] ... | [INFO] [stdout] 91 | | (chunk_index, offset, verified, compressed) [INFO] [stdout] 92 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/diff_cmd.rs:45:45 [INFO] [stdout] | [INFO] [stdout] 43 | .map(|result| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | let (offset, chunk) = result.expect("error chunking"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | tokio::task::spawn_blocking(move || (offset, chunk.verify())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/diff_cmd.rs:45:62 [INFO] [stdout] | [INFO] [stdout] 44 | let (offset, chunk) = result.expect("error chunking"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | tokio::task::spawn_blocking(move || (offset, chunk.verify())) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/diff_cmd.rs:58:45 [INFO] [stdout] | [INFO] [stdout] 57 | .map(|(offset, verified, do_compress)| { [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | tokio::task::spawn_blocking(move || { [INFO] [stdout] | _____________________________________________^ [INFO] [stdout] 59 | | if do_compress { [INFO] [stdout] 60 | | // Compress unique chunks [INFO] [stdout] 61 | | let compressed = verified [INFO] [stdout] ... | [INFO] [stdout] 69 | | } [INFO] [stdout] 70 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 15 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bita` (bin "bita") due to 16 previous errors [INFO] running `Command { std: "docker" "inspect" "9a816924a82d668db10a1a360b05712c0a7df107d0c0743dde005a173664b69c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9a816924a82d668db10a1a360b05712c0a7df107d0c0743dde005a173664b69c", kill_on_drop: false }` [INFO] [stdout] 9a816924a82d668db10a1a360b05712c0a7df107d0c0743dde005a173664b69c