[INFO] fetching crate bird_tool_utils 0.5.0... [INFO] checking bird_tool_utils-0.5.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate bird_tool_utils 0.5.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate bird_tool_utils 0.5.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate bird_tool_utils 0.5.0 [INFO] finished tweaking crates.io crate bird_tool_utils 0.5.0 [INFO] tweaked toml for crates.io crate bird_tool_utils 0.5.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 48 packages to latest compatible versions [INFO] [stderr] Adding env_logger v0.10.2 (latest: v0.11.5) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding roff v0.1.0 (latest: v0.2.2) [INFO] [stderr] Adding version-compare v0.1.1 (latest: v0.2.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 318abfe416754b06569e4717fbc54ec582f421c08dbedfe5c95c34cb6665cce5 [INFO] running `Command { std: "docker" "start" "-a" "318abfe416754b06569e4717fbc54ec582f421c08dbedfe5c95c34cb6665cce5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "318abfe416754b06569e4717fbc54ec582f421c08dbedfe5c95c34cb6665cce5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "318abfe416754b06569e4717fbc54ec582f421c08dbedfe5c95c34cb6665cce5", kill_on_drop: false }` [INFO] [stdout] 318abfe416754b06569e4717fbc54ec582f421c08dbedfe5c95c34cb6665cce5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 264f236b9ed5eb7f8083938384964a4b2b4589aed28107ded4e345f856f7b4ce [INFO] running `Command { std: "docker" "start" "-a" "264f236b9ed5eb7f8083938384964a4b2b4589aed28107ded4e345f856f7b4ce", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking roff v0.1.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking version-compare v0.1.1 [INFO] [stderr] Checking bird_tool_utils-man v0.4.0 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking is-terminal v0.4.13 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Checking bird_tool_utils v0.5.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/clap_utils.rs:143:5 [INFO] [stdout] | [INFO] [stdout] 142 | pub fn add_genome_specification_arguments<'a>(subcommand: clap::Command) -> clap::Command { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | / subcommand [INFO] [stdout] 144 | | .arg( [INFO] [stdout] 145 | | Arg::new("genome-fasta-files") [INFO] [stdout] 146 | | .short('f') [INFO] [stdout] ... | [INFO] [stdout] 162 | | .help("Directory containing fasta files for processing") [INFO] [stdout] 163 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/clap_utils.rs:165:13 [INFO] [stdout] | [INFO] [stdout] 142 | pub fn add_genome_specification_arguments<'a>(subcommand: clap::Command) -> clap::Command { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 165 | / Arg::new("genome-fasta-extension") [INFO] [stdout] 166 | | .short('x') [INFO] [stdout] 167 | | .help("File extension of FASTA files in --genome-fasta-directory") [INFO] [stdout] 168 | | .long("genome-fasta-extension") [INFO] [stdout] ... | [INFO] [stdout] 172 | | //.requires("genome-fasta-directory") [INFO] [stdout] 173 | | .default_value("fna") [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/clap_utils.rs:178:5 [INFO] [stdout] | [INFO] [stdout] 177 | pub fn add_genome_specification_to_section(section: Section) -> Section { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 178 | / section [INFO] [stdout] 179 | | .option( [INFO] [stdout] 180 | | Opt::new("PATH ..") [INFO] [stdout] 181 | | .short("-f") [INFO] [stdout] ... | [INFO] [stdout] 203 | | )), [INFO] [stdout] 204 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/clap_utils.rs:214:12 [INFO] [stdout] | [INFO] [stdout] 212 | pub fn add_clap_verbosity_flags(cmd: clap::Command) -> clap::Command { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 213 | cmd [INFO] [stdout] 214 | .args(&[ [INFO] [stdout] | ____________^ [INFO] [stdout] 215 | | arg!(-v --verbose "Print extra debug logging information"), [INFO] [stdout] 216 | | arg!(--quiet "Unless there is an error, do not print logging information"), [INFO] [stdout] 217 | | ]) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/clap_utils.rs:245:21 [INFO] [stdout] | [INFO] [stdout] 245 | s.push_str(e.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/clap_utils.rs:275:28 [INFO] [stdout] | [INFO] [stdout] 275 | s.push_str(cell.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/clap_utils.rs:143:5 [INFO] [stdout] | [INFO] [stdout] 142 | pub fn add_genome_specification_arguments<'a>(subcommand: clap::Command) -> clap::Command { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | / subcommand [INFO] [stdout] 144 | | .arg( [INFO] [stdout] 145 | | Arg::new("genome-fasta-files") [INFO] [stdout] 146 | | .short('f') [INFO] [stdout] ... | [INFO] [stdout] 162 | | .help("Directory containing fasta files for processing") [INFO] [stdout] 163 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/clap_utils.rs:165:13 [INFO] [stdout] | [INFO] [stdout] 142 | pub fn add_genome_specification_arguments<'a>(subcommand: clap::Command) -> clap::Command { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 165 | / Arg::new("genome-fasta-extension") [INFO] [stdout] 166 | | .short('x') [INFO] [stdout] 167 | | .help("File extension of FASTA files in --genome-fasta-directory") [INFO] [stdout] 168 | | .long("genome-fasta-extension") [INFO] [stdout] ... | [INFO] [stdout] 172 | | //.requires("genome-fasta-directory") [INFO] [stdout] 173 | | .default_value("fna") [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/clap_utils.rs:178:5 [INFO] [stdout] | [INFO] [stdout] 177 | pub fn add_genome_specification_to_section(section: Section) -> Section { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 178 | / section [INFO] [stdout] 179 | | .option( [INFO] [stdout] 180 | | Opt::new("PATH ..") [INFO] [stdout] 181 | | .short("-f") [INFO] [stdout] ... | [INFO] [stdout] 203 | | )), [INFO] [stdout] 204 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bird_tool_utils` (lib) due to 5 previous errors; 2 warnings emitted [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/clap_utils.rs:214:12 [INFO] [stdout] | [INFO] [stdout] 212 | pub fn add_clap_verbosity_flags(cmd: clap::Command) -> clap::Command { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 213 | cmd [INFO] [stdout] 214 | .args(&[ [INFO] [stdout] | ____________^ [INFO] [stdout] 215 | | arg!(-v --verbose "Print extra debug logging information"), [INFO] [stdout] 216 | | arg!(--quiet "Unless there is an error, do not print logging information"), [INFO] [stdout] 217 | | ]) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/clap_utils.rs:245:21 [INFO] [stdout] | [INFO] [stdout] 245 | s.push_str(e.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/clap_utils.rs:275:28 [INFO] [stdout] | [INFO] [stdout] 275 | s.push_str(cell.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bird_tool_utils` (lib test) due to 5 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "264f236b9ed5eb7f8083938384964a4b2b4589aed28107ded4e345f856f7b4ce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "264f236b9ed5eb7f8083938384964a4b2b4589aed28107ded4e345f856f7b4ce", kill_on_drop: false }` [INFO] [stdout] 264f236b9ed5eb7f8083938384964a4b2b4589aed28107ded4e345f856f7b4ce