[INFO] fetching crate bipatch 1.0.0... [INFO] checking bipatch-1.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate bipatch 1.0.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate bipatch 1.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate bipatch 1.0.0 [INFO] finished tweaking crates.io crate bipatch 1.0.0 [INFO] tweaked toml for crates.io crate bipatch 1.0.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 3 packages to latest compatible versions [INFO] [stderr] Adding integer-encoding v2.1.3 (latest: v4.0.2) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 76768ad6d7b582b41e5956db9a371c0fcfacc9d939da125b335808b5b763daa9 [INFO] running `Command { std: "docker" "start" "-a" "76768ad6d7b582b41e5956db9a371c0fcfacc9d939da125b335808b5b763daa9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "76768ad6d7b582b41e5956db9a371c0fcfacc9d939da125b335808b5b763daa9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "76768ad6d7b582b41e5956db9a371c0fcfacc9d939da125b335808b5b763daa9", kill_on_drop: false }` [INFO] [stdout] 76768ad6d7b582b41e5956db9a371c0fcfacc9d939da125b335808b5b763daa9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 58b19c2d23bbffdaf275ca13dd0276fceeaba9610fcb5185af5719cfb4126ed1 [INFO] running `Command { std: "docker" "start" "-a" "58b19c2d23bbffdaf275ca13dd0276fceeaba9610fcb5185af5719cfb4126ed1", kill_on_drop: false }` [INFO] [stderr] Checking integer-encoding v2.1.3 [INFO] [stderr] Checking bipatch v1.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:85:12 [INFO] [stdout] | [INFO] [stdout] 74 | pub fn new(mut patch: R, old: RS) -> Result { [INFO] [stdout] | ------------ ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 86 | | patch, [INFO] [stdout] 87 | | old, [INFO] [stdout] 88 | | state: ReaderState::Initial, [INFO] [stdout] 89 | | buf: vec![0u8; 4096], [INFO] [stdout] 90 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bipatch` (lib test) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:85:12 [INFO] [stdout] | [INFO] [stdout] 74 | pub fn new(mut patch: R, old: RS) -> Result { [INFO] [stdout] | ------------ ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 86 | | patch, [INFO] [stdout] 87 | | old, [INFO] [stdout] 88 | | state: ReaderState::Initial, [INFO] [stdout] 89 | | buf: vec![0u8; 4096], [INFO] [stdout] 90 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bipatch` (lib) due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "58b19c2d23bbffdaf275ca13dd0276fceeaba9610fcb5185af5719cfb4126ed1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "58b19c2d23bbffdaf275ca13dd0276fceeaba9610fcb5185af5719cfb4126ed1", kill_on_drop: false }` [INFO] [stdout] 58b19c2d23bbffdaf275ca13dd0276fceeaba9610fcb5185af5719cfb4126ed1