[INFO] fetching crate bip_handshake 0.7.1... [INFO] checking bip_handshake-0.7.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate bip_handshake 0.7.1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate bip_handshake 0.7.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate bip_handshake 0.7.1 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate bip_handshake 0.7.1 [INFO] tweaked toml for crates.io crate bip_handshake 0.7.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 83 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding bytes v0.4.12 (latest: v1.7.1) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding chrono v0.2.25 (latest: v0.4.38) [INFO] [stderr] Adding cloudabi v0.0.3 (latest: v0.1.0) [INFO] [stderr] Adding crossbeam-deque v0.7.4 (latest: v0.8.5) [INFO] [stderr] Adding crossbeam-epoch v0.8.2 (latest: v0.9.18) [INFO] [stderr] Adding crossbeam-queue v0.2.3 (latest: v0.3.11) [INFO] [stderr] Adding crossbeam-utils v0.7.2 (latest: v0.8.20) [INFO] [stderr] Adding futures v0.1.31 (latest: v0.3.30) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding lock_api v0.3.4 (latest: v0.4.12) [INFO] [stderr] Adding memchr v1.0.2 (latest: v2.7.4) [INFO] [stderr] Adding memoffset v0.5.6 (latest: v0.9.1) [INFO] [stderr] Adding mio v0.6.23 (latest: v1.0.2) [INFO] [stderr] Adding miow v0.2.2 (latest: v0.6.0) [INFO] [stderr] Adding nom v3.2.1 (latest: v7.1.3) [INFO] [stderr] Adding num v0.1.42 (latest: v0.4.3) [INFO] [stderr] Adding num-bigint v0.1.44 (latest: v0.4.6) [INFO] [stderr] Adding num-complex v0.1.43 (latest: v0.4.6) [INFO] [stderr] Adding num-rational v0.1.42 (latest: v0.4.2) [INFO] [stderr] Adding parking_lot v0.9.0 (latest: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.6.3 (latest: v0.9.10) [INFO] [stderr] Adding rand v0.3.23 (latest: v0.8.5) [INFO] [stderr] Adding rand v0.4.6 (latest: v0.8.5) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding rdrand v0.4.0 (latest: v0.8.3) [INFO] [stderr] Adding redox_syscall v0.1.57 (latest: v0.5.3) [INFO] [stderr] Adding rustc_version v0.2.3 (latest: v0.4.1) [INFO] [stderr] Adding scoped-tls v0.1.2 (latest: v1.0.1) [INFO] [stderr] Adding semver v0.9.0 (latest: v1.0.23) [INFO] [stderr] Adding semver-parser v0.7.0 (latest: v0.10.2) [INFO] [stderr] Adding slab v0.3.0 (latest: v0.4.9) [INFO] [stderr] Adding smallvec v0.6.14 (latest: v1.13.2) [INFO] [stderr] Adding time v0.1.45 (latest: v0.3.36) [INFO] [stderr] Adding tokio v0.1.22 (latest: v1.40.0) [INFO] [stderr] Adding tokio-timer v0.1.2 (latest: v0.2.13) [INFO] [stderr] Adding wasi v0.10.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding winapi v0.2.8 (latest: v0.3.9) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0bf7e4a94cc07062bf91817ae0f666e3665380a1848291b5f98e21f495486dee [INFO] running `Command { std: "docker" "start" "-a" "0bf7e4a94cc07062bf91817ae0f666e3665380a1848291b5f98e21f495486dee", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0bf7e4a94cc07062bf91817ae0f666e3665380a1848291b5f98e21f495486dee", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0bf7e4a94cc07062bf91817ae0f666e3665380a1848291b5f98e21f495486dee", kill_on_drop: false }` [INFO] [stdout] 0bf7e4a94cc07062bf91817ae0f666e3665380a1848291b5f98e21f495486dee [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 974e685c3c58f3b317306eab9c5773088e643cde4ad343383526bab155e17d7b [INFO] running `Command { std: "docker" "start" "-a" "974e685c3c58f3b317306eab9c5773088e643cde4ad343383526bab155e17d7b", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Checking futures v0.1.31 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling memoffset v0.5.6 [INFO] [stderr] Checking lock_api v0.3.4 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Checking rustc-serialize v0.3.25 [INFO] [stderr] Checking smallvec v0.6.14 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling gcc v0.3.55 [INFO] [stderr] Checking slab v0.3.0 [INFO] [stderr] Compiling parking_lot_core v0.6.3 [INFO] [stderr] Compiling parking_lot v0.9.0 [INFO] [stderr] Checking crossbeam-queue v0.2.3 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking scoped-tls v0.1.2 [INFO] [stderr] Compiling rust-crypto v0.2.36 [INFO] [stderr] Checking crossbeam-deque v0.7.4 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking net2 v0.2.39 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking bytes v0.4.12 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Checking tokio-executor v0.1.10 [INFO] [stderr] Checking tokio-sync v0.1.8 [INFO] [stderr] Checking nom v3.2.1 [INFO] [stderr] Checking tokio-threadpool v0.1.18 [INFO] [stderr] Checking tokio-io v0.1.13 [INFO] [stderr] Checking rand v0.3.23 [INFO] [stderr] Checking tokio-current-thread v0.1.7 [INFO] [stderr] Checking tokio-timer v0.2.13 [INFO] [stderr] Checking tokio-timer v0.1.2 [INFO] [stderr] Checking num-bigint v0.1.44 [INFO] [stderr] Checking num-complex v0.1.43 [INFO] [stderr] Checking tokio-codec v0.1.2 [INFO] [stderr] Checking tokio-fs v0.1.7 [INFO] [stderr] Checking tokio-reactor v0.1.12 [INFO] [stderr] Checking mio-uds v0.6.8 [INFO] [stderr] Checking tokio-udp v0.1.6 [INFO] [stderr] Checking tokio-tcp v0.1.4 [INFO] [stderr] Checking tokio-uds v0.2.7 [INFO] [stderr] Checking tokio v0.1.22 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking tokio-core v0.1.18 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking chrono v0.2.25 [INFO] [stderr] Checking bip_util v0.5.0 [INFO] [stderr] Checking bip_handshake v0.7.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/bittorrent/framed.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | try!(item.write_bytes(self.write_buffer.by_ref().writer())); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/bittorrent/message.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | try!(self.prot.write_bytes(&mut writer)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/bittorrent/message.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | try!(self.ext.write_bytes(&mut writer)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/bittorrent/message.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | try!(writer.write_all(self.hash.as_ref())); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/bittorrent/message.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | try!(writer.write_all(self.pid.as_ref())); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/handshake/handshaker.rs:142:24 [INFO] [stdout] | [INFO] [stdout] 142 | let listener = try!(transport.listen(&builder.bind, &handle)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/handshake/handshaker.rs:146:13 [INFO] [stdout] | [INFO] [stdout] 146 | try!(listener.local_addr()).port() [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/message/protocol.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | try!(writer.write_all(&[len as u8][..])); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/message/protocol.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | try!(writer.write_all(bytes)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/transport.rs:46:24 [INFO] [stdout] | [INFO] [stdout] 46 | let listener = try!(TcpListener::bind(addr, handle)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/transport.rs:47:27 [INFO] [stdout] | [INFO] [stdout] 47 | let listen_addr = try!(listener.local_addr()); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/message/extensions.rs:94:5 [INFO] [stdout] | [INFO] [stdout] 94 | / do_parse!(bytes, [INFO] [stdout] 95 | | bytes: count_fixed!(u8, be_u8, NUM_EXTENSION_BYTES) >> [INFO] [stdout] 96 | | (Extensions::with_bytes(bytes)) [INFO] [stdout] 97 | | ) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `count_fixed` which comes from the expansion of the macro `do_parse` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/filter/filters.rs:8:33 [INFO] [stdout] | [INFO] [stdout] 8 | filters: Arc>>> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 8 | filters: Arc>>> [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/handshake/handler/handshaker.rs:20:12 [INFO] [stdout] | [INFO] [stdout] 20 | -> Box>, Error=()>> where S: AsyncRead + AsyncWrite + 'static { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 20 | -> Box>, Error=()>> where S: AsyncRead + AsyncWrite + 'static { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/handshake/handler/handshaker.rs:30:12 [INFO] [stdout] | [INFO] [stdout] 30 | -> Box>, Error=()>> where S: AsyncRead + AsyncWrite + 'static { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 30 | -> Box>, Error=()>> where S: AsyncRead + AsyncWrite + 'static { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/handshake/handler/handshaker.rs:67:12 [INFO] [stdout] | [INFO] [stdout] 67 | -> Box>, Error=()>> where S: AsyncRead + AsyncWrite + 'static { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 67 | -> Box>, Error=()>> where S: AsyncRead + AsyncWrite + 'static { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/handshake/handler/initiator.rs:12:107 [INFO] [stdout] | [INFO] [stdout] 12 | ...ilters, Handle, HandshakeTimer)) -> Box>,Error=()>> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 12 | pub fn initiator_handler(item: InitiateMessage, context: &(T, Filters, Handle, HandshakeTimer)) -> Box>,Error=()>> [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/filter/filters.rs:70:38 [INFO] [stdout] | [INFO] [stdout] 70 | fn check_index(ref_filters: &[Box], filter: &F) -> Option [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 70 | fn check_index(ref_filters: &[Box], filter: &F) -> Option [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/filter/mod.rs:58:26 [INFO] [stdout] | [INFO] [stdout] 58 | fn as_any(&self) -> &Any; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 58 | fn as_any(&self) -> &dyn Any; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/filter/filters.rs:41:31 [INFO] [stdout] | [INFO] [stdout] 41 | where B: FnOnce(&[Box]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 41 | where B: FnOnce(&[Box]) { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/filter/filters.rs:54:31 [INFO] [stdout] | [INFO] [stdout] 54 | where B: FnOnce(&[Box]) -> R { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 54 | where B: FnOnce(&[Box]) -> R { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/filter/filters.rs:62:38 [INFO] [stdout] | [INFO] [stdout] 62 | where B: FnOnce(&mut Vec>) -> R { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 62 | where B: FnOnce(&mut Vec>) -> R { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/bittorrent/framed.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | try!(item.write_bytes(self.write_buffer.by_ref().writer())); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/bittorrent/message.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | try!(self.prot.write_bytes(&mut writer)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/bittorrent/message.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | try!(self.ext.write_bytes(&mut writer)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/bittorrent/message.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | try!(writer.write_all(self.hash.as_ref())); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/bittorrent/message.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | try!(writer.write_all(self.pid.as_ref())); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/handshake/handshaker.rs:142:24 [INFO] [stdout] | [INFO] [stdout] 142 | let listener = try!(transport.listen(&builder.bind, &handle)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/handshake/handshaker.rs:146:13 [INFO] [stdout] | [INFO] [stdout] 146 | try!(listener.local_addr()).port() [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/message/protocol.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | try!(writer.write_all(&[len as u8][..])); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/message/protocol.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | try!(writer.write_all(bytes)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/transport.rs:46:24 [INFO] [stdout] | [INFO] [stdout] 46 | let listener = try!(TcpListener::bind(addr, handle)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/transport.rs:47:27 [INFO] [stdout] | [INFO] [stdout] 47 | let listen_addr = try!(listener.local_addr()); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: a method with this name may be added to the standard library in the future [INFO] [stdout] --> src/bittorrent/framed.rs:81:49 [INFO] [stdout] | [INFO] [stdout] 81 | let read_result = self.sock.read_buf(&mut Cursor::new(&mut self.read_buffer[..])); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: once this associated item is added to the standard library, the ambiguity may cause an error or change in behavior! [INFO] [stdout] = note: for more information, see issue #48919 [INFO] [stdout] = help: call with fully qualified syntax `tokio_io::AsyncRead::read_buf(...)` to keep using the current method [INFO] [stdout] = note: `#[warn(unstable_name_collisions)]` on by default [INFO] [stdout] help: add `#![feature(read_buf)]` to the crate attributes to enable `std::io::Read::read_buf` [INFO] [stdout] --> src/lib.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 + #![feature(read_buf)] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: a method with this name may be added to the standard library in the future [INFO] [stdout] --> src/bittorrent/framed.rs:117:47 [INFO] [stdout] | [INFO] [stdout] 117 | ... try_nb!(self.sock.read_buf(&mut cursor)) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: once this associated item is added to the standard library, the ambiguity may cause an error or change in behavior! [INFO] [stdout] = note: for more information, see issue #48919 [INFO] [stdout] = help: call with fully qualified syntax `tokio_io::AsyncRead::read_buf(...)` to keep using the current method [INFO] [stdout] help: add `#![feature(read_buf)]` to the crate attributes to enable `std::io::Read::read_buf` [INFO] [stdout] --> src/lib.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 + #![feature(read_buf)] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/message/extensions.rs:94:5 [INFO] [stdout] | [INFO] [stdout] 94 | / do_parse!(bytes, [INFO] [stdout] 95 | | bytes: count_fixed!(u8, be_u8, NUM_EXTENSION_BYTES) >> [INFO] [stdout] 96 | | (Extensions::with_bytes(bytes)) [INFO] [stdout] 97 | | ) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `count_fixed` which comes from the expansion of the macro `do_parse` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/filter/filters.rs:8:33 [INFO] [stdout] | [INFO] [stdout] 8 | filters: Arc>>> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 8 | filters: Arc>>> [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/handshake/handler/handshaker.rs:20:12 [INFO] [stdout] | [INFO] [stdout] 20 | -> Box>, Error=()>> where S: AsyncRead + AsyncWrite + 'static { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 20 | -> Box>, Error=()>> where S: AsyncRead + AsyncWrite + 'static { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/handshake/handler/handshaker.rs:30:12 [INFO] [stdout] | [INFO] [stdout] 30 | -> Box>, Error=()>> where S: AsyncRead + AsyncWrite + 'static { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 30 | -> Box>, Error=()>> where S: AsyncRead + AsyncWrite + 'static { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/handshake/handler/handshaker.rs:67:12 [INFO] [stdout] | [INFO] [stdout] 67 | -> Box>, Error=()>> where S: AsyncRead + AsyncWrite + 'static { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 67 | -> Box>, Error=()>> where S: AsyncRead + AsyncWrite + 'static { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/handshake/handler/initiator.rs:12:107 [INFO] [stdout] | [INFO] [stdout] 12 | ...ilters, Handle, HandshakeTimer)) -> Box>,Error=()>> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 12 | pub fn initiator_handler(item: InitiateMessage, context: &(T, Filters, Handle, HandshakeTimer)) -> Box>,Error=()>> [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/filter/filters.rs:70:38 [INFO] [stdout] | [INFO] [stdout] 70 | fn check_index(ref_filters: &[Box], filter: &F) -> Option [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 70 | fn check_index(ref_filters: &[Box], filter: &F) -> Option [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/filter/mod.rs:58:26 [INFO] [stdout] | [INFO] [stdout] 58 | fn as_any(&self) -> &Any; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 58 | fn as_any(&self) -> &dyn Any; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/filter/filters.rs:41:31 [INFO] [stdout] | [INFO] [stdout] 41 | where B: FnOnce(&[Box]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 41 | where B: FnOnce(&[Box]) { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/filter/filters.rs:54:31 [INFO] [stdout] | [INFO] [stdout] 54 | where B: FnOnce(&[Box]) -> R { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 54 | where B: FnOnce(&[Box]) -> R { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/filter/filters.rs:62:38 [INFO] [stdout] | [INFO] [stdout] 62 | where B: FnOnce(&mut Vec>) -> R { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 62 | where B: FnOnce(&mut Vec>) -> R { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/filter/filters.rs:107:30 [INFO] [stdout] | [INFO] [stdout] 107 | fn as_any(&self) -> &Any { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 107 | fn as_any(&self) -> &dyn Any { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/filter/filters.rs:134:30 [INFO] [stdout] | [INFO] [stdout] 134 | fn as_any(&self) -> &Any { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 134 | fn as_any(&self) -> &dyn Any { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/filter/filters.rs:161:30 [INFO] [stdout] | [INFO] [stdout] 161 | fn as_any(&self) -> &Any { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 161 | fn as_any(&self) -> &dyn Any { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: a method with this name may be added to the standard library in the future [INFO] [stdout] --> src/bittorrent/framed.rs:81:49 [INFO] [stdout] | [INFO] [stdout] 81 | let read_result = self.sock.read_buf(&mut Cursor::new(&mut self.read_buffer[..])); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: once this associated item is added to the standard library, the ambiguity may cause an error or change in behavior! [INFO] [stdout] = note: for more information, see issue #48919 [INFO] [stdout] = help: call with fully qualified syntax `tokio_io::AsyncRead::read_buf(...)` to keep using the current method [INFO] [stdout] = note: `#[warn(unstable_name_collisions)]` on by default [INFO] [stdout] help: add `#![feature(read_buf)]` to the crate attributes to enable `std::io::Read::read_buf` [INFO] [stdout] --> src/lib.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 + #![feature(read_buf)] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: a method with this name may be added to the standard library in the future [INFO] [stdout] --> src/bittorrent/framed.rs:117:47 [INFO] [stdout] | [INFO] [stdout] 117 | ... try_nb!(self.sock.read_buf(&mut cursor)) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: once this associated item is added to the standard library, the ambiguity may cause an error or change in behavior! [INFO] [stdout] = note: for more information, see issue #48919 [INFO] [stdout] = help: call with fully qualified syntax `tokio_io::AsyncRead::read_buf(...)` to keep using the current method [INFO] [stdout] help: add `#![feature(read_buf)]` to the crate attributes to enable `std::io::Read::read_buf` [INFO] [stdout] --> src/lib.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 + #![feature(read_buf)] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bittorrent/framed.rs:33:52 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn new(sock: S) -> FramedHandshake { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | FramedHandshake{ sock: sock, write_buffer: BytesMut::with_capacity(1), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handshake/handler/mod.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 40 | handle.spawn(future::loop_fn((stream, handler, sink, context), |(stream, mut handler, sink, context)| { [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | / stream.into_future() [INFO] [stdout] 47 | | .map_err(|_| LoopError::Terminate) [INFO] [stdout] 48 | | .and_then(|(opt_item, stream)| { [INFO] [stdout] 49 | | opt_item.ok_or(LoopError::Terminate) [INFO] [stdout] ... | [INFO] [stdout] 67 | | .map(|sink| Loop::Continue((stream, handler, sink, context))) [INFO] [stdout] 68 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handshake/handler/mod.rs:49:17 [INFO] [stdout] | [INFO] [stdout] 48 | .and_then(|(opt_item, stream)| { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | opt_item.ok_or(LoopError::Terminate) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handshake/handler/mod.rs:50:26 [INFO] [stdout] | [INFO] [stdout] 48 | .and_then(|(opt_item, stream)| { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | opt_item.ok_or(LoopError::Terminate) [INFO] [stdout] 50 | .map(|item| (item, stream)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handshake/handler/mod.rs:55:17 [INFO] [stdout] | [INFO] [stdout] 40 | handle.spawn(future::loop_fn((stream, handler, sink, context), |(stream, mut handler, sink, context)| { [INFO] [stdout] | ------- ---- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | .and_then(move |(item, stream)| { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | let into_future = handler(item, &context); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | [INFO] [stdout] 55 | / into_future.into_future() [INFO] [stdout] 56 | | .map_err(|_| LoopError::Terminate) [INFO] [stdout] | |______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handshake/handler/mod.rs:57:31 [INFO] [stdout] | [INFO] [stdout] 40 | handle.spawn(future::loop_fn((stream, handler, sink, context), |(stream, mut handler, sink, context)| { [INFO] [stdout] | ------- ---- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | .and_then(move |(item, stream)| { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | let into_future = handler(item, &context); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | .and_then(move |opt_result| { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 58 | | match opt_result { [INFO] [stdout] 59 | | Some(result) => Ok((result, stream, handler, context, sink)), [INFO] [stdout] 60 | | None => Err(LoopError::Recoverable((stream, handler, context, sink))) [INFO] [stdout] 61 | | } [INFO] [stdout] 62 | | }) [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handshake/handler/mod.rs:65:17 [INFO] [stdout] | [INFO] [stdout] 64 | .and_then(|(result, stream, handler, context, sink)| { [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | / sink.send(result) [INFO] [stdout] 66 | | .map_err(|_| LoopError::Terminate) [INFO] [stdout] | |______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handshake/handler/mod.rs:67:26 [INFO] [stdout] | [INFO] [stdout] 64 | .and_then(|(result, stream, handler, context, sink)| { [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | .map(|sink| Loop::Continue((stream, handler, sink, context))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handshake/handler/mod.rs:67:48 [INFO] [stdout] | [INFO] [stdout] 64 | .and_then(|(result, stream, handler, context, sink)| { [INFO] [stdout] | ------ ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | .map(|sink| Loop::Continue((stream, handler, sink, context))) [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handshake/handler/handshaker.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 29 | fn initiate_handshake(sock: S, init_msg: InitiateMessage, ext: Extensions, pid: PeerId, filters: Filters, timer: HandshakeTimer) [INFO] [stdout] | ------- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | .and_then(move |framed| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | / timer.timeout( [INFO] [stdout] 42 | | framed.into_future() [INFO] [stdout] 43 | | .map_err(|_| ()) [INFO] [stdout] 44 | | .and_then(|(opt_msg, framed)| opt_msg.ok_or(()) [INFO] [stdout] 45 | | .map(|msg| (msg, framed))) [INFO] [stdout] 46 | | ) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handshake/handler/handshaker.rs:47:23 [INFO] [stdout] | [INFO] [stdout] 29 | fn initiate_handshake(sock: S, init_msg: InitiateMessage, ext: Extensions, pid: PeerId, filters: Filters, timer: HandshakeTimer) [INFO] [stdout] | ------- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | .and_then(move |framed| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | .and_then(move |(msg, framed)| { [INFO] [stdout] | _______________________^ [INFO] [stdout] 48 | | let (remote_prot, remote_ext, remote_hash, remote_pid) = msg.into_parts(); [INFO] [stdout] 49 | | let socket = framed.into_inner(); [INFO] [stdout] ... | [INFO] [stdout] 58 | | } [INFO] [stdout] 59 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handshake/handler/handshaker.rs:45:26 [INFO] [stdout] | [INFO] [stdout] 44 | .and_then(|(opt_msg, framed)| opt_msg.ok_or(()) [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | .map(|msg| (msg, framed))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handshake/handler/handshaker.rs:61:25 [INFO] [stdout] | [INFO] [stdout] 61 | .or_else(|_| Ok(None)); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handshake/handler/handshaker.rs:75:30 [INFO] [stdout] | [INFO] [stdout] 73 | .and_then(|(opt_msg, framed)| { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | opt_msg.ok_or(()) [INFO] [stdout] 75 | .map(|msg| (msg, framed)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handshake/handler/handshaker.rs:92:34 [INFO] [stdout] | [INFO] [stdout] 89 | .map(move |framed| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | let socket = framed.into_inner(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | [INFO] [stdout] 92 | Some(CompleteMessage::new(remote_prot, ext.union(&remote_ext), remote_hash, remote_pid, addr, socket)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handshake/handler/handshaker.rs:98:25 [INFO] [stdout] | [INFO] [stdout] 98 | .or_else(|_| Ok(None)); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handshake/handler/initiator.rs:25:22 [INFO] [stdout] | [INFO] [stdout] 24 | .map(|socket| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | Some(HandshakeType::Initiate(socket, item)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handshake/handler/initiator.rs:27:29 [INFO] [stdout] | [INFO] [stdout] 27 | .or_else(|_| Ok(None)) [INFO] [stdout] | - ^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handshake/handshaker.rs:165:12 [INFO] [stdout] | [INFO] [stdout] 140 | fn with_builder(builder: &HandshakerBuilder, transport: T, handle: Handle) -> io::Result> [INFO] [stdout] | ------------ -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 141 | where T: Transport + 'static { [INFO] [stdout] 142 | let listener = try!(transport.listen(&builder.bind, &handle)); [INFO] [stdout] | -------- ---------------------------------------------- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | try!(listener.local_addr()).port() [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | let (addr_send, addr_recv) = mpsc::channel(config.sink_buffer_size()); [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 151 | let (hand_send, hand_recv) = mpsc::channel(config.wait_buffer_size()); [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | let (sock_send, sock_recv) = mpsc::channel(config.done_buffer_size()); [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | [INFO] [stdout] 154 | let filters = Filters::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | let (handshake_timer, initiate_timer) = configured_handshake_timers(config.handshake_timeout(), config.connect_timeout()); [INFO] [stdout] | --------------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | let sink = HandshakerSink::new(addr_send, open_port, builder.pid, filters); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 163 | let stream = HandshakerStream::new(sock_recv); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 164 | [INFO] [stdout] 165 | Ok(Handshaker{ sink: sink, stream: stream }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handshake/handshaker.rs:176:6 [INFO] [stdout] | [INFO] [stdout] 171 | let timer = tokio_timer::wheel() [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 176 | (HandshakeTimer::new(timer.clone(), duration_one), HandshakeTimer::new(timer, duration_two)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handshake/handshaker.rs:176:56 [INFO] [stdout] | [INFO] [stdout] 171 | let timer = tokio_timer::wheel() [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 176 | (HandshakeTimer::new(timer.clone(), duration_one), HandshakeTimer::new(timer, duration_two)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filter/filters.rs:42:27 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn access_filters(&self, block: B) [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | where B: FnOnce(&[Box]) { [INFO] [stdout] 42 | self.read_filters(|ref_filters| { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 43 | | block(ref_filters) [INFO] [stdout] 44 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport.rs:49:12 [INFO] [stdout] | [INFO] [stdout] 46 | let listener = try!(TcpListener::bind(addr, handle)); [INFO] [stdout] | -------- ------------------------------------- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | let listen_addr = try!(listener.local_addr()); [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | [INFO] [stdout] 49 | Ok(TcpListenerStream::new(listen_addr, listener.incoming())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 23 previous errors; 24 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bip_handshake` (lib) due to 24 previous errors; 24 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bittorrent/framed.rs:33:52 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn new(sock: S) -> FramedHandshake { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | FramedHandshake{ sock: sock, write_buffer: BytesMut::with_capacity(1), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handshake/handler/mod.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 40 | handle.spawn(future::loop_fn((stream, handler, sink, context), |(stream, mut handler, sink, context)| { [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | / stream.into_future() [INFO] [stdout] 47 | | .map_err(|_| LoopError::Terminate) [INFO] [stdout] 48 | | .and_then(|(opt_item, stream)| { [INFO] [stdout] 49 | | opt_item.ok_or(LoopError::Terminate) [INFO] [stdout] ... | [INFO] [stdout] 67 | | .map(|sink| Loop::Continue((stream, handler, sink, context))) [INFO] [stdout] 68 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handshake/handler/mod.rs:49:17 [INFO] [stdout] | [INFO] [stdout] 48 | .and_then(|(opt_item, stream)| { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | opt_item.ok_or(LoopError::Terminate) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handshake/handler/mod.rs:50:26 [INFO] [stdout] | [INFO] [stdout] 48 | .and_then(|(opt_item, stream)| { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | opt_item.ok_or(LoopError::Terminate) [INFO] [stdout] 50 | .map(|item| (item, stream)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handshake/handler/mod.rs:55:17 [INFO] [stdout] | [INFO] [stdout] 40 | handle.spawn(future::loop_fn((stream, handler, sink, context), |(stream, mut handler, sink, context)| { [INFO] [stdout] | ------- ---- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | .and_then(move |(item, stream)| { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | let into_future = handler(item, &context); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | [INFO] [stdout] 55 | / into_future.into_future() [INFO] [stdout] 56 | | .map_err(|_| LoopError::Terminate) [INFO] [stdout] | |______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handshake/handler/mod.rs:57:31 [INFO] [stdout] | [INFO] [stdout] 40 | handle.spawn(future::loop_fn((stream, handler, sink, context), |(stream, mut handler, sink, context)| { [INFO] [stdout] | ------- ---- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | .and_then(move |(item, stream)| { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | let into_future = handler(item, &context); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | .and_then(move |opt_result| { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 58 | | match opt_result { [INFO] [stdout] 59 | | Some(result) => Ok((result, stream, handler, context, sink)), [INFO] [stdout] 60 | | None => Err(LoopError::Recoverable((stream, handler, context, sink))) [INFO] [stdout] 61 | | } [INFO] [stdout] 62 | | }) [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handshake/handler/mod.rs:65:17 [INFO] [stdout] | [INFO] [stdout] 64 | .and_then(|(result, stream, handler, context, sink)| { [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | / sink.send(result) [INFO] [stdout] 66 | | .map_err(|_| LoopError::Terminate) [INFO] [stdout] | |______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handshake/handler/mod.rs:67:26 [INFO] [stdout] | [INFO] [stdout] 64 | .and_then(|(result, stream, handler, context, sink)| { [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | .map(|sink| Loop::Continue((stream, handler, sink, context))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handshake/handler/mod.rs:67:48 [INFO] [stdout] | [INFO] [stdout] 64 | .and_then(|(result, stream, handler, context, sink)| { [INFO] [stdout] | ------ ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | .map(|sink| Loop::Continue((stream, handler, sink, context))) [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handshake/handler/handshaker.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 29 | fn initiate_handshake(sock: S, init_msg: InitiateMessage, ext: Extensions, pid: PeerId, filters: Filters, timer: HandshakeTimer) [INFO] [stdout] | ------- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | .and_then(move |framed| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | / timer.timeout( [INFO] [stdout] 42 | | framed.into_future() [INFO] [stdout] 43 | | .map_err(|_| ()) [INFO] [stdout] 44 | | .and_then(|(opt_msg, framed)| opt_msg.ok_or(()) [INFO] [stdout] 45 | | .map(|msg| (msg, framed))) [INFO] [stdout] 46 | | ) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handshake/handler/handshaker.rs:47:23 [INFO] [stdout] | [INFO] [stdout] 29 | fn initiate_handshake(sock: S, init_msg: InitiateMessage, ext: Extensions, pid: PeerId, filters: Filters, timer: HandshakeTimer) [INFO] [stdout] | ------- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | .and_then(move |framed| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | .and_then(move |(msg, framed)| { [INFO] [stdout] | _______________________^ [INFO] [stdout] 48 | | let (remote_prot, remote_ext, remote_hash, remote_pid) = msg.into_parts(); [INFO] [stdout] 49 | | let socket = framed.into_inner(); [INFO] [stdout] ... | [INFO] [stdout] 58 | | } [INFO] [stdout] 59 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handshake/handler/handshaker.rs:45:26 [INFO] [stdout] | [INFO] [stdout] 44 | .and_then(|(opt_msg, framed)| opt_msg.ok_or(()) [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | .map(|msg| (msg, framed))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handshake/handler/handshaker.rs:61:25 [INFO] [stdout] | [INFO] [stdout] 61 | .or_else(|_| Ok(None)); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handshake/handler/handshaker.rs:75:30 [INFO] [stdout] | [INFO] [stdout] 73 | .and_then(|(opt_msg, framed)| { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | opt_msg.ok_or(()) [INFO] [stdout] 75 | .map(|msg| (msg, framed)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handshake/handler/handshaker.rs:92:34 [INFO] [stdout] | [INFO] [stdout] 89 | .map(move |framed| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | let socket = framed.into_inner(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | [INFO] [stdout] 92 | Some(CompleteMessage::new(remote_prot, ext.union(&remote_ext), remote_hash, remote_pid, addr, socket)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handshake/handler/handshaker.rs:98:25 [INFO] [stdout] | [INFO] [stdout] 98 | .or_else(|_| Ok(None)); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handshake/handler/initiator.rs:25:22 [INFO] [stdout] | [INFO] [stdout] 24 | .map(|socket| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | Some(HandshakeType::Initiate(socket, item)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handshake/handler/initiator.rs:27:29 [INFO] [stdout] | [INFO] [stdout] 27 | .or_else(|_| Ok(None)) [INFO] [stdout] | - ^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handshake/handshaker.rs:165:12 [INFO] [stdout] | [INFO] [stdout] 140 | fn with_builder(builder: &HandshakerBuilder, transport: T, handle: Handle) -> io::Result> [INFO] [stdout] | ------------ -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 141 | where T: Transport + 'static { [INFO] [stdout] 142 | let listener = try!(transport.listen(&builder.bind, &handle)); [INFO] [stdout] | -------- ---------------------------------------------- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | try!(listener.local_addr()).port() [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | let (addr_send, addr_recv) = mpsc::channel(config.sink_buffer_size()); [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 151 | let (hand_send, hand_recv) = mpsc::channel(config.wait_buffer_size()); [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | let (sock_send, sock_recv) = mpsc::channel(config.done_buffer_size()); [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | [INFO] [stdout] 154 | let filters = Filters::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | let (handshake_timer, initiate_timer) = configured_handshake_timers(config.handshake_timeout(), config.connect_timeout()); [INFO] [stdout] | --------------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | let sink = HandshakerSink::new(addr_send, open_port, builder.pid, filters); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 163 | let stream = HandshakerStream::new(sock_recv); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 164 | [INFO] [stdout] 165 | Ok(Handshaker{ sink: sink, stream: stream }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handshake/handshaker.rs:176:6 [INFO] [stdout] | [INFO] [stdout] 171 | let timer = tokio_timer::wheel() [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 176 | (HandshakeTimer::new(timer.clone(), duration_one), HandshakeTimer::new(timer, duration_two)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handshake/handshaker.rs:176:56 [INFO] [stdout] | [INFO] [stdout] 171 | let timer = tokio_timer::wheel() [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 176 | (HandshakeTimer::new(timer.clone(), duration_one), HandshakeTimer::new(timer, duration_two)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filter/filters.rs:42:27 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn access_filters(&self, block: B) [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | where B: FnOnce(&[Box]) { [INFO] [stdout] 42 | self.read_filters(|ref_filters| { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 43 | | block(ref_filters) [INFO] [stdout] 44 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport.rs:49:12 [INFO] [stdout] | [INFO] [stdout] 46 | let listener = try!(TcpListener::bind(addr, handle)); [INFO] [stdout] | -------- ------------------------------------- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | let listen_addr = try!(listener.local_addr()); [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | [INFO] [stdout] 49 | Ok(TcpListenerStream::new(listen_addr, listener.incoming())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 23 previous errors; 27 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bip_handshake` (lib test) due to 24 previous errors; 27 warnings emitted [INFO] running `Command { std: "docker" "inspect" "974e685c3c58f3b317306eab9c5773088e643cde4ad343383526bab155e17d7b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "974e685c3c58f3b317306eab9c5773088e643cde4ad343383526bab155e17d7b", kill_on_drop: false }` [INFO] [stdout] 974e685c3c58f3b317306eab9c5773088e643cde4ad343383526bab155e17d7b