[INFO] fetching crate biome_fs 0.5.7... [INFO] checking biome_fs-0.5.7 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate biome_fs 0.5.7 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate biome_fs 0.5.7 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate biome_fs 0.5.7 [INFO] finished tweaking crates.io crate biome_fs 0.5.7 [INFO] tweaked toml for crates.io crate biome_fs 0.5.7 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 111 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding memoffset v0.8.0 (latest: v0.9.1) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.48.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8e978ae35fbf0b5004d04b1a8f85ad6159ad4c3b4da9d9d5ca2144d3550dc970 [INFO] running `Command { std: "docker" "start" "-a" "8e978ae35fbf0b5004d04b1a8f85ad6159ad4c3b4da9d9d5ca2144d3550dc970", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8e978ae35fbf0b5004d04b1a8f85ad6159ad4c3b4da9d9d5ca2144d3550dc970", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8e978ae35fbf0b5004d04b1a8f85ad6159ad4c3b4da9d9d5ca2144d3550dc970", kill_on_drop: false }` [INFO] [stdout] 8e978ae35fbf0b5004d04b1a8f85ad6159ad4c3b4da9d9d5ca2144d3550dc970 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 21cbaec3aff8c9e9a24c2d655095e02dd4186eeb915ea6236248c541a8098d53 [INFO] running `Command { std: "docker" "start" "-a" "21cbaec3aff8c9e9a24c2d655095e02dd4186eeb915ea6236248c541a8098d53", kill_on_drop: false }` [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling memoffset v0.8.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling schemars v0.8.21 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Compiling biome_diagnostics_categories v0.5.7 [INFO] [stderr] Compiling serde_derive_internals v0.29.1 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Compiling bpaf_derive v0.5.10 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking json-strip-comments v1.0.4 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Checking rustc-hash v2.0.0 [INFO] [stderr] Checking countme v3.0.1 [INFO] [stderr] Checking simdutf8 v0.1.4 [INFO] [stderr] Checking dunce v1.0.5 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking crossbeam-queue v0.3.11 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking dashmap v6.0.1 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking directories v5.0.1 [INFO] [stderr] Checking similar v2.6.0 [INFO] [stderr] Compiling biome_markup v0.5.7 [INFO] [stderr] Checking crossbeam v0.8.4 [INFO] [stderr] Checking bpaf v0.9.12 [INFO] [stderr] Compiling schemars_derive v0.8.21 [INFO] [stderr] Compiling biome_diagnostics_macros v0.5.7 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking biome_text_size v0.5.7 [INFO] [stderr] Checking biome_text_edit v0.5.7 [INFO] [stderr] Checking biome_rowan v0.5.7 [INFO] [stderr] Checking backtrace v0.3.73 [INFO] [stderr] Checking oxc_resolver v1.11.0 [INFO] [stderr] Checking biome_console v0.5.7 [INFO] [stderr] Checking biome_diagnostics v0.5.7 [INFO] [stderr] Checking biome_fs v0.5.7 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs/memory.rs:169:12 [INFO] [stdout] | [INFO] [stdout] 126 | let mut inner = if options.create || options.create_new { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | // Acquire write access to the files map if the file may need to be created [INFO] [stdout] 128 | let mut files = self.files.0.write(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 132 | let file: FileEntry = Arc::new(Mutex::new(vec![])); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | let files = self.files.0.read(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 169 | Ok(Box::new(MemoryFile { [INFO] [stdout] | ____________^ [INFO] [stdout] 170 | | inner, [INFO] [stdout] 171 | | can_read: options.read, [INFO] [stdout] 172 | | can_write: options.write, [INFO] [stdout] 173 | | version: 0, [INFO] [stdout] 174 | | })) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs/os.rs:69:32 [INFO] [stdout] | [INFO] [stdout] 68 | fn traversal(&self, func: BoxedTraversal) { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | OsTraversalScope::with(move |scope| { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 70 | | func(scope); [INFO] [stdout] 71 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs/os.rs:156:15 [INFO] [stdout] | [INFO] [stdout] 152 | pub(crate) fn with(func: F) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | scope(move |scope| func(Self::from_rayon(scope))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `biome_fs` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs/memory.rs:169:12 [INFO] [stdout] | [INFO] [stdout] 126 | let mut inner = if options.create || options.create_new { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | // Acquire write access to the files map if the file may need to be created [INFO] [stdout] 128 | let mut files = self.files.0.write(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 132 | let file: FileEntry = Arc::new(Mutex::new(vec![])); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | let files = self.files.0.read(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 169 | Ok(Box::new(MemoryFile { [INFO] [stdout] | ____________^ [INFO] [stdout] 170 | | inner, [INFO] [stdout] 171 | | can_read: options.read, [INFO] [stdout] 172 | | can_write: options.write, [INFO] [stdout] 173 | | version: 0, [INFO] [stdout] 174 | | })) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs/memory.rs:345:15 [INFO] [stdout] | [INFO] [stdout] 324 | let mut fs = MemoryFileSystem::new_read_only(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 345 | match fs.open_with_options(path, OpenOptions::default().read(true).write(true)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs/os.rs:69:32 [INFO] [stdout] | [INFO] [stdout] 68 | fn traversal(&self, func: BoxedTraversal) { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | OsTraversalScope::with(move |scope| { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 70 | | func(scope); [INFO] [stdout] 71 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs/os.rs:156:15 [INFO] [stdout] | [INFO] [stdout] 152 | pub(crate) fn with(func: F) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | scope(move |scope| func(Self::from_rayon(scope))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `biome_fs` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "21cbaec3aff8c9e9a24c2d655095e02dd4186eeb915ea6236248c541a8098d53", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "21cbaec3aff8c9e9a24c2d655095e02dd4186eeb915ea6236248c541a8098d53", kill_on_drop: false }` [INFO] [stdout] 21cbaec3aff8c9e9a24c2d655095e02dd4186eeb915ea6236248c541a8098d53