[INFO] fetching crate biome_analyze 0.5.7... [INFO] checking biome_analyze-0.5.7 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate biome_analyze 0.5.7 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate biome_analyze 0.5.7 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate biome_analyze 0.5.7 [INFO] finished tweaking crates.io crate biome_analyze 0.5.7 [INFO] tweaked toml for crates.io crate biome_analyze 0.5.7 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 85 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding memoffset v0.8.0 (latest: v0.9.1) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6cd25e976a496097f1ce1534b33b5f9f89dcc2b9fdce1ef302d96a5d83bc1be0 [INFO] running `Command { std: "docker" "start" "-a" "6cd25e976a496097f1ce1534b33b5f9f89dcc2b9fdce1ef302d96a5d83bc1be0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6cd25e976a496097f1ce1534b33b5f9f89dcc2b9fdce1ef302d96a5d83bc1be0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6cd25e976a496097f1ce1534b33b5f9f89dcc2b9fdce1ef302d96a5d83bc1be0", kill_on_drop: false }` [INFO] [stdout] 6cd25e976a496097f1ce1534b33b5f9f89dcc2b9fdce1ef302d96a5d83bc1be0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5c5af05e3f22586c73e51e79a1c8466a484d58e4b9439670cf2a06a38a376509 [INFO] running `Command { std: "docker" "start" "-a" "5c5af05e3f22586c73e51e79a1c8466a484d58e4b9439670cf2a06a38a376509", kill_on_drop: false }` [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling memoffset v0.8.0 [INFO] [stderr] Compiling schemars v0.8.21 [INFO] [stderr] Compiling biome_diagnostics_categories v0.5.7 [INFO] [stderr] Compiling serde_derive_internals v0.29.1 [INFO] [stderr] Compiling bpaf_derive v0.5.10 [INFO] [stderr] Checking dashmap v6.0.1 [INFO] [stderr] Checking json-strip-comments v1.0.4 [INFO] [stderr] Checking dunce v1.0.5 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking biome_text_size v0.5.7 [INFO] [stderr] Checking rustc-hash v2.0.0 [INFO] [stderr] Checking countme v3.0.1 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking simdutf8 v0.1.4 [INFO] [stderr] Compiling biome_markup v0.5.7 [INFO] [stderr] Compiling biome_diagnostics_macros v0.5.7 [INFO] [stderr] Checking similar v2.6.0 [INFO] [stderr] Compiling schemars_derive v0.8.21 [INFO] [stderr] Checking biome_text_edit v0.5.7 [INFO] [stderr] Checking bpaf v0.9.12 [INFO] [stderr] Checking biome_rowan v0.5.7 [INFO] [stderr] Checking oxc_resolver v1.11.0 [INFO] [stderr] Checking biome_console v0.5.7 [INFO] [stderr] Checking biome_diagnostics v0.5.7 [INFO] [stderr] Checking biome_analyze v0.5.7 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:102:21 [INFO] [stdout] | [INFO] [stdout] 96 | query_matcher: Matcher, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | phases: BTreeMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:454:25 [INFO] [stdout] | [INFO] [stdout] 449 | Err(diag) => { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 454 | diag.clone().with_file_span(span) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:650:10 [INFO] [stdout] | [INFO] [stdout] 616 | let first_node = token.parent()?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 620 | let mut mutation = BatchMutation::new(first_node); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 642 | let new_token = SyntaxToken::new_detached( [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 650 | Some(AnalyzerAction { [INFO] [stdout] | __________^ [INFO] [stdout] 651 | | mutation, [INFO] [stdout] 652 | | applicability: Applicability::MaybeIncorrect, [INFO] [stdout] 653 | | category: ActionCategory::QuickFix, [INFO] [stdout] ... | [INFO] [stdout] 658 | | rule_name: None, [INFO] [stdout] 659 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:737:10 [INFO] [stdout] | [INFO] [stdout] 701 | let old_token = token.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 702 | let new_token = token.clone().detach(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 703 | [INFO] [stdout] 704 | let old_trivia = if is_leading { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 710 | let old_trivia: Vec<_> = old_trivia.pieces().collect(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 728 | let new_token = if is_leading { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 734 | let mut mutation = BatchMutation::new(root.syntax().clone()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 737 | Some(AnalyzerAction { [INFO] [stdout] | __________^ [INFO] [stdout] 738 | | rule_name: None, [INFO] [stdout] 739 | | category: ActionCategory::QuickFix, [INFO] [stdout] 740 | | applicability: Applicability::Always, [INFO] [stdout] ... | [INFO] [stdout] 745 | | mutation, [INFO] [stdout] 746 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/diagnostics.rs:107:19 [INFO] [stdout] | [INFO] [stdout] 105 | pub fn from_error(error: Error) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | Self { [INFO] [stdout] 107 | kind: DiagnosticKind::Raw(error), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/matcher.rs:46:19 [INFO] [stdout] | [INFO] [stdout] 44 | pub fn new(data: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | Self { [INFO] [stdout] 46 | data: Box::new(data), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/matcher.rs:53:14 [INFO] [stdout] | [INFO] [stdout] 52 | pub fn downcast(self) -> Option { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | Some(*self.data.downcast::().ok()?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/options.rs:26:14 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new(options: O) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | Self((TypeId::of::(), Box::new(options))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry.rs:237:46 [INFO] [stdout] | [INFO] [stdout] 231 | fn add_visitor(&mut self, phase: Phases, visitor: F) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 237 | .or_insert_with(move || Box::new((visitor)())); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:102:21 [INFO] [stdout] | [INFO] [stdout] 96 | query_matcher: Matcher, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | phases: BTreeMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:454:25 [INFO] [stdout] | [INFO] [stdout] 449 | Err(diag) => { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 454 | diag.clone().with_file_span(span) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:650:10 [INFO] [stdout] | [INFO] [stdout] 616 | let first_node = token.parent()?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 620 | let mut mutation = BatchMutation::new(first_node); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 642 | let new_token = SyntaxToken::new_detached( [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 650 | Some(AnalyzerAction { [INFO] [stdout] | __________^ [INFO] [stdout] 651 | | mutation, [INFO] [stdout] 652 | | applicability: Applicability::MaybeIncorrect, [INFO] [stdout] 653 | | category: ActionCategory::QuickFix, [INFO] [stdout] ... | [INFO] [stdout] 658 | | rule_name: None, [INFO] [stdout] 659 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:737:10 [INFO] [stdout] | [INFO] [stdout] 701 | let old_token = token.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 702 | let new_token = token.clone().detach(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 703 | [INFO] [stdout] 704 | let old_trivia = if is_leading { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 710 | let old_trivia: Vec<_> = old_trivia.pieces().collect(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 728 | let new_token = if is_leading { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 734 | let mut mutation = BatchMutation::new(root.syntax().clone()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 737 | Some(AnalyzerAction { [INFO] [stdout] | __________^ [INFO] [stdout] 738 | | rule_name: None, [INFO] [stdout] 739 | | category: ActionCategory::QuickFix, [INFO] [stdout] 740 | | applicability: Applicability::Always, [INFO] [stdout] ... | [INFO] [stdout] 745 | | mutation, [INFO] [stdout] 746 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/signals.rs:83:14 [INFO] [stdout] | [INFO] [stdout] 81 | let diag = (self.diagnostic)(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | let error = Error::from(diag); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | Some(AnalyzerDiagnostic::from_error(error)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/diagnostics.rs:107:19 [INFO] [stdout] | [INFO] [stdout] 105 | pub fn from_error(error: Error) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | Self { [INFO] [stdout] 107 | kind: DiagnosticKind::Raw(error), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/matcher.rs:46:19 [INFO] [stdout] | [INFO] [stdout] 44 | pub fn new(data: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | Self { [INFO] [stdout] 46 | data: Box::new(data), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/matcher.rs:53:14 [INFO] [stdout] | [INFO] [stdout] 52 | pub fn downcast(self) -> Option { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | Some(*self.data.downcast::().ok()?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/signals.rs:171:31 [INFO] [stdout] | [INFO] [stdout] 165 | pub fn new(actions: I) -> Self [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 171 | analyzer_actions: actions [INFO] [stdout] | _______________________________^ [INFO] [stdout] 172 | | .into_iter() [INFO] [stdout] 173 | | .collect::>>() [INFO] [stdout] 174 | | .into_iter(), [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/options.rs:26:14 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new(options: O) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | Self((TypeId::of::(), Box::new(options))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry.rs:237:46 [INFO] [stdout] | [INFO] [stdout] 231 | fn add_visitor(&mut self, phase: Phases, visitor: F) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 237 | .or_insert_with(move || Box::new((visitor)())); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/signals.rs:278:39 [INFO] [stdout] | [INFO] [stdout] 272 | pub fn new(transformations: I) -> Self [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 278 | analyzer_transformations: transformations [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 279 | | .into_iter() [INFO] [stdout] 280 | | .collect::>>() [INFO] [stdout] 281 | | .into_iter(), [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/visitor.rs:24:40 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn match_query(&mut self, query: T) { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | self.query_matcher.match_query(MatchQueryParams { [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 25 | | phase: self.phase, [INFO] [stdout] 26 | | root: self.root, [INFO] [stdout] 27 | | query: Query::new(query), [INFO] [stdout] ... | [INFO] [stdout] 31 | | options: self.options, [INFO] [stdout] 32 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/signals.rs:83:14 [INFO] [stdout] | [INFO] [stdout] 81 | let diag = (self.diagnostic)(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | let error = Error::from(diag); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | Some(AnalyzerDiagnostic::from_error(error)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/signals.rs:171:31 [INFO] [stdout] | [INFO] [stdout] 165 | pub fn new(actions: I) -> Self [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 171 | analyzer_actions: actions [INFO] [stdout] | _______________________________^ [INFO] [stdout] 172 | | .into_iter() [INFO] [stdout] 173 | | .collect::>>() [INFO] [stdout] 174 | | .into_iter(), [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/signals.rs:278:39 [INFO] [stdout] | [INFO] [stdout] 272 | pub fn new(transformations: I) -> Self [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 278 | analyzer_transformations: transformations [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 279 | | .into_iter() [INFO] [stdout] 280 | | .collect::>>() [INFO] [stdout] 281 | | .into_iter(), [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/visitor.rs:24:40 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn match_query(&mut self, query: T) { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | self.query_matcher.match_query(MatchQueryParams { [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 25 | | phase: self.phase, [INFO] [stdout] 26 | | root: self.root, [INFO] [stdout] 27 | | query: Query::new(query), [INFO] [stdout] ... | [INFO] [stdout] 31 | | options: self.options, [INFO] [stdout] 32 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `biome_analyze` (lib) due to 14 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `biome_analyze` (lib test) due to 14 previous errors [INFO] running `Command { std: "docker" "inspect" "5c5af05e3f22586c73e51e79a1c8466a484d58e4b9439670cf2a06a38a376509", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5c5af05e3f22586c73e51e79a1c8466a484d58e4b9439670cf2a06a38a376509", kill_on_drop: false }` [INFO] [stdout] 5c5af05e3f22586c73e51e79a1c8466a484d58e4b9439670cf2a06a38a376509