[INFO] fetching crate binstalk-git-repo-api 0.5.1... [INFO] checking binstalk-git-repo-api-0.5.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate binstalk-git-repo-api 0.5.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate binstalk-git-repo-api 0.5.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate binstalk-git-repo-api 0.5.1 [INFO] finished tweaking crates.io crate binstalk-git-repo-api 0.5.1 [INFO] tweaked toml for crates.io crate binstalk-git-repo-api 0.5.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 244 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding core-foundation v0.9.4 (latest: v0.10.0) [INFO] [stderr] Adding foreign-types v0.3.2 (latest: v0.5.0) [INFO] [stderr] Adding foreign-types-shared v0.1.1 (latest: v0.3.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding h3 v0.0.5 (latest: v0.0.6) [INFO] [stderr] Adding h3-quinn v0.0.6 (latest: v0.0.7) [INFO] [stderr] Adding heck v0.4.1 (latest: v0.5.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding hostname v0.3.1 (latest: v0.4.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding nu-ansi-term v0.46.0 (latest: v0.50.1) [INFO] [stderr] Adding quick-error v1.2.3 (latest: v2.0.1) [INFO] [stderr] Adding redox_syscall v0.3.5 (latest: v0.5.3) [INFO] [stderr] Adding rustls-native-certs v0.7.3 (latest: v0.8.0) [INFO] [stderr] Adding tower v0.4.13 (latest: v0.5.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.48.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding winreg v0.50.0 (latest: v0.52.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1a9c54101b57f8408369d323759176c034ceca1960a7c40750976160e2addb47 [INFO] running `Command { std: "docker" "start" "-a" "1a9c54101b57f8408369d323759176c034ceca1960a7c40750976160e2addb47", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1a9c54101b57f8408369d323759176c034ceca1960a7c40750976160e2addb47", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1a9c54101b57f8408369d323759176c034ceca1960a7c40750976160e2addb47", kill_on_drop: false }` [INFO] [stdout] 1a9c54101b57f8408369d323759176c034ceca1960a7c40750976160e2addb47 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0cbfeb63e506b83e140645c4f13538896e18067c27c64a7c0a82c83abd8d5ba4 [INFO] running `Command { std: "docker" "start" "-a" "0cbfeb63e506b83e140645c4f13538896e18067c27c64a7c0a82c83abd8d5ba4", kill_on_drop: false }` [INFO] [stderr] Checking rustls-pki-types v1.8.0 [INFO] [stderr] Checking alloc-no-stdlib v2.0.4 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Compiling zstd-safe v7.2.1 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Compiling rustls v0.23.12 [INFO] [stderr] Checking rustix v0.38.35 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Checking deflate64 v0.1.9 [INFO] [stderr] Checking castaway v0.2.3 [INFO] [stderr] Checking filetime v0.2.25 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking alloc-stdlib v0.2.2 [INFO] [stderr] Checking futures-lite v2.3.0 [INFO] [stderr] Checking compact_str v0.8.0 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking maybe-owned v0.3.4 [INFO] [stderr] Checking brotli-decompressor v4.0.1 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking serde-tuple-vec-map v1.0.1 [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Checking rustls-pemfile v2.1.3 [INFO] [stderr] Checking webpki-roots v0.26.5 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking rustls-native-certs v0.7.3 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking h2 v0.4.6 [INFO] [stderr] Checking brotli v6.0.0 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Compiling zstd-sys v2.0.13+zstd.1.5.6 [INFO] [stderr] Compiling lzma-sys v0.1.20 [INFO] [stderr] Compiling bzip2-sys v0.1.11+1.0.8 [INFO] [stderr] Checking binstalk-types v0.9.0 [INFO] [stderr] Checking xattr v1.3.1 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking tokio-tar v0.3.1 [INFO] [stderr] Checking binstall-tar v0.4.42 [INFO] [stderr] Checking bzip2 v0.4.4 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking xz2 v0.1.7 [INFO] [stderr] Checking hyper-util v0.1.7 [INFO] [stderr] Checking rustls-webpki v0.102.7 [INFO] [stderr] Checking zstd v0.13.2 [INFO] [stderr] Checking async-compression v0.4.12 [INFO] [stderr] Checking async_zip v0.0.17 [INFO] [stderr] Checking tokio-rustls v0.26.0 [INFO] [stderr] Checking hyper-rustls v0.27.2 [INFO] [stderr] Checking reqwest v0.12.7 [INFO] [stderr] Checking binstalk-downloader v0.13.1 [INFO] [stderr] Checking binstalk-git-repo-api v0.5.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gh_api_client.rs:94:26 [INFO] [stdout] | [INFO] [stdout] 94 | release: GhRelease { [INFO] [stdout] | __________________________^ [INFO] [stdout] 95 | | repo: GhRepo { [INFO] [stdout] 96 | | owner: percent_decode_http_url_path(owner), [INFO] [stdout] 97 | | repo: percent_decode_http_url_path(repo), [INFO] [stdout] 98 | | }, [INFO] [stdout] 99 | | tag: percent_decode_http_url_path(tag), [INFO] [stdout] 100 | | }, [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gh_api_client.rs:101:32 [INFO] [stdout] | [INFO] [stdout] 101 | artifact_name: percent_decode_http_url_path(artifact_name), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gh_api_client.rs:123:39 [INFO] [stdout] | [INFO] [stdout] 121 | fn get(&self, k: K) -> Arc { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 122 | let optional_value = self.0.read().unwrap().deref().get(&k).cloned(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 123 | optional_value.unwrap_or_else(|| Arc::clone(self.0.write().unwrap().entry(k).or_default())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gh_api_client.rs:123:53 [INFO] [stdout] | [INFO] [stdout] 121 | fn get(&self, k: K) -> Arc { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 122 | let optional_value = self.0.read().unwrap().deref().get(&k).cloned(); [INFO] [stdout] 123 | optional_value.unwrap_or_else(|| Arc::clone(self.0.write().unwrap().entry(k).or_default())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gh_api_client.rs:146:14 [INFO] [stdout] | [INFO] [stdout] 145 | pub fn new(client: remote::Client, auth_token: Option>>) -> Self { [INFO] [stdout] | ---------------------- --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | Self(Arc::new(Inner { [INFO] [stdout] | ______________^ [INFO] [stdout] 147 | | client, [INFO] [stdout] 148 | | release_artifacts: Default::default(), [INFO] [stdout] 149 | | retry_after: Default::default(), [INFO] [stdout] ... | [INFO] [stdout] 154 | | only_use_restful_api: AtomicBool::new(false), [INFO] [stdout] 155 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gh_api_client/common.rs:68:12 [INFO] [stdout] | [INFO] [stdout] 63 | let future = request_builder.send(false); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | let response = check_http_status_and_header(future.await?)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | [INFO] [stdout] 68 | Ok(response.json().await?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gh_api_client/error.rs:159:12 [INFO] [stdout] | [INFO] [stdout] 154 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 158 | let s = CompactString::deserialize(deserializer)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 159 | Ok(match &*s { [INFO] [stdout] | ____________^ [INFO] [stdout] 160 | | "RATE_LIMITED" => GraphQLErrorType::RateLimited, [INFO] [stdout] 161 | | _ => GraphQLErrorType::Other(s), [INFO] [stdout] 162 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `binstalk-git-repo-api` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gh_api_client.rs:94:26 [INFO] [stdout] | [INFO] [stdout] 94 | release: GhRelease { [INFO] [stdout] | __________________________^ [INFO] [stdout] 95 | | repo: GhRepo { [INFO] [stdout] 96 | | owner: percent_decode_http_url_path(owner), [INFO] [stdout] 97 | | repo: percent_decode_http_url_path(repo), [INFO] [stdout] 98 | | }, [INFO] [stdout] 99 | | tag: percent_decode_http_url_path(tag), [INFO] [stdout] 100 | | }, [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gh_api_client.rs:101:32 [INFO] [stdout] | [INFO] [stdout] 101 | artifact_name: percent_decode_http_url_path(artifact_name), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gh_api_client.rs:123:39 [INFO] [stdout] | [INFO] [stdout] 121 | fn get(&self, k: K) -> Arc { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 122 | let optional_value = self.0.read().unwrap().deref().get(&k).cloned(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 123 | optional_value.unwrap_or_else(|| Arc::clone(self.0.write().unwrap().entry(k).or_default())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gh_api_client.rs:123:53 [INFO] [stdout] | [INFO] [stdout] 121 | fn get(&self, k: K) -> Arc { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 122 | let optional_value = self.0.read().unwrap().deref().get(&k).cloned(); [INFO] [stdout] 123 | optional_value.unwrap_or_else(|| Arc::clone(self.0.write().unwrap().entry(k).or_default())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gh_api_client.rs:146:14 [INFO] [stdout] | [INFO] [stdout] 145 | pub fn new(client: remote::Client, auth_token: Option>>) -> Self { [INFO] [stdout] | ---------------------- --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | Self(Arc::new(Inner { [INFO] [stdout] | ______________^ [INFO] [stdout] 147 | | client, [INFO] [stdout] 148 | | release_artifacts: Default::default(), [INFO] [stdout] 149 | | retry_after: Default::default(), [INFO] [stdout] ... | [INFO] [stdout] 154 | | only_use_restful_api: AtomicBool::new(false), [INFO] [stdout] 155 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gh_api_client/common.rs:68:12 [INFO] [stdout] | [INFO] [stdout] 63 | let future = request_builder.send(false); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | let response = check_http_status_and_header(future.await?)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | [INFO] [stdout] 68 | Ok(response.json().await?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gh_api_client/error.rs:159:12 [INFO] [stdout] | [INFO] [stdout] 154 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 158 | let s = CompactString::deserialize(deserializer)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 159 | Ok(match &*s { [INFO] [stdout] | ____________^ [INFO] [stdout] 160 | | "RATE_LIMITED" => GraphQLErrorType::RateLimited, [INFO] [stdout] 161 | | _ => GraphQLErrorType::Other(s), [INFO] [stdout] 162 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gh_api_client/repo_info.rs:37:20 [INFO] [stdout] | [INFO] [stdout] 35 | pub(crate) fn new(GhRepo { owner, repo }: GhRepo, private: bool) -> Self { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | Self { [INFO] [stdout] 37 | owner: Owner { login: owner }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gh_api_client.rs:567:30 [INFO] [stdout] | [INFO] [stdout] 565 | let spawn_get_repo_info_task = |repo| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 566 | let client = client.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 567 | tokio::spawn(async move { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 568 | | loop { [INFO] [stdout] 569 | | match client.get_repo_info(&repo).await { [INFO] [stdout] 570 | | Err(GhApiError::RateLimit { retry_after }) => { [INFO] [stdout] ... | [INFO] [stdout] 575 | | } [INFO] [stdout] 576 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `binstalk-git-repo-api` (lib test) due to 10 previous errors [INFO] running `Command { std: "docker" "inspect" "0cbfeb63e506b83e140645c4f13538896e18067c27c64a7c0a82c83abd8d5ba4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0cbfeb63e506b83e140645c4f13538896e18067c27c64a7c0a82c83abd8d5ba4", kill_on_drop: false }` [INFO] [stdout] 0cbfeb63e506b83e140645c4f13538896e18067c27c64a7c0a82c83abd8d5ba4