[INFO] fetching crate binstalk 0.28.2... [INFO] checking binstalk-0.28.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate binstalk 0.28.2 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate binstalk 0.28.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate binstalk 0.28.2 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate binstalk 0.28.2 [INFO] tweaked toml for crates.io crate binstalk 0.28.2 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 383 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding core-foundation v0.9.4 (latest: v0.10.0) [INFO] [stderr] Adding dlopen2 v0.5.0 (latest: v0.7.0) [INFO] [stderr] Adding errno v0.2.8 (latest: v0.3.9) [INFO] [stderr] Adding foreign-types v0.3.2 (latest: v0.5.0) [INFO] [stderr] Adding foreign-types-shared v0.1.1 (latest: v0.3.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding h3 v0.0.5 (latest: v0.0.6) [INFO] [stderr] Adding h3-quinn v0.0.6 (latest: v0.0.7) [INFO] [stderr] Adding heck v0.4.1 (latest: v0.5.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding hostname v0.3.1 (latest: v0.4.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding netlink-packet-route v0.17.1 (latest: v0.20.1) [INFO] [stderr] Adding nix v0.27.1 (latest: v0.29.0) [INFO] [stderr] Adding prodash v28.0.0 (latest: v29.0.0) [INFO] [stderr] Adding quick-error v1.2.3 (latest: v2.0.1) [INFO] [stderr] Adding redox_syscall v0.3.5 (latest: v0.5.3) [INFO] [stderr] Adding rustls-native-certs v0.7.3 (latest: v0.8.0) [INFO] [stderr] Adding system-configuration v0.5.1 (latest: v0.6.1) [INFO] [stderr] Adding system-configuration-sys v0.5.0 (latest: v0.6.0) [INFO] [stderr] Adding tower v0.4.13 (latest: v0.5.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows v0.48.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.48.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding winreg v0.50.0 (latest: v0.52.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b0115d0f02d2325985e7bf6372f4d0fba98a5d5249de24ea4a0ae05f5b094b3c [INFO] running `Command { std: "docker" "start" "-a" "b0115d0f02d2325985e7bf6372f4d0fba98a5d5249de24ea4a0ae05f5b094b3c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b0115d0f02d2325985e7bf6372f4d0fba98a5d5249de24ea4a0ae05f5b094b3c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b0115d0f02d2325985e7bf6372f4d0fba98a5d5249de24ea4a0ae05f5b094b3c", kill_on_drop: false }` [INFO] [stdout] b0115d0f02d2325985e7bf6372f4d0fba98a5d5249de24ea4a0ae05f5b094b3c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e65d424d95a2f09d361ec65f3d9f55687e141c5e8795818f776554a67b164f3b [INFO] running `Command { std: "docker" "start" "-a" "e65d424d95a2f09d361ec65f3d9f55687e141c5e8795818f776554a67b164f3b", kill_on_drop: false }` [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking gix-trace v0.1.9 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking faster-hex v0.9.0 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking bytesize v1.3.0 [INFO] [stderr] Checking human_format v1.1.0 [INFO] [stderr] Checking gix-utils v0.1.12 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking sha1_smol v1.0.1 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking winnow v0.6.18 [INFO] [stderr] Checking lock_api v0.4.12 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking gix-hash v0.14.2 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Checking prodash v28.0.0 [INFO] [stderr] Checking jiff v0.1.12 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking rustls-pki-types v1.8.0 [INFO] [stderr] Checking gix-chunk v0.4.8 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking alloc-no-stdlib v2.0.4 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Compiling zstd-safe v7.2.1 [INFO] [stderr] Checking alloc-stdlib v0.2.2 [INFO] [stderr] Compiling rustls v0.23.12 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Checking brotli-decompressor v4.0.1 [INFO] [stderr] Checking filetime v0.2.25 [INFO] [stderr] Checking deflate64 v0.1.9 [INFO] [stderr] Checking unicode-bom v2.0.3 [INFO] [stderr] Checking shell-words v1.1.0 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking castaway v0.2.3 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking kstring v2.0.2 [INFO] [stderr] Checking rustls-pemfile v2.1.3 [INFO] [stderr] Checking webpki-roots v0.26.5 [INFO] [stderr] Checking gix-sec v0.10.8 [INFO] [stderr] Checking compact_str v0.8.0 [INFO] [stderr] Checking rustls-native-certs v0.7.3 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Checking gix-features v0.38.2 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Checking maybe-owned v0.3.4 [INFO] [stderr] Checking gix-bitmap v0.2.11 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Checking gix-fs v0.11.3 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking futures-lite v2.3.0 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking uluru v3.1.0 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Compiling miette-derive v7.2.0 [INFO] [stderr] Checking clru v0.6.2 [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Compiling maybe-async v0.2.10 [INFO] [stderr] Checking bstr v1.10.0 [INFO] [stderr] Checking io-close v0.3.7 [INFO] [stderr] Checking arc-swap v1.7.1 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling derive_destructure2 v0.1.3 [INFO] [stderr] Checking brotli v6.0.0 [INFO] [stderr] Checking normalize-path v0.2.1 [INFO] [stderr] Compiling leon v3.0.1 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking gix-hashtable v0.5.2 [INFO] [stderr] Checking serde-tuple-vec-map v1.0.1 [INFO] [stderr] Checking errno v0.2.8 [INFO] [stderr] Compiling target-lexicon v0.12.16 [INFO] [stderr] Checking gix-path v0.10.10 [INFO] [stderr] Checking gix-validate v0.9.0 [INFO] [stderr] Checking gix-quote v0.4.12 [INFO] [stderr] Checking gix-commitgraph v0.24.3 [INFO] [stderr] Checking gix-packetline v0.17.6 [INFO] [stderr] Checking gix-glob v0.16.5 [INFO] [stderr] Checking gix-config-value v0.14.8 [INFO] [stderr] Checking gix-command v0.3.9 [INFO] [stderr] Checking gix-url v0.27.5 [INFO] [stderr] Checking gix-packetline-blocking v0.17.5 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Checking miette v7.2.0 [INFO] [stderr] Compiling detect-targets v0.1.20 [INFO] [stderr] Checking guess_host_triple v0.1.4 [INFO] [stderr] Checking gix-attributes v0.22.5 [INFO] [stderr] Checking gix-ignore v0.11.4 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Compiling leon-macros v1.0.2 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking nix v0.27.1 [INFO] [stderr] Checking base16 v0.2.1 [INFO] [stderr] Checking minisign-verify v0.2.2 [INFO] [stderr] Checking toml_edit v0.22.20 [INFO] [stderr] Checking gix-pathspec v0.7.7 [INFO] [stderr] Checking binstalk-types v0.9.0 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Compiling zstd-sys v2.0.13+zstd.1.5.6 [INFO] [stderr] Compiling bzip2-sys v0.1.11+1.0.8 [INFO] [stderr] Compiling lzma-sys v0.1.20 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking xattr v1.3.1 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking gix-prompt v0.8.7 [INFO] [stderr] Checking gix-tempfile v14.0.2 [INFO] [stderr] Checking binstall-tar v0.4.42 [INFO] [stderr] Checking reflink-copy v0.1.19 [INFO] [stderr] Checking gix-lock v14.0.0 [INFO] [stderr] Checking gix-credentials v0.24.5 [INFO] [stderr] Checking atomic-file-install v1.0.5 [INFO] [stderr] Checking binstalk-bins v0.6.0 [INFO] [stderr] Checking gix-date v0.9.0 [INFO] [stderr] Checking gix-actor v0.32.0 [INFO] [stderr] Checking bzip2 v0.4.4 [INFO] [stderr] Checking gix-object v0.44.0 [INFO] [stderr] Checking gix-revwalk v0.15.0 [INFO] [stderr] Checking gix-ref v0.47.0 [INFO] [stderr] Checking gix-pack v0.53.0 [INFO] [stderr] Checking gix-filter v0.13.0 [INFO] [stderr] Checking gix-diff v0.46.0 [INFO] [stderr] Checking gix-traverse v0.41.0 [INFO] [stderr] Checking gix-revision v0.29.0 [INFO] [stderr] Checking gix-negotiate v0.15.0 [INFO] [stderr] Checking xz2 v0.1.7 [INFO] [stderr] Checking gix-refspec v0.25.0 [INFO] [stderr] Checking gix-index v0.35.0 [INFO] [stderr] Checking toml v0.8.19 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking command-group v5.0.1 [INFO] [stderr] Checking jobslot v0.2.19 [INFO] [stderr] Checking gix-config v0.40.0 [INFO] [stderr] Checking gix-discover v0.35.0 [INFO] [stderr] Checking cargo_toml v0.20.4 [INFO] [stderr] Checking rustls-webpki v0.102.7 [INFO] [stderr] Checking gix-worktree v0.36.0 [INFO] [stderr] Checking gix-odb v0.63.0 [INFO] [stderr] Checking h2 v0.4.6 [INFO] [stderr] Checking gix-worktree-state v0.13.0 [INFO] [stderr] Checking tokio-tar v0.3.1 [INFO] [stderr] Checking zstd v0.13.2 [INFO] [stderr] Checking async-compression v0.4.12 [INFO] [stderr] Checking gix-submodule v0.14.0 [INFO] [stderr] Checking cargo-toml-workspace v6.0.1 [INFO] [stderr] Checking async_zip v0.0.17 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking tokio-rustls v0.26.0 [INFO] [stderr] Checking hyper-util v0.1.7 [INFO] [stderr] Checking hyper-rustls v0.27.2 [INFO] [stderr] Checking reqwest v0.12.7 [INFO] [stderr] Checking gix-transport v0.42.3 [INFO] [stderr] Checking binstalk-downloader v0.13.1 [INFO] [stderr] Checking gix-protocol v0.45.3 [INFO] [stderr] Checking binstalk-git-repo-api v0.5.1 [INFO] [stderr] Checking gix v0.66.0 [INFO] [stderr] Checking binstalk-fetchers v0.9.1 [INFO] [stderr] Checking simple-git v0.2.12 [INFO] [stderr] Checking binstalk-registry v0.11.1 [INFO] [stderr] Checking binstalk v0.28.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:103:27 [INFO] [stdout] | [INFO] [stdout] 103 | let get_iter = || self.iter().filter_map(miette::Diagnostic::labels).flatten(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:494:34 [INFO] [stdout] | [INFO] [stdout] 493 | pub fn crate_context(self, crate_name: impl Into) -> Self { [INFO] [stdout] | ---- ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 494 | self.crate_context_inner(crate_name.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:533:9 [INFO] [stdout] | [INFO] [stdout] 532 | fn from(err: io::Error) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 533 | err.downcast::() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:549:9 [INFO] [stdout] | [INFO] [stdout] 548 | fn from(e: RemoteError) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 549 | DownloadError::from(e).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:555:38 [INFO] [stdout] | [INFO] [stdout] 554 | fn from(e: CargoTomlError) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 555 | BinstallError::CargoManifest(Box::new(e)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:561:38 [INFO] [stdout] | [INFO] [stdout] 560 | fn from(e: InvalidPkgFmtError) -> Self { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 561 | BinstallError::InvalidPkgFmt(Box::new(e)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:567:33 [INFO] [stdout] | [INFO] [stdout] 566 | fn from(e: GhApiError) -> Self { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 567 | BinstallError::GhApiErr(Box::new(e)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:579:38 [INFO] [stdout] | [INFO] [stdout] 578 | fn from(e: RegistryError) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 579 | BinstallError::RegistryError(Box::new(e)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:585:43 [INFO] [stdout] | [INFO] [stdout] 584 | fn from(e: InvalidRegistryError) -> Self { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 585 | BinstallError::RegistryParseError(Box::new(e)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:591:48 [INFO] [stdout] | [INFO] [stdout] 590 | fn from(e: LoadManifestFromWSError) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 591 | BinstallError::LoadManifestFromWSError(Box::new(e)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:597:35 [INFO] [stdout] | [INFO] [stdout] 596 | fn from(e: FetchError) -> Self { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 597 | BinstallError::FetchError(Box::new(e)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/helpers/jobserver_client.rs:22:14 [INFO] [stdout] | [INFO] [stdout] 21 | let opt = unsafe { Client::from_env() }; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | Self(OnceCell::new_with(opt)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/helpers/lazy_gh_api_client.rs:24:20 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn new(client: remote::Client, auth_token: GitHubToken) -> Self { [INFO] [stdout] | ---------------------- ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | Self { [INFO] [stdout] 24 | inner: OnceCell::new_with(Some(GhApiClient::new(client.clone(), auth_token))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/helpers/lazy_gh_api_client.rs:26:19 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn new(client: remote::Client, auth_token: GitHubToken) -> Self { [INFO] [stdout] | ---------------------- ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | task: Mutex::new(None), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/helpers/lazy_gh_api_client.rs:35:20 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn with_get_gh_token_future(client: remote::Client, get_auth_token_future: Fut) -> Self [INFO] [stdout] | ---------------------- -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | inner: OnceCell::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/helpers/lazy_gh_api_client.rs:36:19 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn with_get_gh_token_future(client: remote::Client, get_auth_token_future: Fut) -> Self [INFO] [stdout] | ---------------------- -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | task: Mutex::new(Some(AutoAbortJoinHandle::spawn(get_auth_token_future))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/helpers/lazy_gh_api_client.rs:45:20 [INFO] [stdout] | [INFO] [stdout] 44 | let task = self.task.lock().unwrap().take(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | Ok(if let Some(task) = task { [INFO] [stdout] | ____________________^ [INFO] [stdout] 46 | | GhApiClient::new(self.client.clone(), task.await?) [INFO] [stdout] 47 | | } else { [INFO] [stdout] 48 | | GhApiClient::new(self.client.clone(), None) [INFO] [stdout] 49 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/helpers/target_triple.rs:28:12 [INFO] [stdout] | [INFO] [stdout] 26 | let triple = Triple::from_str(s)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | [INFO] [stdout] 28 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 29 | | target_family: triple.operating_system.into_str(), [INFO] [stdout] 30 | | target_arch: if is_universal_macos { [INFO] [stdout] 31 | | Cow::Borrowed("universal") [INFO] [stdout] ... | [INFO] [stdout] 36 | | target_vendor: triple.vendor.to_compact_string(), [INFO] [stdout] 37 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/helpers/tasks.rs:29:14 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn spawn(future: F) -> Self [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | Self(tokio::spawn(future)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ops/resolve.rs:105:16 [INFO] [stdout] | [INFO] [stdout] 99 | let meta = package_info.meta.merge_overrides( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | Ok(Arc::new(TargetData { [INFO] [stdout] | ________________^ [INFO] [stdout] 106 | | target: target.clone(), [INFO] [stdout] 107 | | meta, [INFO] [stdout] 108 | | target_related_info: TargetTriple::from_str(target)?, [INFO] [stdout] 109 | | })) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ops/resolve.rs:321:19 [INFO] [stdout] | [INFO] [stdout] 320 | .filter_map(|(bin, bin_file)| { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 321 | match bin_file.check_source_exists(&mut |p| extracted_files.has_file(p)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ops/resolve.rs:470:48 [INFO] [stdout] | [INFO] [stdout] 455 | let cancellation_token = GitCancellationToken::default(); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 461 | let name = name.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 462 | move || { [INFO] [stdout] 463 | let dir = tempfile::TempDir::new()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 464 | let repo = GitRepository::shallow_clone( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 470 | Ok::<_, BinstallError>(( [INFO] [stdout] | ________________________________________________^ [INFO] [stdout] 471 | | load_manifest_from_workspace(dir.as_ref(), &name) [INFO] [stdout] 472 | | .map_err(BinstallError::from)?, [INFO] [stdout] 473 | | repo.get_head_commit_hash()?, [INFO] [stdout] 474 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ops/resolve/crate_name.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn dedup(mut crate_names: Vec) -> impl Iterator { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | crate_names.sort_by(|x, y| x.name.cmp(&y.name)); [INFO] [stdout] 48 | crate_names.into_iter().coalesce(|previous, current| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ops/resolve/resolution.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn install(self, opts: &Options) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | let crate_name = self.name.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | self.install_inner(opts) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ops/resolve/resolution.rs:57:22 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn install(self, opts: &Options) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | let crate_name = self.name.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | self.install_inner(opts) [INFO] [stdout] 57 | .map_err(|err| err.crate_context(crate_name)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ops/resolve/resolution.rs:84:12 [INFO] [stdout] | [INFO] [stdout] 60 | fn install_inner(self, opts: &Options) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | Ok(CrateInfo { [INFO] [stdout] | ____________^ [INFO] [stdout] 85 | | name: self.name, [INFO] [stdout] 86 | | version_req: self.version_req, [INFO] [stdout] 87 | | current_version: self.new_version, [INFO] [stdout] ... | [INFO] [stdout] 94 | | .collect(), [INFO] [stdout] 95 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 26 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `binstalk` (lib) due to 27 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:103:27 [INFO] [stdout] | [INFO] [stdout] 103 | let get_iter = || self.iter().filter_map(miette::Diagnostic::labels).flatten(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:494:34 [INFO] [stdout] | [INFO] [stdout] 493 | pub fn crate_context(self, crate_name: impl Into) -> Self { [INFO] [stdout] | ---- ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 494 | self.crate_context_inner(crate_name.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:533:9 [INFO] [stdout] | [INFO] [stdout] 532 | fn from(err: io::Error) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 533 | err.downcast::() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:549:9 [INFO] [stdout] | [INFO] [stdout] 548 | fn from(e: RemoteError) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 549 | DownloadError::from(e).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:555:38 [INFO] [stdout] | [INFO] [stdout] 554 | fn from(e: CargoTomlError) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 555 | BinstallError::CargoManifest(Box::new(e)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:561:38 [INFO] [stdout] | [INFO] [stdout] 560 | fn from(e: InvalidPkgFmtError) -> Self { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 561 | BinstallError::InvalidPkgFmt(Box::new(e)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:567:33 [INFO] [stdout] | [INFO] [stdout] 566 | fn from(e: GhApiError) -> Self { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 567 | BinstallError::GhApiErr(Box::new(e)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:579:38 [INFO] [stdout] | [INFO] [stdout] 578 | fn from(e: RegistryError) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 579 | BinstallError::RegistryError(Box::new(e)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:585:43 [INFO] [stdout] | [INFO] [stdout] 584 | fn from(e: InvalidRegistryError) -> Self { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 585 | BinstallError::RegistryParseError(Box::new(e)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:591:48 [INFO] [stdout] | [INFO] [stdout] 590 | fn from(e: LoadManifestFromWSError) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 591 | BinstallError::LoadManifestFromWSError(Box::new(e)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/errors.rs:597:35 [INFO] [stdout] | [INFO] [stdout] 596 | fn from(e: FetchError) -> Self { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 597 | BinstallError::FetchError(Box::new(e)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/helpers/jobserver_client.rs:22:14 [INFO] [stdout] | [INFO] [stdout] 21 | let opt = unsafe { Client::from_env() }; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | Self(OnceCell::new_with(opt)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/helpers/lazy_gh_api_client.rs:24:20 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn new(client: remote::Client, auth_token: GitHubToken) -> Self { [INFO] [stdout] | ---------------------- ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | Self { [INFO] [stdout] 24 | inner: OnceCell::new_with(Some(GhApiClient::new(client.clone(), auth_token))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/helpers/lazy_gh_api_client.rs:26:19 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn new(client: remote::Client, auth_token: GitHubToken) -> Self { [INFO] [stdout] | ---------------------- ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | task: Mutex::new(None), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/helpers/lazy_gh_api_client.rs:35:20 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn with_get_gh_token_future(client: remote::Client, get_auth_token_future: Fut) -> Self [INFO] [stdout] | ---------------------- -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | inner: OnceCell::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/helpers/lazy_gh_api_client.rs:36:19 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn with_get_gh_token_future(client: remote::Client, get_auth_token_future: Fut) -> Self [INFO] [stdout] | ---------------------- -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | task: Mutex::new(Some(AutoAbortJoinHandle::spawn(get_auth_token_future))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/helpers/lazy_gh_api_client.rs:45:20 [INFO] [stdout] | [INFO] [stdout] 44 | let task = self.task.lock().unwrap().take(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | Ok(if let Some(task) = task { [INFO] [stdout] | ____________________^ [INFO] [stdout] 46 | | GhApiClient::new(self.client.clone(), task.await?) [INFO] [stdout] 47 | | } else { [INFO] [stdout] 48 | | GhApiClient::new(self.client.clone(), None) [INFO] [stdout] 49 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/helpers/target_triple.rs:28:12 [INFO] [stdout] | [INFO] [stdout] 26 | let triple = Triple::from_str(s)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | [INFO] [stdout] 28 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 29 | | target_family: triple.operating_system.into_str(), [INFO] [stdout] 30 | | target_arch: if is_universal_macos { [INFO] [stdout] 31 | | Cow::Borrowed("universal") [INFO] [stdout] ... | [INFO] [stdout] 36 | | target_vendor: triple.vendor.to_compact_string(), [INFO] [stdout] 37 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/helpers/tasks.rs:29:14 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn spawn(future: F) -> Self [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | Self(tokio::spawn(future)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ops/resolve.rs:105:16 [INFO] [stdout] | [INFO] [stdout] 99 | let meta = package_info.meta.merge_overrides( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | Ok(Arc::new(TargetData { [INFO] [stdout] | ________________^ [INFO] [stdout] 106 | | target: target.clone(), [INFO] [stdout] 107 | | meta, [INFO] [stdout] 108 | | target_related_info: TargetTriple::from_str(target)?, [INFO] [stdout] 109 | | })) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ops/resolve.rs:321:19 [INFO] [stdout] | [INFO] [stdout] 320 | .filter_map(|(bin, bin_file)| { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 321 | match bin_file.check_source_exists(&mut |p| extracted_files.has_file(p)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ops/resolve.rs:470:48 [INFO] [stdout] | [INFO] [stdout] 455 | let cancellation_token = GitCancellationToken::default(); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 461 | let name = name.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 462 | move || { [INFO] [stdout] 463 | let dir = tempfile::TempDir::new()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 464 | let repo = GitRepository::shallow_clone( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 470 | Ok::<_, BinstallError>(( [INFO] [stdout] | ________________________________________________^ [INFO] [stdout] 471 | | load_manifest_from_workspace(dir.as_ref(), &name) [INFO] [stdout] 472 | | .map_err(BinstallError::from)?, [INFO] [stdout] 473 | | repo.get_head_commit_hash()?, [INFO] [stdout] 474 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ops/resolve/crate_name.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn dedup(mut crate_names: Vec) -> impl Iterator { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | crate_names.sort_by(|x, y| x.name.cmp(&y.name)); [INFO] [stdout] 48 | crate_names.into_iter().coalesce(|previous, current| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ops/resolve/resolution.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn install(self, opts: &Options) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | let crate_name = self.name.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | self.install_inner(opts) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ops/resolve/resolution.rs:57:22 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn install(self, opts: &Options) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | let crate_name = self.name.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | self.install_inner(opts) [INFO] [stdout] 57 | .map_err(|err| err.crate_context(crate_name)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ops/resolve/resolution.rs:84:12 [INFO] [stdout] | [INFO] [stdout] 60 | fn install_inner(self, opts: &Options) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | Ok(CrateInfo { [INFO] [stdout] | ____________^ [INFO] [stdout] 85 | | name: self.name, [INFO] [stdout] 86 | | version_req: self.version_req, [INFO] [stdout] 87 | | current_version: self.new_version, [INFO] [stdout] ... | [INFO] [stdout] 94 | | .collect(), [INFO] [stdout] 95 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 26 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `binstalk` (lib test) due to 27 previous errors [INFO] running `Command { std: "docker" "inspect" "e65d424d95a2f09d361ec65f3d9f55687e141c5e8795818f776554a67b164f3b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e65d424d95a2f09d361ec65f3d9f55687e141c5e8795818f776554a67b164f3b", kill_on_drop: false }` [INFO] [stdout] e65d424d95a2f09d361ec65f3d9f55687e141c5e8795818f776554a67b164f3b