[INFO] fetching crate binhoc 0.1.23... [INFO] checking binhoc-0.1.23 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate binhoc 0.1.23 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate binhoc 0.1.23 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate binhoc 0.1.23 [INFO] finished tweaking crates.io crate binhoc 0.1.23 [INFO] tweaked toml for crates.io crate binhoc 0.1.23 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 50 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding axum-core v0.3.4 (latest: v0.4.3) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding http v0.2.12 (latest: v1.1.0) [INFO] [stderr] Adding http-body v0.4.6 (latest: v1.0.1) [INFO] [stderr] Adding hyper v0.14.30 (latest: v1.4.1) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding virtue v0.0.13 (latest: v0.0.17) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6d4156e27559be45d401059e74e2c5e09feafe9e1f1985502cfa53a7fe107a2d [INFO] running `Command { std: "docker" "start" "-a" "6d4156e27559be45d401059e74e2c5e09feafe9e1f1985502cfa53a7fe107a2d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6d4156e27559be45d401059e74e2c5e09feafe9e1f1985502cfa53a7fe107a2d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6d4156e27559be45d401059e74e2c5e09feafe9e1f1985502cfa53a7fe107a2d", kill_on_drop: false }` [INFO] [stdout] 6d4156e27559be45d401059e74e2c5e09feafe9e1f1985502cfa53a7fe107a2d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4d5f451b60085ec4994401ac6c25cbd6513174d3893cb38bdd554fd97e8ca54e [INFO] running `Command { std: "docker" "start" "-a" "4d5f451b60085ec4994401ac6c25cbd6513174d3893cb38bdd554fd97e8ca54e", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling virtue v0.0.13 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling bincode_derive v2.0.0-rc.3 [INFO] [stderr] Checking bincode v2.0.0-rc.3 [INFO] [stderr] Checking hyper v0.14.30 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Compiling binhoc_macros v0.2.13 [INFO] [stderr] Checking axum-core v0.3.4 [INFO] [stderr] Checking binhoc v0.1.23 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `BoxError` and `response::IntoResponse` [INFO] [stdout] --> src/lib.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | response::IntoResponse, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 12 | extract::FromRequest, [INFO] [stdout] 13 | BoxError, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `BoxError` and `response::IntoResponse` [INFO] [stdout] --> src/lib.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | response::IntoResponse, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 12 | extract::FromRequest, [INFO] [stdout] 13 | BoxError, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:34:91 [INFO] [stdout] | [INFO] [stdout] 34 | async fn from_request(req: Request, _: &State) -> Result { [INFO] [stdout] | ___________________________------------------______________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | | let (_, body) = req.into_parts(); [INFO] [stdout] 36 | | let body = hyper::body::to_bytes(body) [INFO] [stdout] 37 | | .await [INFO] [stdout] ... | [INFO] [stdout] 43 | | Ok(Self(a)) [INFO] [stdout] 44 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:64:91 [INFO] [stdout] | [INFO] [stdout] 64 | async fn from_request(req: Request, _: &State) -> Result { [INFO] [stdout] | ___________________________------------------______________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | | let (_, body) = req.into_parts(); [INFO] [stdout] 66 | | let body = hyper::body::to_bytes(body) [INFO] [stdout] 67 | | .await [INFO] [stdout] ... | [INFO] [stdout] 73 | | Ok(Self(a, b)) [INFO] [stdout] 74 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:97:91 [INFO] [stdout] | [INFO] [stdout] 97 | async fn from_request(req: Request, _: &State) -> Result { [INFO] [stdout] | ___________________________------------------______________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | | let (_, body) = req.into_parts(); [INFO] [stdout] 99 | | let body = hyper::body::to_bytes(body) [INFO] [stdout] 100 | | .await.map_err(|_|StatusCode::INTERNAL_SERVER_ERROR)?; [INFO] [stdout] ... | [INFO] [stdout] 106 | | [INFO] [stdout] 107 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:130:91 [INFO] [stdout] | [INFO] [stdout] 130 | async fn from_request(req: Request, _: &State) -> Result { [INFO] [stdout] | ___________________________------------------______________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 131 | | let (_, body) = req.into_parts(); [INFO] [stdout] 132 | | let body = hyper::body::to_bytes(body) [INFO] [stdout] 133 | | .await [INFO] [stdout] ... | [INFO] [stdout] 139 | | Ok(Self(a, b,c,d,)) [INFO] [stdout] 140 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:165:91 [INFO] [stdout] | [INFO] [stdout] 165 | async fn from_request(req: Request, _: &State) -> Result { [INFO] [stdout] | ___________________________------------------______________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 166 | | let (_, body) = req.into_parts(); [INFO] [stdout] 167 | | let body = hyper::body::to_bytes(body) [INFO] [stdout] 168 | | .await [INFO] [stdout] ... | [INFO] [stdout] 174 | | Ok(Self(a, b,c,d,e)) [INFO] [stdout] 175 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:202:91 [INFO] [stdout] | [INFO] [stdout] 202 | async fn from_request(req: Request, _: &State) -> Result { [INFO] [stdout] | ___________________________------------------______________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 203 | | let (_, body) = req.into_parts(); [INFO] [stdout] 204 | | let body = hyper::body::to_bytes(body) [INFO] [stdout] 205 | | .await [INFO] [stdout] ... | [INFO] [stdout] 211 | | Ok(Self(a, b,c,d,e,f)) [INFO] [stdout] 212 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `binhoc` (lib) due to 7 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:34:91 [INFO] [stdout] | [INFO] [stdout] 34 | async fn from_request(req: Request, _: &State) -> Result { [INFO] [stdout] | ___________________________------------------______________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | | let (_, body) = req.into_parts(); [INFO] [stdout] 36 | | let body = hyper::body::to_bytes(body) [INFO] [stdout] 37 | | .await [INFO] [stdout] ... | [INFO] [stdout] 43 | | Ok(Self(a)) [INFO] [stdout] 44 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:64:91 [INFO] [stdout] | [INFO] [stdout] 64 | async fn from_request(req: Request, _: &State) -> Result { [INFO] [stdout] | ___________________________------------------______________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | | let (_, body) = req.into_parts(); [INFO] [stdout] 66 | | let body = hyper::body::to_bytes(body) [INFO] [stdout] 67 | | .await [INFO] [stdout] ... | [INFO] [stdout] 73 | | Ok(Self(a, b)) [INFO] [stdout] 74 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:97:91 [INFO] [stdout] | [INFO] [stdout] 97 | async fn from_request(req: Request, _: &State) -> Result { [INFO] [stdout] | ___________________________------------------______________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | | let (_, body) = req.into_parts(); [INFO] [stdout] 99 | | let body = hyper::body::to_bytes(body) [INFO] [stdout] 100 | | .await.map_err(|_|StatusCode::INTERNAL_SERVER_ERROR)?; [INFO] [stdout] ... | [INFO] [stdout] 106 | | [INFO] [stdout] 107 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:130:91 [INFO] [stdout] | [INFO] [stdout] 130 | async fn from_request(req: Request, _: &State) -> Result { [INFO] [stdout] | ___________________________------------------______________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 131 | | let (_, body) = req.into_parts(); [INFO] [stdout] 132 | | let body = hyper::body::to_bytes(body) [INFO] [stdout] 133 | | .await [INFO] [stdout] ... | [INFO] [stdout] 139 | | Ok(Self(a, b,c,d,)) [INFO] [stdout] 140 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:165:91 [INFO] [stdout] | [INFO] [stdout] 165 | async fn from_request(req: Request, _: &State) -> Result { [INFO] [stdout] | ___________________________------------------______________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 166 | | let (_, body) = req.into_parts(); [INFO] [stdout] 167 | | let body = hyper::body::to_bytes(body) [INFO] [stdout] 168 | | .await [INFO] [stdout] ... | [INFO] [stdout] 174 | | Ok(Self(a, b,c,d,e)) [INFO] [stdout] 175 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:202:91 [INFO] [stdout] | [INFO] [stdout] 202 | async fn from_request(req: Request, _: &State) -> Result { [INFO] [stdout] | ___________________________------------------______________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 203 | | let (_, body) = req.into_parts(); [INFO] [stdout] 204 | | let body = hyper::body::to_bytes(body) [INFO] [stdout] 205 | | .await [INFO] [stdout] ... | [INFO] [stdout] 211 | | Ok(Self(a, b,c,d,e,f)) [INFO] [stdout] 212 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `binhoc` (lib test) due to 7 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "4d5f451b60085ec4994401ac6c25cbd6513174d3893cb38bdd554fd97e8ca54e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4d5f451b60085ec4994401ac6c25cbd6513174d3893cb38bdd554fd97e8ca54e", kill_on_drop: false }` [INFO] [stdout] 4d5f451b60085ec4994401ac6c25cbd6513174d3893cb38bdd554fd97e8ca54e