[INFO] fetching crate binary_serde_macros 1.0.24... [INFO] checking binary_serde_macros-1.0.24 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate binary_serde_macros 1.0.24 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate binary_serde_macros 1.0.24 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate binary_serde_macros 1.0.24 [INFO] finished tweaking crates.io crate binary_serde_macros 1.0.24 [INFO] tweaked toml for crates.io crate binary_serde_macros 1.0.24 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 5 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bf38bdc11bd390f4796a1a1591fc2a6419771bd11dca98c08788877faf9348e3 [INFO] running `Command { std: "docker" "start" "-a" "bf38bdc11bd390f4796a1a1591fc2a6419771bd11dca98c08788877faf9348e3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bf38bdc11bd390f4796a1a1591fc2a6419771bd11dca98c08788877faf9348e3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bf38bdc11bd390f4796a1a1591fc2a6419771bd11dca98c08788877faf9348e3", kill_on_drop: false }` [INFO] [stdout] bf38bdc11bd390f4796a1a1591fc2a6419771bd11dca98c08788877faf9348e3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6a35ec0a8324ac72ea52a7a67820215c6c2e5cb047c51eeb757b60a49aafe3ce [INFO] running `Command { std: "docker" "start" "-a" "6a35ec0a8324ac72ea52a7a67820215c6c2e5cb047c51eeb757b60a49aafe3ce", kill_on_drop: false }` [INFO] [stderr] Checking syn v2.0.77 [INFO] [stderr] Checking binary_serde_macros v1.0.24 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:175:9 [INFO] [stdout] | [INFO] [stdout] 174 | fn sum>(iter: I) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 175 | iter.reduce(|a, b| a + b).unwrap_or_else(Self::zero) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bitfield.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 17 | let ident = input.parse::()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | Ok(Self{ [INFO] [stdout] | ____________^ [INFO] [stdout] 23 | | bit_order: input.parse()? [INFO] [stdout] 24 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bitfield.rs:57:67 [INFO] [stdout] | [INFO] [stdout] 57 | ... named_fields.named.iter().map(|field| field.ident.as_ref().cloned().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/simple.rs:113:17 [INFO] [stdout] | [INFO] [stdout] 111 | fields: I, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | ) -> impl Iterator + 'a { [INFO] [stdout] 113 | fields.scan(SerializedSizeExpr::zero(), |prev_fields_size, cur_field| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/simple.rs:120:14 [INFO] [stdout] | [INFO] [stdout] 114 | let cur_field_size = TypeExpr::from_type(&cur_field.ty).serialized_size(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | let new_size = &*prev_fields_size + &cur_field_size; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | let offset = core::mem::replace(prev_fields_size, new_size); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 119 | [INFO] [stdout] 120 | Some(FieldOffsetAndSize { [INFO] [stdout] | ______________^ [INFO] [stdout] 121 | | size: cur_field_size, [INFO] [stdout] 122 | | offset: FieldOffsetExpr(offset.0), [INFO] [stdout] 123 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/simple.rs:137:5 [INFO] [stdout] | [INFO] [stdout] 135 | fields: I, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 136 | ) -> impl Iterator + 'a { [INFO] [stdout] 137 | / fields [INFO] [stdout] 138 | | .enumerate() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `binary_serde_macros` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:175:9 [INFO] [stdout] | [INFO] [stdout] 174 | fn sum>(iter: I) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 175 | iter.reduce(|a, b| a + b).unwrap_or_else(Self::zero) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bitfield.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 17 | let ident = input.parse::()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | Ok(Self{ [INFO] [stdout] | ____________^ [INFO] [stdout] 23 | | bit_order: input.parse()? [INFO] [stdout] 24 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bitfield.rs:57:67 [INFO] [stdout] | [INFO] [stdout] 57 | ... named_fields.named.iter().map(|field| field.ident.as_ref().cloned().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/simple.rs:113:17 [INFO] [stdout] | [INFO] [stdout] 111 | fields: I, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | ) -> impl Iterator + 'a { [INFO] [stdout] 113 | fields.scan(SerializedSizeExpr::zero(), |prev_fields_size, cur_field| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/simple.rs:120:14 [INFO] [stdout] | [INFO] [stdout] 114 | let cur_field_size = TypeExpr::from_type(&cur_field.ty).serialized_size(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | let new_size = &*prev_fields_size + &cur_field_size; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | let offset = core::mem::replace(prev_fields_size, new_size); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 119 | [INFO] [stdout] 120 | Some(FieldOffsetAndSize { [INFO] [stdout] | ______________^ [INFO] [stdout] 121 | | size: cur_field_size, [INFO] [stdout] 122 | | offset: FieldOffsetExpr(offset.0), [INFO] [stdout] 123 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/simple.rs:137:5 [INFO] [stdout] | [INFO] [stdout] 135 | fields: I, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 136 | ) -> impl Iterator + 'a { [INFO] [stdout] 137 | / fields [INFO] [stdout] 138 | | .enumerate() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `binary_serde_macros` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "6a35ec0a8324ac72ea52a7a67820215c6c2e5cb047c51eeb757b60a49aafe3ce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6a35ec0a8324ac72ea52a7a67820215c6c2e5cb047c51eeb757b60a49aafe3ce", kill_on_drop: false }` [INFO] [stdout] 6a35ec0a8324ac72ea52a7a67820215c6c2e5cb047c51eeb757b60a49aafe3ce