[INFO] fetching crate binary-security-check 1.3.1... [INFO] checking binary-security-check-1.3.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate binary-security-check 1.3.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate binary-security-check 1.3.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-6-tc2/source/.cargo/config.toml [INFO] started tweaking crates.io crate binary-security-check 1.3.1 [INFO] finished tweaking crates.io crate binary-security-check 1.3.1 [INFO] tweaked toml for crates.io crate binary-security-check 1.3.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate binary-security-check 1.3.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 46a586f44f5f12ee9538afbd0f6d912be23e01d24387e5f5e84942eb716841d0 [INFO] running `Command { std: "docker" "start" "-a" "46a586f44f5f12ee9538afbd0f6d912be23e01d24387e5f5e84942eb716841d0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "46a586f44f5f12ee9538afbd0f6d912be23e01d24387e5f5e84942eb716841d0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "46a586f44f5f12ee9538afbd0f6d912be23e01d24387e5f5e84942eb716841d0", kill_on_drop: false }` [INFO] [stdout] 46a586f44f5f12ee9538afbd0f6d912be23e01d24387e5f5e84942eb716841d0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d1ce7265a30bd46d5e0a8a959628573d333f4509b96de90298358f99112673d1 [INFO] running `Command { std: "docker" "start" "-a" "d1ce7265a30bd46d5e0a8a959628573d333f4509b96de90298358f99112673d1", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Compiling thiserror v1.0.58 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling memoffset v0.9.0 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking either v1.10.0 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking plain v0.2.3 [INFO] [stderr] Checking nu-ansi-term v0.49.0 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling syn v2.0.53 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking memmap2 v0.9.4 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking chrono v0.4.35 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Compiling thiserror-impl v1.0.58 [INFO] [stderr] Compiling scroll_derive v0.12.0 [INFO] [stderr] Compiling clap_derive v4.5.3 [INFO] [stderr] Checking scroll v0.12.0 [INFO] [stderr] Checking goblin v0.8.0 [INFO] [stderr] Checking dynamic-loader-cache v0.1.1 [INFO] [stderr] Checking flexi_logger v0.28.0 [INFO] [stderr] Checking clap v4.5.3 [INFO] [stderr] Checking binary-security-check v1.3.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/elf/needed_libc.rs:31:52 [INFO] [stdout] | [INFO] [stdout] 31 | let r = LIBC_RESOLVER.get_or_init(|| match Self::new(options) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/elf/needed_libc.rs:59:12 [INFO] [stdout] | [INFO] [stdout] 51 | let ld_so_cache = if options.sysroot.is_none() { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 60 | | sys_root: sys_root.into(), [INFO] [stdout] 61 | | ld_so_cache, [INFO] [stdout] 62 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/elf/needed_libc.rs:69:34 [INFO] [stdout] | [INFO] [stdout] 69 | .filter(|needed_lib| KNOWN_LIBC_PATTERN.is_match(needed_lib)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/elf/needed_libc.rs:108:36 [INFO] [stdout] | [INFO] [stdout] 108 | .unwrap_or_else(|| Err(Error::NotFoundNeededLibC(file_name.into()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/options.rs:303:12 [INFO] [stdout] | [INFO] [stdout] 303 | Ok(Box::new(r)) [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui.rs:27:28 [INFO] [stdout] | [INFO] [stdout] 23 | let buffer_writer = termcolor::BufferWriter::stdout(use_color.into()); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | buffer_writer: Arc::new(buffer_writer), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `binary-security-check` (bin "binary-security-check" test) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/elf/needed_libc.rs:31:52 [INFO] [stdout] | [INFO] [stdout] 31 | let r = LIBC_RESOLVER.get_or_init(|| match Self::new(options) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/elf/needed_libc.rs:59:12 [INFO] [stdout] | [INFO] [stdout] 51 | let ld_so_cache = if options.sysroot.is_none() { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 60 | | sys_root: sys_root.into(), [INFO] [stdout] 61 | | ld_so_cache, [INFO] [stdout] 62 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/elf/needed_libc.rs:69:34 [INFO] [stdout] | [INFO] [stdout] 69 | .filter(|needed_lib| KNOWN_LIBC_PATTERN.is_match(needed_lib)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/elf/needed_libc.rs:108:36 [INFO] [stdout] | [INFO] [stdout] 108 | .unwrap_or_else(|| Err(Error::NotFoundNeededLibC(file_name.into()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/options.rs:303:12 [INFO] [stdout] | [INFO] [stdout] 303 | Ok(Box::new(r)) [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui.rs:27:28 [INFO] [stdout] | [INFO] [stdout] 23 | let buffer_writer = termcolor::BufferWriter::stdout(use_color.into()); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | buffer_writer: Arc::new(buffer_writer), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `binary-security-check` (bin "binary-security-check") due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "d1ce7265a30bd46d5e0a8a959628573d333f4509b96de90298358f99112673d1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d1ce7265a30bd46d5e0a8a959628573d333f4509b96de90298358f99112673d1", kill_on_drop: false }` [INFO] [stdout] d1ce7265a30bd46d5e0a8a959628573d333f4509b96de90298358f99112673d1