[INFO] fetching crate binartree 2.0.2... [INFO] checking binartree-2.0.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate binartree 2.0.2 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate binartree 2.0.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate binartree 2.0.2 [INFO] finished tweaking crates.io crate binartree 2.0.2 [INFO] tweaked toml for crates.io crate binartree 2.0.2 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fec2c4a996cd655b6fdf7d8b768ff15a38fe027ee4e20194dbfbb820dd0c0e46 [INFO] running `Command { std: "docker" "start" "-a" "fec2c4a996cd655b6fdf7d8b768ff15a38fe027ee4e20194dbfbb820dd0c0e46", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fec2c4a996cd655b6fdf7d8b768ff15a38fe027ee4e20194dbfbb820dd0c0e46", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fec2c4a996cd655b6fdf7d8b768ff15a38fe027ee4e20194dbfbb820dd0c0e46", kill_on_drop: false }` [INFO] [stdout] fec2c4a996cd655b6fdf7d8b768ff15a38fe027ee4e20194dbfbb820dd0c0e46 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f40e3ac53cb16075d34dbcbc29968ea9b4b44d5a59ab371d9faa321b9c2b13c9 [INFO] running `Command { std: "docker" "start" "-a" "f40e3ac53cb16075d34dbcbc29968ea9b4b44d5a59ab371d9faa321b9c2b13c9", kill_on_drop: false }` [INFO] [stderr] Checking binartree v2.0.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: calls to `std::mem::drop` with a value that implements `Copy` does nothing [INFO] [stdout] --> src/node.rs:206:5 [INFO] [stdout] | [INFO] [stdout] 206 | mem::drop(branch.key); [INFO] [stdout] | ^^^^^^^^^^----------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `T` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_copy_types)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 206 - mem::drop(branch.key); [INFO] [stdout] 206 + let _ = branch.key; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a value that implements `Copy` does nothing [INFO] [stdout] --> src/node.rs:206:5 [INFO] [stdout] | [INFO] [stdout] 206 | mem::drop(branch.key); [INFO] [stdout] | ^^^^^^^^^^----------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `T` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_copy_types)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 206 - mem::drop(branch.key); [INFO] [stdout] 206 + let _ = branch.key; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests.rs:18:25 [INFO] [stdout] | [INFO] [stdout] 17 | let test_node = Node::::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | assert_eq!(test_node, Node::Empty) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests.rs:674:4 [INFO] [stdout] | [INFO] [stdout] 671 | let test_tree:BinaryTree = BinaryTree::default(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 674 | / BinaryTree { [INFO] [stdout] 675 | | top: Node::Empty, [INFO] [stdout] 676 | | size: 0, [INFO] [stdout] 677 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `binartree` (lib test) due to 3 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "f40e3ac53cb16075d34dbcbc29968ea9b4b44d5a59ab371d9faa321b9c2b13c9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f40e3ac53cb16075d34dbcbc29968ea9b4b44d5a59ab371d9faa321b9c2b13c9", kill_on_drop: false }` [INFO] [stdout] f40e3ac53cb16075d34dbcbc29968ea9b4b44d5a59ab371d9faa321b9c2b13c9