[INFO] fetching crate bin-utils 0.2.5... [INFO] checking bin-utils-0.2.5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate bin-utils 0.2.5 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate bin-utils 0.2.5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate bin-utils 0.2.5 [INFO] finished tweaking crates.io crate bin-utils 0.2.5 [INFO] tweaked toml for crates.io crate bin-utils 0.2.5 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 14 packages to latest compatible versions [INFO] [stderr] Adding hash32 v0.2.1 (latest: v0.3.1) [INFO] [stderr] Adding heapless v0.7.17 (latest: v0.8.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] eb8f815f3dae62feae24e00f447af3f934e75b69fed23d73191d4d9a8caf2ae4 [INFO] running `Command { std: "docker" "start" "-a" "eb8f815f3dae62feae24e00f447af3f934e75b69fed23d73191d4d9a8caf2ae4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "eb8f815f3dae62feae24e00f447af3f934e75b69fed23d73191d4d9a8caf2ae4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "eb8f815f3dae62feae24e00f447af3f934e75b69fed23d73191d4d9a8caf2ae4", kill_on_drop: false }` [INFO] [stdout] eb8f815f3dae62feae24e00f447af3f934e75b69fed23d73191d4d9a8caf2ae4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 09885e8d5ac7953d019a4bd77d84363e84d2714f6a5fa65e43a94814477d95f5 [INFO] running `Command { std: "docker" "start" "-a" "09885e8d5ac7953d019a4bd77d84363e84d2714f6a5fa65e43a94814477d95f5", kill_on_drop: false }` [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Checking hash32 v0.2.1 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking try_take v0.1.0 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Compiling heapless v0.7.17 [INFO] [stderr] Checking bin-utils v0.2.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `numeric_rw::*` [INFO] [stdout] --> src/lib.rs:316:9 [INFO] [stdout] | [INFO] [stdout] 316 | pub use numeric_rw::*; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `numeric_rw::*` [INFO] [stdout] --> src/lib.rs:316:9 [INFO] [stdout] | [INFO] [stdout] 316 | pub use numeric_rw::*; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:114:32 [INFO] [stdout] | [INFO] [stdout] 114 | ... Ok((0..).map_while(|_| T::from_bytes(data).ok()).collect()) // Create an infinte iterator, map until from_bytes returns an Error an... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bin-utils` (lib) due to 5 previous errors; 1 warning emitted [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:128:12 [INFO] [stdout] | [INFO] [stdout] 126 | ctx: Ctx, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | ) -> Result { [INFO] [stdout] 128 | Ok((0..) [INFO] [stdout] | ____________^ [INFO] [stdout] 129 | | .map_while(|_| T::from_bytes(data, ctx.clone()).ok()) [INFO] [stdout] 130 | | .collect()) // Create an infinte iterator, map until from_bytes returns an Error and collect. [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:129:28 [INFO] [stdout] | [INFO] [stdout] 129 | .map_while(|_| T::from_bytes(data, ctx.clone()).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:149:45 [INFO] [stdout] | [INFO] [stdout] 149 | self.iter().flat_map(|x| x.to_bytes(ctx.clone())).collect() [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:114:32 [INFO] [stdout] | [INFO] [stdout] 114 | ... Ok((0..).map_while(|_| T::from_bytes(data).ok()).collect()) // Create an infinte iterator, map until from_bytes returns an Error an... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:128:12 [INFO] [stdout] | [INFO] [stdout] 126 | ctx: Ctx, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | ) -> Result { [INFO] [stdout] 128 | Ok((0..) [INFO] [stdout] | ____________^ [INFO] [stdout] 129 | | .map_while(|_| T::from_bytes(data, ctx.clone()).ok()) [INFO] [stdout] 130 | | .collect()) // Create an infinte iterator, map until from_bytes returns an Error and collect. [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:129:28 [INFO] [stdout] | [INFO] [stdout] 129 | .map_while(|_| T::from_bytes(data, ctx.clone()).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:149:45 [INFO] [stdout] | [INFO] [stdout] 149 | self.iter().flat_map(|x| x.to_bytes(ctx.clone())).collect() [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bin-utils` (lib test) due to 5 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "09885e8d5ac7953d019a4bd77d84363e84d2714f6a5fa65e43a94814477d95f5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "09885e8d5ac7953d019a4bd77d84363e84d2714f6a5fa65e43a94814477d95f5", kill_on_drop: false }` [INFO] [stdout] 09885e8d5ac7953d019a4bd77d84363e84d2714f6a5fa65e43a94814477d95f5