[INFO] fetching crate bigbro 0.5.2... [INFO] checking bigbro-0.5.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate bigbro 0.5.2 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate bigbro 0.5.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-6-tc2/source/.cargo/config [INFO] started tweaking crates.io crate bigbro 0.5.2 [INFO] finished tweaking crates.io crate bigbro 0.5.2 [INFO] tweaked toml for crates.io crate bigbro 0.5.2 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 19 packages to latest compatible versions [INFO] [stderr] Adding backtrace v0.2.3 (latest: v0.3.73) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding cpuprofiler v0.0.3 (latest: v0.0.4) [INFO] [stderr] Adding error-chain v0.5.0 (latest: v0.12.4) [INFO] [stderr] Adding lazy_static v0.2.11 (latest: v1.5.0) [INFO] [stderr] Adding winapi v0.2.8 (latest: v0.3.9) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 26ca79bd8f41a6f974f303dbda6f63445b2ab432137c388919db6f5872e9192c [INFO] running `Command { std: "docker" "start" "-a" "26ca79bd8f41a6f974f303dbda6f63445b2ab432137c388919db6f5872e9192c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "26ca79bd8f41a6f974f303dbda6f63445b2ab432137c388919db6f5872e9192c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "26ca79bd8f41a6f974f303dbda6f63445b2ab432137c388919db6f5872e9192c", kill_on_drop: false }` [INFO] [stdout] 26ca79bd8f41a6f974f303dbda6f63445b2ab432137c388919db6f5872e9192c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7020d6a54a949fbcec6e5f1161bb2ee1d225d6687ffd4fb514026a054b996547 [INFO] running `Command { std: "docker" "start" "-a" "7020d6a54a949fbcec6e5f1161bb2ee1d225d6687ffd4fb514026a054b996547", kill_on_drop: false }` [INFO] [stderr] Compiling gcc v0.3.55 [INFO] [stderr] Compiling seccomp-droundy-sys v0.1.2 [INFO] [stderr] Checking seccomp-droundy v0.1.0 [INFO] [stderr] Checking bigbro v0.5.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:622:60 [INFO] [stdout] | [INFO] [stdout] 622 | pub fn stdout(&mut self) -> std::io::Result>> { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 622 | pub fn stdout(&mut self) -> std::io::Result>> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/linux.rs:144:60 [INFO] [stdout] | [INFO] [stdout] 144 | pub fn stdout(&mut self) -> std::io::Result>> { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 144 | pub fn stdout(&mut self) -> std::io::Result>> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:622:60 [INFO] [stdout] | [INFO] [stdout] 622 | pub fn stdout(&mut self) -> std::io::Result>> { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 622 | pub fn stdout(&mut self) -> std::io::Result>> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/linux.rs:144:60 [INFO] [stdout] | [INFO] [stdout] 144 | pub fn stdout(&mut self) -> std::io::Result>> { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 144 | pub fn stdout(&mut self) -> std::io::Result>> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:117:27 [INFO] [stdout] | [INFO] [stdout] 114 | pub fn new>(program: S) -> Command { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | envs_removed: std::collections::HashSet::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:120:20 [INFO] [stdout] | [INFO] [stdout] 114 | pub fn new>(program: S) -> Command { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | inner: imp::Command::new(program), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linux.rs:926:25 [INFO] [stdout] | [INFO] [stdout] 918 | pub fn new>(program: S) -> Command { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 926 | have_error: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linux.rs:1174:12 [INFO] [stdout] | [INFO] [stdout] 1091 | pub fn spawn(mut self, envs_cleared: bool, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1092 | envs_removed: std::collections::HashSet, [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1098 | let have_completed = std::sync::Arc::new(std::sync::atomic::AtomicBool::new(false)); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1099 | let have_completed_two = have_completed.clone(); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1100 | let (tx, rx) = std::sync::mpsc::channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1101 | let status_thread = Some(std::thread::spawn(move || { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1174 | Ok(Child { [INFO] [stdout] | ____________^ [INFO] [stdout] 1175 | | pid: pid, [INFO] [stdout] 1176 | | have_completed: have_completed, [INFO] [stdout] 1177 | | status_thread: status_thread, [INFO] [stdout] 1178 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bigbro` (lib) due to 5 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:117:27 [INFO] [stdout] | [INFO] [stdout] 114 | pub fn new>(program: S) -> Command { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | envs_removed: std::collections::HashSet::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:120:20 [INFO] [stdout] | [INFO] [stdout] 114 | pub fn new>(program: S) -> Command { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | inner: imp::Command::new(program), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linux.rs:926:25 [INFO] [stdout] | [INFO] [stdout] 918 | pub fn new>(program: S) -> Command { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 926 | have_error: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linux.rs:1174:12 [INFO] [stdout] | [INFO] [stdout] 1091 | pub fn spawn(mut self, envs_cleared: bool, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1092 | envs_removed: std::collections::HashSet, [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1098 | let have_completed = std::sync::Arc::new(std::sync::atomic::AtomicBool::new(false)); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1099 | let have_completed_two = have_completed.clone(); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1100 | let (tx, rx) = std::sync::mpsc::channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1101 | let status_thread = Some(std::thread::spawn(move || { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1174 | Ok(Child { [INFO] [stdout] | ____________^ [INFO] [stdout] 1175 | | pid: pid, [INFO] [stdout] 1176 | | have_completed: have_completed, [INFO] [stdout] 1177 | | status_thread: status_thread, [INFO] [stdout] 1178 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bigbro` (lib test) due to 5 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "7020d6a54a949fbcec6e5f1161bb2ee1d225d6687ffd4fb514026a054b996547", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7020d6a54a949fbcec6e5f1161bb2ee1d225d6687ffd4fb514026a054b996547", kill_on_drop: false }` [INFO] [stdout] 7020d6a54a949fbcec6e5f1161bb2ee1d225d6687ffd4fb514026a054b996547