[INFO] fetching crate bifrostlink 0.1.0... [INFO] checking bifrostlink-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate bifrostlink 0.1.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate bifrostlink 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate bifrostlink 0.1.0 [INFO] finished tweaking crates.io crate bifrostlink 0.1.0 [INFO] tweaked toml for crates.io crate bifrostlink 0.1.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 61 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ebd777a1687f639994dd6bdf8d141b9ec8a6f65a4484c3896bf35c43922f030e [INFO] running `Command { std: "docker" "start" "-a" "ebd777a1687f639994dd6bdf8d141b9ec8a6f65a4484c3896bf35c43922f030e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ebd777a1687f639994dd6bdf8d141b9ec8a6f65a4484c3896bf35c43922f030e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ebd777a1687f639994dd6bdf8d141b9ec8a6f65a4484c3896bf35c43922f030e", kill_on_drop: false }` [INFO] [stdout] ebd777a1687f639994dd6bdf8d141b9ec8a6f65a4484c3896bf35c43922f030e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e644d759ccea53e980651589054527071c377278d37f57f0b67993533f43dbae [INFO] running `Command { std: "docker" "start" "-a" "e644d759ccea53e980651589054527071c377278d37f57f0b67993533f43dbae", kill_on_drop: false }` [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking bifrostlink v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `added_via` is never read [INFO] [stdout] --> src/route.rs:50:6 [INFO] [stdout] | [INFO] [stdout] 47 | pub struct ViaListSeconded
{ [INFO] [stdout] | --------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 50 | pub added_via: Via
, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ViaListSeconded` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `forwarded` is never used [INFO] [stdout] --> src/route.rs:151:5 [INFO] [stdout] | [INFO] [stdout] 133 | / impl
InverseRouteSet
[INFO] [stdout] 134 | | where [INFO] [stdout] 135 | | Address: AddressT, [INFO] [stdout] | |______________________- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 151 | fn forwarded(&self, via: Via
) -> Option + '_> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `update` is never used [INFO] [stdout] --> src/route.rs:266:9 [INFO] [stdout] | [INFO] [stdout] 163 | / impl
RouteSet
[INFO] [stdout] 164 | | where [INFO] [stdout] 165 | | Address: AddressT, [INFO] [stdout] | |______________________- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 266 | pub fn update(&mut self, address: Address, via: Via
, rtt: Rtt) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/route.rs:169:12 [INFO] [stdout] | [INFO] [stdout] 167 | pub fn new(tx: Sender>) -> Self { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 168 | Self { [INFO] [stdout] 169 | routes: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/route.rs:170:13 [INFO] [stdout] | [INFO] [stdout] 167 | pub fn new(tx: Sender>) -> Self { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 170 | inverse: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/route.rs:284:19 [INFO] [stdout] | [INFO] [stdout] 284 | .map(|(a, d)| (a.clone(), d.min_rtt.clone())) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/route.rs:284:30 [INFO] [stdout] | [INFO] [stdout] 284 | .map(|(a, d)| (a.clone(), d.min_rtt.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packet.rs:27:8 [INFO] [stdout] | [INFO] [stdout] 17 | fn new(wrapper: PacketWrapper) -> Self { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | let bytes = BytesMut::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | let mut writer = bytes.writer(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | serde_json::to_writer(&mut writer, &wrapper).expect("serialization should not fail"); [INFO] [stdout] 25 | let bytes = writer.into_inner(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | Self { [INFO] [stdout] 27 | to: to.clone(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packet.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 17 | fn new(wrapper: PacketWrapper) -> Self { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | let bytes = BytesMut::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | let mut writer = bytes.writer(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | serde_json::to_writer(&mut writer, &wrapper).expect("serialization should not fail"); [INFO] [stdout] 25 | let bytes = writer.into_inner(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | message: bytes.freeze(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packet.rs:36:13 [INFO] [stdout] | [INFO] [stdout] 32 | sender: Address, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | receiver: Address, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | Self::new(PacketWrapper::Request { [INFO] [stdout] | ___________________^ [INFO] [stdout] 37 | | sender, [INFO] [stdout] 38 | | receiver, [INFO] [stdout] 39 | | request: T::name().to_owned(), [INFO] [stdout] 40 | | response: None, [INFO] [stdout] 41 | | data, [INFO] [stdout] 42 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packet.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 45 | sender: Address, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | receiver: Address, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | Self::new(PacketWrapper::Request { [INFO] [stdout] | ___________________^ [INFO] [stdout] 54 | | sender, [INFO] [stdout] 55 | | receiver, [INFO] [stdout] 56 | | request: T::name().to_owned(), [INFO] [stdout] 57 | | response: Some(ResponseTo { rid: id.to_owned() }), [INFO] [stdout] 58 | | data, [INFO] [stdout] 59 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packet.rs:62:13 [INFO] [stdout] | [INFO] [stdout] 61 | pub fn new_error_response(rid: &str, receiver: Address, error: E) -> Self { [INFO] [stdout] | ----------------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | Self::new(PacketWrapper::Response { [INFO] [stdout] | ___________________^ [INFO] [stdout] 63 | | rid: rid.to_owned(), [INFO] [stdout] 64 | | request_origin: receiver, [INFO] [stdout] 65 | | error: Some(error.to_string()), [INFO] [stdout] 66 | | data: (), [INFO] [stdout] 67 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packet.rs:70:13 [INFO] [stdout] | [INFO] [stdout] 69 | pub fn new_response(rid: &str, receiver: Address, data: &T) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | Self::new(PacketWrapper::Response { [INFO] [stdout] | ___________________^ [INFO] [stdout] 71 | | rid: rid.to_owned(), [INFO] [stdout] 72 | | request_origin: receiver, [INFO] [stdout] 73 | | error: None, [INFO] [stdout] 74 | | data, [INFO] [stdout] 75 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/internal_handlers.rs:50:8 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn update_for(&self, address: Address) -> Option> { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | Some(UpdatedForwardedRtt { [INFO] [stdout] | ______________^ [INFO] [stdout] 51 | | to: self.for_address.clone(), [INFO] [stdout] 52 | | rtt, [INFO] [stdout] 53 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polling/notification.rs:32:6 [INFO] [stdout] | [INFO] [stdout] 26 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | ) -> Result, serde_json::Error> { [INFO] [stdout] 28 | let request = match serde_json::from_slice(&self.request) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | Ok(v) => v, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | Err(e) => return Err(e), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | }; [INFO] [stdout] 32 | Ok(PollingNotification { [INFO] [stdout] | ____________^ [INFO] [stdout] 33 | | from: self.from, [INFO] [stdout] 34 | | request, [INFO] [stdout] 35 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polling/request.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 29 | fn respond_raw(&mut self, out: OutgoingMessage
) { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | match self.respond.take().expect("didn't responded yet").send(out) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polling/request.rs:43:20 [INFO] [stdout] | [INFO] [stdout] 42 | pub(crate) fn respond_ok(mut self, response: R) { [INFO] [stdout] | -------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | self.respond_raw(OutgoingMessage::new_response( [INFO] [stdout] | __________________________^ [INFO] [stdout] 44 | | &self.id, [INFO] [stdout] 45 | | self.from.clone(), [INFO] [stdout] 46 | | &response, [INFO] [stdout] 47 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polling/request.rs:50:20 [INFO] [stdout] | [INFO] [stdout] 49 | pub(crate) fn respond_err(mut self, response: E) { [INFO] [stdout] | -------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | self.respond_raw(OutgoingMessage::new_error_response( [INFO] [stdout] | __________________________^ [INFO] [stdout] 51 | | &self.id, [INFO] [stdout] 52 | | self.from.clone(), [INFO] [stdout] 53 | | response, [INFO] [stdout] 54 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polling/request.rs:75:6 [INFO] [stdout] | [INFO] [stdout] 65 | mut self, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | let raw = self.request.take().expect("not yet converted"); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | let request = match serde_json::from_slice(&raw) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | Ok(v) => v, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | Err(e) => return Err((e, self)), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | }; [INFO] [stdout] 75 | Ok(PollingRequest { [INFO] [stdout] | ____________^ [INFO] [stdout] 76 | | opaque: self, [INFO] [stdout] 77 | | request, [INFO] [stdout] 78 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polling/request.rs:217:8 [INFO] [stdout] | [INFO] [stdout] 183 | let mut inner = self.inner.write().expect("write"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 184 | [INFO] [stdout] 185 | let (otx, mut orx) = unbounded_channel(); [INFO] [stdout] | --- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 190 | let (tx, rx) = unbounded_channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 217 | Some(PollingRequestStream { [INFO] [stdout] | ______________^ [INFO] [stdout] 218 | | rpc: self.clone().downgrade(), [INFO] [stdout] 219 | | channel: rx, [INFO] [stdout] 220 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc.rs:85:34 [INFO] [stdout] | [INFO] [stdout] 81 | packet_source: Address, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | request: Bytes, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | rid: &str, [INFO] [stdout] 84 | respond_to: Address, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | ) -> OutgoingMessage
{ [INFO] [stdout] | ___________________________________________^ [INFO] [stdout] 86 | | let request: R = match serde_json::from_slice(&request) { [INFO] [stdout] 87 | | Ok(v) => v, [INFO] [stdout] 88 | | Err(e) => { [INFO] [stdout] ... | [INFO] [stdout] 103 | | } [INFO] [stdout] 104 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc.rs:141:67 [INFO] [stdout] | [INFO] [stdout] 141 | async fn handle(&self, packet_source: Address, request: Bytes) { [INFO] [stdout] | ____________________________________----------------------__--------------__^ [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | | let request: R = match serde_json::from_slice(&request) { [INFO] [stdout] 143 | | Ok(v) => v, [INFO] [stdout] 144 | | Err(e) => { [INFO] [stdout] ... | [INFO] [stdout] 155 | | } [INFO] [stdout] 156 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc.rs:227:3 [INFO] [stdout] | [INFO] [stdout] 226 | fn respond_with_error(&mut self, rid: &str, to: Address, error: &str) { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 227 | / self.tx [INFO] [stdout] 228 | | .send(OutgoingMessage::new_error_response(rid, to, error).into()) [INFO] [stdout] | |_____________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc.rs:468:8 [INFO] [stdout] | [INFO] [stdout] 467 | pub fn upgrade(self) -> Option> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 468 | Some(Rpc { [INFO] [stdout] | ______________^ [INFO] [stdout] 469 | | inner: self.inner.upgrade()?, [INFO] [stdout] 470 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc.rs:487:11 [INFO] [stdout] | [INFO] [stdout] 485 | pub fn downgrade(self) -> WeakRpc { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 486 | WeakRpc { [INFO] [stdout] 487 | inner: Arc::downgrade(&self.inner), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 22 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `added_via` is never read [INFO] [stdout] --> src/route.rs:50:6 [INFO] [stdout] | [INFO] [stdout] 47 | pub struct ViaListSeconded
{ [INFO] [stdout] | --------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 50 | pub added_via: Via
, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ViaListSeconded` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `forwarded` is never used [INFO] [stdout] --> src/route.rs:151:5 [INFO] [stdout] | [INFO] [stdout] 133 | / impl
InverseRouteSet
[INFO] [stdout] 134 | | where [INFO] [stdout] 135 | | Address: AddressT, [INFO] [stdout] | |______________________- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 151 | fn forwarded(&self, via: Via
) -> Option + '_> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `update` is never used [INFO] [stdout] --> src/route.rs:266:9 [INFO] [stdout] | [INFO] [stdout] 163 | / impl
RouteSet
[INFO] [stdout] 164 | | where [INFO] [stdout] 165 | | Address: AddressT, [INFO] [stdout] | |______________________- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 266 | pub fn update(&mut self, address: Address, via: Via
, rtt: Rtt) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/route.rs:169:12 [INFO] [stdout] | [INFO] [stdout] 167 | pub fn new(tx: Sender>) -> Self { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 168 | Self { [INFO] [stdout] 169 | routes: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bifrostlink` (lib test) due to 23 previous errors; 3 warnings emitted [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/route.rs:170:13 [INFO] [stdout] | [INFO] [stdout] 167 | pub fn new(tx: Sender>) -> Self { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 170 | inverse: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/route.rs:284:19 [INFO] [stdout] | [INFO] [stdout] 284 | .map(|(a, d)| (a.clone(), d.min_rtt.clone())) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/route.rs:284:30 [INFO] [stdout] | [INFO] [stdout] 284 | .map(|(a, d)| (a.clone(), d.min_rtt.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packet.rs:27:8 [INFO] [stdout] | [INFO] [stdout] 17 | fn new(wrapper: PacketWrapper) -> Self { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | let bytes = BytesMut::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | let mut writer = bytes.writer(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | serde_json::to_writer(&mut writer, &wrapper).expect("serialization should not fail"); [INFO] [stdout] 25 | let bytes = writer.into_inner(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | Self { [INFO] [stdout] 27 | to: to.clone(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packet.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 17 | fn new(wrapper: PacketWrapper) -> Self { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | let bytes = BytesMut::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | let mut writer = bytes.writer(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | serde_json::to_writer(&mut writer, &wrapper).expect("serialization should not fail"); [INFO] [stdout] 25 | let bytes = writer.into_inner(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | message: bytes.freeze(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packet.rs:36:13 [INFO] [stdout] | [INFO] [stdout] 32 | sender: Address, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | receiver: Address, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | Self::new(PacketWrapper::Request { [INFO] [stdout] | ___________________^ [INFO] [stdout] 37 | | sender, [INFO] [stdout] 38 | | receiver, [INFO] [stdout] 39 | | request: T::name().to_owned(), [INFO] [stdout] 40 | | response: None, [INFO] [stdout] 41 | | data, [INFO] [stdout] 42 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packet.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 45 | sender: Address, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | receiver: Address, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | Self::new(PacketWrapper::Request { [INFO] [stdout] | ___________________^ [INFO] [stdout] 54 | | sender, [INFO] [stdout] 55 | | receiver, [INFO] [stdout] 56 | | request: T::name().to_owned(), [INFO] [stdout] 57 | | response: Some(ResponseTo { rid: id.to_owned() }), [INFO] [stdout] 58 | | data, [INFO] [stdout] 59 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packet.rs:62:13 [INFO] [stdout] | [INFO] [stdout] 61 | pub fn new_error_response(rid: &str, receiver: Address, error: E) -> Self { [INFO] [stdout] | ----------------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | Self::new(PacketWrapper::Response { [INFO] [stdout] | ___________________^ [INFO] [stdout] 63 | | rid: rid.to_owned(), [INFO] [stdout] 64 | | request_origin: receiver, [INFO] [stdout] 65 | | error: Some(error.to_string()), [INFO] [stdout] 66 | | data: (), [INFO] [stdout] 67 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packet.rs:70:13 [INFO] [stdout] | [INFO] [stdout] 69 | pub fn new_response(rid: &str, receiver: Address, data: &T) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | Self::new(PacketWrapper::Response { [INFO] [stdout] | ___________________^ [INFO] [stdout] 71 | | rid: rid.to_owned(), [INFO] [stdout] 72 | | request_origin: receiver, [INFO] [stdout] 73 | | error: None, [INFO] [stdout] 74 | | data, [INFO] [stdout] 75 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/internal_handlers.rs:50:8 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn update_for(&self, address: Address) -> Option> { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | Some(UpdatedForwardedRtt { [INFO] [stdout] | ______________^ [INFO] [stdout] 51 | | to: self.for_address.clone(), [INFO] [stdout] 52 | | rtt, [INFO] [stdout] 53 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polling/notification.rs:32:6 [INFO] [stdout] | [INFO] [stdout] 26 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | ) -> Result, serde_json::Error> { [INFO] [stdout] 28 | let request = match serde_json::from_slice(&self.request) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | Ok(v) => v, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | Err(e) => return Err(e), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | }; [INFO] [stdout] 32 | Ok(PollingNotification { [INFO] [stdout] | ____________^ [INFO] [stdout] 33 | | from: self.from, [INFO] [stdout] 34 | | request, [INFO] [stdout] 35 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polling/request.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 29 | fn respond_raw(&mut self, out: OutgoingMessage
) { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | match self.respond.take().expect("didn't responded yet").send(out) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polling/request.rs:43:20 [INFO] [stdout] | [INFO] [stdout] 42 | pub(crate) fn respond_ok(mut self, response: R) { [INFO] [stdout] | -------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | self.respond_raw(OutgoingMessage::new_response( [INFO] [stdout] | __________________________^ [INFO] [stdout] 44 | | &self.id, [INFO] [stdout] 45 | | self.from.clone(), [INFO] [stdout] 46 | | &response, [INFO] [stdout] 47 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polling/request.rs:50:20 [INFO] [stdout] | [INFO] [stdout] 49 | pub(crate) fn respond_err(mut self, response: E) { [INFO] [stdout] | -------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | self.respond_raw(OutgoingMessage::new_error_response( [INFO] [stdout] | __________________________^ [INFO] [stdout] 51 | | &self.id, [INFO] [stdout] 52 | | self.from.clone(), [INFO] [stdout] 53 | | response, [INFO] [stdout] 54 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polling/request.rs:75:6 [INFO] [stdout] | [INFO] [stdout] 65 | mut self, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | let raw = self.request.take().expect("not yet converted"); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | let request = match serde_json::from_slice(&raw) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | Ok(v) => v, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | Err(e) => return Err((e, self)), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | }; [INFO] [stdout] 75 | Ok(PollingRequest { [INFO] [stdout] | ____________^ [INFO] [stdout] 76 | | opaque: self, [INFO] [stdout] 77 | | request, [INFO] [stdout] 78 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polling/request.rs:217:8 [INFO] [stdout] | [INFO] [stdout] 183 | let mut inner = self.inner.write().expect("write"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 184 | [INFO] [stdout] 185 | let (otx, mut orx) = unbounded_channel(); [INFO] [stdout] | --- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 190 | let (tx, rx) = unbounded_channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 217 | Some(PollingRequestStream { [INFO] [stdout] | ______________^ [INFO] [stdout] 218 | | rpc: self.clone().downgrade(), [INFO] [stdout] 219 | | channel: rx, [INFO] [stdout] 220 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc.rs:85:34 [INFO] [stdout] | [INFO] [stdout] 81 | packet_source: Address, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | request: Bytes, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | rid: &str, [INFO] [stdout] 84 | respond_to: Address, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | ) -> OutgoingMessage
{ [INFO] [stdout] | ___________________________________________^ [INFO] [stdout] 86 | | let request: R = match serde_json::from_slice(&request) { [INFO] [stdout] 87 | | Ok(v) => v, [INFO] [stdout] 88 | | Err(e) => { [INFO] [stdout] ... | [INFO] [stdout] 103 | | } [INFO] [stdout] 104 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc.rs:141:67 [INFO] [stdout] | [INFO] [stdout] 141 | async fn handle(&self, packet_source: Address, request: Bytes) { [INFO] [stdout] | ____________________________________----------------------__--------------__^ [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | | let request: R = match serde_json::from_slice(&request) { [INFO] [stdout] 143 | | Ok(v) => v, [INFO] [stdout] 144 | | Err(e) => { [INFO] [stdout] ... | [INFO] [stdout] 155 | | } [INFO] [stdout] 156 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc.rs:227:3 [INFO] [stdout] | [INFO] [stdout] 226 | fn respond_with_error(&mut self, rid: &str, to: Address, error: &str) { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 227 | / self.tx [INFO] [stdout] 228 | | .send(OutgoingMessage::new_error_response(rid, to, error).into()) [INFO] [stdout] | |_____________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc.rs:468:8 [INFO] [stdout] | [INFO] [stdout] 467 | pub fn upgrade(self) -> Option> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 468 | Some(Rpc { [INFO] [stdout] | ______________^ [INFO] [stdout] 469 | | inner: self.inner.upgrade()?, [INFO] [stdout] 470 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpc.rs:487:11 [INFO] [stdout] | [INFO] [stdout] 485 | pub fn downgrade(self) -> WeakRpc { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 486 | WeakRpc { [INFO] [stdout] 487 | inner: Arc::downgrade(&self.inner), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 22 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bifrostlink` (lib) due to 23 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "e644d759ccea53e980651589054527071c377278d37f57f0b67993533f43dbae", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e644d759ccea53e980651589054527071c377278d37f57f0b67993533f43dbae", kill_on_drop: false }` [INFO] [stdout] e644d759ccea53e980651589054527071c377278d37f57f0b67993533f43dbae