[INFO] fetching crate bidir_termtree 0.1.1... [INFO] checking bidir_termtree-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate bidir_termtree 0.1.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate bidir_termtree 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate bidir_termtree 0.1.1 [INFO] finished tweaking crates.io crate bidir_termtree 0.1.1 [INFO] tweaked toml for crates.io crate bidir_termtree 0.1.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate bidir_termtree 0.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c8e852c2fe26c44b1b48fe9a1ffba33e2c87a832a4c2abbe133cd8d050d43376 [INFO] running `Command { std: "docker" "start" "-a" "c8e852c2fe26c44b1b48fe9a1ffba33e2c87a832a4c2abbe133cd8d050d43376", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c8e852c2fe26c44b1b48fe9a1ffba33e2c87a832a4c2abbe133cd8d050d43376", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c8e852c2fe26c44b1b48fe9a1ffba33e2c87a832a4c2abbe133cd8d050d43376", kill_on_drop: false }` [INFO] [stdout] c8e852c2fe26c44b1b48fe9a1ffba33e2c87a832a4c2abbe133cd8d050d43376 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a672a63e33b8e06fe5b874d7400b4d9c3f9c5879297dec938fc324adf5eadeb8 [INFO] running `Command { std: "docker" "start" "-a" "a672a63e33b8e06fe5b874d7400b4d9c3f9c5879297dec938fc324adf5eadeb8", kill_on_drop: false }` [INFO] [stderr] Checking bidir_termtree v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:45:21 [INFO] [stdout] | [INFO] [stdout] 42 | pub fn new(root: D) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | leaves: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:99:28 [INFO] [stdout] | [INFO] [stdout] 98 | fn extend>(&mut self, iter: T) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | self.leaves.extend(iter.into_iter().map(Into::into)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:281:40 [INFO] [stdout] | [INFO] [stdout] 281 | enqueue_leaves(&mut queue, self.clone(), no_space); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Tree` does not implement `Clone`, so calling `clone` on `&Tree` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 281 - enqueue_leaves(&mut queue, self.clone(), no_space); [INFO] [stdout] 281 + enqueue_leaves(&mut queue, self, no_space); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `Tree`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 33 + #[derive(Clone)] [INFO] [stdout] 34 | pub struct Tree { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bidir_termtree` (lib) due to 3 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:45:21 [INFO] [stdout] | [INFO] [stdout] 42 | pub fn new(root: D) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | leaves: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:99:28 [INFO] [stdout] | [INFO] [stdout] 98 | fn extend>(&mut self, iter: T) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | self.leaves.extend(iter.into_iter().map(Into::into)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:281:40 [INFO] [stdout] | [INFO] [stdout] 281 | enqueue_leaves(&mut queue, self.clone(), no_space); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Tree` does not implement `Clone`, so calling `clone` on `&Tree` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 281 - enqueue_leaves(&mut queue, self.clone(), no_space); [INFO] [stdout] 281 + enqueue_leaves(&mut queue, self, no_space); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `Tree`, implement `Clone` for it [INFO] [stdout] | [INFO] [stdout] 33 + #[derive(Clone)] [INFO] [stdout] 34 | pub struct Tree { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bidir_termtree` (lib test) due to 3 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "a672a63e33b8e06fe5b874d7400b4d9c3f9c5879297dec938fc324adf5eadeb8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a672a63e33b8e06fe5b874d7400b4d9c3f9c5879297dec938fc324adf5eadeb8", kill_on_drop: false }` [INFO] [stdout] a672a63e33b8e06fe5b874d7400b4d9c3f9c5879297dec938fc324adf5eadeb8