[INFO] fetching crate bgp-rs 0.6.0... [INFO] checking bgp-rs-0.6.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate bgp-rs 0.6.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate bgp-rs 0.6.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate bgp-rs 0.6.0 [INFO] finished tweaking crates.io crate bgp-rs 0.6.0 [INFO] tweaked toml for crates.io crate bgp-rs 0.6.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 26 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding derive-into-owned v0.1.0 (latest: v0.2.0) [INFO] [stderr] Adding etherparse v0.9.0 (latest: v0.15.0) [INFO] [stderr] Adding libflate v0.1.27 (latest: v2.1.0) [INFO] [stderr] Adding pcap-file v1.1.1 (latest: v2.0.0) [INFO] [stderr] Adding quote v0.3.15 (latest: v1.0.37) [INFO] [stderr] Adding syn v0.11.11 (latest: v2.0.77) [INFO] [stderr] Adding unicode-xid v0.0.4 (latest: v0.2.5) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a2b79874d09c29b4002ed698fc1b18ddcb34040205affd3b44194ada74cc109a [INFO] running `Command { std: "docker" "start" "-a" "a2b79874d09c29b4002ed698fc1b18ddcb34040205affd3b44194ada74cc109a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a2b79874d09c29b4002ed698fc1b18ddcb34040205affd3b44194ada74cc109a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a2b79874d09c29b4002ed698fc1b18ddcb34040205affd3b44194ada74cc109a", kill_on_drop: false }` [INFO] [stdout] a2b79874d09c29b4002ed698fc1b18ddcb34040205affd3b44194ada74cc109a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d19a34a3bf90c71d22e2f6927e0ea9edf2c39dd7c3f17bb8ad653d40969efad7 [INFO] running `Command { std: "docker" "start" "-a" "d19a34a3bf90c71d22e2f6927e0ea9edf2c39dd7c3f17bb8ad653d40969efad7", kill_on_drop: false }` [INFO] [stderr] Compiling unicode-xid v0.0.4 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling quote v0.3.15 [INFO] [stderr] Checking rle-decode-fast v1.0.3 [INFO] [stderr] Checking take_mut v0.2.2 [INFO] [stderr] Checking unchecked-index v0.2.2 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Compiling synom v0.11.3 [INFO] [stderr] Compiling syn v0.11.11 [INFO] [stderr] Checking libflate v0.1.27 [INFO] [stderr] Checking mrt-rs v2.0.1 [INFO] [stderr] Checking etherparse v0.9.0 [INFO] [stderr] Checking bgp-rs v0.6.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking twoway v0.2.2 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:502:27 [INFO] [stdout] | [INFO] [stdout] 496 | pub fn new(stream: T) -> Self [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 502 | capabilities: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/open.rs:57:12 [INFO] [stdout] | [INFO] [stdout] 43 | let mut parameters: Vec = Vec::with_capacity(length as usize); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | Ok(Open { [INFO] [stdout] | ____________^ [INFO] [stdout] 58 | | version, [INFO] [stdout] 59 | | peer_asn, [INFO] [stdout] 60 | | hold_timer, [INFO] [stdout] 61 | | identifier, [INFO] [stdout] 62 | | parameters, [INFO] [stdout] 63 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/open.rs:155:12 [INFO] [stdout] | [INFO] [stdout] 155 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 156 | | 2 + (cap_length as u16), [INFO] [stdout] 157 | | match cap_code { [INFO] [stdout] 158 | | // MP_BGP [INFO] [stdout] ... | [INFO] [stdout] 240 | | }, [INFO] [stdout] 241 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/open.rs:335:12 [INFO] [stdout] | [INFO] [stdout] 335 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 336 | | 2 + (param_length as u16), [INFO] [stdout] 337 | | if param_type == 2 { [INFO] [stdout] 338 | | let mut bytes_read: i32 = 0; [INFO] [stdout] ... | [INFO] [stdout] 364 | | }, [INFO] [stdout] 365 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bgp-rs` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "d19a34a3bf90c71d22e2f6927e0ea9edf2c39dd7c3f17bb8ad653d40969efad7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d19a34a3bf90c71d22e2f6927e0ea9edf2c39dd7c3f17bb8ad653d40969efad7", kill_on_drop: false }` [INFO] [stdout] d19a34a3bf90c71d22e2f6927e0ea9edf2c39dd7c3f17bb8ad653d40969efad7