[INFO] fetching crate bfc 1.12.0... [INFO] checking bfc-1.12.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate bfc 1.12.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate bfc 1.12.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate bfc 1.12.0 [INFO] finished tweaking crates.io crate bfc 1.12.0 [INFO] tweaked toml for crates.io crate bfc 1.12.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate bfc 1.12.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0049a8863a5d02a696d17543624c96173b4576e0d29ba3ad42650f5eb88e2ff7 [INFO] running `Command { std: "docker" "start" "-a" "0049a8863a5d02a696d17543624c96173b4576e0d29ba3ad42650f5eb88e2ff7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0049a8863a5d02a696d17543624c96173b4576e0d29ba3ad42650f5eb88e2ff7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0049a8863a5d02a696d17543624c96173b4576e0d29ba3ad42650f5eb88e2ff7", kill_on_drop: false }` [INFO] [stdout] 0049a8863a5d02a696d17543624c96173b4576e0d29ba3ad42650f5eb88e2ff7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] aad6d16bf2b2e4368b7a7d5b692d56ad63e22cb820e8f73d2f36f1551182d10c [INFO] running `Command { std: "docker" "start" "-a" "aad6d16bf2b2e4368b7a7d5b692d56ad63e22cb820e8f73d2f36f1551182d10c", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.60 [INFO] [stderr] Compiling thiserror v1.0.40 [INFO] [stderr] Compiling rustix v0.37.20 [INFO] [stderr] Compiling ucd-trie v0.1.5 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling regex-syntax v0.7.2 [INFO] [stderr] Checking anstyle-parse v0.2.0 [INFO] [stderr] Checking getrandom v0.1.16 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Checking anstyle v1.0.0 [INFO] [stderr] Compiling tempfile v3.6.0 [INFO] [stderr] Checking aho-corasick v1.0.2 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking unicode-width v0.1.10 [INFO] [stderr] Compiling quote v1.0.28 [INFO] [stderr] Checking log v0.4.19 [INFO] [stderr] Compiling syn v2.0.18 [INFO] [stderr] Checking either v1.8.1 [INFO] [stderr] Checking ariadne v0.3.0 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking pretty_assertions v1.3.0 [INFO] [stderr] Checking regex v1.8.4 [INFO] [stderr] Checking is-terminal v0.4.7 [INFO] [stderr] Checking terminal_size v0.2.6 [INFO] [stderr] Checking anstream v0.3.2 [INFO] [stderr] Checking clap_builder v4.3.4 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Compiling thiserror-impl v1.0.40 [INFO] [stderr] Checking quickcheck v0.9.2 [INFO] [stderr] Compiling pest v2.6.0 [INFO] [stderr] Checking clap v4.3.4 [INFO] [stderr] Compiling semver-parser v0.10.2 [INFO] [stderr] Compiling semver v0.11.0 [INFO] [stderr] Compiling llvm-sys v130.1.1 [INFO] [stderr] Checking bfc v1.12.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:43:11 [INFO] [stdout] | [INFO] [stdout] 34 | let mut file = match File::open(path) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | Ok(file) => file, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | Err(message) => { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | match file.read_to_string(&mut contents) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/llvm.rs:952:12 [INFO] [stdout] | [INFO] [stdout] 935 | let cpu = CString::new("generic").unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 936 | // features are documented: http://llvm.org/docs/CommandGuide/llc.html#cmdoption-mattr [INFO] [stdout] 937 | let features = CString::new("").unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 952 | Ok(TargetMachine { tm: target_machine }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peephole.rs:447:5 [INFO] [stdout] | [INFO] [stdout] 444 | fn ordered_values(map: HashMap) -> Vec { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 445 | let mut items: Vec<_> = map.into_iter().collect(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 446 | items.sort_by(|a, b| a.0.cmp(&b.0)); [INFO] [stdout] 447 | items.into_iter().map(|(_, v)| v).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shell.rs:19:11 [INFO] [stdout] | [INFO] [stdout] 14 | let mut c = Command::new(command); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 19 | match c.output() { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bfc` (bin "bfc") due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:43:11 [INFO] [stdout] | [INFO] [stdout] 34 | let mut file = match File::open(path) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | Ok(file) => file, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | Err(message) => { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | match file.read_to_string(&mut contents) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/llvm.rs:952:12 [INFO] [stdout] | [INFO] [stdout] 935 | let cpu = CString::new("generic").unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 936 | // features are documented: http://llvm.org/docs/CommandGuide/llc.html#cmdoption-mattr [INFO] [stdout] 937 | let features = CString::new("").unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 952 | Ok(TargetMachine { tm: target_machine }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peephole.rs:447:5 [INFO] [stdout] | [INFO] [stdout] 444 | fn ordered_values(map: HashMap) -> Vec { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 445 | let mut items: Vec<_> = map.into_iter().collect(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 446 | items.sort_by(|a, b| a.0.cmp(&b.0)); [INFO] [stdout] 447 | items.into_iter().map(|(_, v)| v).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shell.rs:19:11 [INFO] [stdout] | [INFO] [stdout] 14 | let mut c = Command::new(command); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 19 | match c.output() { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bfc` (bin "bfc" test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "aad6d16bf2b2e4368b7a7d5b692d56ad63e22cb820e8f73d2f36f1551182d10c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aad6d16bf2b2e4368b7a7d5b692d56ad63e22cb820e8f73d2f36f1551182d10c", kill_on_drop: false }` [INFO] [stdout] aad6d16bf2b2e4368b7a7d5b692d56ad63e22cb820e8f73d2f36f1551182d10c