[INFO] fetching crate better_default 1.0.5... [INFO] checking better_default-1.0.5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate better_default 1.0.5 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate better_default 1.0.5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate better_default 1.0.5 [INFO] finished tweaking crates.io crate better_default 1.0.5 [INFO] tweaked toml for crates.io crate better_default 1.0.5 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate better_default 1.0.5 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 31e4f1ed3b16d8bbdbddddd78cf410f5b83f8abf4ab51a196a86fbb77ef0496d [INFO] running `Command { std: "docker" "start" "-a" "31e4f1ed3b16d8bbdbddddd78cf410f5b83f8abf4ab51a196a86fbb77ef0496d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "31e4f1ed3b16d8bbdbddddd78cf410f5b83f8abf4ab51a196a86fbb77ef0496d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "31e4f1ed3b16d8bbdbddddd78cf410f5b83f8abf4ab51a196a86fbb77ef0496d", kill_on_drop: false }` [INFO] [stdout] 31e4f1ed3b16d8bbdbddddd78cf410f5b83f8abf4ab51a196a86fbb77ef0496d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7a1cb9d4ca47aa4fe4abe4c862e23e168a7ecbc97d5de93b81e803c4b9836dec [INFO] running `Command { std: "docker" "start" "-a" "7a1cb9d4ca47aa4fe4abe4c862e23e168a7ecbc97d5de93b81e803c4b9836dec", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking winnow v0.6.6 [INFO] [stderr] Compiling serde_json v1.0.115 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Compiling trybuild v1.0.91 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking quote v1.0.36 [INFO] [stderr] Checking syn v2.0.58 [INFO] [stderr] Checking serde_spanned v0.6.5 [INFO] [stderr] Checking toml_datetime v0.6.5 [INFO] [stderr] Checking better_default v1.0.5 (/opt/rustwide/workdir) [INFO] [stderr] Checking toml_edit v0.22.9 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:728:5 [INFO] [stdout] | [INFO] [stdout] 725 | pub fn better_default(input: TokenStream) -> TokenStream { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 726 | let input = syn::parse_macro_input!(input as DeriveInput); [INFO] [stdout] | ----- --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 727 | [INFO] [stdout] 728 | derive::derive(&input).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/default.rs:59:75 [INFO] [stdout] | [INFO] [stdout] 59 | let default_tokens = default_tokens.and_then(|meta| handle_error!(meta.parse_args::(), error_tokens)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/default.rs:90:5 [INFO] [stdout] | [INFO] [stdout] 87 | let default_value_vec = get_field_default_values(top_default_values, fields, error_tokens); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | [INFO] [stdout] 89 | let flattened_tokens = default_value_vec.join_tokens(&Token![,](Span2::call_site())); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | proc_macro2::Group::new(delimiter, flattened_tokens).into_token_stream() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `better_default` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "7a1cb9d4ca47aa4fe4abe4c862e23e168a7ecbc97d5de93b81e803c4b9836dec", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7a1cb9d4ca47aa4fe4abe4c862e23e168a7ecbc97d5de93b81e803c4b9836dec", kill_on_drop: false }` [INFO] [stdout] 7a1cb9d4ca47aa4fe4abe4c862e23e168a7ecbc97d5de93b81e803c4b9836dec