[INFO] fetching crate best403unlocker-rs 0.1.4... [INFO] checking best403unlocker-rs-0.1.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate best403unlocker-rs 0.1.4 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate best403unlocker-rs 0.1.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate best403unlocker-rs 0.1.4 [INFO] finished tweaking crates.io crate best403unlocker-rs 0.1.4 [INFO] tweaked toml for crates.io crate best403unlocker-rs 0.1.4 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate best403unlocker-rs 0.1.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d6d39e86f93d78c5278cc6f012a158dfd3b44059a74fb1f5cbdba73ebeec5756 [INFO] running `Command { std: "docker" "start" "-a" "d6d39e86f93d78c5278cc6f012a158dfd3b44059a74fb1f5cbdba73ebeec5756", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d6d39e86f93d78c5278cc6f012a158dfd3b44059a74fb1f5cbdba73ebeec5756", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d6d39e86f93d78c5278cc6f012a158dfd3b44059a74fb1f5cbdba73ebeec5756", kill_on_drop: false }` [INFO] [stdout] d6d39e86f93d78c5278cc6f012a158dfd3b44059a74fb1f5cbdba73ebeec5756 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0dc826c812c0c80904c331ca54942dc5f36bedd57e28e3c88d12c4c46da933f4 [INFO] running `Command { std: "docker" "start" "-a" "0dc826c812c0c80904c331ca54942dc5f36bedd57e28e3c88d12c4c46da933f4", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Checking bytes v1.6.1 [INFO] [stderr] Compiling cc v1.1.6 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Compiling openssl v0.10.65 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Checking match_cfg v0.1.0 [INFO] [stderr] Checking anstyle-query v1.1.0 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking idna v0.4.0 [INFO] [stderr] Checking winnow v0.6.14 [INFO] [stderr] Checking data-encoding v2.6.0 [INFO] [stderr] Checking rustls-pki-types v1.7.0 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking colored v2.1.0 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking encoding_rs v0.8.34 [INFO] [stderr] Checking rustls-pemfile v2.1.2 [INFO] [stderr] Compiling syn v2.0.71 [INFO] [stderr] Checking lru-cache v0.1.2 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking env_filter v0.1.0 [INFO] [stderr] Checking env_logger v0.11.3 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking colog v1.3.0 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking hostname v0.3.1 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking resolv-conf v0.7.0 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling openssl-sys v0.9.103 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling native-tls v0.2.12 [INFO] [stderr] Compiling tokio-macros v2.3.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Compiling enum-as-inner v0.6.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tokio v1.38.1 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking trust-dns-proto v0.23.2 [INFO] [stderr] Checking h2 v0.4.5 [INFO] [stderr] Checking toml_datetime v0.6.6 [INFO] [stderr] Checking serde_spanned v0.6.6 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking toml_edit v0.22.16 [INFO] [stderr] Checking trust-dns-resolver v0.23.2 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking toml v0.8.15 [INFO] [stderr] Checking hyper-util v0.1.6 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.5 [INFO] [stderr] Checking best403unlocker-rs v0.1.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: unreachable statement [INFO] [stdout] --> src/config.rs:48:25 [INFO] [stdout] | [INFO] [stdout] 47 | process::exit(1); [INFO] [stdout] | ---------------- any code following this expression is unreachable [INFO] [stdout] 48 | todo!("Implement downloading the config file if not found"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ unreachable statement [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] = note: this warning originates in the macro `$crate::panic` which comes from the expansion of the macro `todo` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable statement [INFO] [stdout] --> src/config.rs:48:25 [INFO] [stdout] | [INFO] [stdout] 47 | process::exit(1); [INFO] [stdout] | ---------------- any code following this expression is unreachable [INFO] [stdout] 48 | todo!("Implement downloading the config file if not found"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ unreachable statement [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] = note: this warning originates in the macro `$crate::panic` which comes from the expansion of the macro `todo` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resolver.rs:23:23 [INFO] [stdout] | [INFO] [stdout] 20 | let resolver = TokioAsyncResolver::tokio(resolver_config, ResolverOpts::default()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | resolver: Arc::new(Mutex::new(resolver)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resolver.rs:23:23 [INFO] [stdout] | [INFO] [stdout] 20 | let resolver = TokioAsyncResolver::tokio(resolver_config, ResolverOpts::default()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | resolver: Arc::new(Mutex::new(resolver)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resolver.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 29 | fn resolve(&self, name: reqwest::dns::Name) -> Resolving { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | let resolver = self.resolver.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | [INFO] [stdout] 32 | let fut = async move { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | Box::pin(fut) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resolver.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 29 | fn resolve(&self, name: reqwest::dns::Name) -> Resolving { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | let resolver = self.resolver.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | [INFO] [stdout] 32 | let fut = async move { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | Box::pin(fut) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resolver.rs:37:16 [INFO] [stdout] | [INFO] [stdout] 29 | fn resolve(&self, name: reqwest::dns::Name) -> Resolving { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | let resolver = self.resolver.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | let resolver = resolver.lock().await; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | let response = resolver.lookup_ip(name_str).await?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let addrs: Vec = response.iter().map(|ip| SocketAddr::new(ip, 0)).collect(); [INFO] [stdout] 37 | Ok(Box::new(addrs.into_iter()) as Box + Send>) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resolver.rs:37:16 [INFO] [stdout] | [INFO] [stdout] 29 | fn resolve(&self, name: reqwest::dns::Name) -> Resolving { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | let resolver = self.resolver.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | let resolver = resolver.lock().await; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | let response = resolver.lookup_ip(name_str).await?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let addrs: Vec = response.iter().map(|ip| SocketAddr::new(ip, 0)).collect(); [INFO] [stdout] 37 | Ok(Box::new(addrs.into_iter()) as Box + Send>) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `best403unlocker-rs` (bin "best403unlocker-rs" test) due to 4 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `best403unlocker-rs` (bin "best403unlocker-rs") due to 4 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "0dc826c812c0c80904c331ca54942dc5f36bedd57e28e3c88d12c4c46da933f4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0dc826c812c0c80904c331ca54942dc5f36bedd57e28e3c88d12c4c46da933f4", kill_on_drop: false }` [INFO] [stdout] 0dc826c812c0c80904c331ca54942dc5f36bedd57e28e3c88d12c4c46da933f4