[INFO] fetching crate bendy 0.4.0-beta.2... [INFO] checking bendy-0.4.0-beta.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate bendy 0.4.0-beta.2 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate bendy 0.4.0-beta.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate bendy 0.4.0-beta.2 [INFO] removed 0 missing examples [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate bendy 0.4.0-beta.2 [INFO] tweaked toml for crates.io crate bendy 0.4.0-beta.2 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate bendy 0.4.0-beta.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `snafu` dependency) [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5a6fa887fceb94ae88c6f35e095d531f5ff4fdc452cee3c98e62514de6c05709 [INFO] running `Command { std: "docker" "start" "-a" "5a6fa887fceb94ae88c6f35e095d531f5ff4fdc452cee3c98e62514de6c05709", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5a6fa887fceb94ae88c6f35e095d531f5ff4fdc452cee3c98e62514de6c05709", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5a6fa887fceb94ae88c6f35e095d531f5ff4fdc452cee3c98e62514de6c05709", kill_on_drop: false }` [INFO] [stdout] 5a6fa887fceb94ae88c6f35e095d531f5ff4fdc452cee3c98e62514de6c05709 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 56cc8fb4be64020a30f548be34c685ff779f63034e208dd705ed3e92f8ea667d [INFO] running `Command { std: "docker" "start" "-a" "56cc8fb4be64020a30f548be34c685ff779f63034e208dd705ed3e92f8ea667d", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `snafu` dependency) [INFO] [stderr] Compiling proc-macro2 v1.0.40 [INFO] [stderr] Compiling unicode-ident v1.0.2 [INFO] [stderr] Compiling quote v1.0.20 [INFO] [stderr] Compiling syn v1.0.98 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Compiling rustversion v1.0.8 [INFO] [stderr] Compiling serde_derive v1.0.140 [INFO] [stderr] Checking regex-syntax v0.6.27 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking regex v1.6.0 [INFO] [stderr] Compiling snafu-derive v0.7.1 [INFO] [stderr] Checking snafu v0.7.1 [INFO] [stderr] Checking bendy v0.4.0-beta.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition name: `debug` [INFO] [stdout] --> src/decoding/decoder.rs:128:28 [INFO] [stdout] | [INFO] [stdout] 128 | let ival = if cfg!(debug) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows` [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(debug)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(debug)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `replace_top` is never used [INFO] [stdout] --> src/state_tracker/stack.rs:9:8 [INFO] [stdout] | [INFO] [stdout] 4 | pub trait Stack { [INFO] [stdout] | ----- method in this trait [INFO] [stdout] ... [INFO] [stdout] 9 | fn replace_top(&mut self, new_value: T); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoding/error.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 74 | pub fn malformed_content(source: SourceT) -> Self [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | let error = Arc::new(source); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | ErrorKind::MalformedContent { source: error }.into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoding/error.rs:89:21 [INFO] [stdout] | [INFO] [stdout] 88 | pub fn missing_field(field_name: impl Display) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | Error::from(ErrorKind::MissingField { [INFO] [stdout] | _____________________^ [INFO] [stdout] 90 | | field: field_name.to_string(), [INFO] [stdout] 91 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoding/error.rs:96:21 [INFO] [stdout] | [INFO] [stdout] 95 | pub fn unexpected_field(field_name: impl Display) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | Error::from(ErrorKind::UnexpectedField { [INFO] [stdout] | _____________________^ [INFO] [stdout] 97 | | field: field_name.to_string(), [INFO] [stdout] 98 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoding/error.rs:103:21 [INFO] [stdout] | [INFO] [stdout] 102 | pub fn unexpected_token(expected: impl Display, discovered: impl Display) -> Self { [INFO] [stdout] | ---------------------- ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | Error::from(ErrorKind::UnexpectedToken { [INFO] [stdout] | _____________________^ [INFO] [stdout] 104 | | expected: expected.to_string(), [INFO] [stdout] 105 | | discovered: discovered.to_string(), [INFO] [stdout] 106 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoding/error.rs:145:22 [INFO] [stdout] | [INFO] [stdout] 144 | fn context(self, context: impl Display) -> Self { [INFO] [stdout] | ---- --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | self.map_err(|err| err.context(context)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoding/from_bencode.rs:31:13 [INFO] [stdout] | [INFO] [stdout] 27 | let mut decoder = Decoder::new(bytes).with_max_depth(Self::EXPECTED_RECURSION_DEPTH); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | let object = decoder.next_object()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | Err(Error::from(StructureError::UnexpectedEof)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoding/from_bencode.rs:154:9 [INFO] [stdout] | [INFO] [stdout] 150 | fn decode_bencode_object(object: Object) -> Result [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 154 | T::decode_bencode_object(object).map(Rc::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoding/from_bencode.rs:165:9 [INFO] [stdout] | [INFO] [stdout] 161 | fn decode_bencode_object(object: Object) -> Result [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 165 | object.try_into_bytes().map(Vec::from).map(AsString) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoding/object.rs:112:38 [INFO] [stdout] | [INFO] [stdout] 112 | self.bytes_or_else(|obj| Err(Error::unexpected_token("String", obj.into_token().name()))) [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoding/object.rs:202:40 [INFO] [stdout] | [INFO] [stdout] 202 | self.integer_or_else(|obj| Err(Error::unexpected_token("Num", obj.into_token().name()))) [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoding/object.rs:296:37 [INFO] [stdout] | [INFO] [stdout] 296 | self.list_or_else(|obj| Err(Error::unexpected_token("List", obj.into_token().name()))) [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoding/object.rs:392:43 [INFO] [stdout] | [INFO] [stdout] 392 | self.dictionary_or_else(|obj| Err(Error::unexpected_token("Dict", obj.into_token().name()))) [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/encoding/encoder.rs:311:24 [INFO] [stdout] | [INFO] [stdout] 309 | iterable: impl Iterator, [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 310 | ) -> Result<(), Error> { [INFO] [stdout] 311 | self.emit_list(|e| { [INFO] [stdout] | ________________________^ [INFO] [stdout] 312 | | for item in iterable { [INFO] [stdout] 313 | | e.emit(item)?; [INFO] [stdout] 314 | | } [INFO] [stdout] 315 | | Ok(()) [INFO] [stdout] 316 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/encoding/to_bencode.rs:32:31 [INFO] [stdout] | [INFO] [stdout] 32 | encoder.emit_with(|e| self.encode(e).map_err(Error::into))?; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bendy` (lib) due to 15 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "56cc8fb4be64020a30f548be34c685ff779f63034e208dd705ed3e92f8ea667d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "56cc8fb4be64020a30f548be34c685ff779f63034e208dd705ed3e92f8ea667d", kill_on_drop: false }` [INFO] [stdout] 56cc8fb4be64020a30f548be34c685ff779f63034e208dd705ed3e92f8ea667d