[INFO] fetching crate benchify 0.4.5... [INFO] checking benchify-0.4.5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate benchify 0.4.5 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate benchify 0.4.5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate benchify 0.4.5 [INFO] finished tweaking crates.io crate benchify 0.4.5 [INFO] tweaked toml for crates.io crate benchify 0.4.5 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate benchify 0.4.5 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c0586b76c862fa02a55d4329a609981253c9fefdc35988804cd1be1ecd036dd3 [INFO] running `Command { std: "docker" "start" "-a" "c0586b76c862fa02a55d4329a609981253c9fefdc35988804cd1be1ecd036dd3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c0586b76c862fa02a55d4329a609981253c9fefdc35988804cd1be1ecd036dd3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c0586b76c862fa02a55d4329a609981253c9fefdc35988804cd1be1ecd036dd3", kill_on_drop: false }` [INFO] [stdout] c0586b76c862fa02a55d4329a609981253c9fefdc35988804cd1be1ecd036dd3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1dc8807bc9bd9c0eb5da73aa108a32960560d8ba518dc7c3f4b0942f9bcd5ee0 [INFO] running `Command { std: "docker" "start" "-a" "1dc8807bc9bd9c0eb5da73aa108a32960560d8ba518dc7c3f4b0942f9bcd5ee0", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling rustix v0.38.4 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Checking bitflags v2.3.3 [INFO] [stderr] Compiling serde v1.0.180 [INFO] [stderr] Checking linux-raw-sys v0.4.5 [INFO] [stderr] Compiling proc-macro2 v1.0.66 [INFO] [stderr] Compiling serde_derive v1.0.180 [INFO] [stderr] Checking regex-syntax v0.7.4 [INFO] [stderr] Compiling unicode-ident v1.0.11 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking anstyle v1.0.1 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Checking hashbrown v0.14.0 [INFO] [stderr] Checking anstyle-parse v0.2.1 [INFO] [stderr] Compiling rayon-core v1.11.0 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Checking gimli v0.27.3 [INFO] [stderr] Compiling eyre v0.6.8 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Checking clap_lex v0.5.0 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking rustc-demangle v0.1.23 [INFO] [stderr] Compiling memoffset v0.9.0 [INFO] [stderr] Compiling crossbeam-epoch v0.9.15 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking log v0.4.19 [INFO] [stderr] Checking termcolor v1.2.0 [INFO] [stderr] Checking unicode-width v0.1.10 [INFO] [stderr] Checking winnow v0.5.3 [INFO] [stderr] Checking indexmap v2.0.0 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking aho-corasick v1.0.2 [INFO] [stderr] Checking object v0.31.1 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking number_prefix v0.3.0 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking console v0.15.7 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking crossbeam-channel v0.5.8 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Checking owo-colors v3.5.0 [INFO] [stderr] Compiling quote v1.0.32 [INFO] [stderr] Checking crossbeam-deque v0.8.3 [INFO] [stderr] Compiling cc v1.0.80 [INFO] [stderr] Compiling syn v2.0.28 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking regex-automata v0.3.4 [INFO] [stderr] Checking anstream v0.3.2 [INFO] [stderr] Checking clap_builder v4.3.19 [INFO] [stderr] Checking rayon v1.7.0 [INFO] [stderr] Compiling backtrace v0.3.68 [INFO] [stderr] Checking addr2line v0.20.0 [INFO] [stderr] Checking toml_datetime v0.6.3 [INFO] [stderr] Checking serde_spanned v0.6.3 [INFO] [stderr] Checking csv v1.2.2 [INFO] [stderr] Checking toml_edit v0.19.14 [INFO] [stderr] Checking regex v1.9.1 [INFO] [stderr] Checking env_logger v0.10.0 [INFO] [stderr] Checking indicatif v0.15.0 [INFO] [stderr] Checking pretty_env_logger v0.5.0 [INFO] [stderr] Checking color-eyre v0.6.2 [INFO] [stderr] Compiling clap_derive v4.3.12 [INFO] [stderr] Checking toml v0.7.6 [INFO] [stderr] Checking clap v4.3.19 [INFO] [stderr] Checking benchify v0.4.5 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:99:24 [INFO] [stdout] | [INFO] [stdout] 97 | mut buf: impl std::io::Read + std::marker::Send + 'static, [INFO] [stdout] | --------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | ) -> std::thread::JoinHandle> { [INFO] [stdout] 99 | std::thread::spawn(move || { [INFO] [stdout] | ________________________^ [INFO] [stdout] 100 | | let mut res = vec![]; [INFO] [stdout] 101 | | buf.read_to_end(&mut res)?; [INFO] [stdout] 102 | | Ok(String::from_utf8_lossy(&res).into_owned()) [INFO] [stdout] 103 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:645:50 [INFO] [stdout] | [INFO] [stdout] 645 | .map(|tool| (test, tool, Some(mpb.add(ProgressBar::new_spinner())))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:695:28 [INFO] [stdout] | [INFO] [stdout] 682 | let timings = if use_known_csv_data { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 695 | Ok((test.name.as_ref(), tool.name.as_ref(), timings)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `benchify` (bin "benchify") due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:99:24 [INFO] [stdout] | [INFO] [stdout] 97 | mut buf: impl std::io::Read + std::marker::Send + 'static, [INFO] [stdout] | --------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | ) -> std::thread::JoinHandle> { [INFO] [stdout] 99 | std::thread::spawn(move || { [INFO] [stdout] | ________________________^ [INFO] [stdout] 100 | | let mut res = vec![]; [INFO] [stdout] 101 | | buf.read_to_end(&mut res)?; [INFO] [stdout] 102 | | Ok(String::from_utf8_lossy(&res).into_owned()) [INFO] [stdout] 103 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:645:50 [INFO] [stdout] | [INFO] [stdout] 645 | .map(|tool| (test, tool, Some(mpb.add(ProgressBar::new_spinner())))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:695:28 [INFO] [stdout] | [INFO] [stdout] 682 | let timings = if use_known_csv_data { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 695 | Ok((test.name.as_ref(), tool.name.as_ref(), timings)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `benchify` (bin "benchify" test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "1dc8807bc9bd9c0eb5da73aa108a32960560d8ba518dc7c3f4b0942f9bcd5ee0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1dc8807bc9bd9c0eb5da73aa108a32960560d8ba518dc7c3f4b0942f9bcd5ee0", kill_on_drop: false }` [INFO] [stdout] 1dc8807bc9bd9c0eb5da73aa108a32960560d8ba518dc7c3f4b0942f9bcd5ee0