[INFO] fetching crate benchie 0.5.0... [INFO] checking benchie-0.5.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate benchie 0.5.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate benchie 0.5.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-0-tc2/source/.cargo/config [INFO] started tweaking crates.io crate benchie 0.5.0 [INFO] finished tweaking crates.io crate benchie 0.5.0 [INFO] tweaked toml for crates.io crate benchie 0.5.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate benchie 0.5.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b6052fe4f63fe0889f889bb9672683abdb55b30accd2b5e422c2333baf2faedc [INFO] running `Command { std: "docker" "start" "-a" "b6052fe4f63fe0889f889bb9672683abdb55b30accd2b5e422c2333baf2faedc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b6052fe4f63fe0889f889bb9672683abdb55b30accd2b5e422c2333baf2faedc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b6052fe4f63fe0889f889bb9672683abdb55b30accd2b5e422c2333baf2faedc", kill_on_drop: false }` [INFO] [stdout] b6052fe4f63fe0889f889bb9672683abdb55b30accd2b5e422c2333baf2faedc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 56f7ed7cbf27f5f181e40f97d19ea2a541827b63a691cd0eeb3d359b0918a93b [INFO] running `Command { std: "docker" "start" "-a" "56f7ed7cbf27f5f181e40f97d19ea2a541827b63a691cd0eeb3d359b0918a93b", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Compiling proc-macro2 v1.0.39 [INFO] [stderr] Compiling unicode-ident v1.0.0 [INFO] [stderr] Compiling syn v1.0.96 [INFO] [stderr] Compiling pkg-config v0.3.25 [INFO] [stderr] Compiling serde_derive v1.0.137 [INFO] [stderr] Compiling crossbeam-utils v0.8.8 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling serde v1.0.137 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling crossbeam-epoch v0.9.8 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling rayon-core v1.9.3 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Checking matches v0.1.9 [INFO] [stderr] Compiling quote v1.0.18 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Compiling jobserver v0.1.24 [INFO] [stderr] Checking crossbeam-channel v0.5.4 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Compiling indexmap v1.8.2 [INFO] [stderr] Compiling rayon v1.5.3 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking ryu v1.0.10 [INFO] [stderr] Checking unicode-bidi v0.3.8 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Checking unicode-normalization v0.1.19 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling openssl-src v111.20.0+1.1.1o [INFO] [stderr] Compiling lock_api v0.4.7 [INFO] [stderr] Compiling rustversion v1.0.6 [INFO] [stderr] Compiling anyhow v1.0.57 [INFO] [stderr] Compiling serde_json v1.0.81 [INFO] [stderr] Compiling parking_lot_core v0.9.3 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking os_str_bytes v6.1.0 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Compiling sysinfo v0.24.2 [INFO] [stderr] Compiling libz-sys v1.1.8 [INFO] [stderr] Compiling openssl-sys v0.9.74 [INFO] [stderr] Compiling libssh2-sys v0.2.23 [INFO] [stderr] Compiling libgit2-sys v0.12.26+1.3.0 [INFO] [stderr] Checking clap_lex v0.2.0 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stderr] Checking once_cell v1.12.0 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Checking smallvec v1.8.0 [INFO] [stderr] Checking itoa v1.0.2 [INFO] [stderr] Checking openssl-probe v0.1.5 [INFO] [stderr] Checking clap v3.1.18 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Checking colored v2.0.0 [INFO] [stderr] Checking itertools v0.10.3 [INFO] [stderr] Compiling cargo-husky v1.5.0 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking fastrand v1.7.0 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking tempfile v3.3.0 [INFO] [stderr] Compiling cli-table-derive v0.4.5 [INFO] [stderr] Compiling thiserror-impl v1.0.31 [INFO] [stderr] Compiling serial_test_derive v0.7.0 [INFO] [stderr] Checking serial_test v0.7.0 [INFO] [stderr] Checking thiserror v1.0.31 [INFO] [stderr] Checking bstr v0.2.17 [INFO] [stderr] Checking csv v1.1.6 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking cli-table v0.4.7 [INFO] [stderr] Checking bytesize v1.1.0 [INFO] [stderr] Checking git2 v0.13.25 [INFO] [stderr] Checking benchie v0.5.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/benchmark.rs:175:5 [INFO] [stdout] | [INFO] [stdout] 124 | Err(GitError::Unknown(error)) => { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 128 | Err(known_error) => { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | append_benchmark(&benchmark).context("unable to save new benchmark") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:58:5 [INFO] [stdout] | [INFO] [stdout] 58 | serde_json::from_str::(&raw).context("failed to parse benchie data file") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:82:8 [INFO] [stdout] | [INFO] [stdout] 74 | pub fn deserialize<'de, D, T>(d: D) -> Result [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | Ok(s.try_into().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `benchie` (lib test) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/benchmark.rs:175:5 [INFO] [stdout] | [INFO] [stdout] 124 | Err(GitError::Unknown(error)) => { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 128 | Err(known_error) => { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | append_benchmark(&benchmark).context("unable to save new benchmark") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:58:5 [INFO] [stdout] | [INFO] [stdout] 58 | serde_json::from_str::(&raw).context("failed to parse benchie data file") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:82:8 [INFO] [stdout] | [INFO] [stdout] 74 | pub fn deserialize<'de, D, T>(d: D) -> Result [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | Ok(s.try_into().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `benchie` (lib) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "56f7ed7cbf27f5f181e40f97d19ea2a541827b63a691cd0eeb3d359b0918a93b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "56f7ed7cbf27f5f181e40f97d19ea2a541827b63a691cd0eeb3d359b0918a93b", kill_on_drop: false }` [INFO] [stdout] 56f7ed7cbf27f5f181e40f97d19ea2a541827b63a691cd0eeb3d359b0918a93b