[INFO] fetching crate below-common 0.8.1... [INFO] checking below-common-0.8.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate below-common 0.8.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate below-common 0.8.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate below-common 0.8.1 [INFO] finished tweaking crates.io crate below-common 0.8.1 [INFO] tweaked toml for crates.io crate below-common 0.8.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 133 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding crossterm v0.25.0 (latest: v0.28.1) [INFO] [stderr] Adding cursive v0.20.0 (latest: v0.21.1) [INFO] [stderr] Adding cursive_core v0.3.7 (latest: v0.4.6) [INFO] [stderr] Adding erased-serde v0.3.31 (latest: v0.4.5) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding mio v0.8.11 (latest: v1.0.2) [INFO] [stderr] Adding term v0.7.0 (latest: v1.0.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.48.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c790601bb54dbff1dea411d99b11e844f49d0e65e99ba7867a7977b91afdb508 [INFO] running `Command { std: "docker" "start" "-a" "c790601bb54dbff1dea411d99b11e844f49d0e65e99ba7867a7977b91afdb508", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c790601bb54dbff1dea411d99b11e844f49d0e65e99ba7867a7977b91afdb508", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c790601bb54dbff1dea411d99b11e844f49d0e65e99ba7867a7977b91afdb508", kill_on_drop: false }` [INFO] [stdout] c790601bb54dbff1dea411d99b11e844f49d0e65e99ba7867a7977b91afdb508 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 67889b5f5c4296c2f151501c42aea51cd523b73c558ae78d96bf2d5b821c0925 [INFO] running `Command { std: "docker" "start" "-a" "67889b5f5c4296c2f151501c42aea51cd523b73c558ae78d96bf2d5b821c0925", kill_on_drop: false }` [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling slog v2.7.0 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking xi-unicode v0.3.0 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking owning_ref v0.4.1 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking term v0.7.0 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Checking crossterm v0.25.0 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking erased-serde v0.3.31 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking slog-term v2.9.1 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling darling_core v0.20.10 [INFO] [stderr] Compiling enum-map-derive v0.17.0 [INFO] [stderr] Checking enum-map v2.7.3 [INFO] [stderr] Compiling darling_macro v0.20.10 [INFO] [stderr] Compiling darling v0.20.10 [INFO] [stderr] Compiling enumset_derive v0.10.0 [INFO] [stderr] Checking enumset v1.1.5 [INFO] [stderr] Checking cursive_core v0.3.7 [INFO] [stderr] Checking cursive v0.20.0 [INFO] [stderr] Checking below-common v0.8.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated method `chrono::NaiveDateTime::timestamp`: use `.and_utc().timestamp()` instead [INFO] [stdout] --> src/dateutil.rs:487:30 [INFO] [stdout] | [INFO] [stdout] 487 | let timestamp = time.timestamp(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `chrono::NaiveDateTime::timestamp`: use `.and_utc().timestamp()` instead [INFO] [stdout] --> src/dateutil.rs:487:30 [INFO] [stdout] | [INFO] [stdout] 487 | let timestamp = time.timestamp(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveDateTime::from_timestamp_opt`: use `DateTime::from_timestamp` instead [INFO] [stdout] --> src/util.rs:126:32 [INFO] [stdout] | [INFO] [stdout] 126 | let naive = NaiveDateTime::from_timestamp_opt(timestamp.clone(), 0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveDateTime::from_timestamp_opt`: use `DateTime::from_timestamp` instead [INFO] [stdout] --> src/util.rs:126:32 [INFO] [stdout] | [INFO] [stdout] 126 | let naive = NaiveDateTime::from_timestamp_opt(timestamp.clone(), 0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fileutil.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn get_dir_size>(path: P) -> u64 { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | / WalkDir::new(path) [INFO] [stdout] 22 | | .into_iter() [INFO] [stdout] 23 | | .filter_map(|entry| entry.ok()) [INFO] [stdout] 24 | | .filter_map(|entry| entry.metadata().ok()) [INFO] [stdout] 25 | | .filter(|metadata| metadata.is_file()) [INFO] [stdout] | |______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fileutil.rs:24:29 [INFO] [stdout] | [INFO] [stdout] 24 | .filter_map(|entry| entry.metadata().ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/logutil.rs:120:19 [INFO] [stdout] | [INFO] [stdout] 118 | pub fn new(file_io: W, term_io: T) -> Self { [INFO] [stdout] | ---------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 119 | Self { [INFO] [stdout] 120 | file: Arc::new(Mutex::new(file_io)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/logutil.rs:121:19 [INFO] [stdout] | [INFO] [stdout] 118 | pub fn new(file_io: W, term_io: T) -> Self { [INFO] [stdout] | ---------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | term: Arc::new(Mutex::new(term_io)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/logutil.rs:140:16 [INFO] [stdout] | [INFO] [stdout] 135 | f: F, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 140 | f(&mut CompoundRecordDecorator( [INFO] [stdout] | ________________^ [INFO] [stdout] 141 | | &*self.file, [INFO] [stdout] 142 | | &*self.term, [INFO] [stdout] 143 | | *LOG_TARGET [INFO] [stdout] 144 | | .read() [INFO] [stdout] 145 | | .expect("Failed to acquire write lock on the LOG_TARGET"), [INFO] [stdout] 146 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/logutil.rs:243:24 [INFO] [stdout] | [INFO] [stdout] 242 | let plain = slog_term::PlainSyncDecorator::new(std::io::stderr()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 243 | slog::Logger::root(slog_term::FullFormat::new(plain).build().fuse(), slog::o!()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `below-common` (lib) due to 7 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fileutil.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn get_dir_size>(path: P) -> u64 { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | / WalkDir::new(path) [INFO] [stdout] 22 | | .into_iter() [INFO] [stdout] 23 | | .filter_map(|entry| entry.ok()) [INFO] [stdout] 24 | | .filter_map(|entry| entry.metadata().ok()) [INFO] [stdout] 25 | | .filter(|metadata| metadata.is_file()) [INFO] [stdout] | |______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fileutil.rs:24:29 [INFO] [stdout] | [INFO] [stdout] 24 | .filter_map(|entry| entry.metadata().ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/logutil.rs:120:19 [INFO] [stdout] | [INFO] [stdout] 118 | pub fn new(file_io: W, term_io: T) -> Self { [INFO] [stdout] | ---------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 119 | Self { [INFO] [stdout] 120 | file: Arc::new(Mutex::new(file_io)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/logutil.rs:121:19 [INFO] [stdout] | [INFO] [stdout] 118 | pub fn new(file_io: W, term_io: T) -> Self { [INFO] [stdout] | ---------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | term: Arc::new(Mutex::new(term_io)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/logutil.rs:140:16 [INFO] [stdout] | [INFO] [stdout] 135 | f: F, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 140 | f(&mut CompoundRecordDecorator( [INFO] [stdout] | ________________^ [INFO] [stdout] 141 | | &*self.file, [INFO] [stdout] 142 | | &*self.term, [INFO] [stdout] 143 | | *LOG_TARGET [INFO] [stdout] 144 | | .read() [INFO] [stdout] 145 | | .expect("Failed to acquire write lock on the LOG_TARGET"), [INFO] [stdout] 146 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/logutil.rs:243:24 [INFO] [stdout] | [INFO] [stdout] 242 | let plain = slog_term::PlainSyncDecorator::new(std::io::stderr()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 243 | slog::Logger::root(slog_term::FullFormat::new(plain).build().fuse(), slog::o!()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `below-common` (lib test) due to 7 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "67889b5f5c4296c2f151501c42aea51cd523b73c558ae78d96bf2d5b821c0925", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "67889b5f5c4296c2f151501c42aea51cd523b73c558ae78d96bf2d5b821c0925", kill_on_drop: false }` [INFO] [stdout] 67889b5f5c4296c2f151501c42aea51cd523b73c558ae78d96bf2d5b821c0925