[INFO] fetching crate bellperson-nonnative 0.4.0... [INFO] checking bellperson-nonnative-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate bellperson-nonnative 0.4.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate bellperson-nonnative 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate bellperson-nonnative 0.4.0 [INFO] finished tweaking crates.io crate bellperson-nonnative 0.4.0 [INFO] tweaked toml for crates.io crate bellperson-nonnative 0.4.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 95 packages to latest compatible versions [INFO] [stderr] Adding bellperson v0.24.1 (latest: v0.26.0) [INFO] [stderr] Adding blstrs v0.6.2 (latest: v0.7.1) [INFO] [stderr] Adding ec-gpu-gen v0.5.2 (latest: v0.7.1) [INFO] [stderr] Adding env_logger v0.8.4 (latest: v0.11.5) [INFO] [stderr] Adding ff v0.12.1 (latest: v0.13.0) [INFO] [stderr] Adding ff_derive v0.12.1 (latest: v0.13.0) [INFO] [stderr] Adding flume v0.10.14 (latest: v0.11.0) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding group v0.12.1 (latest: v0.13.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding memmap2 v0.5.10 (latest: v0.9.4) [INFO] [stderr] Adding num-bigint v0.3.3 (latest: v0.4.6) [INFO] [stderr] Adding pairing v0.22.0 (latest: v0.23.0) [INFO] [stderr] Adding radium v0.7.0 (latest: v1.1.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding wyz v0.5.1 (latest: v0.6.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1e4d142f598688d605fac2bb799ad1ad555b6663de688e08b5388154e8ae61f3 [INFO] running `Command { std: "docker" "start" "-a" "1e4d142f598688d605fac2bb799ad1ad555b6663de688e08b5388154e8ae61f3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1e4d142f598688d605fac2bb799ad1ad555b6663de688e08b5388154e8ae61f3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1e4d142f598688d605fac2bb799ad1ad555b6663de688e08b5388154e8ae61f3", kill_on_drop: false }` [INFO] [stdout] 1e4d142f598688d605fac2bb799ad1ad555b6663de688e08b5388154e8ae61f3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4dcb0152a8fd30225eca39df2b53b918e42202fa2e0219d57f482b2f401ac7c6 [INFO] running `Command { std: "docker" "start" "-a" "4dcb0152a8fd30225eca39df2b53b918e42202fa2e0219d57f482b2f401ac7c6", kill_on_drop: false }` [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling radium v0.7.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling tap v1.0.1 [INFO] [stderr] Compiling num-bigint v0.3.3 [INFO] [stderr] Compiling execute-command-tokens v0.1.7 [INFO] [stderr] Compiling funty v2.0.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling blst v0.3.13 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling scopeguard v1.2.0 [INFO] [stderr] Compiling subtle v2.6.1 [INFO] [stderr] Compiling rand_xorshift v0.3.0 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling wyz v0.5.1 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling spin v0.9.8 [INFO] [stderr] Compiling crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling ec-gpu-gen v0.5.2 [INFO] [stderr] Compiling flume v0.10.14 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Compiling cpufeatures v0.2.13 [INFO] [stderr] Compiling crossbeam-channel v0.5.13 [INFO] [stderr] Compiling byte-slice-cast v1.2.2 [INFO] [stderr] Checking bitvec v1.0.1 [INFO] [stderr] Compiling ec-gpu v0.2.0 [INFO] [stderr] Compiling hex v0.4.3 [INFO] [stderr] Compiling yastl v0.1.2 [INFO] [stderr] Compiling crossbeam-deque v0.8.5 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking threadpool v1.8.1 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Compiling num-integer v0.1.46 [INFO] [stderr] Checking constant_time_eq v0.3.1 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking memmap2 v0.5.10 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling generic-array v1.1.0 [INFO] [stderr] Checking blake2s_simd v1.0.2 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling crypto-common v0.1.6 [INFO] [stderr] Compiling block-buffer v0.10.4 [INFO] [stderr] Compiling digest v0.10.7 [INFO] [stderr] Compiling sha2 v0.10.8 [INFO] [stderr] Compiling quickcheck_macros v1.0.0 [INFO] [stderr] Compiling addchain v0.2.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling ff v0.12.1 [INFO] [stderr] Compiling group v0.12.1 [INFO] [stderr] Compiling ff_derive v0.12.1 [INFO] [stderr] Compiling pairing v0.22.0 [INFO] [stderr] Checking env_logger v0.8.4 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling execute-command-macro-impl v0.1.10 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling execute-command-macro v0.1.9 [INFO] [stderr] Compiling execute v0.2.13 [INFO] [stderr] Compiling zeroize v1.8.1 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking quickcheck v1.0.3 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking blstrs v0.6.2 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Compiling bellperson v0.24.1 [INFO] [stderr] Checking bellperson-nonnative v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: method `grab_mut` is never used [INFO] [stdout] --> src/lib.rs:16:8 [INFO] [stdout] | [INFO] [stdout] 14 | trait OptionExt { [INFO] [stdout] | --------- method in this trait [INFO] [stdout] 15 | fn grab(&self) -> Result<&T, SynthesisError>; [INFO] [stdout] 16 | fn grab_mut(&mut self) -> Result<&mut T, SynthesisError>; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/gadget.rs:136:12 [INFO] [stdout] | [INFO] [stdout] 128 | mut cs: CS, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | let o0 = Gadget::mux(cs.namespace(|| "out 0"), s, i0, i1)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | let o1 = Gadget::mux(cs.namespace(|| "out 1"), ¬_s, i0, i1)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 136 | Ok((o0, o1)) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/lazy.rs:20:19 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new(f: F) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | Self { [INFO] [stdout] 20 | cell: Rc::new(RefCell::new(LazyCellInner::Unforced(f))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/lazy.rs:46:19 [INFO] [stdout] | [INFO] [stdout] 44 | fn from(t: T) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | Self { [INFO] [stdout] 46 | cell: Rc::new(RefCell::new(LazyCellInner::Forced(t))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mp/bignat.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 27 | limbs: I, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | limbs.rev().fold(BigInt::from(0), |mut acc, limb| { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mp/bignat.rs:142:30 [INFO] [stdout] | [INFO] [stdout] 142 | || match *values_cell.borrow() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mp/bignat.rs:219:13 [INFO] [stdout] | [INFO] [stdout] 210 | f: F, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 219 | f().and_then(|v| Ok((nat_to_limbs::(&v, limb_width, n_limbs)?, v))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mp/bignat.rs:228:30 [INFO] [stdout] | [INFO] [stdout] 228 | || match *all_values_cell.borrow() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mp/bignat.rs:806:41 [INFO] [stdout] | [INFO] [stdout] 795 | mut cs: CS, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 806 | self_grouped.equal_when_carried(cs.namespace(|| "grouped"), &other_grouped) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mp/bignat.rs:833:26 [INFO] [stdout] | [INFO] [stdout] 812 | mut cs: CS, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 833 | self.verify_mult(cs.namespace(|| "multcheck"), &factor, &other) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&BigInt` instead of cloning the inner type [INFO] [stdout] --> src/mp/bignat.rs:1293:32 [INFO] [stdout] | [INFO] [stdout] 1293 | || Ok(value.grab()?.clone().clone()), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bellperson-nonnative` (lib) due to 10 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: method `grab_mut` is never used [INFO] [stdout] --> src/lib.rs:16:8 [INFO] [stdout] | [INFO] [stdout] 14 | trait OptionExt { [INFO] [stdout] | --------- method in this trait [INFO] [stdout] 15 | fn grab(&self) -> Result<&T, SynthesisError>; [INFO] [stdout] 16 | fn grab_mut(&mut self) -> Result<&mut T, SynthesisError>; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/gadget.rs:136:12 [INFO] [stdout] | [INFO] [stdout] 128 | mut cs: CS, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | let o0 = Gadget::mux(cs.namespace(|| "out 0"), s, i0, i1)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | let o1 = Gadget::mux(cs.namespace(|| "out 1"), ¬_s, i0, i1)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 136 | Ok((o0, o1)) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/lazy.rs:20:19 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new(f: F) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | Self { [INFO] [stdout] 20 | cell: Rc::new(RefCell::new(LazyCellInner::Unforced(f))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/lazy.rs:46:19 [INFO] [stdout] | [INFO] [stdout] 44 | fn from(t: T) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | Self { [INFO] [stdout] 46 | cell: Rc::new(RefCell::new(LazyCellInner::Forced(t))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mp/bignat.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 27 | limbs: I, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | limbs.rev().fold(BigInt::from(0), |mut acc, limb| { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mp/bignat.rs:142:30 [INFO] [stdout] | [INFO] [stdout] 142 | || match *values_cell.borrow() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mp/bignat.rs:219:13 [INFO] [stdout] | [INFO] [stdout] 210 | f: F, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 219 | f().and_then(|v| Ok((nat_to_limbs::(&v, limb_width, n_limbs)?, v))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mp/bignat.rs:228:30 [INFO] [stdout] | [INFO] [stdout] 228 | || match *all_values_cell.borrow() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mp/bignat.rs:806:41 [INFO] [stdout] | [INFO] [stdout] 795 | mut cs: CS, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 806 | self_grouped.equal_when_carried(cs.namespace(|| "grouped"), &other_grouped) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mp/bignat.rs:833:26 [INFO] [stdout] | [INFO] [stdout] 812 | mut cs: CS, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 833 | self.verify_mult(cs.namespace(|| "multcheck"), &factor, &other) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&num_bigint::BigInt` instead of cloning the inner type [INFO] [stdout] --> src/mp/bignat.rs:1293:32 [INFO] [stdout] | [INFO] [stdout] 1293 | || Ok(value.grab()?.clone().clone()), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bellperson-nonnative` (lib test) due to 10 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "4dcb0152a8fd30225eca39df2b53b918e42202fa2e0219d57f482b2f401ac7c6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4dcb0152a8fd30225eca39df2b53b918e42202fa2e0219d57f482b2f401ac7c6", kill_on_drop: false }` [INFO] [stdout] 4dcb0152a8fd30225eca39df2b53b918e42202fa2e0219d57f482b2f401ac7c6