[INFO] fetching crate bellman_ce 0.8.0... [INFO] checking bellman_ce-0.8.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate bellman_ce 0.8.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate bellman_ce 0.8.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate bellman_ce 0.8.0 [INFO] finished tweaking crates.io crate bellman_ce 0.8.0 [INFO] tweaked toml for crates.io crate bellman_ce 0.8.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 76 packages to latest compatible versions [INFO] [stderr] Adding arrayvec v0.4.12 (latest: v0.7.6) [INFO] [stderr] Adding arrayvec v0.5.2 (latest: v0.7.6) [INFO] [stderr] Adding bit-vec v0.6.3 (latest: v0.8.0) [INFO] [stderr] Adding blake2s_simd v0.5.11 (latest: v1.0.2) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding constant_time_eq v0.1.5 (latest: v0.3.1) [INFO] [stderr] Adding crossbeam v0.7.3 (latest: v0.8.4) [INFO] [stderr] Adding crossbeam-channel v0.4.4 (latest: v0.5.13) [INFO] [stderr] Adding crossbeam-deque v0.7.4 (latest: v0.8.5) [INFO] [stderr] Adding crossbeam-epoch v0.8.2 (latest: v0.9.18) [INFO] [stderr] Adding crossbeam-queue v0.2.3 (latest: v0.3.11) [INFO] [stderr] Adding crossbeam-utils v0.7.2 (latest: v0.8.20) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding memoffset v0.5.6 (latest: v0.9.1) [INFO] [stderr] Adding rand v0.4.6 (latest: v0.8.5) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding rdrand v0.4.0 (latest: v0.8.3) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding tiny-keccak v1.5.0 (latest: v2.0.2) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `futures` dependency) [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] def01e2c2e8641fb9529c4fcf799e1a41f16de73f4201354db478c484348811b [INFO] running `Command { std: "docker" "start" "-a" "def01e2c2e8641fb9529c4fcf799e1a41f16de73f4201354db478c484348811b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "def01e2c2e8641fb9529c4fcf799e1a41f16de73f4201354db478c484348811b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "def01e2c2e8641fb9529c4fcf799e1a41f16de73f4201354db478c484348811b", kill_on_drop: false }` [INFO] [stdout] def01e2c2e8641fb9529c4fcf799e1a41f16de73f4201354db478c484348811b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bc4bc0ab68fbd6646fe81fac08b2e1867a4f977a67110710a0a159a317dfd059 [INFO] running `Command { std: "docker" "start" "-a" "bc4bc0ab68fbd6646fe81fac08b2e1867a4f977a67110710a0a159a317dfd059", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `futures` dependency) [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking constant_time_eq v0.1.5 [INFO] [stderr] Checking arrayref v0.3.8 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Checking crossbeam-channel v0.4.4 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking tiny-keccak v1.5.0 [INFO] [stderr] Checking blake2s_simd v0.5.11 [INFO] [stderr] Checking blake2s_const v0.8.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking crossbeam v0.7.3 [INFO] [stderr] Compiling num-integer v0.1.46 [INFO] [stderr] Compiling num-bigint v0.4.6 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Compiling ff_derive_ce v0.11.2 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking ff_ce v0.14.3 [INFO] [stderr] Checking pairing_ce v0.28.6 [INFO] [stderr] Checking bellman_ce v0.8.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: private item shadows public glob re-export [INFO] [stdout] --> src/lib.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | use crate::pairing::ff as ff; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the name `ff` in the type namespace is supposed to be publicly re-exported here [INFO] [stdout] --> src/lib.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | pub use pairing::*; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] note: but the private item here shadows it [INFO] [stdout] --> src/lib.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | use crate::pairing::ff as ff; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(hidden_glob_reexports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused attribute `allow` [INFO] [stdout] --> src/log.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | #[allow(unused_macros)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the built-in attribute `allow` will be ignored, since it's applied to the macro invocation `cfg_if` [INFO] [stdout] --> src/log.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | cfg_if! { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] = note: `#[warn(unused_attributes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `nightly` [INFO] [stdout] --> src/plonk/fft/mod.rs:9:7 [INFO] [stdout] | [INFO] [stdout] 9 | #[cfg(feature = "nightly")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `allocator`, `asm`, `blake2-rfc`, `blake2s_const`, `crossbeam`, `default`, `gm17`, `lazy_static`, `marlin`, `multicore`, `nolog`, `plonk`, `prefetch`, `redshift`, `sonic`, `tiny-keccak`, `wasm`, and `web-sys` [INFO] [stdout] = help: consider adding `nightly` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `nightly` [INFO] [stdout] --> src/plonk/fft/mod.rs:11:7 [INFO] [stdout] | [INFO] [stdout] 11 | #[cfg(feature = "nightly")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `allocator`, `asm`, `blake2-rfc`, `blake2s_const`, `crossbeam`, `default`, `gm17`, `lazy_static`, `marlin`, `multicore`, `nolog`, `plonk`, `prefetch`, `redshift`, `sonic`, `tiny-keccak`, `wasm`, and `web-sys` [INFO] [stdout] = help: consider adding `nightly` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `nightly` [INFO] [stdout] --> src/plonk/fft/mod.rs:13:7 [INFO] [stdout] | [INFO] [stdout] 13 | #[cfg(feature = "nightly")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `allocator`, `asm`, `blake2-rfc`, `blake2s_const`, `crossbeam`, `default`, `gm17`, `lazy_static`, `marlin`, `multicore`, `nolog`, `plonk`, `prefetch`, `redshift`, `sonic`, `tiny-keccak`, `wasm`, and `web-sys` [INFO] [stdout] = help: consider adding `nightly` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `nightly` [INFO] [stdout] --> src/plonk/fft/mod.rs:20:14 [INFO] [stdout] | [INFO] [stdout] 20 | if #[cfg(feature = "nightly")] { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `allocator`, `asm`, `blake2-rfc`, `blake2s_const`, `crossbeam`, `default`, `gm17`, `lazy_static`, `marlin`, `multicore`, `nolog`, `plonk`, `prefetch`, `redshift`, `sonic`, `tiny-keccak`, `wasm`, and `web-sys` [INFO] [stdout] = help: consider adding `nightly` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: private item shadows public glob re-export [INFO] [stdout] --> src/lib.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | use crate::pairing::ff as ff; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the name `ff` in the type namespace is supposed to be publicly re-exported here [INFO] [stdout] --> src/lib.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | pub use pairing::*; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] note: but the private item here shadows it [INFO] [stdout] --> src/lib.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | use crate::pairing::ff as ff; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(hidden_glob_reexports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused attribute `allow` [INFO] [stdout] --> src/log.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | #[allow(unused_macros)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the built-in attribute `allow` will be ignored, since it's applied to the macro invocation `cfg_if` [INFO] [stdout] --> src/log.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | cfg_if! { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] = note: `#[warn(unused_attributes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `nightly` [INFO] [stdout] --> src/plonk/fft/mod.rs:9:7 [INFO] [stdout] | [INFO] [stdout] 9 | #[cfg(feature = "nightly")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `allocator`, `asm`, `blake2-rfc`, `blake2s_const`, `crossbeam`, `default`, `gm17`, `lazy_static`, `marlin`, `multicore`, `nolog`, `plonk`, `prefetch`, `redshift`, `sonic`, `tiny-keccak`, `wasm`, and `web-sys` [INFO] [stdout] = help: consider adding `nightly` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `nightly` [INFO] [stdout] --> src/plonk/fft/mod.rs:11:7 [INFO] [stdout] | [INFO] [stdout] 11 | #[cfg(feature = "nightly")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `allocator`, `asm`, `blake2-rfc`, `blake2s_const`, `crossbeam`, `default`, `gm17`, `lazy_static`, `marlin`, `multicore`, `nolog`, `plonk`, `prefetch`, `redshift`, `sonic`, `tiny-keccak`, `wasm`, and `web-sys` [INFO] [stdout] = help: consider adding `nightly` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `nightly` [INFO] [stdout] --> src/plonk/fft/mod.rs:13:7 [INFO] [stdout] | [INFO] [stdout] 13 | #[cfg(feature = "nightly")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `allocator`, `asm`, `blake2-rfc`, `blake2s_const`, `crossbeam`, `default`, `gm17`, `lazy_static`, `marlin`, `multicore`, `nolog`, `plonk`, `prefetch`, `redshift`, `sonic`, `tiny-keccak`, `wasm`, and `web-sys` [INFO] [stdout] = help: consider adding `nightly` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `nightly` [INFO] [stdout] --> src/plonk/fft/mod.rs:20:14 [INFO] [stdout] | [INFO] [stdout] 20 | if #[cfg(feature = "nightly")] { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `allocator`, `asm`, `blake2-rfc`, `blake2s_const`, `crossbeam`, `default`, `gm17`, `lazy_static`, `marlin`, `multicore`, `nolog`, `plonk`, `prefetch`, `redshift`, `sonic`, `tiny-keccak`, `wasm`, and `web-sys` [INFO] [stdout] = help: consider adding `nightly` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/groth16/mod.rs:373:12 [INFO] [stdout] | [INFO] [stdout] 288 | mut reader: R, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 373 | Ok(Parameters { [INFO] [stdout] | ____________^ [INFO] [stdout] 374 | | vk: vk, [INFO] [stdout] 375 | | h: Arc::new(h), [INFO] [stdout] 376 | | l: Arc::new(l), [INFO] [stdout] ... | [INFO] [stdout] 379 | | b_g2: Arc::new(b_g2) [INFO] [stdout] 380 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/groth16/generator.rs:501:8 [INFO] [stdout] | [INFO] [stdout] 179 | circuit: C, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 246 | let worker = Worker::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 501 | Ok(Parameters { [INFO] [stdout] | ________^ [INFO] [stdout] 502 | | vk: vk, [INFO] [stdout] 503 | | h: Arc::new(h.into_iter().map(|e| e.into_affine()).collect()), [INFO] [stdout] 504 | | l: Arc::new(l.into_iter().map(|e| e.into_affine()).collect()), [INFO] [stdout] ... | [INFO] [stdout] 509 | | b_g2: Arc::new(b_g2.into_iter().filter(|e| !e.is_zero()).map(|e| e.into_affine()).collect()) [INFO] [stdout] 510 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plonk/adaptor/alternative.rs:1606:13 [INFO] [stdout] | [INFO] [stdout] 1599 | fn alloc(&mut self, _: A, f: F) -> Result [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1606 | f().map_err(|_| crate::SynthesisError::AssignmentMissing) [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plonk/adaptor/alternative.rs:1626:13 [INFO] [stdout] | [INFO] [stdout] 1618 | f: F, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1626 | f().map_err(|_| crate::SynthesisError::AssignmentMissing) [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plonk/adaptor/alternative.rs:1943:22 [INFO] [stdout] | [INFO] [stdout] 1939 | pub fn new<'b>(circuit: C, hints: &'b Vec<(usize, TranspilationVariant)>) -> Self [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1943 | circuit: Cell::new(Some(circuit)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plonk/generator/mod.rs:523:8 [INFO] [stdout] | [INFO] [stdout] 475 | pub fn setup, C: Circuit>(circuit: &C, meta: S::Meta) -> Result<(PlonkSetup, PlonkSetupAux... [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 482 | let worker = Worker::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 483 | [INFO] [stdout] 484 | let committer = S::new_for_size(n.next_power_of_two(), meta); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 488 | let (q_l, q_l_aux) = committer.commit_single(&q_l); [INFO] [stdout] | --- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 489 | let (q_r, q_r_aux) = committer.commit_single(&q_r); [INFO] [stdout] | --- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 490 | let (q_o, q_o_aux) = committer.commit_single(&q_o); [INFO] [stdout] | --- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 491 | let (q_m, q_m_aux) = committer.commit_single(&q_m); [INFO] [stdout] | --- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 492 | let (q_c, q_c_aux) = committer.commit_single(&q_c); [INFO] [stdout] | --- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 493 | let (s_id, s_id_aux) = committer.commit_single(&s_id); [INFO] [stdout] | ---- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 494 | let (sigma_1, sigma_1_aux) = committer.commit_single(&sigma_1); [INFO] [stdout] | ------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 495 | let (sigma_2, sigma_2_aux) = committer.commit_single(&sigma_2); [INFO] [stdout] | ------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 496 | let (sigma_3, sigma_3_aux) = committer.commit_single(&sigma_3); [INFO] [stdout] | ------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 497 | [INFO] [stdout] 498 | let setup = PlonkSetup:: { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 511 | let aux = PlonkSetupAuxData:: { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 523 | Ok((setup, aux)) [INFO] [stdout] | ^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bounds on generic parameters in type aliases are not enforced [INFO] [stdout] --> src/plonk/prover/mod.rs:654:13 [INFO] [stdout] | [INFO] [stdout] 654 | type Iop = TrivialBlake2sIOP; [INFO] [stdout] | ^^^^^^ will not be checked at usage sites of the type alias [INFO] [stdout] | [INFO] [stdout] = note: this is a known limitation of the type checker that may be lifted in a future edition. [INFO] [stdout] see issue #112792 for more information [INFO] [stdout] = help: add `#![feature(lazy_type_alias)]` to the crate attributes to enable the desired semantics [INFO] [stdout] = note: `#[warn(type_alias_bounds)]` on by default [INFO] [stdout] help: remove this bound [INFO] [stdout] | [INFO] [stdout] 654 - type Iop = TrivialBlake2sIOP; [INFO] [stdout] 654 + type Iop = TrivialBlake2sIOP; [INFO] [stdout] | [INFO] [stdout] help: fully qualify this associated type [INFO] [stdout] | [INFO] [stdout] 654 | type Iop = TrivialBlake2sIOP<::Fr>; [INFO] [stdout] | + +++++++++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bounds on generic parameters in type aliases are not enforced [INFO] [stdout] --> src/plonk/prover/mod.rs:655:13 [INFO] [stdout] | [INFO] [stdout] 655 | type Fri = NaiveFriIop>; [INFO] [stdout] | ^^^^^^ will not be checked at usage sites of the type alias [INFO] [stdout] | [INFO] [stdout] = note: this is a known limitation of the type checker that may be lifted in a future edition. [INFO] [stdout] see issue #112792 for more information [INFO] [stdout] = help: add `#![feature(lazy_type_alias)]` to the crate attributes to enable the desired semantics [INFO] [stdout] help: remove this bound [INFO] [stdout] | [INFO] [stdout] 655 - type Fri = NaiveFriIop>; [INFO] [stdout] 655 + type Fri = NaiveFriIop>; [INFO] [stdout] | [INFO] [stdout] help: fully qualify this associated type [INFO] [stdout] | [INFO] [stdout] 655 | type Fri = NaiveFriIop<::Fr, Iop>; [INFO] [stdout] | + +++++++++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plonk/commitments/transparent/mod.rs:116:14 [INFO] [stdout] | [INFO] [stdout] 114 | let original_tree = < < FRI as FriIop >::IopType as IOP >::create(&original_poly_lde.as_ref()); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | [INFO] [stdout] 116 | Some((original_poly_lde, original_tree)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plonk/commitments/transparent/mod.rs:137:22 [INFO] [stdout] | [INFO] [stdout] 131 | let original_tree = < < FRI as FriIop >::IopType as IOP >::create(&original_poly_lde.as_ref()); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | let commitment = original_tree.get_root(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | (commitment, Some((original_poly_lde, original_tree))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plonk/commitments/transparent/fri/naive_fri/naive_fri.rs:228:12 [INFO] [stdout] | [INFO] [stdout] 144 | let l0_commitment: I = I::create(lde_values.as_ref()); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 157 | let mut intermediate_commitments = vec![]; [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 168 | let mut roots = vec![]; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 218 | let final_root = roots.last().expect("will work").clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 228 | Ok(FRIProofPrototype { [INFO] [stdout] | ____________^ [INFO] [stdout] 229 | | l0_commitment, [INFO] [stdout] 230 | | intermediate_commitments, [INFO] [stdout] 231 | | intermediate_values, [INFO] [stdout] ... | [INFO] [stdout] 237 | | lde_factor, [INFO] [stdout] 238 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plonk/commitments/transparent/fri/naive_fri/naive_fri.rs:385:12 [INFO] [stdout] | [INFO] [stdout] 255 | let mut roots = vec![]; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 256 | let l0_commitment: I = I::create(lde_values.as_ref()); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 257 | let root = l0_commitment.get_root(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 274 | let mut intermediate_commitments = vec![]; [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 358 | let final_root = roots.last().expect("will work").clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 385 | Ok(FRIProofPrototype { [INFO] [stdout] | ____________^ [INFO] [stdout] 386 | | l0_commitment, [INFO] [stdout] 387 | | intermediate_commitments, [INFO] [stdout] 388 | | intermediate_values, [INFO] [stdout] ... | [INFO] [stdout] 394 | | lde_factor, [INFO] [stdout] 395 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plonk/better_cs/adaptor.rs:1632:13 [INFO] [stdout] | [INFO] [stdout] 1625 | fn alloc(&mut self, _: A, f: F) -> Result [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1632 | f().map_err(|_| crate::SynthesisError::AssignmentMissing) [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plonk/better_cs/adaptor.rs:1652:13 [INFO] [stdout] | [INFO] [stdout] 1644 | f: F, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1652 | f().map_err(|_| crate::SynthesisError::AssignmentMissing) [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plonk/better_cs/adaptor.rs:2076:22 [INFO] [stdout] | [INFO] [stdout] 2072 | pub fn new<'b>(circuit: C, hints: &'b Vec<(usize, TranspilationVariant)>) -> Self [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2076 | circuit: Cell::new(Some(circuit)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plonk/better_cs/keys.rs:308:8 [INFO] [stdout] | [INFO] [stdout] 300 | pub fn read_polynomial_coeffs(mut reader: R) -> std::io::Result> { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 308 | Ok(Polynomial::from_coeffs(poly_coeffs).expect("must fit into some domain")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plonk/better_cs/keys.rs:319:8 [INFO] [stdout] | [INFO] [stdout] 311 | pub fn read_polynomial_values_unpadded(mut reader: R) -> std::io::Result> { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 319 | Ok(Polynomial::from_values_unpadded(poly_values).expect("must fit into some domain")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plonk/better_cs/fma_adaptor.rs:1698:13 [INFO] [stdout] | [INFO] [stdout] 1691 | fn alloc(&mut self, _: A, f: F) -> Result [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1698 | f().map_err(|_| crate::SynthesisError::AssignmentMissing) [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plonk/better_cs/fma_adaptor.rs:1718:13 [INFO] [stdout] | [INFO] [stdout] 1710 | f: F, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1718 | f().map_err(|_| crate::SynthesisError::AssignmentMissing) [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plonk/better_cs/fma_adaptor.rs:2320:22 [INFO] [stdout] | [INFO] [stdout] 2316 | pub fn new<'b>(circuit: C, hints: &'b Vec<(usize, TranspilationVariant)>) -> Self [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2320 | circuit: Cell::new(Some(circuit)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plonk/better_better_cs/cs.rs:157:9 [INFO] [stdout] | [INFO] [stdout] 156 | fn into_internal(self) -> Box> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 157 | Box::from(self) as Box> [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/cs.rs:522:13 [INFO] [stdout] | [INFO] [stdout] 522 | drop(lde); [INFO] [stdout] | ^^^^^---^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&&data_structures::PolynomialProxy<'_, ::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 522 - drop(lde); [INFO] [stdout] 522 + let _ = lde; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a value that implements `Copy` does nothing [INFO] [stdout] --> src/plonk/better_better_cs/cs.rs:529:9 [INFO] [stdout] | [INFO] [stdout] 529 | drop(lde_without_dilation); [INFO] [stdout] | ^^^^^--------------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `std::option::Option<&data_structures::PolynomialProxy<'_, ::Fr, polynomials::Values>>` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_copy_types)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 529 - drop(lde_without_dilation); [INFO] [stdout] 529 + let _ = lde_without_dilation; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plonk/better_better_cs/lookup_tables.rs:105:29 [INFO] [stdout] | [INFO] [stdout] 97 | table: L, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | apply_over: Vec, [INFO] [stdout] 99 | name_generator: Option String) + 'static + Send + Sync>>, [INFO] [stdout] | ------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | table_to_apply: Box::from(table) as Box>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/proof/mod.rs:1269:17 [INFO] [stdout] | [INFO] [stdout] 1269 | drop(a_ref); [INFO] [stdout] | ^^^^^-----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 1269 - drop(a_ref); [INFO] [stdout] 1269 + let _ = a_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/proof/mod.rs:1282:17 [INFO] [stdout] | [INFO] [stdout] 1282 | drop(b_ref); [INFO] [stdout] | ^^^^^-----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 1282 - drop(b_ref); [INFO] [stdout] 1282 + let _ = b_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/proof/mod.rs:1292:17 [INFO] [stdout] | [INFO] [stdout] 1292 | drop(c_ref); [INFO] [stdout] | ^^^^^-----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 1292 - drop(c_ref); [INFO] [stdout] 1292 + let _ = c_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plonk/better_better_cs/gates/selector_optimized_with_d_next.rs:353:12 [INFO] [stdout] | [INFO] [stdout] 260 | fn format_term(mut instance: MainGateTerm, padding: Variable) -> Result<(SmallVec<[Variable; DEFAULT_SMALLVEC_CAPACITY]>, SmallVec... [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 264 | let mut flattened_variables = smallvec::smallvec![padding; 4]; [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 265 | let mut flattened_coefficients = smallvec::smallvec![E::Fr::zero(); 8]; [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 353 | Ok((flattened_variables, flattened_coefficients)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plonk/better_better_cs/gates/selector_optimized_with_d_next.rs:408:12 [INFO] [stdout] | [INFO] [stdout] 356 | fn format_linear_term_with_duplicates(mut instance: MainGateTerm, padding: Variable) -> Result<(SmallVec<[Variable; DEFAULT_SMALLV... [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 361 | let mut flattened_variables = smallvec::smallvec![padding; 4]; [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 362 | let mut flattened_coefficients = smallvec::smallvec![E::Fr::zero(); 8]; [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 408 | Ok((flattened_variables, flattened_coefficients)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/selector_optimized_with_d_next.rs:454:9 [INFO] [stdout] | [INFO] [stdout] 454 | drop(constants_poly_ref); [INFO] [stdout] | ^^^^^------------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Coefficients>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 454 - drop(constants_poly_ref); [INFO] [stdout] 454 + let _ = constants_poly_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/selector_optimized_with_d_next.rs:494:9 [INFO] [stdout] | [INFO] [stdout] 494 | drop(q_a_ref); [INFO] [stdout] | ^^^^^-------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 494 - drop(q_a_ref); [INFO] [stdout] 494 + let _ = q_a_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/selector_optimized_with_d_next.rs:495:9 [INFO] [stdout] | [INFO] [stdout] 495 | drop(a_ref); [INFO] [stdout] | ^^^^^-----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 495 - drop(a_ref); [INFO] [stdout] 495 + let _ = a_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/selector_optimized_with_d_next.rs:509:9 [INFO] [stdout] | [INFO] [stdout] 509 | drop(q_b_ref); [INFO] [stdout] | ^^^^^-------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 509 - drop(q_b_ref); [INFO] [stdout] 509 + let _ = q_b_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/selector_optimized_with_d_next.rs:510:9 [INFO] [stdout] | [INFO] [stdout] 510 | drop(b_ref); [INFO] [stdout] | ^^^^^-----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 510 - drop(b_ref); [INFO] [stdout] 510 + let _ = b_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/selector_optimized_with_d_next.rs:524:9 [INFO] [stdout] | [INFO] [stdout] 524 | drop(q_c_ref); [INFO] [stdout] | ^^^^^-------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 524 - drop(q_c_ref); [INFO] [stdout] 524 + let _ = q_c_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/selector_optimized_with_d_next.rs:525:9 [INFO] [stdout] | [INFO] [stdout] 525 | drop(c_ref); [INFO] [stdout] | ^^^^^-----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 525 - drop(c_ref); [INFO] [stdout] 525 + let _ = c_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/selector_optimized_with_d_next.rs:539:9 [INFO] [stdout] | [INFO] [stdout] 539 | drop(q_d_ref); [INFO] [stdout] | ^^^^^-------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 539 - drop(q_d_ref); [INFO] [stdout] 539 + let _ = q_d_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/selector_optimized_with_d_next.rs:540:9 [INFO] [stdout] | [INFO] [stdout] 540 | drop(d_ref); [INFO] [stdout] | ^^^^^-----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 540 - drop(d_ref); [INFO] [stdout] 540 + let _ = d_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/selector_optimized_with_d_next.rs:559:9 [INFO] [stdout] | [INFO] [stdout] 559 | drop(q_m_ab_ref); [INFO] [stdout] | ^^^^^----------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 559 - drop(q_m_ab_ref); [INFO] [stdout] 559 + let _ = q_m_ab_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/selector_optimized_with_d_next.rs:560:9 [INFO] [stdout] | [INFO] [stdout] 560 | drop(a_ref); [INFO] [stdout] | ^^^^^-----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 560 - drop(a_ref); [INFO] [stdout] 560 + let _ = a_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/selector_optimized_with_d_next.rs:561:9 [INFO] [stdout] | [INFO] [stdout] 561 | drop(b_ref); [INFO] [stdout] | ^^^^^-----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 561 - drop(b_ref); [INFO] [stdout] 561 + let _ = b_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/selector_optimized_with_d_next.rs:580:9 [INFO] [stdout] | [INFO] [stdout] 580 | drop(q_m_ac_ref); [INFO] [stdout] | ^^^^^----------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 580 - drop(q_m_ac_ref); [INFO] [stdout] 580 + let _ = q_m_ac_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/selector_optimized_with_d_next.rs:581:9 [INFO] [stdout] | [INFO] [stdout] 581 | drop(a_ref); [INFO] [stdout] | ^^^^^-----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 581 - drop(a_ref); [INFO] [stdout] 581 + let _ = a_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/selector_optimized_with_d_next.rs:582:9 [INFO] [stdout] | [INFO] [stdout] 582 | drop(c_ref); [INFO] [stdout] | ^^^^^-----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 582 - drop(c_ref); [INFO] [stdout] 582 + let _ = c_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/selector_optimized_with_d_next.rs:596:9 [INFO] [stdout] | [INFO] [stdout] 596 | drop(q_d_next_ref); [INFO] [stdout] | ^^^^^------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 596 - drop(q_d_next_ref); [INFO] [stdout] 596 + let _ = q_d_next_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/selector_optimized_with_d_next.rs:597:9 [INFO] [stdout] | [INFO] [stdout] 597 | drop(d_next_ref); [INFO] [stdout] | ^^^^^----------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 597 - drop(d_next_ref); [INFO] [stdout] 597 + let _ = d_next_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plonk/better_better_cs/gates/main_gate_with_d_next.rs:335:12 [INFO] [stdout] | [INFO] [stdout] 245 | fn format_term(mut instance: MainGateTerm, padding: Variable) -> Result<(SmallVec<[Variable; DEFAULT_SMALLVEC_CAPACITY]>, SmallVec... [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 246 | let mut flattened_variables = smallvec::smallvec![padding; 4]; [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 247 | let mut flattened_coefficients = smallvec::smallvec![E::Fr::zero(); 7]; [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 335 | Ok((flattened_variables, flattened_coefficients)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plonk/better_better_cs/gates/main_gate_with_d_next.rs:386:12 [INFO] [stdout] | [INFO] [stdout] 338 | fn format_linear_term_with_duplicates(mut instance: MainGateTerm, padding: Variable) -> Result<(SmallVec<[Variable; DEFAULT_SMALLV... [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 339 | let mut flattened_variables = smallvec::smallvec![padding; 4]; [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 340 | let mut flattened_coefficients = smallvec::smallvec![E::Fr::zero(); 7]; [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 386 | Ok((flattened_variables, flattened_coefficients)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/main_gate_with_d_next.rs:432:9 [INFO] [stdout] | [INFO] [stdout] 432 | drop(constants_poly_ref); [INFO] [stdout] | ^^^^^------------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Coefficients>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 432 - drop(constants_poly_ref); [INFO] [stdout] 432 + let _ = constants_poly_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/main_gate_with_d_next.rs:472:9 [INFO] [stdout] | [INFO] [stdout] 472 | drop(q_a_ref); [INFO] [stdout] | ^^^^^-------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 472 - drop(q_a_ref); [INFO] [stdout] 472 + let _ = q_a_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/main_gate_with_d_next.rs:473:9 [INFO] [stdout] | [INFO] [stdout] 473 | drop(a_ref); [INFO] [stdout] | ^^^^^-----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 473 - drop(a_ref); [INFO] [stdout] 473 + let _ = a_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/main_gate_with_d_next.rs:487:9 [INFO] [stdout] | [INFO] [stdout] 487 | drop(q_b_ref); [INFO] [stdout] | ^^^^^-------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 487 - drop(q_b_ref); [INFO] [stdout] 487 + let _ = q_b_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/main_gate_with_d_next.rs:488:9 [INFO] [stdout] | [INFO] [stdout] 488 | drop(b_ref); [INFO] [stdout] | ^^^^^-----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 488 - drop(b_ref); [INFO] [stdout] 488 + let _ = b_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/main_gate_with_d_next.rs:502:9 [INFO] [stdout] | [INFO] [stdout] 502 | drop(q_c_ref); [INFO] [stdout] | ^^^^^-------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 502 - drop(q_c_ref); [INFO] [stdout] 502 + let _ = q_c_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/main_gate_with_d_next.rs:503:9 [INFO] [stdout] | [INFO] [stdout] 503 | drop(c_ref); [INFO] [stdout] | ^^^^^-----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 503 - drop(c_ref); [INFO] [stdout] 503 + let _ = c_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/main_gate_with_d_next.rs:517:9 [INFO] [stdout] | [INFO] [stdout] 517 | drop(q_d_ref); [INFO] [stdout] | ^^^^^-------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 517 - drop(q_d_ref); [INFO] [stdout] 517 + let _ = q_d_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/main_gate_with_d_next.rs:518:9 [INFO] [stdout] | [INFO] [stdout] 518 | drop(d_ref); [INFO] [stdout] | ^^^^^-----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 518 - drop(d_ref); [INFO] [stdout] 518 + let _ = d_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/main_gate_with_d_next.rs:537:9 [INFO] [stdout] | [INFO] [stdout] 537 | drop(q_m_ref); [INFO] [stdout] | ^^^^^-------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 537 - drop(q_m_ref); [INFO] [stdout] 537 + let _ = q_m_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/main_gate_with_d_next.rs:538:9 [INFO] [stdout] | [INFO] [stdout] 538 | drop(a_ref); [INFO] [stdout] | ^^^^^-----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 538 - drop(a_ref); [INFO] [stdout] 538 + let _ = a_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/main_gate_with_d_next.rs:539:9 [INFO] [stdout] | [INFO] [stdout] 539 | drop(b_ref); [INFO] [stdout] | ^^^^^-----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 539 - drop(b_ref); [INFO] [stdout] 539 + let _ = b_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/main_gate_with_d_next.rs:553:9 [INFO] [stdout] | [INFO] [stdout] 553 | drop(q_d_next_ref); [INFO] [stdout] | ^^^^^------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 553 - drop(q_d_next_ref); [INFO] [stdout] 553 + let _ = q_d_next_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/main_gate_with_d_next.rs:554:9 [INFO] [stdout] | [INFO] [stdout] 554 | drop(d_next_ref); [INFO] [stdout] | ^^^^^----------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 554 - drop(d_next_ref); [INFO] [stdout] 554 + let _ = d_next_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source.rs:40:10 [INFO] [stdout] | [INFO] [stdout] 39 | fn new(self) -> (Arc>, usize) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | (self.0.clone(), self.1) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/multicore.rs:105:9 [INFO] [stdout] | [INFO] [stdout] 99 | f: F [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | / crossbeam::scope(|scope| { [INFO] [stdout] 106 | | f(scope, chunk_size) [INFO] [stdout] 107 | | }).expect("must run") [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 26 previous errors; 44 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bellman_ce` (lib) due to 27 previous errors; 44 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/groth16/mod.rs:373:12 [INFO] [stdout] | [INFO] [stdout] 288 | mut reader: R, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 373 | Ok(Parameters { [INFO] [stdout] | ____________^ [INFO] [stdout] 374 | | vk: vk, [INFO] [stdout] 375 | | h: Arc::new(h), [INFO] [stdout] 376 | | l: Arc::new(l), [INFO] [stdout] ... | [INFO] [stdout] 379 | | b_g2: Arc::new(b_g2) [INFO] [stdout] 380 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/groth16/generator.rs:501:8 [INFO] [stdout] | [INFO] [stdout] 179 | circuit: C, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 246 | let worker = Worker::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 501 | Ok(Parameters { [INFO] [stdout] | ________^ [INFO] [stdout] 502 | | vk: vk, [INFO] [stdout] 503 | | h: Arc::new(h.into_iter().map(|e| e.into_affine()).collect()), [INFO] [stdout] 504 | | l: Arc::new(l.into_iter().map(|e| e.into_affine()).collect()), [INFO] [stdout] ... | [INFO] [stdout] 509 | | b_g2: Arc::new(b_g2.into_iter().filter(|e| !e.is_zero()).map(|e| e.into_affine()).collect()) [INFO] [stdout] 510 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/groth16/mod.rs:506:58 [INFO] [stdout] | [INFO] [stdout] 506 | let a = cs.alloc(|| "a", || self.a.ok_or(SynthesisError::AssignmentMissing))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/groth16/mod.rs:507:58 [INFO] [stdout] | [INFO] [stdout] 507 | let b = cs.alloc(|| "b", || self.b.ok_or(SynthesisError::AssignmentMissing))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plonk/adaptor/alternative.rs:1606:13 [INFO] [stdout] | [INFO] [stdout] 1599 | fn alloc(&mut self, _: A, f: F) -> Result [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1606 | f().map_err(|_| crate::SynthesisError::AssignmentMissing) [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plonk/adaptor/alternative.rs:1626:13 [INFO] [stdout] | [INFO] [stdout] 1618 | f: F, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1626 | f().map_err(|_| crate::SynthesisError::AssignmentMissing) [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plonk/adaptor/alternative.rs:1943:22 [INFO] [stdout] | [INFO] [stdout] 1939 | pub fn new<'b>(circuit: C, hints: &'b Vec<(usize, TranspilationVariant)>) -> Self [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1943 | circuit: Cell::new(Some(circuit)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plonk/generator/mod.rs:523:8 [INFO] [stdout] | [INFO] [stdout] 475 | pub fn setup, C: Circuit>(circuit: &C, meta: S::Meta) -> Result<(PlonkSetup, PlonkSetupAux... [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 482 | let worker = Worker::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 483 | [INFO] [stdout] 484 | let committer = S::new_for_size(n.next_power_of_two(), meta); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 488 | let (q_l, q_l_aux) = committer.commit_single(&q_l); [INFO] [stdout] | --- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 489 | let (q_r, q_r_aux) = committer.commit_single(&q_r); [INFO] [stdout] | --- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 490 | let (q_o, q_o_aux) = committer.commit_single(&q_o); [INFO] [stdout] | --- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 491 | let (q_m, q_m_aux) = committer.commit_single(&q_m); [INFO] [stdout] | --- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 492 | let (q_c, q_c_aux) = committer.commit_single(&q_c); [INFO] [stdout] | --- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 493 | let (s_id, s_id_aux) = committer.commit_single(&s_id); [INFO] [stdout] | ---- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 494 | let (sigma_1, sigma_1_aux) = committer.commit_single(&sigma_1); [INFO] [stdout] | ------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 495 | let (sigma_2, sigma_2_aux) = committer.commit_single(&sigma_2); [INFO] [stdout] | ------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 496 | let (sigma_3, sigma_3_aux) = committer.commit_single(&sigma_3); [INFO] [stdout] | ------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 497 | [INFO] [stdout] 498 | let setup = PlonkSetup:: { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 511 | let aux = PlonkSetupAuxData:: { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 523 | Ok((setup, aux)) [INFO] [stdout] | ^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bounds on generic parameters in type aliases are not enforced [INFO] [stdout] --> src/plonk/prover/mod.rs:654:13 [INFO] [stdout] | [INFO] [stdout] 654 | type Iop = TrivialBlake2sIOP; [INFO] [stdout] | ^^^^^^ will not be checked at usage sites of the type alias [INFO] [stdout] | [INFO] [stdout] = note: this is a known limitation of the type checker that may be lifted in a future edition. [INFO] [stdout] see issue #112792 for more information [INFO] [stdout] = help: add `#![feature(lazy_type_alias)]` to the crate attributes to enable the desired semantics [INFO] [stdout] = note: `#[warn(type_alias_bounds)]` on by default [INFO] [stdout] help: remove this bound [INFO] [stdout] | [INFO] [stdout] 654 - type Iop = TrivialBlake2sIOP; [INFO] [stdout] 654 + type Iop = TrivialBlake2sIOP; [INFO] [stdout] | [INFO] [stdout] help: fully qualify this associated type [INFO] [stdout] | [INFO] [stdout] 654 | type Iop = TrivialBlake2sIOP<::Fr>; [INFO] [stdout] | + +++++++++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bounds on generic parameters in type aliases are not enforced [INFO] [stdout] --> src/plonk/prover/mod.rs:655:13 [INFO] [stdout] | [INFO] [stdout] 655 | type Fri = NaiveFriIop>; [INFO] [stdout] | ^^^^^^ will not be checked at usage sites of the type alias [INFO] [stdout] | [INFO] [stdout] = note: this is a known limitation of the type checker that may be lifted in a future edition. [INFO] [stdout] see issue #112792 for more information [INFO] [stdout] = help: add `#![feature(lazy_type_alias)]` to the crate attributes to enable the desired semantics [INFO] [stdout] help: remove this bound [INFO] [stdout] | [INFO] [stdout] 655 - type Fri = NaiveFriIop>; [INFO] [stdout] 655 + type Fri = NaiveFriIop>; [INFO] [stdout] | [INFO] [stdout] help: fully qualify this associated type [INFO] [stdout] | [INFO] [stdout] 655 | type Fri = NaiveFriIop<::Fr, Iop>; [INFO] [stdout] | + +++++++++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plonk/commitments/transparent/mod.rs:116:14 [INFO] [stdout] | [INFO] [stdout] 114 | let original_tree = < < FRI as FriIop >::IopType as IOP >::create(&original_poly_lde.as_ref()); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | [INFO] [stdout] 116 | Some((original_poly_lde, original_tree)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plonk/commitments/transparent/mod.rs:137:22 [INFO] [stdout] | [INFO] [stdout] 131 | let original_tree = < < FRI as FriIop >::IopType as IOP >::create(&original_poly_lde.as_ref()); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | let commitment = original_tree.get_root(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | (commitment, Some((original_poly_lde, original_tree))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plonk/commitments/transparent/fri/naive_fri/naive_fri.rs:228:12 [INFO] [stdout] | [INFO] [stdout] 144 | let l0_commitment: I = I::create(lde_values.as_ref()); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 157 | let mut intermediate_commitments = vec![]; [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 168 | let mut roots = vec![]; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 218 | let final_root = roots.last().expect("will work").clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 228 | Ok(FRIProofPrototype { [INFO] [stdout] | ____________^ [INFO] [stdout] 229 | | l0_commitment, [INFO] [stdout] 230 | | intermediate_commitments, [INFO] [stdout] 231 | | intermediate_values, [INFO] [stdout] ... | [INFO] [stdout] 237 | | lde_factor, [INFO] [stdout] 238 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plonk/commitments/transparent/fri/naive_fri/naive_fri.rs:385:12 [INFO] [stdout] | [INFO] [stdout] 255 | let mut roots = vec![]; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 256 | let l0_commitment: I = I::create(lde_values.as_ref()); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 257 | let root = l0_commitment.get_root(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 274 | let mut intermediate_commitments = vec![]; [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 358 | let final_root = roots.last().expect("will work").clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 385 | Ok(FRIProofPrototype { [INFO] [stdout] | ____________^ [INFO] [stdout] 386 | | l0_commitment, [INFO] [stdout] 387 | | intermediate_commitments, [INFO] [stdout] 388 | | intermediate_values, [INFO] [stdout] ... | [INFO] [stdout] 394 | | lde_factor, [INFO] [stdout] 395 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plonk/better_cs/adaptor.rs:1632:13 [INFO] [stdout] | [INFO] [stdout] 1625 | fn alloc(&mut self, _: A, f: F) -> Result [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1632 | f().map_err(|_| crate::SynthesisError::AssignmentMissing) [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plonk/better_cs/adaptor.rs:1652:13 [INFO] [stdout] | [INFO] [stdout] 1644 | f: F, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1652 | f().map_err(|_| crate::SynthesisError::AssignmentMissing) [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plonk/better_cs/adaptor.rs:2076:22 [INFO] [stdout] | [INFO] [stdout] 2072 | pub fn new<'b>(circuit: C, hints: &'b Vec<(usize, TranspilationVariant)>) -> Self [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2076 | circuit: Cell::new(Some(circuit)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plonk/better_cs/keys.rs:308:8 [INFO] [stdout] | [INFO] [stdout] 300 | pub fn read_polynomial_coeffs(mut reader: R) -> std::io::Result> { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 308 | Ok(Polynomial::from_coeffs(poly_coeffs).expect("must fit into some domain")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plonk/better_cs/keys.rs:319:8 [INFO] [stdout] | [INFO] [stdout] 311 | pub fn read_polynomial_values_unpadded(mut reader: R) -> std::io::Result> { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 319 | Ok(Polynomial::from_values_unpadded(poly_values).expect("must fit into some domain")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plonk/better_cs/fma_adaptor.rs:1698:13 [INFO] [stdout] | [INFO] [stdout] 1691 | fn alloc(&mut self, _: A, f: F) -> Result [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1698 | f().map_err(|_| crate::SynthesisError::AssignmentMissing) [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plonk/better_cs/fma_adaptor.rs:1718:13 [INFO] [stdout] | [INFO] [stdout] 1710 | f: F, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1718 | f().map_err(|_| crate::SynthesisError::AssignmentMissing) [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plonk/better_cs/fma_adaptor.rs:2320:22 [INFO] [stdout] | [INFO] [stdout] 2316 | pub fn new<'b>(circuit: C, hints: &'b Vec<(usize, TranspilationVariant)>) -> Self [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2320 | circuit: Cell::new(Some(circuit)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plonk/better_better_cs/cs.rs:157:9 [INFO] [stdout] | [INFO] [stdout] 156 | fn into_internal(self) -> Box> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 157 | Box::from(self) as Box> [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/cs.rs:522:13 [INFO] [stdout] | [INFO] [stdout] 522 | drop(lde); [INFO] [stdout] | ^^^^^---^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&&data_structures::PolynomialProxy<'_, ::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 522 - drop(lde); [INFO] [stdout] 522 + let _ = lde; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a value that implements `Copy` does nothing [INFO] [stdout] --> src/plonk/better_better_cs/cs.rs:529:9 [INFO] [stdout] | [INFO] [stdout] 529 | drop(lde_without_dilation); [INFO] [stdout] | ^^^^^--------------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `std::option::Option<&data_structures::PolynomialProxy<'_, ::Fr, polynomials::Values>>` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_copy_types)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 529 - drop(lde_without_dilation); [INFO] [stdout] 529 + let _ = lde_without_dilation; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/cs.rs:3771:13 [INFO] [stdout] | [INFO] [stdout] 3771 | drop(a_ref); [INFO] [stdout] | ^^^^^-----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 3771 - drop(a_ref); [INFO] [stdout] 3771 + let _ = a_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plonk/better_better_cs/lookup_tables.rs:105:29 [INFO] [stdout] | [INFO] [stdout] 97 | table: L, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | apply_over: Vec, [INFO] [stdout] 99 | name_generator: Option String) + 'static + Send + Sync>>, [INFO] [stdout] | ------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | table_to_apply: Box::from(table) as Box>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/proof/mod.rs:1269:17 [INFO] [stdout] | [INFO] [stdout] 1269 | drop(a_ref); [INFO] [stdout] | ^^^^^-----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 1269 - drop(a_ref); [INFO] [stdout] 1269 + let _ = a_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/proof/mod.rs:1282:17 [INFO] [stdout] | [INFO] [stdout] 1282 | drop(b_ref); [INFO] [stdout] | ^^^^^-----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 1282 - drop(b_ref); [INFO] [stdout] 1282 + let _ = b_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/proof/mod.rs:1292:17 [INFO] [stdout] | [INFO] [stdout] 1292 | drop(c_ref); [INFO] [stdout] | ^^^^^-----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 1292 - drop(c_ref); [INFO] [stdout] 1292 + let _ = c_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plonk/better_better_cs/gates/selector_optimized_with_d_next.rs:353:12 [INFO] [stdout] | [INFO] [stdout] 260 | fn format_term(mut instance: MainGateTerm, padding: Variable) -> Result<(SmallVec<[Variable; DEFAULT_SMALLVEC_CAPACITY]>, SmallVec... [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 264 | let mut flattened_variables = smallvec::smallvec![padding; 4]; [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 265 | let mut flattened_coefficients = smallvec::smallvec![E::Fr::zero(); 8]; [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 353 | Ok((flattened_variables, flattened_coefficients)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plonk/better_better_cs/gates/selector_optimized_with_d_next.rs:408:12 [INFO] [stdout] | [INFO] [stdout] 356 | fn format_linear_term_with_duplicates(mut instance: MainGateTerm, padding: Variable) -> Result<(SmallVec<[Variable; DEFAULT_SMALLV... [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 361 | let mut flattened_variables = smallvec::smallvec![padding; 4]; [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 362 | let mut flattened_coefficients = smallvec::smallvec![E::Fr::zero(); 8]; [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 408 | Ok((flattened_variables, flattened_coefficients)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/selector_optimized_with_d_next.rs:454:9 [INFO] [stdout] | [INFO] [stdout] 454 | drop(constants_poly_ref); [INFO] [stdout] | ^^^^^------------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Coefficients>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 454 - drop(constants_poly_ref); [INFO] [stdout] 454 + let _ = constants_poly_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/selector_optimized_with_d_next.rs:494:9 [INFO] [stdout] | [INFO] [stdout] 494 | drop(q_a_ref); [INFO] [stdout] | ^^^^^-------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 494 - drop(q_a_ref); [INFO] [stdout] 494 + let _ = q_a_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/selector_optimized_with_d_next.rs:495:9 [INFO] [stdout] | [INFO] [stdout] 495 | drop(a_ref); [INFO] [stdout] | ^^^^^-----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 495 - drop(a_ref); [INFO] [stdout] 495 + let _ = a_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/selector_optimized_with_d_next.rs:509:9 [INFO] [stdout] | [INFO] [stdout] 509 | drop(q_b_ref); [INFO] [stdout] | ^^^^^-------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 509 - drop(q_b_ref); [INFO] [stdout] 509 + let _ = q_b_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/selector_optimized_with_d_next.rs:510:9 [INFO] [stdout] | [INFO] [stdout] 510 | drop(b_ref); [INFO] [stdout] | ^^^^^-----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 510 - drop(b_ref); [INFO] [stdout] 510 + let _ = b_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/selector_optimized_with_d_next.rs:524:9 [INFO] [stdout] | [INFO] [stdout] 524 | drop(q_c_ref); [INFO] [stdout] | ^^^^^-------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 524 - drop(q_c_ref); [INFO] [stdout] 524 + let _ = q_c_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/selector_optimized_with_d_next.rs:525:9 [INFO] [stdout] | [INFO] [stdout] 525 | drop(c_ref); [INFO] [stdout] | ^^^^^-----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 525 - drop(c_ref); [INFO] [stdout] 525 + let _ = c_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/selector_optimized_with_d_next.rs:539:9 [INFO] [stdout] | [INFO] [stdout] 539 | drop(q_d_ref); [INFO] [stdout] | ^^^^^-------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 539 - drop(q_d_ref); [INFO] [stdout] 539 + let _ = q_d_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/selector_optimized_with_d_next.rs:540:9 [INFO] [stdout] | [INFO] [stdout] 540 | drop(d_ref); [INFO] [stdout] | ^^^^^-----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 540 - drop(d_ref); [INFO] [stdout] 540 + let _ = d_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/selector_optimized_with_d_next.rs:559:9 [INFO] [stdout] | [INFO] [stdout] 559 | drop(q_m_ab_ref); [INFO] [stdout] | ^^^^^----------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 559 - drop(q_m_ab_ref); [INFO] [stdout] 559 + let _ = q_m_ab_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/selector_optimized_with_d_next.rs:560:9 [INFO] [stdout] | [INFO] [stdout] 560 | drop(a_ref); [INFO] [stdout] | ^^^^^-----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 560 - drop(a_ref); [INFO] [stdout] 560 + let _ = a_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/selector_optimized_with_d_next.rs:561:9 [INFO] [stdout] | [INFO] [stdout] 561 | drop(b_ref); [INFO] [stdout] | ^^^^^-----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 561 - drop(b_ref); [INFO] [stdout] 561 + let _ = b_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/selector_optimized_with_d_next.rs:580:9 [INFO] [stdout] | [INFO] [stdout] 580 | drop(q_m_ac_ref); [INFO] [stdout] | ^^^^^----------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 580 - drop(q_m_ac_ref); [INFO] [stdout] 580 + let _ = q_m_ac_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/selector_optimized_with_d_next.rs:581:9 [INFO] [stdout] | [INFO] [stdout] 581 | drop(a_ref); [INFO] [stdout] | ^^^^^-----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 581 - drop(a_ref); [INFO] [stdout] 581 + let _ = a_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/selector_optimized_with_d_next.rs:582:9 [INFO] [stdout] | [INFO] [stdout] 582 | drop(c_ref); [INFO] [stdout] | ^^^^^-----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 582 - drop(c_ref); [INFO] [stdout] 582 + let _ = c_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/selector_optimized_with_d_next.rs:596:9 [INFO] [stdout] | [INFO] [stdout] 596 | drop(q_d_next_ref); [INFO] [stdout] | ^^^^^------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 596 - drop(q_d_next_ref); [INFO] [stdout] 596 + let _ = q_d_next_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/selector_optimized_with_d_next.rs:597:9 [INFO] [stdout] | [INFO] [stdout] 597 | drop(d_next_ref); [INFO] [stdout] | ^^^^^----------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 597 - drop(d_next_ref); [INFO] [stdout] 597 + let _ = d_next_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plonk/better_better_cs/gates/main_gate_with_d_next.rs:335:12 [INFO] [stdout] | [INFO] [stdout] 245 | fn format_term(mut instance: MainGateTerm, padding: Variable) -> Result<(SmallVec<[Variable; DEFAULT_SMALLVEC_CAPACITY]>, SmallVec... [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 246 | let mut flattened_variables = smallvec::smallvec![padding; 4]; [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 247 | let mut flattened_coefficients = smallvec::smallvec![E::Fr::zero(); 7]; [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 335 | Ok((flattened_variables, flattened_coefficients)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plonk/better_better_cs/gates/main_gate_with_d_next.rs:386:12 [INFO] [stdout] | [INFO] [stdout] 338 | fn format_linear_term_with_duplicates(mut instance: MainGateTerm, padding: Variable) -> Result<(SmallVec<[Variable; DEFAULT_SMALLV... [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 339 | let mut flattened_variables = smallvec::smallvec![padding; 4]; [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 340 | let mut flattened_coefficients = smallvec::smallvec![E::Fr::zero(); 7]; [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 386 | Ok((flattened_variables, flattened_coefficients)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/main_gate_with_d_next.rs:432:9 [INFO] [stdout] | [INFO] [stdout] 432 | drop(constants_poly_ref); [INFO] [stdout] | ^^^^^------------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Coefficients>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 432 - drop(constants_poly_ref); [INFO] [stdout] 432 + let _ = constants_poly_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/main_gate_with_d_next.rs:472:9 [INFO] [stdout] | [INFO] [stdout] 472 | drop(q_a_ref); [INFO] [stdout] | ^^^^^-------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 472 - drop(q_a_ref); [INFO] [stdout] 472 + let _ = q_a_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/main_gate_with_d_next.rs:473:9 [INFO] [stdout] | [INFO] [stdout] 473 | drop(a_ref); [INFO] [stdout] | ^^^^^-----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 473 - drop(a_ref); [INFO] [stdout] 473 + let _ = a_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/main_gate_with_d_next.rs:487:9 [INFO] [stdout] | [INFO] [stdout] 487 | drop(q_b_ref); [INFO] [stdout] | ^^^^^-------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 487 - drop(q_b_ref); [INFO] [stdout] 487 + let _ = q_b_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/main_gate_with_d_next.rs:488:9 [INFO] [stdout] | [INFO] [stdout] 488 | drop(b_ref); [INFO] [stdout] | ^^^^^-----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 488 - drop(b_ref); [INFO] [stdout] 488 + let _ = b_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/main_gate_with_d_next.rs:502:9 [INFO] [stdout] | [INFO] [stdout] 502 | drop(q_c_ref); [INFO] [stdout] | ^^^^^-------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 502 - drop(q_c_ref); [INFO] [stdout] 502 + let _ = q_c_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/main_gate_with_d_next.rs:503:9 [INFO] [stdout] | [INFO] [stdout] 503 | drop(c_ref); [INFO] [stdout] | ^^^^^-----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 503 - drop(c_ref); [INFO] [stdout] 503 + let _ = c_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/main_gate_with_d_next.rs:517:9 [INFO] [stdout] | [INFO] [stdout] 517 | drop(q_d_ref); [INFO] [stdout] | ^^^^^-------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 517 - drop(q_d_ref); [INFO] [stdout] 517 + let _ = q_d_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/main_gate_with_d_next.rs:518:9 [INFO] [stdout] | [INFO] [stdout] 518 | drop(d_ref); [INFO] [stdout] | ^^^^^-----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 518 - drop(d_ref); [INFO] [stdout] 518 + let _ = d_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/main_gate_with_d_next.rs:537:9 [INFO] [stdout] | [INFO] [stdout] 537 | drop(q_m_ref); [INFO] [stdout] | ^^^^^-------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 537 - drop(q_m_ref); [INFO] [stdout] 537 + let _ = q_m_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/main_gate_with_d_next.rs:538:9 [INFO] [stdout] | [INFO] [stdout] 538 | drop(a_ref); [INFO] [stdout] | ^^^^^-----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 538 - drop(a_ref); [INFO] [stdout] 538 + let _ = a_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/main_gate_with_d_next.rs:539:9 [INFO] [stdout] | [INFO] [stdout] 539 | drop(b_ref); [INFO] [stdout] | ^^^^^-----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 539 - drop(b_ref); [INFO] [stdout] 539 + let _ = b_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/main_gate_with_d_next.rs:553:9 [INFO] [stdout] | [INFO] [stdout] 553 | drop(q_d_next_ref); [INFO] [stdout] | ^^^^^------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 553 - drop(q_d_next_ref); [INFO] [stdout] 553 + let _ = q_d_next_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/plonk/better_better_cs/gates/main_gate_with_d_next.rs:554:9 [INFO] [stdout] | [INFO] [stdout] 554 | drop(d_next_ref); [INFO] [stdout] | ^^^^^----------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&polynomials::Polynomial<::Fr, polynomials::Values>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 554 - drop(d_next_ref); [INFO] [stdout] 554 + let _ = d_next_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source.rs:40:10 [INFO] [stdout] | [INFO] [stdout] 39 | fn new(self) -> (Arc>, usize) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | (self.0.clone(), self.1) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `A` should have a snake case name [INFO] [stdout] --> src/multiexp.rs:1022:13 [INFO] [stdout] | [INFO] [stdout] 1022 | let A = (0..size).map(|_| ::G1::rand(rng)).collect::>(); [INFO] [stdout] | ^ help: convert the identifier to snake case: `a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `B` should have a snake case name [INFO] [stdout] --> src/multiexp.rs:1023:13 [INFO] [stdout] | [INFO] [stdout] 1023 | let B = (0..size).map(|_| ::G1::rand(rng)).collect::>(); [INFO] [stdout] | ^ help: convert the identifier to snake case: `b` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `C` should have a snake case name [INFO] [stdout] --> src/multiexp.rs:1027:13 [INFO] [stdout] | [INFO] [stdout] 1027 | let C = (0..size).map(|i| { [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `c` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `A` should have a snake case name [INFO] [stdout] --> src/multiexp.rs:1047:13 [INFO] [stdout] | [INFO] [stdout] 1047 | let A = (0..size).map(|_| ::G1::rand(rng)).collect::>(); [INFO] [stdout] | ^ help: convert the identifier to snake case: `a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `B` should have a snake case name [INFO] [stdout] --> src/multiexp.rs:1051:13 [INFO] [stdout] | [INFO] [stdout] 1051 | let B = (0..size).map(|i| { [INFO] [stdout] | ^ help: convert the identifier to snake case: `b` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `bench_Pippenger_with_small_chunk` should have a snake case name [INFO] [stdout] --> src/multiexp.rs:1064:8 [INFO] [stdout] | [INFO] [stdout] 1064 | fn bench_Pippenger_with_small_chunk() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `bench_pippenger_with_small_chunk` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/multicore.rs:105:9 [INFO] [stdout] | [INFO] [stdout] 99 | f: F [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | / crossbeam::scope(|scope| { [INFO] [stdout] 106 | | f(scope, chunk_size) [INFO] [stdout] 107 | | }).expect("must run") [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 28 previous errors; 51 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bellman_ce` (lib test) due to 29 previous errors; 51 warnings emitted [INFO] running `Command { std: "docker" "inspect" "bc4bc0ab68fbd6646fe81fac08b2e1867a4f977a67110710a0a159a317dfd059", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bc4bc0ab68fbd6646fe81fac08b2e1867a4f977a67110710a0a159a317dfd059", kill_on_drop: false }` [INFO] [stdout] bc4bc0ab68fbd6646fe81fac08b2e1867a4f977a67110710a0a159a317dfd059