[INFO] fetching crate beatrice 0.3.2... [INFO] checking beatrice-0.3.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate beatrice 0.3.2 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate beatrice 0.3.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate beatrice 0.3.2 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate beatrice 0.3.2 [INFO] tweaked toml for crates.io crate beatrice 0.3.2 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate beatrice 0.3.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9e8658f2834b65d06353155925b91c152455ee3bf9e00488158e622b89095399 [INFO] running `Command { std: "docker" "start" "-a" "9e8658f2834b65d06353155925b91c152455ee3bf9e00488158e622b89095399", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9e8658f2834b65d06353155925b91c152455ee3bf9e00488158e622b89095399", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9e8658f2834b65d06353155925b91c152455ee3bf9e00488158e622b89095399", kill_on_drop: false }` [INFO] [stdout] 9e8658f2834b65d06353155925b91c152455ee3bf9e00488158e622b89095399 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 26667ae4817be35b7dbed35968c63c89e71b7b1c43e74ecf2707398b80093fad [INFO] running `Command { std: "docker" "start" "-a" "26667ae4817be35b7dbed35968c63c89e71b7b1c43e74ecf2707398b80093fad", kill_on_drop: false }` [INFO] [stderr] Compiling futures-core v0.3.21 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Checking cache-padded v1.2.0 [INFO] [stderr] Compiling safe-proc-macro2 v1.0.36 [INFO] [stderr] Checking futures-io v0.3.21 [INFO] [stderr] Checking fastrand v1.7.0 [INFO] [stderr] Checking once_cell v1.12.0 [INFO] [stderr] Checking event-listener v2.5.2 [INFO] [stderr] Checking pin-project-lite v0.2.9 [INFO] [stderr] Checking waker-fn v1.1.0 [INFO] [stderr] Compiling unicode-xid v0.2.3 [INFO] [stderr] Checking parking v2.0.0 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Checking matches v0.1.9 [INFO] [stderr] Checking atomic-waker v1.0.0 [INFO] [stderr] Checking async-task v4.2.0 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Checking slab v0.4.6 [INFO] [stderr] Checking unicode-bidi v0.3.8 [INFO] [stderr] Checking concurrent-queue v1.2.2 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking async-lock v2.5.0 [INFO] [stderr] Checking safina-sync v0.2.4 [INFO] [stderr] Checking safina-threadpool v0.2.4 [INFO] [stderr] Checking safina-timer v0.1.11 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Checking fixed-buffer v0.5.0 [INFO] [stderr] Checking temp-file v0.1.7 [INFO] [stderr] Checking temp-dir v0.1.11 [INFO] [stderr] Checking permit v0.1.4 [INFO] [stderr] Checking async-channel v1.6.1 [INFO] [stderr] Checking safina-executor v0.3.3 [INFO] [stderr] Compiling safe-quote v1.0.15 [INFO] [stderr] Checking futures-lite v1.12.0 [INFO] [stderr] Compiling safe-regex-compiler v0.2.5 [INFO] [stderr] Checking unicode-normalization v0.1.19 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Checking polling v2.2.0 [INFO] [stderr] Compiling safe-regex-macro v0.2.5 [INFO] [stderr] Checking blocking v1.2.0 [INFO] [stderr] Checking async-io v1.7.0 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking async-fs v1.5.0 [INFO] [stderr] Checking safe-regex v0.2.5 [INFO] [stderr] Checking async-net v1.6.1 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Checking beatrice v0.3.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:378:13 [INFO] [stdout] | [INFO] [stdout] 371 | request_handler: F, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 376 | let async_request_handler = |req: Request| async move { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 377 | let request_handler_clone = request_handler.clone(); [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 378 | / safina_executor::schedule_blocking(move || request_handler_clone(req)) [INFO] [stdout] 379 | | .await [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/body_reader.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn file(path: impl AsRef) -> Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | Ok(Self::File(std::fs::File::open(path.as_ref())?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response.rs:111:9 [INFO] [stdout] | [INFO] [stdout] 110 | pub fn html(code: u16, body: impl Into) -> Self { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | Self::new(code).with_type(ContentType::Html).with_body(body) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response.rs:129:13 [INFO] [stdout] | [INFO] [stdout] 127 | let (sender, receiver) = sync_channel(50); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | ( [INFO] [stdout] 129 | EventSender(Some(sender)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response.rs:130:13 [INFO] [stdout] | [INFO] [stdout] 127 | let (sender, receiver) = sync_channel(50); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | / Self::new(200) [INFO] [stdout] 131 | | .with_type(ContentType::EventStream) [INFO] [stdout] 132 | | .with_body(ResponseBody::EventStream(Mutex::new(EventReceiver( [INFO] [stdout] 133 | | receiver, [INFO] [stdout] 134 | | )))), [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response.rs:140:9 [INFO] [stdout] | [INFO] [stdout] 139 | pub fn text(code: u16, body: impl Into) -> Self { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 140 | / Self::new(code) [INFO] [stdout] 141 | | .with_type(ContentType::PlainText) [INFO] [stdout] | |______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response.rs:155:9 [INFO] [stdout] | [INFO] [stdout] 154 | pub fn redirect_303(location: impl AsRef) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | Response::new(303).with_header("location", location.as_ref().try_into().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:378:13 [INFO] [stdout] | [INFO] [stdout] 371 | request_handler: F, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 376 | let async_request_handler = |req: Request| async move { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 377 | let request_handler_clone = request_handler.clone(); [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 378 | / safina_executor::schedule_blocking(move || request_handler_clone(req)) [INFO] [stdout] 379 | | .await [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/body_reader.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn file(path: impl AsRef) -> Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | Ok(Self::File(std::fs::File::open(path.as_ref())?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response.rs:111:9 [INFO] [stdout] | [INFO] [stdout] 110 | pub fn html(code: u16, body: impl Into) -> Self { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | Self::new(code).with_type(ContentType::Html).with_body(body) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response.rs:129:13 [INFO] [stdout] | [INFO] [stdout] 127 | let (sender, receiver) = sync_channel(50); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | ( [INFO] [stdout] 129 | EventSender(Some(sender)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response.rs:130:13 [INFO] [stdout] | [INFO] [stdout] 127 | let (sender, receiver) = sync_channel(50); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | / Self::new(200) [INFO] [stdout] 131 | | .with_type(ContentType::EventStream) [INFO] [stdout] 132 | | .with_body(ResponseBody::EventStream(Mutex::new(EventReceiver( [INFO] [stdout] 133 | | receiver, [INFO] [stdout] 134 | | )))), [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response.rs:140:9 [INFO] [stdout] | [INFO] [stdout] 139 | pub fn text(code: u16, body: impl Into) -> Self { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 140 | / Self::new(code) [INFO] [stdout] 141 | | .with_type(ContentType::PlainText) [INFO] [stdout] | |______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response.rs:155:9 [INFO] [stdout] | [INFO] [stdout] 154 | pub fn redirect_303(location: impl AsRef) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | Response::new(303).with_header("location", location.as_ref().try_into().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `beatrice` (lib test) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `beatrice` (lib) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "26667ae4817be35b7dbed35968c63c89e71b7b1c43e74ecf2707398b80093fad", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "26667ae4817be35b7dbed35968c63c89e71b7b1c43e74ecf2707398b80093fad", kill_on_drop: false }` [INFO] [stdout] 26667ae4817be35b7dbed35968c63c89e71b7b1c43e74ecf2707398b80093fad