[INFO] fetching crate bdk_core 0.1.0... [INFO] checking bdk_core-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate bdk_core 0.1.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate bdk_core 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate bdk_core 0.1.0 [INFO] finished tweaking crates.io crate bdk_core 0.1.0 [INFO] tweaked toml for crates.io crate bdk_core 0.1.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 23 packages to latest compatible versions [INFO] [stderr] Adding ahash v0.4.8 (latest: v0.8.11) [INFO] [stderr] Adding hashbrown v0.9.1 (latest: v0.14.5) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1fdfc7fd407f8aa30039223e07feca9e2dc839853e532dc193e2f168e5d2cc34 [INFO] running `Command { std: "docker" "start" "-a" "1fdfc7fd407f8aa30039223e07feca9e2dc839853e532dc193e2f168e5d2cc34", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1fdfc7fd407f8aa30039223e07feca9e2dc839853e532dc193e2f168e5d2cc34", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1fdfc7fd407f8aa30039223e07feca9e2dc839853e532dc193e2f168e5d2cc34", kill_on_drop: false }` [INFO] [stdout] 1fdfc7fd407f8aa30039223e07feca9e2dc839853e532dc193e2f168e5d2cc34 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 16671ac7e1192e5830fc8b43bf0fcbddfcb61254512d0bf807bce4cefaa9abf5 [INFO] running `Command { std: "docker" "start" "-a" "16671ac7e1192e5830fc8b43bf0fcbddfcb61254512d0bf807bce4cefaa9abf5", kill_on_drop: false }` [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Compiling bitcoin-internals v0.3.0 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking bitcoin-io v0.1.2 [INFO] [stderr] Compiling hex_lit v0.1.1 [INFO] [stderr] Compiling bitcoin v0.32.2 [INFO] [stderr] Checking bech32 v0.11.0 [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Checking hex-conservative v0.2.1 [INFO] [stderr] Checking bitcoin-units v0.1.2 [INFO] [stderr] Checking bitcoin_hashes v0.14.0 [INFO] [stderr] Compiling secp256k1-sys v0.10.0 [INFO] [stderr] Checking base58ck v0.1.0 [INFO] [stderr] Checking secp256k1 v0.29.0 [INFO] [stderr] Checking bdk_core v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/checkpoint.rs:154:9 [INFO] [stdout] | [INFO] [stdout] 148 | pub fn range(&self, range: R) -> impl Iterator [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 154 | / self.iter() [INFO] [stdout] 155 | | .skip_while(move |cp| match end_bound { [INFO] [stdout] 156 | | core::ops::Bound::Included(inc_bound) => cp.height() > inc_bound, [INFO] [stdout] 157 | | core::ops::Bound::Excluded(exc_bound) => cp.height() >= exc_bound, [INFO] [stdout] 158 | | core::ops::Bound::Unbounded => false, [INFO] [stdout] 159 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/checkpoint.rs:199:9 [INFO] [stdout] | [INFO] [stdout] 175 | pub fn insert(self, block_id: BlockId) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 178 | let mut cp = self.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 179 | let mut tail = vec![]; [INFO] [stdout] 180 | let base = loop { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 199 | base.extend(core::iter::once(block_id).chain(tail.into_iter().rev())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/checkpoint.rs:220:14 [INFO] [stdout] | [INFO] [stdout] 218 | let current = self.current.clone()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 219 | self.current.clone_from(¤t.prev); [INFO] [stdout] 220 | Some(CheckPoint(current)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/checkpoint.rs:230:22 [INFO] [stdout] | [INFO] [stdout] 228 | fn into_iter(self) -> Self::IntoIter { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 229 | CheckPointIter { [INFO] [stdout] 230 | current: Some(self.0), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spk_client.rs:106:32 [INFO] [stdout] | [INFO] [stdout] 105 | pub fn spks(self, spks: impl IntoIterator) -> Self { [INFO] [stdout] | ---- ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | self.spks_with_indexes(spks.into_iter().map(|spk| ((), spk))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spk_client.rs:442:9 [INFO] [stdout] | [INFO] [stdout] 441 | pub fn next_spk(&mut self, keychain: K) -> Option> { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 442 | self.iter_spks(keychain).next() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bdk_core` (lib test) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/checkpoint.rs:154:9 [INFO] [stdout] | [INFO] [stdout] 148 | pub fn range(&self, range: R) -> impl Iterator [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 154 | / self.iter() [INFO] [stdout] 155 | | .skip_while(move |cp| match end_bound { [INFO] [stdout] 156 | | core::ops::Bound::Included(inc_bound) => cp.height() > inc_bound, [INFO] [stdout] 157 | | core::ops::Bound::Excluded(exc_bound) => cp.height() >= exc_bound, [INFO] [stdout] 158 | | core::ops::Bound::Unbounded => false, [INFO] [stdout] 159 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/checkpoint.rs:199:9 [INFO] [stdout] | [INFO] [stdout] 175 | pub fn insert(self, block_id: BlockId) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 178 | let mut cp = self.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 179 | let mut tail = vec![]; [INFO] [stdout] 180 | let base = loop { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 199 | base.extend(core::iter::once(block_id).chain(tail.into_iter().rev())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/checkpoint.rs:220:14 [INFO] [stdout] | [INFO] [stdout] 218 | let current = self.current.clone()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 219 | self.current.clone_from(¤t.prev); [INFO] [stdout] 220 | Some(CheckPoint(current)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/checkpoint.rs:230:22 [INFO] [stdout] | [INFO] [stdout] 228 | fn into_iter(self) -> Self::IntoIter { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 229 | CheckPointIter { [INFO] [stdout] 230 | current: Some(self.0), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spk_client.rs:106:32 [INFO] [stdout] | [INFO] [stdout] 105 | pub fn spks(self, spks: impl IntoIterator) -> Self { [INFO] [stdout] | ---- ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | self.spks_with_indexes(spks.into_iter().map(|spk| ((), spk))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spk_client.rs:442:9 [INFO] [stdout] | [INFO] [stdout] 441 | pub fn next_spk(&mut self, keychain: K) -> Option> { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 442 | self.iter_spks(keychain).next() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bdk_core` (lib) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "16671ac7e1192e5830fc8b43bf0fcbddfcb61254512d0bf807bce4cefaa9abf5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "16671ac7e1192e5830fc8b43bf0fcbddfcb61254512d0bf807bce4cefaa9abf5", kill_on_drop: false }` [INFO] [stdout] 16671ac7e1192e5830fc8b43bf0fcbddfcb61254512d0bf807bce4cefaa9abf5