[INFO] fetching crate bcf_reader 0.3.1... [INFO] checking bcf_reader-0.3.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate bcf_reader 0.3.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate bcf_reader 0.3.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate bcf_reader 0.3.1 [INFO] finished tweaking crates.io crate bcf_reader 0.3.1 [INFO] tweaked toml for crates.io crate bcf_reader 0.3.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 20 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5ff10d6c256bada9147b1231efdfeb764a4ac9efbf385363e6fa1bd5f483f860 [INFO] running `Command { std: "docker" "start" "-a" "5ff10d6c256bada9147b1231efdfeb764a4ac9efbf385363e6fa1bd5f483f860", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5ff10d6c256bada9147b1231efdfeb764a4ac9efbf385363e6fa1bd5f483f860", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5ff10d6c256bada9147b1231efdfeb764a4ac9efbf385363e6fa1bd5f483f860", kill_on_drop: false }` [INFO] [stdout] 5ff10d6c256bada9147b1231efdfeb764a4ac9efbf385363e6fa1bd5f483f860 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ec63dee33155ff1917521d5b687931840c4601310326697af4e9d0b02c61d28d [INFO] running `Command { std: "docker" "start" "-a" "ec63dee33155ff1917521d5b687931840c4601310326697af4e9d0b02c61d28d", kill_on_drop: false }` [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking rayon-core v1.12.1 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking bcf_reader v0.3.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:152:21 [INFO] [stdout] | [INFO] [stdout] 151 | fn add_context(self, context: &'static str) -> Error { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | Error::from(std::io::Error::new(self.kind(), context)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1836:41 [INFO] [stdout] | [INFO] [stdout] 1835 | .map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1836 | Error::from(std::io::Error::new( [INFO] [stdout] | _________________________________________^ [INFO] [stdout] 1837 | | e.kind(), [INFO] [stdout] 1838 | | "error in reading csi bin loffset field", [INFO] [stdout] 1839 | | )) [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1844:37 [INFO] [stdout] | [INFO] [stdout] 1843 | n_chunk: file.read_i32::().map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1844 | Error::from(std::io::Error::new( [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 1845 | | e.kind(), [INFO] [stdout] 1846 | | "error in reading csi bin n_chunk field", [INFO] [stdout] 1847 | | )) [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1857:45 [INFO] [stdout] | [INFO] [stdout] 1856 | ... .map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1857 | ... Error::from(std::io::Error::new( [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 1858 | | ... e.kind(), [INFO] [stdout] 1859 | | ... "error in reading csi chunk chunk_beg", [INFO] [stdout] 1860 | | ... )) [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1866:45 [INFO] [stdout] | [INFO] [stdout] 1865 | ... .map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1866 | ... Error::from(std::io::Error::new( [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 1867 | | ... e.kind(), [INFO] [stdout] 1868 | | ... "error in reading csi chunk chunk_end", [INFO] [stdout] 1869 | | ... )) [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:2083:12 [INFO] [stdout] | [INFO] [stdout] 2076 | path_bcf: impl AsRef, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 2077 | path_csi: impl AsRef, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2080 | let reader = File::open(path_bcf.as_ref()).map(BufReader::new)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 2081 | let csi = Csi::from_path(path_csi.as_ref())?; [INFO] [stdout] 2082 | let reader = ParMultiGzipReader::from_reader(reader, max_gzip.unwrap_or(3), None, None)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 2083 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 2084 | | inner: reader, [INFO] [stdout] 2085 | | csi, [INFO] [stdout] 2086 | | header_parsed: false, [INFO] [stdout] 2087 | | genome_interval: None, [INFO] [stdout] 2088 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bcf_reader` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:152:21 [INFO] [stdout] | [INFO] [stdout] 151 | fn add_context(self, context: &'static str) -> Error { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | Error::from(std::io::Error::new(self.kind(), context)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1836:41 [INFO] [stdout] | [INFO] [stdout] 1835 | .map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1836 | Error::from(std::io::Error::new( [INFO] [stdout] | _________________________________________^ [INFO] [stdout] 1837 | | e.kind(), [INFO] [stdout] 1838 | | "error in reading csi bin loffset field", [INFO] [stdout] 1839 | | )) [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1844:37 [INFO] [stdout] | [INFO] [stdout] 1843 | n_chunk: file.read_i32::().map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1844 | Error::from(std::io::Error::new( [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 1845 | | e.kind(), [INFO] [stdout] 1846 | | "error in reading csi bin n_chunk field", [INFO] [stdout] 1847 | | )) [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1857:45 [INFO] [stdout] | [INFO] [stdout] 1856 | ... .map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1857 | ... Error::from(std::io::Error::new( [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 1858 | | ... e.kind(), [INFO] [stdout] 1859 | | ... "error in reading csi chunk chunk_beg", [INFO] [stdout] 1860 | | ... )) [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1866:45 [INFO] [stdout] | [INFO] [stdout] 1865 | ... .map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1866 | ... Error::from(std::io::Error::new( [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 1867 | | ... e.kind(), [INFO] [stdout] 1868 | | ... "error in reading csi chunk chunk_end", [INFO] [stdout] 1869 | | ... )) [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:2083:12 [INFO] [stdout] | [INFO] [stdout] 2076 | path_bcf: impl AsRef, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 2077 | path_csi: impl AsRef, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2080 | let reader = File::open(path_bcf.as_ref()).map(BufReader::new)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 2081 | let csi = Csi::from_path(path_csi.as_ref())?; [INFO] [stdout] 2082 | let reader = ParMultiGzipReader::from_reader(reader, max_gzip.unwrap_or(3), None, None)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 2083 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 2084 | | inner: reader, [INFO] [stdout] 2085 | | csi, [INFO] [stdout] 2086 | | header_parsed: false, [INFO] [stdout] 2087 | | genome_interval: None, [INFO] [stdout] 2088 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bcf_reader` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "ec63dee33155ff1917521d5b687931840c4601310326697af4e9d0b02c61d28d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ec63dee33155ff1917521d5b687931840c4601310326697af4e9d0b02c61d28d", kill_on_drop: false }` [INFO] [stdout] ec63dee33155ff1917521d5b687931840c4601310326697af4e9d0b02c61d28d