[INFO] fetching crate bcc 0.0.34... [INFO] checking bcc-0.0.34 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate bcc 0.0.34 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate bcc 0.0.34 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate bcc 0.0.34 [INFO] finished tweaking crates.io crate bcc 0.0.34 [INFO] tweaked toml for crates.io crate bcc 0.0.34 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate bcc 0.0.34 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 26765af17e1fc492fb7d53662c369817599a7f0dde595c68b940122dc6a222c7 [INFO] running `Command { std: "docker" "start" "-a" "26765af17e1fc492fb7d53662c369817599a7f0dde595c68b940122dc6a222c7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "26765af17e1fc492fb7d53662c369817599a7f0dde595c68b940122dc6a222c7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "26765af17e1fc492fb7d53662c369817599a7f0dde595c68b940122dc6a222c7", kill_on_drop: false }` [INFO] [stdout] 26765af17e1fc492fb7d53662c369817599a7f0dde595c68b940122dc6a222c7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9d429aa040c0aa697cf56c2773af3913c0af2d17d6d77084e176f8d549e5a7bb [INFO] running `Command { std: "docker" "start" "-a" "9d429aa040c0aa697cf56c2773af3913c0af2d17d6d77084e176f8d549e5a7bb", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.149 [INFO] [stderr] Compiling proc-macro2 v1.0.69 [INFO] [stderr] Compiling thiserror v1.0.50 [INFO] [stderr] Compiling bcc-sys v0.23.0 [INFO] [stderr] Checking unicode-width v0.1.6 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Checking deranged v0.3.9 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling syn v2.0.38 [INFO] [stderr] Checking time v0.3.30 [INFO] [stderr] Checking atty v0.2.13 [INFO] [stderr] Checking nix v0.27.1 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Compiling thiserror-impl v1.0.50 [INFO] [stderr] Checking ctrlc v3.4.1 [INFO] [stderr] Checking bcc v0.0.34 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `cflags` is never read [INFO] [stdout] --> src/core/mod.rs:84:5 [INFO] [stdout] | [INFO] [stdout] 73 | pub struct BPF { [INFO] [stdout] | --- field in this struct [INFO] [stdout] ... [INFO] [stdout] 84 | cflags: Vec, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `BPF` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `code_fd` is never read [INFO] [stdout] --> src/core/kprobe/v0_9_0.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 14 | pub struct Kprobe { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 15 | code_fd: File, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Kprobe` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `code_fd` is never read [INFO] [stdout] --> src/core/perf_event/v0_4_0.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct PerfEvent { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 13 | code_fd: File, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PerfEvent` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `code_fd` and `p` are never read [INFO] [stdout] --> src/core/raw_tracepoint/v0_6_0.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct RawTracepoint { [INFO] [stdout] | ------------- fields in this struct [INFO] [stdout] 12 | name: CString, [INFO] [stdout] 13 | code_fd: File, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 14 | p: i32, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `RawTracepoint` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `code_fd` and `p` are never read [INFO] [stdout] --> src/core/tracepoint/v0_6_0.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 12 | pub struct Tracepoint { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 15 | code_fd: File, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 16 | p: i32, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `Tracepoint` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `code_fd` is never read [INFO] [stdout] --> src/core/uprobe/v0_17_0.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 14 | pub struct Uprobe { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 15 | code_fd: File, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Uprobe` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `comm`, `pid`, `cpu`, `flags`, `timestamp`, and `msg` are never read [INFO] [stdout] --> src/utils/trace_print.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct PrintkItem { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 8 | comm: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 9 | pid: String, [INFO] [stdout] | ^^^ [INFO] [stdout] 10 | cpu: String, [INFO] [stdout] | ^^^ [INFO] [stdout] 11 | flags: String, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 12 | timestamp: String, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 13 | msg: String, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PrintkItem` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/perf_event/v0_4_0.rs:73:12 [INFO] [stdout] | [INFO] [stdout] 20 | code: File, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 74 | | ev_type, [INFO] [stdout] 75 | | ev_config, [INFO] [stdout] 76 | | p: vec, [INFO] [stdout] 77 | | code_fd: code, [INFO] [stdout] 78 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/xdp/v0_4_0.rs:28:12 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn new(name: String, code: File, device: String, flags: u32) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | let device = to_cstring(device, "device")?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 29 | | name, [INFO] [stdout] 30 | | device, [INFO] [stdout] 31 | | flags, [INFO] [stdout] 32 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/helpers.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 6 | pub fn to_cstring>(value: S, field: &'static str) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 7 | CString::new(value.into()).map_err(|_| BccError::InvalidCString { field }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/perf_event/mod.rs:45:8 [INFO] [stdout] | [INFO] [stdout] 28 | raw_cb: Box, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | let callback = Box::new(PerfCallback::new(raw_cb)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | Ok(PerfReader { [INFO] [stdout] | ________^ [INFO] [stdout] 46 | | ptr: AtomicPtr::new(reader as *mut bcc_sys::bccapi::perf_reader), [INFO] [stdout] 47 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/perf_event/callback.rs:17:41 [INFO] [stdout] | [INFO] [stdout] 17 | let _ = std::panic::catch_unwind(|| (*(*(pc as *mut PerfCallback)).raw_cb)(slice)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/perf_event/perf_map.rs:63:12 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn build(mut self) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | let mut readers: Vec = vec![]; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | Ok(PerfMap { readers }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/perf_event/perf_map.rs:82:5 [INFO] [stdout] | [INFO] [stdout] 78 | pub fn init_perf_map(table: Table, cb: F) -> Result [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | PerfMapBuilder::new(table, cb).build() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ring_buf/callback.rs:23:41 [INFO] [stdout] | [INFO] [stdout] 23 | let _ = std::panic::catch_unwind(|| (*(*(ctx as *mut RingCallback)).ring_cb)(slice)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ring_buf/ring_buf.rs:108:12 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn build(mut self) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | Ok(RingBuf { [INFO] [stdout] | ____________^ [INFO] [stdout] 109 | | table_cb_pairs: self.table_cb_pairs, [INFO] [stdout] 110 | | ring_buf_manager, [INFO] [stdout] 111 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket/mod.rs:82:20 [INFO] [stdout] | [INFO] [stdout] 82 | Ok(SocketWrapper::new(iface.to_owned(), socket_fd)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bcc` (lib) due to 11 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `cflags` is never read [INFO] [stdout] --> src/core/mod.rs:84:5 [INFO] [stdout] | [INFO] [stdout] 73 | pub struct BPF { [INFO] [stdout] | --- field in this struct [INFO] [stdout] ... [INFO] [stdout] 84 | cflags: Vec, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `BPF` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `code_fd` is never read [INFO] [stdout] --> src/core/kprobe/v0_9_0.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 14 | pub struct Kprobe { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 15 | code_fd: File, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Kprobe` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `code_fd` is never read [INFO] [stdout] --> src/core/perf_event/v0_4_0.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct PerfEvent { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 13 | code_fd: File, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PerfEvent` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `code_fd` and `p` are never read [INFO] [stdout] --> src/core/raw_tracepoint/v0_6_0.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct RawTracepoint { [INFO] [stdout] | ------------- fields in this struct [INFO] [stdout] 12 | name: CString, [INFO] [stdout] 13 | code_fd: File, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 14 | p: i32, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `RawTracepoint` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `code_fd` and `p` are never read [INFO] [stdout] --> src/core/tracepoint/v0_6_0.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 12 | pub struct Tracepoint { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 15 | code_fd: File, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 16 | p: i32, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `Tracepoint` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `code_fd` is never read [INFO] [stdout] --> src/core/uprobe/v0_17_0.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 14 | pub struct Uprobe { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 15 | code_fd: File, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Uprobe` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `comm`, `pid`, `cpu`, `flags`, `timestamp`, and `msg` are never read [INFO] [stdout] --> src/utils/trace_print.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct PrintkItem { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 8 | comm: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 9 | pid: String, [INFO] [stdout] | ^^^ [INFO] [stdout] 10 | cpu: String, [INFO] [stdout] | ^^^ [INFO] [stdout] 11 | flags: String, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 12 | timestamp: String, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 13 | msg: String, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PrintkItem` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/perf_event/v0_4_0.rs:73:12 [INFO] [stdout] | [INFO] [stdout] 20 | code: File, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 74 | | ev_type, [INFO] [stdout] 75 | | ev_config, [INFO] [stdout] 76 | | p: vec, [INFO] [stdout] 77 | | code_fd: code, [INFO] [stdout] 78 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/xdp/v0_4_0.rs:28:12 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn new(name: String, code: File, device: String, flags: u32) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | let device = to_cstring(device, "device")?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 29 | | name, [INFO] [stdout] 30 | | device, [INFO] [stdout] 31 | | flags, [INFO] [stdout] 32 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/helpers.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 6 | pub fn to_cstring>(value: S, field: &'static str) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 7 | CString::new(value.into()).map_err(|_| BccError::InvalidCString { field }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/perf_event/mod.rs:45:8 [INFO] [stdout] | [INFO] [stdout] 28 | raw_cb: Box, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | let callback = Box::new(PerfCallback::new(raw_cb)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | Ok(PerfReader { [INFO] [stdout] | ________^ [INFO] [stdout] 46 | | ptr: AtomicPtr::new(reader as *mut bcc_sys::bccapi::perf_reader), [INFO] [stdout] 47 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/perf_event/callback.rs:17:41 [INFO] [stdout] | [INFO] [stdout] 17 | let _ = std::panic::catch_unwind(|| (*(*(pc as *mut PerfCallback)).raw_cb)(slice)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/perf_event/perf_map.rs:63:12 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn build(mut self) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | let mut readers: Vec = vec![]; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | Ok(PerfMap { readers }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/perf_event/perf_map.rs:82:5 [INFO] [stdout] | [INFO] [stdout] 78 | pub fn init_perf_map(table: Table, cb: F) -> Result [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | PerfMapBuilder::new(table, cb).build() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ring_buf/callback.rs:23:41 [INFO] [stdout] | [INFO] [stdout] 23 | let _ = std::panic::catch_unwind(|| (*(*(ctx as *mut RingCallback)).ring_cb)(slice)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ring_buf/ring_buf.rs:108:12 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn build(mut self) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | Ok(RingBuf { [INFO] [stdout] | ____________^ [INFO] [stdout] 109 | | table_cb_pairs: self.table_cb_pairs, [INFO] [stdout] 110 | | ring_buf_manager, [INFO] [stdout] 111 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket/mod.rs:82:20 [INFO] [stdout] | [INFO] [stdout] 82 | Ok(SocketWrapper::new(iface.to_owned(), socket_fd)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bcc` (lib test) due to 11 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "9d429aa040c0aa697cf56c2773af3913c0af2d17d6d77084e176f8d549e5a7bb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9d429aa040c0aa697cf56c2773af3913c0af2d17d6d77084e176f8d549e5a7bb", kill_on_drop: false }` [INFO] [stdout] 9d429aa040c0aa697cf56c2773af3913c0af2d17d6d77084e176f8d549e5a7bb