[INFO] fetching crate batl 0.2.1... [INFO] checking batl-0.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate batl 0.2.1 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate batl 0.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate batl 0.2.1 [INFO] finished tweaking crates.io crate batl 0.2.1 [INFO] tweaked toml for crates.io crate batl 0.2.1 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate batl 0.2.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 756e261c24a56d50193b47effcb3d33686c14368ef39c208ef1212b8ccb2ce39 [INFO] running `Command { std: "docker" "start" "-a" "756e261c24a56d50193b47effcb3d33686c14368ef39c208ef1212b8ccb2ce39", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "756e261c24a56d50193b47effcb3d33686c14368ef39c208ef1212b8ccb2ce39", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "756e261c24a56d50193b47effcb3d33686c14368ef39c208ef1212b8ccb2ce39", kill_on_drop: false }` [INFO] [stdout] 756e261c24a56d50193b47effcb3d33686c14368ef39c208ef1212b8ccb2ce39 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f623748796cd6e65735e528877d3ae882b10a70a1bfb961a7b6974e1320b9145 [INFO] running `Command { std: "docker" "start" "-a" "f623748796cd6e65735e528877d3ae882b10a70a1bfb961a7b6974e1320b9145", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.154 [INFO] [stderr] Compiling proc-macro2 v1.0.82 [INFO] [stderr] Compiling serde v1.0.201 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking anstyle-query v1.0.3 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking miniz_oxide v0.7.2 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking bstr v1.9.1 [INFO] [stderr] Checking winnow v0.5.40 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking unicode_categories v0.1.1 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking unicode-width v0.1.12 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Compiling thiserror v1.0.60 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking snailquote v0.2.0 [INFO] [stderr] Checking shell-words v1.1.0 [INFO] [stderr] Checking envfile v0.2.1 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking colored v2.1.0 [INFO] [stderr] Checking pathdiff v0.2.1 [INFO] [stderr] Checking flate2 v1.0.30 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking filetime v0.2.23 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Compiling syn v2.0.61 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling jobserver v0.1.31 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling cc v1.0.97 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking xattr v1.3.1 [INFO] [stderr] Checking tar v0.4.40 [INFO] [stderr] Checking dialoguer v0.10.4 [INFO] [stderr] Checking globset v0.4.14 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Compiling libz-sys v1.1.16 [INFO] [stderr] Compiling openssl-sys v0.9.102 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Compiling libssh2-sys v0.3.0 [INFO] [stderr] Compiling libgit2-sys v0.16.2+1.7.2 [INFO] [stderr] Checking ignore v0.4.22 [INFO] [stderr] Compiling rustls v0.22.4 [INFO] [stderr] Compiling serde_derive v1.0.201 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Compiling thiserror-impl v1.0.60 [INFO] [stderr] Checking rustls-webpki v0.102.4 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking ureq v2.9.7 [INFO] [stderr] Checking git2 v0.18.3 [INFO] [stderr] Checking serde_spanned v0.6.5 [INFO] [stderr] Checking toml_datetime v0.6.5 [INFO] [stderr] Checking toml_edit v0.19.15 [INFO] [stderr] Checking toml v0.7.8 [INFO] [stderr] Checking batl v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: multiple associated items are never used [INFO] [stdout] --> src/config.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 20 | impl Config { [INFO] [stdout] | ----------- associated items in this implementation [INFO] [stdout] ... [INFO] [stdout] 60 | pub fn get_on_condition_from_dir(path: &Path, f: impl Fn(&Self) -> bool) -> Result, ReadConfigError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 82 | pub fn get_on_condition(f: impl Fn(&Self) -> bool) -> Result, ReadConfigError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 86 | pub fn get_workspace() -> Result, ReadConfigError> { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 90 | pub fn get_repository() -> Result, ReadConfigError> { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 94 | pub fn get_workspace_from_dir(path: &Path) -> Result, ReadConfigError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 98 | pub fn get_repository_from_dir(path: &Path) -> Result, ReadConfigError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 110 | pub fn path(&self) -> Option { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `config` is never used [INFO] [stdout] --> src/env.rs:151:5 [INFO] [stdout] | [INFO] [stdout] 148 | pub trait Resource { [INFO] [stdout] | -------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 151 | fn config(&self) -> &Config; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `path` is never read [INFO] [stdout] --> src/env.rs:498:2 [INFO] [stdout] | [INFO] [stdout] 496 | pub struct Archive { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 497 | tar: tar::Archive, [INFO] [stdout] 498 | path: PathBuf [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `tar` and `path` are never used [INFO] [stdout] --> src/env.rs:522:9 [INFO] [stdout] | [INFO] [stdout] 501 | impl Archive { [INFO] [stdout] | ------------ methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 522 | pub fn tar(&self) -> &tar::Archive { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 526 | pub fn path(&self) -> &Path { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/workspace.rs:49:26 [INFO] [stdout] | [INFO] [stdout] 48 | .filter_map(|entry| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | Some(("".to_string(), entry.ok()?.path())) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/workspace.rs:68:31 [INFO] [stdout] | [INFO] [stdout] 67 | .filter_map(|entry| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | Some((new_name.clone(), entry.ok()?.path())) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/repository.rs:99:26 [INFO] [stdout] | [INFO] [stdout] 98 | .filter_map(|entry| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | Some(("".to_string(), entry.ok()?.path())) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/repository.rs:118:31 [INFO] [stdout] | [INFO] [stdout] 117 | .filter_map(|entry| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | Some((new_name.clone(), entry.ok()?.path())) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:39:6 [INFO] [stdout] | [INFO] [stdout] 39 | Ok(toml::from_str(&config_str)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:75:6 [INFO] [stdout] | [INFO] [stdout] 60 | pub fn get_on_condition_from_dir(path: &Path, f: impl Fn(&Self) -> bool) -> Result, ReadConfigError> { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | Ok(None) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/env.rs:215:6 [INFO] [stdout] | [INFO] [stdout] 198 | let config = Config { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 215 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 216 | | path: repo_path, [INFO] [stdout] 217 | | config, [INFO] [stdout] 218 | | name [INFO] [stdout] 219 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/env.rs:229:6 [INFO] [stdout] | [INFO] [stdout] 227 | let config = Config::read(&path.join("batl.toml"))?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 228 | [INFO] [stdout] 229 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 230 | | name: path.into(), [INFO] [stdout] 231 | | path: path.to_path_buf(), [INFO] [stdout] 232 | | config, [INFO] [stdout] 233 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/env.rs:314:6 [INFO] [stdout] | [INFO] [stdout] 276 | let mut walk_builder = ignore::WalkBuilder::new(self.path()); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 284 | let walk = walk_builder.build(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 293 | let archive_file = File::create(&tar_path)?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 294 | let mut archive = tar::Builder::new(archive_file); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 312 | let archive = archive.into_inner()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 313 | [INFO] [stdout] 314 | Ok(Archive { [INFO] [stdout] | ____________^ [INFO] [stdout] 315 | | tar: tar::Archive::new(archive), [INFO] [stdout] 316 | | path: tar_path.to_path_buf() [INFO] [stdout] 317 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/env.rs:383:6 [INFO] [stdout] | [INFO] [stdout] 371 | let config = Config { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 383 | Ok(Workspace { [INFO] [stdout] | ____________^ [INFO] [stdout] 384 | | path, [INFO] [stdout] 385 | | config, [INFO] [stdout] 386 | | name [INFO] [stdout] 387 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/env.rs:417:6 [INFO] [stdout] | [INFO] [stdout] 415 | let config = Config::read(&path.join("batl.toml"))?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 416 | [INFO] [stdout] 417 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 418 | | name: path.into(), [INFO] [stdout] 419 | | path: path.to_path_buf(), [INFO] [stdout] 420 | | config [INFO] [stdout] 421 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple associated items are never used [INFO] [stdout] --> src/config.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 20 | impl Config { [INFO] [stdout] | ----------- associated items in this implementation [INFO] [stdout] ... [INFO] [stdout] 60 | pub fn get_on_condition_from_dir(path: &Path, f: impl Fn(&Self) -> bool) -> Result, ReadConfigError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 82 | pub fn get_on_condition(f: impl Fn(&Self) -> bool) -> Result, ReadConfigError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 86 | pub fn get_workspace() -> Result, ReadConfigError> { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 90 | pub fn get_repository() -> Result, ReadConfigError> { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 94 | pub fn get_workspace_from_dir(path: &Path) -> Result, ReadConfigError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 98 | pub fn get_repository_from_dir(path: &Path) -> Result, ReadConfigError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 110 | pub fn path(&self) -> Option { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `config` is never used [INFO] [stdout] --> src/env.rs:151:5 [INFO] [stdout] | [INFO] [stdout] 148 | pub trait Resource { [INFO] [stdout] | -------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 151 | fn config(&self) -> &Config; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `path` is never read [INFO] [stdout] --> src/env.rs:498:2 [INFO] [stdout] | [INFO] [stdout] 496 | pub struct Archive { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 497 | tar: tar::Archive, [INFO] [stdout] 498 | path: PathBuf [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `tar` and `path` are never used [INFO] [stdout] --> src/env.rs:522:9 [INFO] [stdout] | [INFO] [stdout] 501 | impl Archive { [INFO] [stdout] | ------------ methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 522 | pub fn tar(&self) -> &tar::Archive { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 526 | pub fn path(&self) -> &Path { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/workspace.rs:49:26 [INFO] [stdout] | [INFO] [stdout] 48 | .filter_map(|entry| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | Some(("".to_string(), entry.ok()?.path())) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/workspace.rs:68:31 [INFO] [stdout] | [INFO] [stdout] 67 | .filter_map(|entry| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | Some((new_name.clone(), entry.ok()?.path())) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/repository.rs:99:26 [INFO] [stdout] | [INFO] [stdout] 98 | .filter_map(|entry| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | Some(("".to_string(), entry.ok()?.path())) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/repository.rs:118:31 [INFO] [stdout] | [INFO] [stdout] 117 | .filter_map(|entry| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | Some((new_name.clone(), entry.ok()?.path())) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:39:6 [INFO] [stdout] | [INFO] [stdout] 39 | Ok(toml::from_str(&config_str)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:75:6 [INFO] [stdout] | [INFO] [stdout] 60 | pub fn get_on_condition_from_dir(path: &Path, f: impl Fn(&Self) -> bool) -> Result, ReadConfigError> { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | Ok(None) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/env.rs:215:6 [INFO] [stdout] | [INFO] [stdout] 198 | let config = Config { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 215 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 216 | | path: repo_path, [INFO] [stdout] 217 | | config, [INFO] [stdout] 218 | | name [INFO] [stdout] 219 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/env.rs:229:6 [INFO] [stdout] | [INFO] [stdout] 227 | let config = Config::read(&path.join("batl.toml"))?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 228 | [INFO] [stdout] 229 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 230 | | name: path.into(), [INFO] [stdout] 231 | | path: path.to_path_buf(), [INFO] [stdout] 232 | | config, [INFO] [stdout] 233 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/env.rs:314:6 [INFO] [stdout] | [INFO] [stdout] 276 | let mut walk_builder = ignore::WalkBuilder::new(self.path()); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 284 | let walk = walk_builder.build(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 293 | let archive_file = File::create(&tar_path)?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 294 | let mut archive = tar::Builder::new(archive_file); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 312 | let archive = archive.into_inner()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 313 | [INFO] [stdout] 314 | Ok(Archive { [INFO] [stdout] | ____________^ [INFO] [stdout] 315 | | tar: tar::Archive::new(archive), [INFO] [stdout] 316 | | path: tar_path.to_path_buf() [INFO] [stdout] 317 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/env.rs:383:6 [INFO] [stdout] | [INFO] [stdout] 371 | let config = Config { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 383 | Ok(Workspace { [INFO] [stdout] | ____________^ [INFO] [stdout] 384 | | path, [INFO] [stdout] 385 | | config, [INFO] [stdout] 386 | | name [INFO] [stdout] 387 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/env.rs:417:6 [INFO] [stdout] | [INFO] [stdout] 415 | let config = Config::read(&path.join("batl.toml"))?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 416 | [INFO] [stdout] 417 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 418 | | name: path.into(), [INFO] [stdout] 419 | | path: path.to_path_buf(), [INFO] [stdout] 420 | | config [INFO] [stdout] 421 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `batl` (bin "batl") due to 12 previous errors; 4 warnings emitted [INFO] [stdout] error: aborting due to 11 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `batl` (bin "batl" test) due to 12 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "f623748796cd6e65735e528877d3ae882b10a70a1bfb961a7b6974e1320b9145", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f623748796cd6e65735e528877d3ae882b10a70a1bfb961a7b6974e1320b9145", kill_on_drop: false }` [INFO] [stdout] f623748796cd6e65735e528877d3ae882b10a70a1bfb961a7b6974e1320b9145