[INFO] fetching crate batbox-collection 0.16.0... [INFO] checking batbox-collection-0.16.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate batbox-collection 0.16.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate batbox-collection 0.16.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate batbox-collection 0.16.0 [INFO] finished tweaking crates.io crate batbox-collection 0.16.0 [INFO] tweaked toml for crates.io crate batbox-collection 0.16.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 25 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b6bc5bd3f91383727ed0bd6c968328b644d0cc08d2ab0ab7db3882ee2a0fdb05 [INFO] running `Command { std: "docker" "start" "-a" "b6bc5bd3f91383727ed0bd6c968328b644d0cc08d2ab0ab7db3882ee2a0fdb05", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b6bc5bd3f91383727ed0bd6c968328b644d0cc08d2ab0ab7db3882ee2a0fdb05", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b6bc5bd3f91383727ed0bd6c968328b644d0cc08d2ab0ab7db3882ee2a0fdb05", kill_on_drop: false }` [INFO] [stdout] b6bc5bd3f91383727ed0bd6c968328b644d0cc08d2ab0ab7db3882ee2a0fdb05 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8ba65aaac40237ea224feff7b0b6887e1f18319258fba58b95956bd40d0158f8 [INFO] running `Command { std: "docker" "start" "-a" "8ba65aaac40237ea224feff7b0b6887e1f18319258fba58b95956bd40d0158f8", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling strsim v0.11.1 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Compiling equivalent v1.0.1 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Compiling winnow v0.6.18 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling indexmap v2.5.0 [INFO] [stderr] Compiling serde_spanned v0.6.7 [INFO] [stderr] Compiling toml_datetime v0.6.8 [INFO] [stderr] Compiling darling_core v0.20.10 [INFO] [stderr] Compiling toml_edit v0.22.20 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling darling_macro v0.20.10 [INFO] [stderr] Compiling toml v0.8.19 [INFO] [stderr] Compiling darling v0.20.10 [INFO] [stderr] Compiling batbox-diff-derive v0.16.0 [INFO] [stderr] Compiling batbox-collection-derive v0.16.0 [INFO] [stderr] Checking batbox-diff v0.16.0 [INFO] [stderr] Checking batbox-collection v0.16.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:177:53 [INFO] [stdout] | [INFO] [stdout] 177 | .extend(entities.into_iter().map(|obj| (obj.id().clone(), obj))); [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:194:18 [INFO] [stdout] | [INFO] [stdout] 193 | fn into_iter(self) -> Self::IntoIter { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 194 | Box::new(self.by_id.into_values()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `batbox-collection` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:177:53 [INFO] [stdout] | [INFO] [stdout] 177 | .extend(entities.into_iter().map(|obj| (obj.id().clone(), obj))); [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:194:18 [INFO] [stdout] | [INFO] [stdout] 193 | fn into_iter(self) -> Self::IntoIter { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 194 | Box::new(self.by_id.into_values()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `batbox-collection` (lib test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "8ba65aaac40237ea224feff7b0b6887e1f18319258fba58b95956bd40d0158f8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8ba65aaac40237ea224feff7b0b6887e1f18319258fba58b95956bd40d0158f8", kill_on_drop: false }` [INFO] [stdout] 8ba65aaac40237ea224feff7b0b6887e1f18319258fba58b95956bd40d0158f8