[INFO] fetching crate bat 0.24.0... [INFO] checking bat-0.24.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate bat 0.24.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate bat 0.24.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate bat 0.24.0 [INFO] finished tweaking crates.io crate bat 0.24.0 [INFO] tweaked toml for crates.io crate bat 0.24.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate bat 0.24.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fa75c68b3d6ac93302bdbb5f8be97344434856f519a4bc04fe6911252f2ab16c [INFO] running `Command { std: "docker" "start" "-a" "fa75c68b3d6ac93302bdbb5f8be97344434856f519a4bc04fe6911252f2ab16c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fa75c68b3d6ac93302bdbb5f8be97344434856f519a4bc04fe6911252f2ab16c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fa75c68b3d6ac93302bdbb5f8be97344434856f519a4bc04fe6911252f2ab16c", kill_on_drop: false }` [INFO] [stdout] fa75c68b3d6ac93302bdbb5f8be97344434856f519a4bc04fe6911252f2ab16c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 37a6e754ee8db4658018c48925ee35a7bb19d681f077e222088db94ade27cfd1 [INFO] running `Command { std: "docker" "start" "-a" "37a6e754ee8db4658018c48925ee35a7bb19d681f077e222088db94ade27cfd1", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Compiling proc-macro2 v1.0.66 [INFO] [stderr] Compiling unicode-ident v1.0.4 [INFO] [stderr] Compiling quote v1.0.26 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling rustix v0.38.11 [INFO] [stderr] Compiling pkg-config v0.3.25 [INFO] [stderr] Compiling serde v1.0.163 [INFO] [stderr] Compiling utf8parse v0.2.1 [INFO] [stderr] Compiling linux-raw-sys v0.4.5 [INFO] [stderr] Compiling bitflags v2.4.0 [INFO] [stderr] Compiling anstyle-parse v0.2.0 [INFO] [stderr] Compiling syn v1.0.104 [INFO] [stderr] Compiling colorchoice v1.0.0 [INFO] [stderr] Checking aho-corasick v1.0.1 [INFO] [stderr] Checking regex-syntax v0.7.2 [INFO] [stderr] Compiling anstyle-query v1.0.0 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Checking anstyle v1.0.0 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Compiling syn v2.0.12 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Compiling proc-macro-hack v0.5.19 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Checking itoa v1.0.3 [INFO] [stderr] Compiling anstream v0.6.4 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Compiling jobserver v0.1.25 [INFO] [stderr] Compiling indexmap v1.9.1 [INFO] [stderr] Compiling strsim v0.10.0 [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Compiling clap_lex v0.5.0 [INFO] [stderr] Checking regex-automata v0.3.7 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Checking regex v1.8.3 [INFO] [stderr] Compiling terminal_size v0.3.0 [INFO] [stderr] Compiling libz-sys v1.1.8 [INFO] [stderr] Compiling sys-info v0.9.1 [INFO] [stderr] Compiling onig_sys v69.8.1 [INFO] [stderr] Checking bstr v1.6.0 [INFO] [stderr] Compiling clap_builder v4.4.6 [INFO] [stderr] Compiling libgit2-sys v0.16.1+1.7.1 [INFO] [stderr] Compiling lock_api v0.4.9 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Compiling thiserror v1.0.40 [INFO] [stderr] Compiling serde_json v1.0.85 [INFO] [stderr] Compiling parking_lot_core v0.9.7 [INFO] [stderr] Checking safemem v0.3.3 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking percent-encoding v2.2.0 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking ryu v1.0.11 [INFO] [stderr] Checking num_threads v0.1.6 [INFO] [stderr] Checking unicode-bidi v0.3.8 [INFO] [stderr] Checking form_urlencoded v1.1.0 [INFO] [stderr] Checking time v0.3.14 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Checking idna v0.3.0 [INFO] [stderr] Checking line-wrap v0.1.1 [INFO] [stderr] Checking quick-xml v0.28.1 [INFO] [stderr] Checking aho-corasick v0.7.19 [INFO] [stderr] Checking bytemuck v1.12.1 [INFO] [stderr] Compiling serde_derive v1.0.163 [INFO] [stderr] Compiling thiserror-impl v1.0.40 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Compiling semver v1.0.17 [INFO] [stderr] Checking hashbrown v0.14.1 [INFO] [stderr] Compiling bugreport v0.5.0 [INFO] [stderr] Checking base64 v0.21.0 [INFO] [stderr] Compiling git-version-macro v0.3.5 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking smallvec v1.10.0 [INFO] [stderr] Checking globset v0.4.10 [INFO] [stderr] Checking indexmap v2.0.2 [INFO] [stderr] Checking git-version v0.3.5 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Compiling clap v4.4.6 [INFO] [stderr] Checking rgb v0.8.34 [INFO] [stderr] Checking flate2 v1.0.27 [INFO] [stderr] Checking url v2.3.1 [INFO] [stderr] Checking walkdir v2.3.3 [INFO] [stderr] Checking regex-syntax v0.6.27 [INFO] [stderr] Checking std_prelude v0.2.12 [INFO] [stderr] Checking shell-escape v0.1.5 [INFO] [stderr] Checking predicates-core v1.0.6 [INFO] [stderr] Checking unicode-width v0.1.10 [INFO] [stderr] Checking home v0.5.5 [INFO] [stderr] Checking unsafe-libyaml v0.2.9 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking either v1.8.0 [INFO] [stderr] Checking grep-cli v0.1.9 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Checking etcetera v0.8.0 [INFO] [stderr] Checking console v0.15.5 [INFO] [stderr] Checking path_abs v0.5.1 [INFO] [stderr] Checking ansi_colours v1.2.1 [INFO] [stderr] Checking content_inspector v0.2.4 [INFO] [stderr] Checking encoding_rs v0.8.33 [INFO] [stderr] Checking nu-ansi-term v0.49.0 [INFO] [stderr] Checking termtree v0.2.4 [INFO] [stderr] Compiling bat v0.24.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking normalize-line-endings v0.3.0 [INFO] [stderr] Checking wild v2.1.0 [INFO] [stderr] Checking bytesize v1.3.0 [INFO] [stderr] Checking shell-words v1.1.0 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Checking predicates-tree v1.0.5 [INFO] [stderr] Checking dashmap v5.4.0 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Compiling serial_test_derive v2.0.0 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking fastrand v2.0.0 [INFO] [stderr] Checking predicates v3.0.3 [INFO] [stderr] Checking anstyle v0.3.5 [INFO] [stderr] Checking dissimilar v1.0.5 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking nix v0.26.2 [INFO] [stderr] Checking tempfile v3.8.0 [INFO] [stderr] Checking serial_test v2.0.0 [INFO] [stderr] Checking expect-test v1.4.1 [INFO] [stderr] Checking assert_cmd v2.0.10 [INFO] [stderr] Checking onig v6.4.0 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking plist v1.4.3 [INFO] [stderr] Checking clircle v0.4.0 [INFO] [stderr] Checking serde_yaml v0.9.25 [INFO] [stderr] Checking syntect v5.0.0 [INFO] [stderr] Checking git2 v0.18.0 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/assets.rs:174:9 [INFO] [stdout] | [INFO] [stdout] 171 | file_name: impl AsRef, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 174 | self.get_syntax_for_path(file_name, mapping) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/assets/assets_metadata.rs:73:29 [INFO] [stdout] | [INFO] [stdout] 73 | .and_then(|ver| Version::parse(ver).ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/input.rs:274:20 [INFO] [stdout] | [INFO] [stdout] 259 | pub(crate) fn new(mut reader: R) -> InputReader<'a> { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 274 | inner: Box::new(reader), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/output.rs:125:12 [INFO] [stdout] | [INFO] [stdout] 73 | let mut p = Command::new(resolved_path); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 125 | Ok(p.stdin(Stdio::piped()) [INFO] [stdout] | ____________^ [INFO] [stdout] 126 | | .spawn() [INFO] [stdout] 127 | | .map(OutputType::Pager) [INFO] [stdout] 128 | | .unwrap_or_else(|_| OutputType::stdout())) [INFO] [stdout] | |_____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pretty_printer.rs:58:21 [INFO] [stdout] | [INFO] [stdout] 49 | let config = Config { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | assets: HighlightingAssets::from_binary(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pretty_printer.rs:82:20 [INFO] [stdout] | [INFO] [stdout] 81 | pub fn input_file(&mut self, path: impl AsRef) -> &mut Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | self.input(Input::from_file(path).kind("File")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pretty_printer.rs:91:21 [INFO] [stdout] | [INFO] [stdout] 86 | pub fn input_files(&mut self, paths: I) -> &mut Self [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | self.inputs(paths.into_iter().map(Input::from_file)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pretty_printer.rs:303:24 [INFO] [stdout] | [INFO] [stdout] 299 | let inputs = std::mem::take(&mut self.inputs); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 303 | controller.run(inputs.into_iter().map(|i| i.into()).collect(), None) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pretty_printer.rs:271:32 [INFO] [stdout] | [INFO] [stdout] 271 | .unwrap_or_else(|| Term::stdout().size().1 as usize); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pretty_printer.rs:321:9 [INFO] [stdout] | [INFO] [stdout] 320 | pub fn from_reader(reader: R) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 321 | input::Input::from_reader(Box::new(reader)).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pretty_printer.rs:326:9 [INFO] [stdout] | [INFO] [stdout] 325 | pub fn from_file(path: impl AsRef) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 326 | input::Input::ordinary_file(path).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/printer.rs:233:12 [INFO] [stdout] | [INFO] [stdout] 181 | let mut decorations: Vec> = Vec::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 213 | let highlighter_from_set = if input [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 227 | Err(e) => return Err(e), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 233 | Ok(InteractivePrinter { [INFO] [stdout] | ____________^ [INFO] [stdout] 234 | | panel_width, [INFO] [stdout] 235 | | colors, [INFO] [stdout] 236 | | config, [INFO] [stdout] ... | [INFO] [stdout] 243 | | background_color_highlight, [INFO] [stdout] 244 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/syntax_mapping.rs:240:9 [INFO] [stdout] | [INFO] [stdout] 225 | pub(crate) fn get_syntax_for(&self, path: impl AsRef) -> Option> { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 240 | / self.ignored_suffixes [INFO] [stdout] 241 | | .try_with_stripped_suffix(file_name, |stripped_file_name| { [INFO] [stdout] 242 | | Ok(self.get_syntax_for(stripped_file_name)) [INFO] [stdout] 243 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/syntax_mapping/ignored_suffixes.rs:65:12 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn try_with_stripped_suffix(&self, file_name: &'a OsStr, func: F) -> Result> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | Ok(None) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bat` (lib) due to 15 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/assets.rs:174:9 [INFO] [stdout] | [INFO] [stdout] 171 | file_name: impl AsRef, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 174 | self.get_syntax_for_path(file_name, mapping) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/assets/assets_metadata.rs:73:29 [INFO] [stdout] | [INFO] [stdout] 73 | .and_then(|ver| Version::parse(ver).ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/input.rs:274:20 [INFO] [stdout] | [INFO] [stdout] 259 | pub(crate) fn new(mut reader: R) -> InputReader<'a> { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 274 | inner: Box::new(reader), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/line_range.rs:245:40 [INFO] [stdout] | [INFO] [stdout] 245 | LineRanges::from(rs.iter().map(|r| LineRange::from(r).unwrap()).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/output.rs:125:12 [INFO] [stdout] | [INFO] [stdout] 73 | let mut p = Command::new(resolved_path); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 125 | Ok(p.stdin(Stdio::piped()) [INFO] [stdout] | ____________^ [INFO] [stdout] 126 | | .spawn() [INFO] [stdout] 127 | | .map(OutputType::Pager) [INFO] [stdout] 128 | | .unwrap_or_else(|_| OutputType::stdout())) [INFO] [stdout] | |_____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pretty_printer.rs:58:21 [INFO] [stdout] | [INFO] [stdout] 49 | let config = Config { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | assets: HighlightingAssets::from_binary(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pretty_printer.rs:82:20 [INFO] [stdout] | [INFO] [stdout] 81 | pub fn input_file(&mut self, path: impl AsRef) -> &mut Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | self.input(Input::from_file(path).kind("File")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pretty_printer.rs:91:21 [INFO] [stdout] | [INFO] [stdout] 86 | pub fn input_files(&mut self, paths: I) -> &mut Self [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | self.inputs(paths.into_iter().map(Input::from_file)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pretty_printer.rs:303:24 [INFO] [stdout] | [INFO] [stdout] 299 | let inputs = std::mem::take(&mut self.inputs); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 303 | controller.run(inputs.into_iter().map(|i| i.into()).collect(), None) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pretty_printer.rs:271:32 [INFO] [stdout] | [INFO] [stdout] 271 | .unwrap_or_else(|| Term::stdout().size().1 as usize); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pretty_printer.rs:321:9 [INFO] [stdout] | [INFO] [stdout] 320 | pub fn from_reader(reader: R) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 321 | input::Input::from_reader(Box::new(reader)).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pretty_printer.rs:326:9 [INFO] [stdout] | [INFO] [stdout] 325 | pub fn from_file(path: impl AsRef) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 326 | input::Input::ordinary_file(path).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/printer.rs:233:12 [INFO] [stdout] | [INFO] [stdout] 181 | let mut decorations: Vec> = Vec::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 213 | let highlighter_from_set = if input [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 227 | Err(e) => return Err(e), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 233 | Ok(InteractivePrinter { [INFO] [stdout] | ____________^ [INFO] [stdout] 234 | | panel_width, [INFO] [stdout] 235 | | colors, [INFO] [stdout] 236 | | config, [INFO] [stdout] ... | [INFO] [stdout] 243 | | background_color_highlight, [INFO] [stdout] 244 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/syntax_mapping.rs:240:9 [INFO] [stdout] | [INFO] [stdout] 225 | pub(crate) fn get_syntax_for(&self, path: impl AsRef) -> Option> { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 240 | / self.ignored_suffixes [INFO] [stdout] 241 | | .try_with_stripped_suffix(file_name, |stripped_file_name| { [INFO] [stdout] 242 | | Ok(self.get_syntax_for(stripped_file_name)) [INFO] [stdout] 243 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/syntax_mapping/ignored_suffixes.rs:65:12 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn try_with_stripped_suffix(&self, file_name: &'a OsStr, func: F) -> Result> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | Ok(None) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 15 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bat` (lib test) due to 16 previous errors [INFO] running `Command { std: "docker" "inspect" "37a6e754ee8db4658018c48925ee35a7bb19d681f077e222088db94ade27cfd1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "37a6e754ee8db4658018c48925ee35a7bb19d681f077e222088db94ade27cfd1", kill_on_drop: false }` [INFO] [stdout] 37a6e754ee8db4658018c48925ee35a7bb19d681f077e222088db94ade27cfd1