[INFO] fetching crate bastion-executor 0.4.2... [INFO] checking bastion-executor-0.4.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate bastion-executor 0.4.2 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate bastion-executor 0.4.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate bastion-executor 0.4.2 [INFO] finished tweaking crates.io crate bastion-executor 0.4.2 [INFO] tweaked toml for crates.io crate bastion-executor 0.4.2 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate bastion-executor 0.4.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b15a3230c5b3823725368fa9930efcdc1238d715249508c104163cf688d95c87 [INFO] running `Command { std: "docker" "start" "-a" "b15a3230c5b3823725368fa9930efcdc1238d715249508c104163cf688d95c87", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b15a3230c5b3823725368fa9930efcdc1238d715249508c104163cf688d95c87", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b15a3230c5b3823725368fa9930efcdc1238d715249508c104163cf688d95c87", kill_on_drop: false }` [INFO] [stdout] b15a3230c5b3823725368fa9930efcdc1238d715249508c104163cf688d95c87 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ccd5fcaddfbf12ac368940eb47f894e0d58faf76601de78e0807987ae6fb8f89 [INFO] running `Command { std: "docker" "start" "-a" "ccd5fcaddfbf12ac368940eb47f894e0d58faf76601de78e0807987ae6fb8f89", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling libc v0.2.112 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.85 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling futures-core v0.3.19 [INFO] [stderr] Checking pin-project-lite v0.2.8 [INFO] [stderr] Compiling crossbeam-utils v0.8.5 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling futures-channel v0.3.19 [INFO] [stderr] Compiling parking_lot_core v0.8.5 [INFO] [stderr] Checking ppv-lite86 v0.2.16 [INFO] [stderr] Checking smallvec v1.7.0 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling futures-task v0.3.19 [INFO] [stderr] Checking tracing-core v0.1.21 [INFO] [stderr] Checking instant v0.1.12 [INFO] [stderr] Compiling crossbeam-epoch v0.9.5 [INFO] [stderr] Checking futures-sink v0.3.19 [INFO] [stderr] Compiling futures-util v0.3.19 [INFO] [stderr] Compiling anyhow v1.0.52 [INFO] [stderr] Checking lock_api v0.4.5 [INFO] [stderr] Checking slab v0.4.5 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Checking once_cell v1.9.0 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Compiling crossbeam-queue v0.3.2 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking futures-io v0.3.19 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking slice-group-by v0.2.6 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking tracing-log v0.1.2 [INFO] [stderr] Checking itertools v0.10.3 [INFO] [stderr] Checking sharded-slab v0.1.4 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Checking thread_local v1.1.3 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking bastion-utils v0.3.2 [INFO] [stderr] Checking bit-set v0.5.2 [INFO] [stderr] Checking bytes v1.1.0 [INFO] [stderr] Checking crossbeam-channel v0.5.1 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking arrayvec v0.7.2 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking futures-timer v3.0.2 [INFO] [stderr] Compiling quote v1.0.14 [INFO] [stderr] Checking quick-error v2.0.1 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking tracing-subscriber v0.3.5 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand_xorshift v0.3.0 [INFO] [stderr] Checking lightproc v0.3.5 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Checking tempfile v3.2.0 [INFO] [stderr] Checking rusty-fork v0.3.0 [INFO] [stderr] Checking proptest v1.0.0 [INFO] [stderr] Compiling thiserror-impl v1.0.30 [INFO] [stderr] Compiling tokio-macros v1.7.0 [INFO] [stderr] Compiling futures-macro v0.3.19 [INFO] [stderr] Compiling tracing-attributes v0.1.18 [INFO] [stderr] Compiling async-stream-impl v0.3.2 [INFO] [stderr] Checking tokio v1.15.0 [INFO] [stderr] Checking async-stream v0.3.2 [INFO] [stderr] Checking tracing v0.1.29 [INFO] [stderr] Checking thiserror v1.0.30 [INFO] [stderr] Checking lever v0.1.2 [INFO] [stderr] Checking bastion-executor v0.4.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: ambiguous glob re-exports [INFO] [stdout] --> src/lib.rs:45:13 [INFO] [stdout] | [INFO] [stdout] 45 | pub use crate::blocking::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ the name `spawn_blocking` in the value namespace is first re-exported here [INFO] [stdout] 46 | pub use crate::pool::*; [INFO] [stdout] | -------------- but the name `spawn_blocking` in the value namespace is also re-exported here [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ambiguous_glob_reexports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::blocking::*` [INFO] [stdout] --> src/lib.rs:45:13 [INFO] [stdout] | [INFO] [stdout] 45 | pub use crate::blocking::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/run.rs:90:79 [INFO] [stdout] | [INFO] [stdout] 90 | let arc_parker: Arc = cache.take().unwrap_or_else(|| Arc::new(Parker::new())); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/run_queue.rs:295:39 [INFO] [stdout] | [INFO] [stdout] 295 | guard.defer_unchecked(move || old.into_owned().into_box().dealloc()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/thread_manager.rs:181:29 [INFO] [stdout] | [INFO] [stdout] 176 | pub fn new(static_threads: usize, runner: Arc) -> Self { [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 181 | parked_threads: ArrayQueue::new(dynamic_threads), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/worker.rs:42:16 [INFO] [stdout] | [INFO] [stdout] 30 | pub(crate) fn set_stack(stack: *const ProcStack, f: F) -> R [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | STACK.with(|st| { [INFO] [stdout] | ________________^ [INFO] [stdout] 43 | | st.set(stack); [INFO] [stdout] 44 | | let _guard = ResetStack(st); [INFO] [stdout] ... | [INFO] [stdout] 47 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bastion-executor` (lib) due to 5 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "ccd5fcaddfbf12ac368940eb47f894e0d58faf76601de78e0807987ae6fb8f89", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ccd5fcaddfbf12ac368940eb47f894e0d58faf76601de78e0807987ae6fb8f89", kill_on_drop: false }` [INFO] [stdout] ccd5fcaddfbf12ac368940eb47f894e0d58faf76601de78e0807987ae6fb8f89