[INFO] fetching crate basteh-memory 0.4.0-alpha.5... [INFO] checking basteh-memory-0.4.0-alpha.5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate basteh-memory 0.4.0-alpha.5 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate basteh-memory 0.4.0-alpha.5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate basteh-memory 0.4.0-alpha.5 [INFO] finished tweaking crates.io crate basteh-memory 0.4.0-alpha.5 [INFO] tweaked toml for crates.io crate basteh-memory 0.4.0-alpha.5 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 59 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 22ef6d72ae9b3de6de8c2c24d8062632d3c6e11fa84fafd60c36a5148907b152 [INFO] running `Command { std: "docker" "start" "-a" "22ef6d72ae9b3de6de8c2c24d8062632d3c6e11fa84fafd60c36a5148907b152", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "22ef6d72ae9b3de6de8c2c24d8062632d3c6e11fa84fafd60c36a5148907b152", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "22ef6d72ae9b3de6de8c2c24d8062632d3c6e11fa84fafd60c36a5148907b152", kill_on_drop: false }` [INFO] [stdout] 22ef6d72ae9b3de6de8c2c24d8062632d3c6e11fa84fafd60c36a5148907b152 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 365ef1aab194ea94beb6f804a8294f7427f111944141b29a6dfacc1ddae6846f [INFO] running `Command { std: "docker" "start" "-a" "365ef1aab194ea94beb6f804a8294f7427f111944141b29a6dfacc1ddae6846f", kill_on_drop: false }` [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking basteh v0.4.0-alpha.5 [INFO] [stderr] Checking basteh-memory v0.4.0-alpha.5 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/delayqueue.rs:139:6 [INFO] [stdout] | [INFO] [stdout] 76 | let mut dq = DelayQueue::new(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | let mut ids = HashMap::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | let (queue_write, mut rx) = mpsc::channel::>(input_buffer); [INFO] [stdout] | ----------- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | let (tx, queue_read) = mpsc::channel::(output_buffer); [INFO] [stdout] | -- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | (DelayQueueSender(queue_write), queue_read) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/delayqueue.rs:139:6 [INFO] [stdout] | [INFO] [stdout] 76 | let mut dq = DelayQueue::new(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | let mut ids = HashMap::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | let (queue_write, mut rx) = mpsc::channel::>(input_buffer); [INFO] [stdout] | ----------- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | let (tx, queue_read) = mpsc::channel::(output_buffer); [INFO] [stdout] | -- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | (DelayQueueSender(queue_write), queue_read) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store.rs:87:82 [INFO] [stdout] | [INFO] [stdout] 87 | async fn set(&self, scope: &str, key: &[u8], value: Value<'_>) -> Result<()> { [INFO] [stdout] | __________________________________________________----------------________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | | let scope: Arc = scope.into(); [INFO] [stdout] 89 | | let key: Arc<[u8]> = key.into(); [INFO] [stdout] ... | [INFO] [stdout] 104 | | Ok(()) [INFO] [stdout] 105 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `basteh-memory` (lib) due to 8 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store.rs:87:82 [INFO] [stdout] | [INFO] [stdout] 87 | async fn set(&self, scope: &str, key: &[u8], value: Value<'_>) -> Result<()> { [INFO] [stdout] | __________________________________________________----------------________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | | let scope: Arc = scope.into(); [INFO] [stdout] 89 | | let key: Arc<[u8]> = key.into(); [INFO] [stdout] ... | [INFO] [stdout] 104 | | Ok(()) [INFO] [stdout] 105 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store.rs:148:83 [INFO] [stdout] | [INFO] [stdout] 148 | async fn push(&self, scope: &str, key: &[u8], value: Value<'_>) -> Result<()> { [INFO] [stdout] | ___________________________________________________----------------________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | | let mut lock = self.map.lock(); [INFO] [stdout] 150 | | let val = lock [INFO] [stdout] 151 | | .entry(scope.into()) [INFO] [stdout] ... | [INFO] [stdout] 161 | | Ok(()) [INFO] [stdout] 162 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store.rs:154:49 [INFO] [stdout] | [INFO] [stdout] 154 | .or_insert_with(|| OwnedValue::List(Vec::new())); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store.rs:148:83 [INFO] [stdout] | [INFO] [stdout] 148 | async fn push(&self, scope: &str, key: &[u8], value: Value<'_>) -> Result<()> { [INFO] [stdout] | ___________________________________________________----------------________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | | let mut lock = self.map.lock(); [INFO] [stdout] 150 | | let val = lock [INFO] [stdout] 151 | | .entry(scope.into()) [INFO] [stdout] ... | [INFO] [stdout] 161 | | Ok(()) [INFO] [stdout] 162 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store.rs:164:97 [INFO] [stdout] | [INFO] [stdout] 164 | async fn push_multiple(&self, scope: &str, key: &[u8], value: Vec>) -> Result<()> { [INFO] [stdout] | ____________________________________________________________---------------------________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 165 | | let mut lock = self.map.lock(); [INFO] [stdout] 166 | | let val = lock [INFO] [stdout] 167 | | .entry(scope.into()) [INFO] [stdout] ... | [INFO] [stdout] 177 | | Ok(()) [INFO] [stdout] 178 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store.rs:154:49 [INFO] [stdout] | [INFO] [stdout] 154 | .or_insert_with(|| OwnedValue::List(Vec::new())); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store.rs:170:49 [INFO] [stdout] | [INFO] [stdout] 170 | .or_insert_with(|| OwnedValue::List(Vec::new())); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store.rs:274:21 [INFO] [stdout] | [INFO] [stdout] 272 | value: Value<'_>, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 273 | expire_in: Duration, [INFO] [stdout] 274 | ) -> Result<()> { [INFO] [stdout] | _____________________^ [INFO] [stdout] 275 | | let scope: Arc = scope.into(); [INFO] [stdout] 276 | | let key: Arc<[u8]> = key.into(); [INFO] [stdout] ... | [INFO] [stdout] 286 | | .map_err(|e| BastehError::custom(e)) [INFO] [stdout] 287 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store.rs:164:97 [INFO] [stdout] | [INFO] [stdout] 164 | async fn push_multiple(&self, scope: &str, key: &[u8], value: Vec>) -> Result<()> { [INFO] [stdout] | ____________________________________________________________---------------------________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 165 | | let mut lock = self.map.lock(); [INFO] [stdout] 166 | | let val = lock [INFO] [stdout] 167 | | .entry(scope.into()) [INFO] [stdout] ... | [INFO] [stdout] 177 | | Ok(()) [INFO] [stdout] 178 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store.rs:170:49 [INFO] [stdout] | [INFO] [stdout] 170 | .or_insert_with(|| OwnedValue::List(Vec::new())); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store.rs:274:21 [INFO] [stdout] | [INFO] [stdout] 272 | value: Value<'_>, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 273 | expire_in: Duration, [INFO] [stdout] 274 | ) -> Result<()> { [INFO] [stdout] | _____________________^ [INFO] [stdout] 275 | | let scope: Arc = scope.into(); [INFO] [stdout] 276 | | let key: Arc<[u8]> = key.into(); [INFO] [stdout] ... | [INFO] [stdout] 286 | | .map_err(|e| BastehError::custom(e)) [INFO] [stdout] 287 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `basteh-memory` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "365ef1aab194ea94beb6f804a8294f7427f111944141b29a6dfacc1ddae6846f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "365ef1aab194ea94beb6f804a8294f7427f111944141b29a6dfacc1ddae6846f", kill_on_drop: false }` [INFO] [stdout] 365ef1aab194ea94beb6f804a8294f7427f111944141b29a6dfacc1ddae6846f