[INFO] fetching crate basex 0.7.0... [INFO] checking basex-0.7.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate basex 0.7.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate basex 0.7.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate basex 0.7.0 [INFO] finished tweaking crates.io crate basex 0.7.0 [INFO] tweaked toml for crates.io crate basex 0.7.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate basex 0.7.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 65ede0db9260f31ad46f5e866fa765ad0807563295105617622dc73f82a97835 [INFO] running `Command { std: "docker" "start" "-a" "65ede0db9260f31ad46f5e866fa765ad0807563295105617622dc73f82a97835", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "65ede0db9260f31ad46f5e866fa765ad0807563295105617622dc73f82a97835", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "65ede0db9260f31ad46f5e866fa765ad0807563295105617622dc73f82a97835", kill_on_drop: false }` [INFO] [stdout] 65ede0db9260f31ad46f5e866fa765ad0807563295105617622dc73f82a97835 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b3e918b6dde2fc6e330059d17397b93cdb1d5b12de98aaa50334c3bf0660ba65 [INFO] running `Command { std: "docker" "start" "-a" "b3e918b6dde2fc6e330059d17397b93cdb1d5b12de98aaa50334c3bf0660ba65", kill_on_drop: false }` [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Compiling typenum v1.14.0 [INFO] [stderr] Compiling proc-macro2 v1.0.34 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling syn v1.0.82 [INFO] [stderr] Compiling same-file v1.0.6 [INFO] [stderr] Compiling cpufeatures v0.2.1 [INFO] [stderr] Compiling opaque-debug v0.3.0 [INFO] [stderr] Checking md5 v0.7.0 [INFO] [stderr] Checking matches v0.1.9 [INFO] [stderr] Checking circbuf v0.2.0 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Compiling generic-array v0.14.4 [INFO] [stderr] Compiling test-case v1.2.1 [INFO] [stderr] Checking basex v0.7.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `self::connection::Unauthenticated` [INFO] [stdout] --> src/connection/mod.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 7 | pub use self::connection::Unauthenticated; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::response::Response` [INFO] [stdout] --> src/query/mod.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | pub use self::response::Response; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/client.rs:104:12 [INFO] [stdout] | [INFO] [stdout] 101 | let stream = TcpStream::connect(&format!("{}:{}", host, port))?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | let connection = Connection::new(stream).authenticate(user, password)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | [INFO] [stdout] 104 | Ok(Client::new(connection)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/client.rs:157:12 [INFO] [stdout] | [INFO] [stdout] 155 | pub fn execute(mut self, command: &str) -> Result> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 156 | self.connection.send_arg(&mut command.as_bytes())?; [INFO] [stdout] 157 | Ok(Response::new(self)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/client.rs:282:12 [INFO] [stdout] | [INFO] [stdout] 281 | pub fn query<'a, R: AsResource<'a>>(self, query: R) -> Result> { [INFO] [stdout] | ---- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 282 | Ok(QueryWithOptionalInfo::new(self, query)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/client.rs:332:12 [INFO] [stdout] | [INFO] [stdout] 329 | pub fn with_info(self) -> Result> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 330 | let (mut client, _) = self.client.execute("SET QUERYINFO true")?.close()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 331 | let id = Self::query(&mut client, self.query)?; [INFO] [stdout] 332 | Ok(Query::with_info(id, client)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/client.rs:338:12 [INFO] [stdout] | [INFO] [stdout] 335 | pub fn without_info(self) -> Result> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 336 | let (mut client, _) = self.client.execute("SET QUERYINFO false")?.close()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 337 | let id = Self::query(&mut client, self.query)?; [INFO] [stdout] 338 | Ok(Query::without_info(id, client)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection/connection.rs:68:12 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn authenticate(mut self, user: &str, password: &str) -> Result> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | Ok(Connection { [INFO] [stdout] | ____________^ [INFO] [stdout] 69 | | state: Default::default(), [INFO] [stdout] 70 | | stream: self.stream, [INFO] [stdout] 71 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/query/argument.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn write<'b, R: AsResource<'b>>(&mut self, argument: R) -> Result<()> { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | self.0.send_arg(&mut argument.into_read()).map(|_| ()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/query/query.rs:192:12 [INFO] [stdout] | [INFO] [stdout] 188 | pub fn execute(mut self) -> Result> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 192 | Ok(Response::new(self)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `basex` (lib) due to 9 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "b3e918b6dde2fc6e330059d17397b93cdb1d5b12de98aaa50334c3bf0660ba65", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b3e918b6dde2fc6e330059d17397b93cdb1d5b12de98aaa50334c3bf0660ba65", kill_on_drop: false }` [INFO] [stdout] b3e918b6dde2fc6e330059d17397b93cdb1d5b12de98aaa50334c3bf0660ba65