[INFO] fetching crate ban2bgp 0.1.3... [INFO] checking ban2bgp-0.1.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ban2bgp 0.1.3 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate ban2bgp 0.1.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ban2bgp 0.1.3 [INFO] finished tweaking crates.io crate ban2bgp 0.1.3 [INFO] tweaked toml for crates.io crate ban2bgp 0.1.3 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate ban2bgp 0.1.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1b92c1c5e32297b86d0ef722ea54e1841a7e20cbd0d87e1ce942e5a500585d35 [INFO] running `Command { std: "docker" "start" "-a" "1b92c1c5e32297b86d0ef722ea54e1841a7e20cbd0d87e1ce942e5a500585d35", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1b92c1c5e32297b86d0ef722ea54e1841a7e20cbd0d87e1ce942e5a500585d35", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1b92c1c5e32297b86d0ef722ea54e1841a7e20cbd0d87e1ce942e5a500585d35", kill_on_drop: false }` [INFO] [stdout] 1b92c1c5e32297b86d0ef722ea54e1841a7e20cbd0d87e1ce942e5a500585d35 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 16c81b8c5008a97e5842b61d8ff176d15bf00d1bab6a5c56d633ba036eafed1f [INFO] running `Command { std: "docker" "start" "-a" "16c81b8c5008a97e5842b61d8ff176d15bf00d1bab6a5c56d633ba036eafed1f", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.69 [INFO] [stderr] Compiling libc v0.2.149 [INFO] [stderr] Compiling futures-core v0.3.28 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Compiling futures-channel v0.3.28 [INFO] [stderr] Checking futures-sink v0.3.28 [INFO] [stderr] Compiling futures-task v0.3.28 [INFO] [stderr] Checking smallvec v1.11.1 [INFO] [stderr] Compiling futures-util v0.3.28 [INFO] [stderr] Checking futures-io v0.3.28 [INFO] [stderr] Compiling rustix v0.38.20 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling serde v1.0.190 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking linux-raw-sys v0.4.10 [INFO] [stderr] Checking http v0.2.9 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking termcolor v1.3.0 [INFO] [stderr] Compiling serde_json v1.0.107 [INFO] [stderr] Checking percent-encoding v2.3.0 [INFO] [stderr] Checking idna v0.4.0 [INFO] [stderr] Checking configparser v1.0.0 [INFO] [stderr] Checking utf8-width v0.1.6 [INFO] [stderr] Checking html-escape v0.2.13 [INFO] [stderr] Checking form_urlencoded v1.2.0 [INFO] [stderr] Checking ini v1.3.0 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking http-body v0.4.5 [INFO] [stderr] Checking url v2.4.1 [INFO] [stderr] Compiling syn v2.0.38 [INFO] [stderr] Checking mio v0.8.9 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking socket2 v0.5.5 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking chrono v0.4.31 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Checking env_logger v0.10.0 [INFO] [stderr] Checking pretty_env_logger v0.5.0 [INFO] [stderr] Compiling futures-macro v0.3.28 [INFO] [stderr] Compiling tokio-macros v2.1.0 [INFO] [stderr] Compiling serde_derive v1.0.190 [INFO] [stderr] Checking tokio v1.33.0 [INFO] [stderr] Checking futures-executor v0.3.28 [INFO] [stderr] Checking futures v0.3.28 [INFO] [stderr] Checking tokio-util v0.7.10 [INFO] [stderr] Checking h2 v0.3.21 [INFO] [stderr] Checking zettabgp v0.3.4 [INFO] [stderr] Checking hyper v0.14.27 [INFO] [stderr] Checking ban2bgp v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:110:21 [INFO] [stdout] | [INFO] [stdout] 108 | pub fn new(c: Arc, cancel_tok: tokio_util::sync::CancellationToken) -> Svc { [INFO] [stdout] | ----------------- ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | Svc { [INFO] [stdout] 110 | bgprib: Arc::new(Mutex::new(BgpRib::new(c.clone(), cancel_tok.clone()))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:111:18 [INFO] [stdout] | [INFO] [stdout] 108 | pub fn new(c: Arc, cancel_tok: tokio_util::sync::CancellationToken) -> Svc { [INFO] [stdout] | ----------------- ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | cfg: c.clone(), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:453:43 [INFO] [stdout] | [INFO] [stdout] 450 | let _svc1 = _svc.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 451 | async move { [INFO] [stdout] 452 | let _svc2 = _svc1.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 453 | Ok::<_, hyper::Error>(service_fn(move |req: Request| { [INFO] [stdout] | ___________________________________________^ [INFO] [stdout] 454 | | let _svc3 = _svc2.clone(); [INFO] [stdout] 455 | | async move { _svc3.read().await.response_fn(req).await } [INFO] [stdout] 456 | | })) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:455:74 [INFO] [stdout] | [INFO] [stdout] 453 | Ok::<_, hyper::Error>(service_fn(move |req: Request| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 454 | let _svc3 = _svc2.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 455 | async move { _svc3.read().await.response_fn(req).await } [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bgprib.rs:65:18 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn new(peer: BgpPeer) -> Arc> { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | Arc::new(RwLock::new(BgpPeerShell { [INFO] [stdout] | __________________^ [INFO] [stdout] 66 | | peer, [INFO] [stdout] 67 | | state: Arc::new(RwLock::new(PeerState::New)), [INFO] [stdout] 68 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bgprib.rs:163:20 [INFO] [stdout] | [INFO] [stdout] 157 | pub fn new(cfg: Arc, cancel: tokio_util::sync::CancellationToken) -> BgpRib { [INFO] [stdout] | ------------------- ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 163 | peers: Arc::new(RwLock::new(BgpPeers::new())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ban2bgp` (bin "ban2bgp") due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:110:21 [INFO] [stdout] | [INFO] [stdout] 108 | pub fn new(c: Arc, cancel_tok: tokio_util::sync::CancellationToken) -> Svc { [INFO] [stdout] | ----------------- ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | Svc { [INFO] [stdout] 110 | bgprib: Arc::new(Mutex::new(BgpRib::new(c.clone(), cancel_tok.clone()))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:111:18 [INFO] [stdout] | [INFO] [stdout] 108 | pub fn new(c: Arc, cancel_tok: tokio_util::sync::CancellationToken) -> Svc { [INFO] [stdout] | ----------------- ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | cfg: c.clone(), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:453:43 [INFO] [stdout] | [INFO] [stdout] 450 | let _svc1 = _svc.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 451 | async move { [INFO] [stdout] 452 | let _svc2 = _svc1.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 453 | Ok::<_, hyper::Error>(service_fn(move |req: Request| { [INFO] [stdout] | ___________________________________________^ [INFO] [stdout] 454 | | let _svc3 = _svc2.clone(); [INFO] [stdout] 455 | | async move { _svc3.read().await.response_fn(req).await } [INFO] [stdout] 456 | | })) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:455:74 [INFO] [stdout] | [INFO] [stdout] 453 | Ok::<_, hyper::Error>(service_fn(move |req: Request| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 454 | let _svc3 = _svc2.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 455 | async move { _svc3.read().await.response_fn(req).await } [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bgprib.rs:65:18 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn new(peer: BgpPeer) -> Arc> { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | Arc::new(RwLock::new(BgpPeerShell { [INFO] [stdout] | __________________^ [INFO] [stdout] 66 | | peer, [INFO] [stdout] 67 | | state: Arc::new(RwLock::new(PeerState::New)), [INFO] [stdout] 68 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bgprib.rs:163:20 [INFO] [stdout] | [INFO] [stdout] 157 | pub fn new(cfg: Arc, cancel: tokio_util::sync::CancellationToken) -> BgpRib { [INFO] [stdout] | ------------------- ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 163 | peers: Arc::new(RwLock::new(BgpPeers::new())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ban2bgp` (bin "ban2bgp" test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "16c81b8c5008a97e5842b61d8ff176d15bf00d1bab6a5c56d633ba036eafed1f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "16c81b8c5008a97e5842b61d8ff176d15bf00d1bab6a5c56d633ba036eafed1f", kill_on_drop: false }` [INFO] [stdout] 16c81b8c5008a97e5842b61d8ff176d15bf00d1bab6a5c56d633ba036eafed1f