[INFO] fetching crate ban 0.60.1... [INFO] checking ban-0.60.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ban 0.60.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate ban 0.60.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ban 0.60.1 [INFO] finished tweaking crates.io crate ban 0.60.1 [INFO] tweaked toml for crates.io crate ban 0.60.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 13 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 31cdbef44b19675a60ef81bfb0fccd152b5e900a27b05a716ebf1c1d2affbc9d [INFO] running `Command { std: "docker" "start" "-a" "31cdbef44b19675a60ef81bfb0fccd152b5e900a27b05a716ebf1c1d2affbc9d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "31cdbef44b19675a60ef81bfb0fccd152b5e900a27b05a716ebf1c1d2affbc9d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "31cdbef44b19675a60ef81bfb0fccd152b5e900a27b05a716ebf1c1d2affbc9d", kill_on_drop: false }` [INFO] [stdout] 31cdbef44b19675a60ef81bfb0fccd152b5e900a27b05a716ebf1c1d2affbc9d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] edc9f12f2232e480731aa3f7b71843d20ebff82f49a7e17867b503822f4010f2 [INFO] running `Command { std: "docker" "start" "-a" "edc9f12f2232e480731aa3f7b71843d20ebff82f49a7e17867b503822f4010f2", kill_on_drop: false }` [INFO] [stderr] Checking morel v0.3.0 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking ban v0.60.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `BufRead`, `BufReader`, `fmt::Write`, and `fs::File` [INFO] [stdout] --> src/compile/lex.rs:404:9 [INFO] [stdout] | [INFO] [stdout] 404 | fmt::Write, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 405 | fs::File, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 406 | io::{BufRead, BufReader}, [INFO] [stdout] | ^^^^^^^ ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Operator` [INFO] [stdout] --> src/compile/lex.rs:412:22 [INFO] [stdout] | [INFO] [stdout] 412 | Keyword, Operator, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/render.rs:139:17 [INFO] [stdout] | [INFO] [stdout] 139 | _ => unreachable!("parser must catch invalid top level tree"), [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/render.rs:139:17 [INFO] [stdout] | [INFO] [stdout] 116 | Tree::Raw(ra) => { [INFO] [stdout] | ------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 120 | Tree::Output(ou) => { [INFO] [stdout] | ---------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 124 | Tree::If(i) => { [INFO] [stdout] | ----------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 127 | Tree::For(fo) => { [INFO] [stdout] | ------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 139 | _ => unreachable!("parser must catch invalid top level tree"), [INFO] [stdout] | ^ ...and 3 other patterns collectively make this unreachable [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `region` is never read [INFO] [stdout] --> src/compile/parse/tree.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 29 | pub struct Block { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] ... [INFO] [stdout] 35 | pub region: Region, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Block` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `region` is never read [INFO] [stdout] --> src/compile/parse/tree.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 41 | pub struct Extends { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 45 | pub region: Region, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Extends` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `region` is never read [INFO] [stdout] --> src/compile/parse/tree.rs:160:9 [INFO] [stdout] | [INFO] [stdout] 158 | pub struct Output { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 159 | pub expression: Expression, [INFO] [stdout] 160 | pub region: Region, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Output` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `region` is never read [INFO] [stdout] --> src/compile/parse/tree.rs:303:9 [INFO] [stdout] | [INFO] [stdout] 298 | pub struct Mount { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] ... [INFO] [stdout] 303 | pub region: Region, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Mount` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `region` is never read [INFO] [stdout] --> src/compile/parse/tree.rs:339:9 [INFO] [stdout] | [INFO] [stdout] 329 | pub struct If { [INFO] [stdout] | -- field in this struct [INFO] [stdout] ... [INFO] [stdout] 339 | pub region: Region, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `If` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `region` is never read [INFO] [stdout] --> src/compile/parse/tree.rs:352:9 [INFO] [stdout] | [INFO] [stdout] 344 | pub struct For { [INFO] [stdout] | --- field in this struct [INFO] [stdout] ... [INFO] [stdout] 352 | pub region: Region, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `For` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `region` is never read [INFO] [stdout] --> src/compile/parse/tree.rs:373:9 [INFO] [stdout] | [INFO] [stdout] 366 | pub struct KeyValue { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 373 | pub region: Region, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `KeyValue` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compile/parse.rs:247:12 [INFO] [stdout] | [INFO] [stdout] 71 | let mut scopes: Vec = vec![Scope::new()]; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 247 | Ok(Template::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 248 | | name, [INFO] [stdout] 249 | | scopes.remove(0), [INFO] [stdout] 250 | | self.lexer.source.to_owned(), [INFO] [stdout] 251 | | self.extended, [INFO] [stdout] 252 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compile/parse.rs:173:70 [INFO] [stdout] | [INFO] [stdout] 173 | ... match states.pop().ok_or_else(|| Error::build(INVALID_SYNTAX) [INFO] [stdout] | ________________________________________________________^ [INFO] [stdout] 174 | | ... .with_pointer(self.lexer.source, end) [INFO] [stdout] | |_______________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compile/parse.rs:182:84 [INFO] [stdout] | [INFO] [stdout] 182 | ... let else_branch = has_else.then(|| scopes.pop().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compile/parse.rs:761:13 [INFO] [stdout] | [INFO] [stdout] 760 | let as_number: Number = window.parse().map_err(|_| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 761 | / Error::build("unrecognizable number") [INFO] [stdout] 762 | | .with_pointer(self.lexer.source, region) [INFO] [stdout] | |________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log/error.rs:63:21 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn new(reason: T, name: T, help: T, visual: Y) -> Self [INFO] [stdout] | --------- ------- ------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | visual: Some(Box::new(visual)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log/error.rs:88:21 [INFO] [stdout] | [INFO] [stdout] 81 | pub fn build(reason: T) -> Self [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | visual: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 102 | / Renderer::new(self.engine, &template, self.shadow.store) [INFO] [stdout] 103 | | .with_blocks(take(&mut self.blocks)) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render.rs:372:21 [INFO] [stdout] | [INFO] [stdout] 371 | let returned = func.unwrap().apply(&value, &arguments).or_else(|error| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 372 | Err(error.with_pointer(self.template.get_source(), call.name.region)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render/store.rs:54:30 [INFO] [stdout] | [INFO] [stdout] 54 | .map_err(|_| Err(Error::build(format!("value {} is unserializable", value)))); [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ban` (lib) due to 10 previous errors; 8 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/render.rs:139:17 [INFO] [stdout] | [INFO] [stdout] 139 | _ => unreachable!("parser must catch invalid top level tree"), [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/render.rs:139:17 [INFO] [stdout] | [INFO] [stdout] 116 | Tree::Raw(ra) => { [INFO] [stdout] | ------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 120 | Tree::Output(ou) => { [INFO] [stdout] | ---------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 124 | Tree::If(i) => { [INFO] [stdout] | ----------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 127 | Tree::For(fo) => { [INFO] [stdout] | ------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 139 | _ => unreachable!("parser must catch invalid top level tree"), [INFO] [stdout] | ^ ...and 3 other patterns collectively make this unreachable [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `region` is never read [INFO] [stdout] --> src/compile/parse/tree.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 29 | pub struct Block { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] ... [INFO] [stdout] 35 | pub region: Region, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Block` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `region` is never read [INFO] [stdout] --> src/compile/parse/tree.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 41 | pub struct Extends { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 45 | pub region: Region, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Extends` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `region` is never read [INFO] [stdout] --> src/compile/parse/tree.rs:160:9 [INFO] [stdout] | [INFO] [stdout] 158 | pub struct Output { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 159 | pub expression: Expression, [INFO] [stdout] 160 | pub region: Region, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Output` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `region` is never read [INFO] [stdout] --> src/compile/parse/tree.rs:303:9 [INFO] [stdout] | [INFO] [stdout] 298 | pub struct Mount { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] ... [INFO] [stdout] 303 | pub region: Region, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Mount` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `region` is never read [INFO] [stdout] --> src/compile/parse/tree.rs:339:9 [INFO] [stdout] | [INFO] [stdout] 329 | pub struct If { [INFO] [stdout] | -- field in this struct [INFO] [stdout] ... [INFO] [stdout] 339 | pub region: Region, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `If` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `region` is never read [INFO] [stdout] --> src/compile/parse/tree.rs:352:9 [INFO] [stdout] | [INFO] [stdout] 344 | pub struct For { [INFO] [stdout] | --- field in this struct [INFO] [stdout] ... [INFO] [stdout] 352 | pub region: Region, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `For` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compile/parse.rs:247:12 [INFO] [stdout] | [INFO] [stdout] 71 | let mut scopes: Vec = vec![Scope::new()]; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 247 | Ok(Template::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 248 | | name, [INFO] [stdout] 249 | | scopes.remove(0), [INFO] [stdout] 250 | | self.lexer.source.to_owned(), [INFO] [stdout] 251 | | self.extended, [INFO] [stdout] 252 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compile/parse.rs:173:70 [INFO] [stdout] | [INFO] [stdout] 173 | ... match states.pop().ok_or_else(|| Error::build(INVALID_SYNTAX) [INFO] [stdout] | ________________________________________________________^ [INFO] [stdout] 174 | | ... .with_pointer(self.lexer.source, end) [INFO] [stdout] | |_______________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compile/parse.rs:182:84 [INFO] [stdout] | [INFO] [stdout] 182 | ... let else_branch = has_else.then(|| scopes.pop().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compile/parse.rs:761:13 [INFO] [stdout] | [INFO] [stdout] 760 | let as_number: Number = window.parse().map_err(|_| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 761 | / Error::build("unrecognizable number") [INFO] [stdout] 762 | | .with_pointer(self.lexer.source, region) [INFO] [stdout] | |________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compile/parse.rs:1060:15 [INFO] [stdout] | [INFO] [stdout] 1042 | let template = get_parser_n( [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1060 | match template.get_scope().data.last().unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine.rs:527:59 [INFO] [stdout] | [INFO] [stdout] 527 | assert!(engine.get_filter("faux").is_some_and(|f| f [INFO] [stdout] | ___________________________________________________________^ [INFO] [stdout] 528 | | .apply(&value, &arguments) [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine.rs:532:59 [INFO] [stdout] | [INFO] [stdout] 532 | assert!(engine.get_filter("faux").is_some_and(|f| f [INFO] [stdout] | ___________________________________________________________^ [INFO] [stdout] 533 | | .apply(&value, &arguments) [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log/error.rs:63:21 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn new(reason: T, name: T, help: T, visual: Y) -> Self [INFO] [stdout] | --------- ------- ------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | visual: Some(Box::new(visual)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log/error.rs:88:21 [INFO] [stdout] | [INFO] [stdout] 81 | pub fn build(reason: T) -> Self [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | visual: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 102 | / Renderer::new(self.engine, &template, self.shadow.store) [INFO] [stdout] 103 | | .with_blocks(take(&mut self.blocks)) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render.rs:372:21 [INFO] [stdout] | [INFO] [stdout] 371 | let returned = func.unwrap().apply(&value, &arguments).or_else(|error| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 372 | Err(error.with_pointer(self.template.get_source(), call.name.region)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render/store.rs:54:30 [INFO] [stdout] | [INFO] [stdout] 54 | .map_err(|_| Err(Error::build(format!("value {} is unserializable", value)))); [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render.rs:802:10 [INFO] [stdout] | [INFO] [stdout] 801 | let engine = Engine::default(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 802 | (engine.compile(text).unwrap(), engine) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ban` (lib test) due to 14 previous errors; 9 warnings emitted [INFO] running `Command { std: "docker" "inspect" "edc9f12f2232e480731aa3f7b71843d20ebff82f49a7e17867b503822f4010f2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "edc9f12f2232e480731aa3f7b71843d20ebff82f49a7e17867b503822f4010f2", kill_on_drop: false }` [INFO] [stdout] edc9f12f2232e480731aa3f7b71843d20ebff82f49a7e17867b503822f4010f2