[INFO] fetching crate bam 0.1.4... [INFO] checking bam-0.1.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate bam 0.1.4 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate bam 0.1.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate bam 0.1.4 [INFO] finished tweaking crates.io crate bam 0.1.4 [INFO] tweaked toml for crates.io crate bam 0.1.4 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 22 packages to latest compatible versions [INFO] [stderr] Adding getrandom v0.1.16 (latest: v0.2.15) [INFO] [stderr] Adding rand v0.7.3 (latest: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.2.2 (latest: v0.3.1) [INFO] [stderr] Adding rand_core v0.5.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_hc v0.2.0 (latest: v0.3.2) [INFO] [stderr] Adding wasi v0.9.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b0b31dcfd452765b7064da43bb350b001d8914c9dd1a3a9eae15d0040d6704af [INFO] running `Command { std: "docker" "start" "-a" "b0b31dcfd452765b7064da43bb350b001d8914c9dd1a3a9eae15d0040d6704af", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b0b31dcfd452765b7064da43bb350b001d8914c9dd1a3a9eae15d0040d6704af", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b0b31dcfd452765b7064da43bb350b001d8914c9dd1a3a9eae15d0040d6704af", kill_on_drop: false }` [INFO] [stdout] b0b31dcfd452765b7064da43bb350b001d8914c9dd1a3a9eae15d0040d6704af [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] aa602bc86e8477bf08e6ffb967b6bf6f6a07c2ce320648737479dcb294bf199e [INFO] running `Command { std: "docker" "start" "-a" "aa602bc86e8477bf08e6ffb967b6bf6f6a07c2ce320648737479dcb294bf199e", kill_on_drop: false }` [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking bam v0.1.4 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bgzip/mod.rs:446:26 [INFO] [stdout] | [INFO] [stdout] 443 | pub fn new T + Send>(constructor: F) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 446 | constructor: Box::new(constructor), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bgzip/read.rs:161:12 [INFO] [stdout] | [INFO] [stdout] 159 | fn new(mut stream: R) -> io::Result { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 160 | let offset = stream.seek(SeekFrom::Current(0))?; [INFO] [stdout] 161 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 162 | | stream, offset, [INFO] [stdout] 163 | | chunks: Vec::new(), [INFO] [stdout] 164 | | index: 0, [INFO] [stdout] 165 | | started: false, [INFO] [stdout] 166 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bgzip/read.rs:305:26 [INFO] [stdout] | [INFO] [stdout] 288 | let working_queue = Arc::new(Mutex::new(WorkingQueue::default())); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 289 | let finish = Arc::new(AtomicBool::new(false)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 290 | let worker_handles = (0..threads).map(|i| { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 305 | blocks_pool: ObjectPool::new(|| Block::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bgzip/read.rs:296:13 [INFO] [stdout] | [INFO] [stdout] 291 | let worker = Worker { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 296 | / thread::Builder::new() [INFO] [stdout] 297 | | .name(format!("bgzip_read{}", i + 1)) [INFO] [stdout] 298 | | .spawn(|| worker.run()) [INFO] [stdout] | |_______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bgzip/read.rs:517:12 [INFO] [stdout] | [INFO] [stdout] 510 | pub fn from_stream(stream: R, additional_threads: u16) -> io::Result { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 511 | let reader = JumpingReadBlock::new(stream)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 512 | let decompressor: Box + Send> = if additional_threads == 0 { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 517 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 518 | | decompressor, [INFO] [stdout] 519 | | reader, [INFO] [stdout] 520 | | chunks_index: 0, [INFO] [stdout] 521 | | started: false, [INFO] [stdout] 522 | | contents_offset: 0, [INFO] [stdout] 523 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/bgzip/read.rs:631:17 [INFO] [stdout] | [INFO] [stdout] 631 | std::mem::drop(block); [INFO] [stdout] | ^^^^^^^^^^^^^^^-----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&Block` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 631 - std::mem::drop(block); [INFO] [stdout] 631 + let _ = block; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/bgzip/read.rs:635:13 [INFO] [stdout] | [INFO] [stdout] 635 | std::mem::drop(block); [INFO] [stdout] | ^^^^^^^^^^^^^^^-----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&Block` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 635 - std::mem::drop(block); [INFO] [stdout] 635 + let _ = block; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bgzip/read.rs:712:12 [INFO] [stdout] | [INFO] [stdout] 710 | pub fn from_path>(path: P, additional_threads: u16) -> io::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 711 | let file = File::open(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 712 | Ok(Self::from_stream(file, additional_threads)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/bgzip/read.rs:773:17 [INFO] [stdout] | [INFO] [stdout] 773 | std::mem::drop(block); [INFO] [stdout] | ^^^^^^^^^^^^^^^-----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&Block` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 773 - std::mem::drop(block); [INFO] [stdout] 773 + let _ = block; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/bgzip/read.rs:787:9 [INFO] [stdout] | [INFO] [stdout] 787 | std::mem::drop(block); [INFO] [stdout] | ^^^^^^^^^^^^^^^-----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&Block` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 787 - std::mem::drop(block); [INFO] [stdout] 787 + let _ = block; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bgzip/write.rs:209:26 [INFO] [stdout] | [INFO] [stdout] 191 | let working_queue = Arc::new(Mutex::new(WorkingQueue::default())); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 192 | let finish = Arc::new(AtomicBool::new(false)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 193 | let worker_handles = (0..threads).map(|i| { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 209 | blocks_pool: ObjectPool::new(|| Block::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bgzip/write.rs:200:13 [INFO] [stdout] | [INFO] [stdout] 194 | let worker = Worker { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 200 | / thread::Builder::new() [INFO] [stdout] 201 | | .name(format!("bgzip_write{}", i + 1)) [INFO] [stdout] 202 | | .spawn(|| worker.run()) [INFO] [stdout] | |_______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bgzip/write.rs:355:12 [INFO] [stdout] | [INFO] [stdout] 353 | pub fn from_path>(&self, path: P) -> io::Result> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 354 | let file = File::create(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 355 | Ok(self.from_stream(file)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bgzip/write.rs:377:20 [INFO] [stdout] | [INFO] [stdout] 375 | fn new(value: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 376 | Self { [INFO] [stdout] 377 | value: Some(value), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bam_reader.rs:145:32 [INFO] [stdout] | [INFO] [stdout] 144 | pub fn warn(warning: F) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | ModificationTime::Warn(Box::new(warning)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bam_reader.rs:387:9 [INFO] [stdout] | [INFO] [stdout] 386 | pub fn from_path>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 387 | IndexedReaderBuilder::new().from_path(path) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bam_reader.rs:395:12 [INFO] [stdout] | [INFO] [stdout] 392 | fn new(mut reader: bgzip::SeekReader, index: Index) -> Result { [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 395 | Ok(Self { reader, header, index }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bam_reader.rs:421:12 [INFO] [stdout] | [INFO] [stdout] 408 | pub fn fetch_by<'a, F>(&'a mut self, region: &Region, predicate: F) -> Result> [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 421 | Ok(RegionViewer { [INFO] [stdout] | ____________^ [INFO] [stdout] 422 | | parent: self, [INFO] [stdout] 423 | | start: region.start() as i32, [INFO] [stdout] 424 | | end: region.end() as i32, [INFO] [stdout] 425 | | predicate: Box::new(predicate), [INFO] [stdout] 426 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bam_reader.rs:447:24 [INFO] [stdout] | [INFO] [stdout] 437 | pub fn full_by<'a, F>(&'a mut self, predicate: F) -> RegionViewer<'a, R> [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 447 | predicate: Box::new(predicate), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bam_reader.rs:469:24 [INFO] [stdout] | [INFO] [stdout] 459 | pub fn unmapped_by<'a, F>(&'a mut self, predicate: F) -> RegionViewer<'a, R> [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 469 | predicate: Box::new(predicate), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bam_reader.rs:496:24 [INFO] [stdout] | [INFO] [stdout] 487 | pub fn fetch_chunks_by<'a, F, I>(&'a mut self, chunks: I, predicate: F) -> RegionViewer<'a, R> [INFO] [stdout] | --------- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 496 | predicate: Box::new(predicate), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bam_reader.rs:588:12 [INFO] [stdout] | [INFO] [stdout] 585 | pub fn from_stream(stream: R, additional_threads: u16) -> Result { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 586 | let mut reader = bgzip::ConsecutiveReader::from_stream(stream, additional_threads); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 587 | let header = Header::from_bam(&mut reader)?; [INFO] [stdout] 588 | Ok(Self { reader, header }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bam_writer.rs:66:12 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn from_stream(&mut self, stream: W, header: Header) -> Result> { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | let mut writer = bgzip::Writer::build() [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | Ok(BamWriter { writer, header }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sam.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn from_stream(&mut self, mut stream: W, header: Header) -> Result> { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | Ok(SamWriter { stream, header }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sam.rs:184:12 [INFO] [stdout] | [INFO] [stdout] 170 | pub fn from_stream(mut stream: R) -> Result { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 184 | Ok(SamReader { stream, header, buffer }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sam.rs:211:15 [INFO] [stdout] | [INFO] [stdout] 203 | let res = match record.fill_from_sam(self.buffer.trim(), &self.header) { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 204 | Ok(()) => Ok(true), [INFO] [stdout] 205 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 211 | match self.stream.read_line(&mut self.buffer) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/pileup.rs:350:21 [INFO] [stdout] | [INFO] [stdout] 350 | std::mem::drop(entry); [INFO] [stdout] | ^^^^^^^^^^^^^^^-----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut PileupEntry` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 350 - std::mem::drop(entry); [INFO] [stdout] 350 + let _ = entry; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stdout] error: aborting due to 22 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bam` (lib) due to 23 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "aa602bc86e8477bf08e6ffb967b6bf6f6a07c2ce320648737479dcb294bf199e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aa602bc86e8477bf08e6ffb967b6bf6f6a07c2ce320648737479dcb294bf199e", kill_on_drop: false }` [INFO] [stdout] aa602bc86e8477bf08e6ffb967b6bf6f6a07c2ce320648737479dcb294bf199e